From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [i-g-t v3 7/9] tests/kms_vrr: Allow for multiple rates in a test
Date: Mon, 18 Dec 2023 13:52:05 +0530 [thread overview]
Message-ID: <20231218082207.32719-8-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231218082207.32719-1-bhanuprakash.modem@intel.com>
From: Sean Paul <seanpaul@chromium.org>
Instead of passing just one rate into flip_and_measure, pass in an array
to allow for tests which vary the refresh rate from one frame to the
next. Currently the test will just cycle through the rates in order per
frame.
Just framework, no changes to any tests.
v2:
- Added to the set
v3: (Bhanu)
- Rebase
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_vrr.c | 63 ++++++++++++++++++++++++++-----------------------
1 file changed, 34 insertions(+), 29 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 5d25a4672..2b6e1064b 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -387,7 +387,7 @@ do_flip(data_t *data, igt_fb_t *fb)
*/
static uint32_t
flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
- uint64_t rate_ns, uint64_t duration_ns)
+ uint64_t *rates_ns, int num_rates, uint64_t duration_ns)
{
uint64_t start_ns, last_event_ns, target_ns;
uint32_t total_flip = 0, total_pass = 0;
@@ -399,9 +399,10 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
start_ns = last_event_ns = target_ns = get_kernel_event_ns(data,
DRM_EVENT_FLIP_COMPLETE);
- for (;;) {
+ for (int i = 0;;++i) {
uint64_t event_ns, wait_ns;
int64_t diff_ns;
+ uint64_t rate_ns = rates_ns[i % num_rates];
front = !front;
do_flip(data, front ? &data->fb[1] : &data->fb[0]);
@@ -452,8 +453,12 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
while (get_time_ns() < target_ns - 10);
}
- igt_info("Completed %u flips, %u were in threshold for (%llu Hz) %"PRIu64"ns.\n",
- total_flip, total_pass, (NSECS_PER_SEC/rate_ns), rate_ns);
+ igt_info("Completed %u flips, %u were in threshold for [", total_flip, total_pass);
+ for (int i = 0; i < num_rates; ++i) {
+ igt_info("(%llu Hz) %"PRIu64"ns%s", (NSECS_PER_SEC/rates_ns[i]), rates_ns[i],
+ i < num_rates - 1 ? "," : "");
+ }
+ igt_info("]\n");
return total_flip ? ((total_pass * 100) / total_flip) : 0;
}
@@ -465,12 +470,12 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
uint32_t result;
vtest_ns_t vtest_ns;
range_t range;
- uint64_t rate;
+ uint64_t rate[] = {0};
prepare_test(data, output, pipe);
range = data->range;
vtest_ns = data->vtest_ns;
- rate = vtest_ns.rate_ns;
+ rate[0] = vtest_ns.rate_ns;
igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n",
output->name, kmstest_pipe_name(pipe), range.min, range.max);
@@ -484,7 +489,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
* This is to make sure we were actually in the middle of
* active flipping before doing the DPMS/suspend steps.
*/
- flip_and_measure(data, output, pipe, rate, 250000000ull);
+ flip_and_measure(data, output, pipe, rate, 1, 250000000ull);
if (flags & TEST_DPMS) {
kmstest_set_connector_dpms(output->display->drm_fd,
@@ -515,27 +520,27 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
* next Vmin.
*/
if (flags & TEST_FLIPLINE) {
- rate = rate_from_refresh(range.max + 5);
- result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
+ rate[0] = rate_from_refresh(range.max + 5);
+ result = flip_and_measure(data, output, pipe, rate, 1, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
- (range.max + 5), rate, result);
+ (range.max + 5), rate[0], result);
}
if (flags & ~TEST_NEGATIVE) {
- rate = vtest_ns.rate_ns;
- result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
+ rate[0] = vtest_ns.rate_ns;
+ result = flip_and_measure(data, output, pipe, rate, 1, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
- ((range.max + range.min) / 2), rate, result);
+ ((range.max + range.min) / 2), rate[0], result);
}
if (flags & TEST_FLIPLINE) {
- rate = rate_from_refresh(range.min - 5);
- result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
+ rate[0] = rate_from_refresh(range.min - 5);
+ result = flip_and_measure(data, output, pipe, rate, 1, data->duration_ns);
igt_assert_f(result < 50,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold exceeded, result was %u%%\n",
- (range.min - 5), rate, result);
+ (range.min - 5), rate[0], result);
}
/*
@@ -544,11 +549,11 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
* a VRR capable panel.
*/
set_vrr_on_pipe(data, pipe, !(flags & TEST_FASTSET), (flags & TEST_NEGATIVE) ? true : false);
- rate = vtest_ns.rate_ns;
- result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
+ rate[0] = vtest_ns.rate_ns;
+ result = flip_and_measure(data, output, pipe, rate, 1, data->duration_ns);
igt_assert_f(result < 10,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold exceeded, result was %u%%\n",
- ((range.max + range.min) / 2), rate, (flags & TEST_NEGATIVE)? "on" : "off", result);
+ ((range.max + range.min) / 2), rate[0], (flags & TEST_NEGATIVE)? "on" : "off", result);
}
static void
@@ -556,7 +561,7 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3
{
uint32_t result;
vtest_ns_t vtest_ns;
- uint64_t rate;
+ uint64_t rate[] = {0};
bool vrr = !!(flags & TEST_SEAMLESS_VRR);
igt_info("Use HIGH_RR Mode as default (VRR: %s): ", vrr ? "ON" : "OFF");
@@ -568,11 +573,11 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3
if (vrr)
set_vrr_on_pipe(data, pipe, false, true);
- rate = vtest_ns.max;
- result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
+ rate[0] = vtest_ns.max;
+ result = flip_and_measure(data, output, pipe, rate, 1, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold not reached, result was %u%%\n",
- data->range.max, rate, vrr ? "on" : "off", result);
+ data->range.max, rate[0], vrr ? "on" : "off", result);
/* Switch to low rr mode without modeset. */
igt_info("Switch to LOW_RR Mode (VRR: %s): ", vrr ? "ON" : "OFF");
@@ -580,11 +585,11 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3
igt_output_override_mode(output, &data->switch_modes[LOW_RR_MODE]);
igt_assert(igt_display_try_commit_atomic(&data->display, 0, NULL) == 0);
- rate = vtest_ns.min;
- result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
+ rate[0] = vtest_ns.min;
+ result = flip_and_measure(data, output, pipe, rate, 1, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold not reached, result was %u%%\n",
- data->range.min, rate, vrr ? "on" : "off", result);
+ data->range.min, rate[0], vrr ? "on" : "off", result);
/* Switch back to high rr mode without modeset. */
igt_info("Switch back to HIGH_RR Mode (VRR: %s): ", vrr ? "ON" : "OFF");
@@ -592,11 +597,11 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3
igt_output_override_mode(output, &data->switch_modes[HIGH_RR_MODE]);
igt_assert(igt_display_try_commit_atomic(&data->display, 0, NULL) == 0);
- rate = vtest_ns.rate_ns;
- result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
+ rate[0] = vtest_ns.rate_ns;
+ result = flip_and_measure(data, output, pipe, rate, 1, data->duration_ns);
igt_assert_f(vrr ? (result > 75) : (result < 10),
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold %s, result was %u%%\n",
- ((data->range.max + data->range.min) / 2), rate,
+ ((data->range.max + data->range.min) / 2), rate[0],
vrr ? "on" : "off", vrr ? "not reached" : "exceeded", result);
}
--
2.40.0
next prev parent reply other threads:[~2023-12-18 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 8:21 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-18 8:21 ` [i-g-t v3 1/9] tests/kms_vrr: Move fb0 and fb1 to an array Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 2/9] tests/kms_vrr: Move vtest_ns into data_t Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 3/9] tests/kms_vrr: Allow test rate to be altered from the command line Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 4/9] tests/kms_vrr: Allow test duration to be specified " Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 5/9] tests/kms_vrr: Change the pattern displayed in the test Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 6/9] tests/kms_vrr: Add ability to flip static image for flicker profiling Bhanuprakash Modem
2023-12-18 8:22 ` Bhanuprakash Modem [this message]
2023-12-18 8:22 ` [i-g-t v3 8/9] tests/kms_vrr: Add a max/min test to oscillate between rates Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 9/9] HAX/DO_NOT_MERGE: Test VRR only in BAT Bhanuprakash Modem
2023-12-18 20:24 ` ✗ Fi.CI.BAT: failure for tests/kms_vrr: Modify kms_vrr to allow flicker profiling (rev2) Patchwork
2023-12-18 21:12 ` ✗ CI.xeBAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-19 2:06 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 7/9] tests/kms_vrr: Allow for multiple rates in a test Bhanuprakash Modem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218082207.32719-8-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox