From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [i-g-t v3 4/9] tests/kms_vrr: Allow test duration to be specified from the command line
Date: Mon, 18 Dec 2023 13:52:02 +0530 [thread overview]
Message-ID: <20231218082207.32719-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231218082207.32719-1-bhanuprakash.modem@intel.com>
From: Sean Paul <seanpaul@chromium.org>
Using --duration argument, otherwise use default.
v2:
- Add short opt to the main callsite (Bhanu)
v3: (Bhanu)
- Rebase
- Nit: 's/d:r:/dr:/'
Cc: Mark Yacoub <markyacoub@chromium.org>
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_vrr.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 014497bcd..cf42b4345 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -114,6 +114,7 @@ typedef struct data {
range_t range;
drmModeModeInfo switch_modes[RR_MODES_COUNT];
vtest_ns_t vtest_ns;
+ uint64_t duration_ns;
} data_t;
typedef void (*test_t)(data_t*, enum pipe, igt_output_t*, uint32_t);
@@ -278,6 +279,9 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
data->vtest_ns.rate_ns >= data->vtest_ns.max,
"Invalid test rate specified!\n");
+ if (data->duration_ns == 0)
+ data->duration_ns = TEST_DURATION_NS;
+
/* Prepare resources */
igt_create_color_fb(data->drm_fd, mode.hdisplay, mode.vdisplay,
DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
@@ -467,7 +471,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
*/
if (flags & TEST_FLIPLINE) {
rate = rate_from_refresh(range.max + 5);
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
(range.max + 5), rate, result);
@@ -475,7 +479,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
if (flags & ~TEST_NEGATIVE) {
rate = vtest_ns.rate_ns;
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
((range.max + range.min) / 2), rate, result);
@@ -483,7 +487,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
if (flags & TEST_FLIPLINE) {
rate = rate_from_refresh(range.min - 5);
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result < 50,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold exceeded, result was %u%%\n",
(range.min - 5), rate, result);
@@ -496,7 +500,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
*/
set_vrr_on_pipe(data, pipe, !(flags & TEST_FASTSET), (flags & TEST_NEGATIVE) ? true : false);
rate = vtest_ns.rate_ns;
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result < 10,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold exceeded, result was %u%%\n",
((range.max + range.min) / 2), rate, (flags & TEST_NEGATIVE)? "on" : "off", result);
@@ -520,7 +524,7 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3
set_vrr_on_pipe(data, pipe, false, true);
rate = vtest_ns.max;
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold not reached, result was %u%%\n",
data->range.max, rate, vrr ? "on" : "off", result);
@@ -532,7 +536,7 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3
igt_assert(igt_display_try_commit_atomic(&data->display, 0, NULL) == 0);
rate = vtest_ns.min;
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(result > 75,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold not reached, result was %u%%\n",
data->range.min, rate, vrr ? "on" : "off", result);
@@ -544,7 +548,7 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3
igt_assert(igt_display_try_commit_atomic(&data->display, 0, NULL) == 0);
rate = vtest_ns.rate_ns;
- result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
+ result = flip_and_measure(data, output, pipe, rate, data->duration_ns);
igt_assert_f(vrr ? (result > 75) : (result < 10),
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s threshold %s, result was %u%%\n",
((data->range.max + data->range.min) / 2), rate,
@@ -668,6 +672,9 @@ static int opt_handler(int opt, int opt_index, void *_data)
data_t *data = _data;
switch (opt) {
+ case 'd':
+ data->duration_ns = atoi(optarg) * NSECS_PER_SEC;
+ break;
case 'r':
data->vtest_ns.rate_ns = rate_from_refresh(atoi(optarg));
break;
@@ -676,16 +683,18 @@ static int opt_handler(int opt, int opt_index, void *_data)
}
static const struct option long_opts[] = {
+ { .name = "duration", .has_arg = true, .val = 'd', },
{ .name = "refresh-rate", .has_arg = true, .val = 'r', },
{}
};
static const char help_str[] =
+ " --duration <duration-seconds>\t\tHow long to run the test for\n"
" --refresh-rate <refresh-hz>\t\tThe refresh rate to flip at\n";
static data_t data;
-igt_main_args("r:", long_opts, help_str, opt_handler, &data)
+igt_main_args("dr:", long_opts, help_str, opt_handler, &data)
{
igt_fixture {
data.drm_fd = drm_open_driver_master(DRIVER_ANY);
--
2.40.0
next prev parent reply other threads:[~2023-12-18 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 8:21 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-18 8:21 ` [i-g-t v3 1/9] tests/kms_vrr: Move fb0 and fb1 to an array Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 2/9] tests/kms_vrr: Move vtest_ns into data_t Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 3/9] tests/kms_vrr: Allow test rate to be altered from the command line Bhanuprakash Modem
2023-12-18 8:22 ` Bhanuprakash Modem [this message]
2023-12-18 8:22 ` [i-g-t v3 5/9] tests/kms_vrr: Change the pattern displayed in the test Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 6/9] tests/kms_vrr: Add ability to flip static image for flicker profiling Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 7/9] tests/kms_vrr: Allow for multiple rates in a test Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 8/9] tests/kms_vrr: Add a max/min test to oscillate between rates Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 9/9] HAX/DO_NOT_MERGE: Test VRR only in BAT Bhanuprakash Modem
2023-12-18 20:24 ` ✗ Fi.CI.BAT: failure for tests/kms_vrr: Modify kms_vrr to allow flicker profiling (rev2) Patchwork
2023-12-18 21:12 ` ✗ CI.xeBAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-19 2:06 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 4/9] tests/kms_vrr: Allow test duration to be specified from the command line Bhanuprakash Modem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218082207.32719-5-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox