From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [i-g-t v3 6/9] tests/kms_vrr: Add ability to flip static image for flicker profiling
Date: Mon, 18 Dec 2023 13:52:04 +0530 [thread overview]
Message-ID: <20231218082207.32719-7-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231218082207.32719-1-bhanuprakash.modem@intel.com>
From: Sean Paul <seanpaul@chromium.org>
Add a --static-image argument which will paint both framebuffers
identically. This allows us to profile VRR flicker on the panel.
v2:
- Add short opt to the main callsite (Bhanu)
v3: (Bhanu)
- Rebase
- Nit: 's/d:r:s:/drs:/'
Cc: Mark Yacoub <markyacoub@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_vrr.c | 53 ++++++++++++++++++++++++++++++-------------------
1 file changed, 33 insertions(+), 20 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 8f0483db1..5d25a4672 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -115,6 +115,7 @@ typedef struct data {
drmModeModeInfo switch_modes[RR_MODES_COUNT];
vtest_ns_t vtest_ns;
uint64_t duration_ns;
+ bool static_image;
} data_t;
typedef void (*test_t)(data_t*, enum pipe, igt_output_t*, uint32_t);
@@ -283,6 +284,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
drmModeModeInfo mode;
cairo_t *cr;
int bar_width, bar_height, bar_remaining, horizontal_bar_height;
+ int num_painted_fbs;
mode = *igt_output_get_mode(output);
@@ -315,25 +317,31 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
horizontal_bar_height = mode.vdisplay / 8;
bar_height = mode.vdisplay - horizontal_bar_height * 2;
bar_remaining = mode.hdisplay % bar_width;
- cr = igt_get_cairo_ctx(data->drm_fd, &data->fb[0]);
- for (int j = 0; j < num_bars; ++j) {
- unsigned int width = bar_width;
- if (j == num_bars - 1)
- width += bar_remaining;
-
- /* Red->Green->Blue gradient */
- if (j < num_bars / 2)
- paint_bar(cr, j * bar_width, 0, width, bar_height,
- j, num_bars / 2,
- 1.0, 0.0, 0.0, 0.0, 1.0, 0.0);
- else
- paint_bar(cr, j * bar_width, 0, width, bar_height,
- j - num_bars / 2, num_bars / 2,
- 0.0, 1.0, 0.0, 0.0, 0.0, 1.0);
+ num_painted_fbs = data->static_image ? 2 : 1;
+ for (int i = 0; i < num_painted_fbs; ++i) {
+ cr = igt_get_cairo_ctx(data->drm_fd, &data->fb[i]);
+ for (int j = 0; j < num_bars; ++j) {
+ unsigned int width = bar_width;
+ if (j == num_bars - 1)
+ width += bar_remaining;
+
+ /* Red->Green->Blue gradient */
+ if (j < num_bars / 2)
+ paint_bar(cr, j * bar_width, 0, width,
+ bar_height,
+ j, num_bars / 2,
+ 1.0, 0.0, 0.0, 0.0, 1.0, 0.0);
+ else
+ paint_bar(cr, j * bar_width, 0, width,
+ bar_height,
+ j - num_bars / 2, num_bars / 2,
+ 0.0, 1.0, 0.0, 0.0, 0.0, 1.0);
+ }
+ igt_paint_color(cr, 0, mode.vdisplay - horizontal_bar_height,
+ mode.hdisplay, horizontal_bar_height,
+ 1.00, 1.00, 1.00);
+ igt_put_cairo_ctx(cr);
}
- igt_paint_color(cr, 0, mode.vdisplay - horizontal_bar_height,
- mode.hdisplay, horizontal_bar_height, 1.00, 1.00, 1.00);
- igt_put_cairo_ctx(cr);
/* Take care of any required modesetting before the test begins. */
data->primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -715,6 +723,9 @@ static int opt_handler(int opt, int opt_index, void *_data)
case 'r':
data->vtest_ns.rate_ns = rate_from_refresh(atoi(optarg));
break;
+ case 's':
+ data->static_image = true;
+ break;
}
return IGT_OPT_HANDLER_SUCCESS;
}
@@ -722,16 +733,18 @@ static int opt_handler(int opt, int opt_index, void *_data)
static const struct option long_opts[] = {
{ .name = "duration", .has_arg = true, .val = 'd', },
{ .name = "refresh-rate", .has_arg = true, .val = 'r', },
+ { .name = "static-image", .has_arg = false, .val = 's', },
{}
};
static const char help_str[] =
" --duration <duration-seconds>\t\tHow long to run the test for\n"
- " --refresh-rate <refresh-hz>\t\tThe refresh rate to flip at\n";
+ " --refresh-rate <refresh-hz>\t\tThe refresh rate to flip at\n"
+ " --static-image\t\tFlip a static image for flicker profiling\n";
static data_t data;
-igt_main_args("dr:", long_opts, help_str, opt_handler, &data)
+igt_main_args("drs:", long_opts, help_str, opt_handler, &data)
{
igt_fixture {
data.drm_fd = drm_open_driver_master(DRIVER_ANY);
--
2.40.0
next prev parent reply other threads:[~2023-12-18 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 8:21 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-18 8:21 ` [i-g-t v3 1/9] tests/kms_vrr: Move fb0 and fb1 to an array Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 2/9] tests/kms_vrr: Move vtest_ns into data_t Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 3/9] tests/kms_vrr: Allow test rate to be altered from the command line Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 4/9] tests/kms_vrr: Allow test duration to be specified " Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 5/9] tests/kms_vrr: Change the pattern displayed in the test Bhanuprakash Modem
2023-12-18 8:22 ` Bhanuprakash Modem [this message]
2023-12-18 8:22 ` [i-g-t v3 7/9] tests/kms_vrr: Allow for multiple rates in a test Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 8/9] tests/kms_vrr: Add a max/min test to oscillate between rates Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 9/9] HAX/DO_NOT_MERGE: Test VRR only in BAT Bhanuprakash Modem
2023-12-18 20:24 ` ✗ Fi.CI.BAT: failure for tests/kms_vrr: Modify kms_vrr to allow flicker profiling (rev2) Patchwork
2023-12-18 21:12 ` ✗ CI.xeBAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-19 2:06 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 6/9] tests/kms_vrr: Add ability to flip static image for " Bhanuprakash Modem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218082207.32719-7-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox