Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v3 1/4] tests/xe_oa: Drop TestOa from metric_set()
@ 2024-09-03 20:54 José Roberto de Souza
  2024-09-03 20:54 ` [PATCH i-g-t v3 2/4] xe/oa: Update oa-lnl.xml José Roberto de Souza
                   ` (9 more replies)
  0 siblings, 10 replies; 12+ messages in thread
From: José Roberto de Souza @ 2024-09-03 20:54 UTC (permalink / raw)
  To: igt-dev; +Cc: Ashutosh Dixit, José Roberto de Souza

Some platforms don't provide TestOa and Renderbasic and ComputeBasic
are better tests for render and compute engine and available in all
platforms.

Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/intel/xe_oa.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index f2c6d53007..aae9be2c40 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -311,15 +311,20 @@ static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_cl
 	struct intel_xe_perf_metric_set *metric_set_iter;
 	struct intel_xe_perf_metric_set *test_set = NULL;
 
-	if (hwe->engine_class == DRM_XE_ENGINE_CLASS_RENDER ||
-	    hwe->engine_class == DRM_XE_ENGINE_CLASS_COMPUTE)
-		test_set_name = "TestOa";
-	else if ((hwe->engine_class == DRM_XE_ENGINE_CLASS_VIDEO_DECODE ||
-		  hwe->engine_class == DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE) &&
-		 HAS_OAM(devid))
-		test_set_name = "MediaSet1";
-	else
-		igt_assert(!"reached");
+	switch (hwe->engine_class) {
+	case DRM_XE_ENGINE_CLASS_RENDER:
+		test_set_name = "RenderBasic";
+		break;
+	case DRM_XE_ENGINE_CLASS_COMPUTE:
+		test_set_name = "ComputeBasic";
+		break;
+	case DRM_XE_ENGINE_CLASS_VIDEO_DECODE:
+	case DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE:
+		if (HAS_OAM(devid))
+			test_set_name = "MediaSet1";
+	default:
+		igt_assert(!"missing");
+	}
 
 	igt_list_for_each_entry(metric_set_iter, &intel_xe_perf->metric_sets, link) {
 		if (strcmp(metric_set_iter->symbol_name, test_set_name) == 0) {
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-09-10  0:35 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 20:54 [PATCH i-g-t v3 1/4] tests/xe_oa: Drop TestOa from metric_set() José Roberto de Souza
2024-09-03 20:54 ` [PATCH i-g-t v3 2/4] xe/oa: Update oa-lnl.xml José Roberto de Souza
2024-09-03 20:54 ` [PATCH i-g-t v3 3/4] xe/oa: Update scripts to support BMG José Roberto de Souza
2024-09-05 16:36   ` Dixit, Ashutosh
2024-09-03 20:54 ` [PATCH i-g-t v3 4/4] xe/oa: Add oa-bmg.xml José Roberto de Souza
2024-09-03 22:03 ` ✓ CI.xeBAT: success for series starting with [i-g-t,v3,1/4] tests/xe_oa: Drop TestOa from metric_set() Patchwork
2024-09-03 22:27 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-09-04  1:44 ` ✗ CI.xeFULL: " Patchwork
2024-09-05 23:41 ` ✓ CI.xeBAT: success for series starting with [i-g-t,v3,1/4] tests/xe_oa: Drop TestOa from metric_set() (rev2) Patchwork
2024-09-06  0:12 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-08  4:24 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-10  0:35 ` ✗ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox