From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 1/6] tests/gem_ctx_engines: Fix gen6+ check
Date: Mon, 23 Sep 2024 23:45:52 +0300 [thread overview]
Message-ID: <20240923204557.32123-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240923204557.32123-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Put the parens in the correct spot so that we are actually
checking for gen6+ instead of 'intel_gen() != 0' (which is
always true btw since intel_gen() returns -1 when it doesn't
detect a valid device).
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/intel/gem_ctx_engines.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/intel/gem_ctx_engines.c b/tests/intel/gem_ctx_engines.c
index 94a47ecc3079..24240df66062 100644
--- a/tests/intel/gem_ctx_engines.c
+++ b/tests/intel/gem_ctx_engines.c
@@ -643,7 +643,7 @@ igt_main
const intel_ctx_t *ctx;
igt_require(gem_scheduler_enabled(i915));
- igt_require(intel_gen(intel_get_drm_devid(i915) >= 6));
+ igt_require(intel_gen(intel_get_drm_devid(i915)) >= 6);
ctx = intel_ctx_create_all_physical(i915);
for_each_ctx_engine(i915, ctx, e) {
--
2.44.2
next prev parent reply other threads:[~2024-09-23 20:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 20:45 [PATCH i-g-t 0/6] igt: Clean up some Intel platform checks Ville Syrjala
2024-09-23 20:45 ` Ville Syrjala [this message]
2024-09-23 20:57 ` [PATCH i-g-t 1/6] tests/gem_ctx_engines: Fix gen6+ check Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 2/6] tests/kms_frontbuffer_tracking: Simplify tiling vs. platform tests Ville Syrjala
2024-09-23 20:58 ` Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 3/6] tests/kms_ccs: Use logical && instead of bitwise & Ville Syrjala
2024-09-23 21:01 ` Lucas De Marchi
2024-09-23 21:32 ` Ville Syrjälä
2024-09-23 20:45 ` [PATCH i-g-t 4/6] tests/xe_ccs: " Ville Syrjala
2024-09-23 21:02 ` Lucas De Marchi
2024-09-24 6:34 ` Zbigniew Kempczyński
2024-09-23 20:45 ` [PATCH i-g-t 5/6] igt: Get rid of AT_LEAST_DISPLAY() Ville Syrjala
2024-09-23 21:02 ` Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 6/6] igt: Get rid of AT_LEAST_GEN() Ville Syrjala
2024-09-23 21:09 ` Lucas De Marchi
2024-09-25 23:39 ` ✓ CI.xeBAT: success for igt: Clean up some Intel platform checks Patchwork
2024-09-25 23:53 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-26 4:10 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-26 9:27 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240923204557.32123-2-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox