Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 5/6] igt: Get rid of AT_LEAST_DISPLAY()
Date: Mon, 23 Sep 2024 23:45:56 +0300	[thread overview]
Message-ID: <20240923204557.32123-6-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240923204557.32123-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

AT_LEAST_DISPLAY() looks completely pointless. Just
compare numbers naturally.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/intel_chipset.h     | 1 -
 tests/intel/kms_pm_dc.c | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index 270392c83c2a..85c075a4ad8b 100644
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -210,7 +210,6 @@ void intel_check_pch(void);
 
 #define IS_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver == x)
 #define AT_LEAST_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver >= x)
-#define AT_LEAST_DISPLAY(devid, x) (intel_get_device_info(devid)->display_ver >= x)
 
 #define IS_GEN2(devid)		IS_GEN(devid, 2)
 #define IS_GEN3(devid)		IS_GEN(devid, 3)
diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index c87e1d4084fb..541e94cb5b05 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -92,7 +92,7 @@
 #define KMS_HELPER "/sys/module/drm_kms_helper/parameters/"
 #define PACKAGE_CSTATE_PATH  "pmc_core/package_cstate_show"
 #define KMS_POLL_DISABLE 0
-#define DC9_RESETS_DC_COUNTERS(devid) (!(IS_DG1(devid) || IS_DG2(devid) || AT_LEAST_DISPLAY(devid, 14)))
+#define DC9_RESETS_DC_COUNTERS(devid) (!(IS_DG1(devid) || IS_DG2(devid) || intel_display_ver(devid) >= 14))
 #define SEC 1
 #define MSEC (SEC * 1000)
 
-- 
2.44.2


  parent reply	other threads:[~2024-09-23 20:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 20:45 [PATCH i-g-t 0/6] igt: Clean up some Intel platform checks Ville Syrjala
2024-09-23 20:45 ` [PATCH i-g-t 1/6] tests/gem_ctx_engines: Fix gen6+ check Ville Syrjala
2024-09-23 20:57   ` Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 2/6] tests/kms_frontbuffer_tracking: Simplify tiling vs. platform tests Ville Syrjala
2024-09-23 20:58   ` Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 3/6] tests/kms_ccs: Use logical && instead of bitwise & Ville Syrjala
2024-09-23 21:01   ` Lucas De Marchi
2024-09-23 21:32     ` Ville Syrjälä
2024-09-23 20:45 ` [PATCH i-g-t 4/6] tests/xe_ccs: " Ville Syrjala
2024-09-23 21:02   ` Lucas De Marchi
2024-09-24  6:34   ` Zbigniew Kempczyński
2024-09-23 20:45 ` Ville Syrjala [this message]
2024-09-23 21:02   ` [PATCH i-g-t 5/6] igt: Get rid of AT_LEAST_DISPLAY() Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 6/6] igt: Get rid of AT_LEAST_GEN() Ville Syrjala
2024-09-23 21:09   ` Lucas De Marchi
2024-09-25 23:39 ` ✓ CI.xeBAT: success for igt: Clean up some Intel platform checks Patchwork
2024-09-25 23:53 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-26  4:10 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-26  9:27 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240923204557.32123-6-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox