Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 2/6] tests/kms_frontbuffer_tracking: Simplify tiling vs. platform tests
Date: Mon, 23 Sep 2024 23:45:53 +0300	[thread overview]
Message-ID: <20240923204557.32123-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240923204557.32123-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The gen12+ check seems pointless when we already check for
4tile specifically, so just get rid of it. Also drop the
redundant comments.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/intel/kms_frontbuffer_tracking.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index f1bef9ab85ff..0646af62e51c 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -4766,17 +4766,13 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 
 					igt_require(igt_draw_supports_method(drm.fd, t.method));
 
-					/* Tiling Y is only supported on GEN9+ */
 					if (t.tiling == TILING_Y) {
 						igt_require(AT_LEAST_GEN(drm.devid, 9));
 						igt_require(!intel_get_device_info(drm.devid)->has_4tile);
 					}
 
-					/* Tiling 4 is only supported on GEN12+ */
-					if (t.tiling == TILING_4) {
-						igt_require(AT_LEAST_GEN(drm.devid, 12));
+					if (t.tiling == TILING_4)
 						igt_require(intel_get_device_info(drm.devid)->has_4tile);
-					}
 
 					if (tiling_is_valid(t.feature, t.tiling))
 						draw_subtest(&t);
-- 
2.44.2


  parent reply	other threads:[~2024-09-23 20:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 20:45 [PATCH i-g-t 0/6] igt: Clean up some Intel platform checks Ville Syrjala
2024-09-23 20:45 ` [PATCH i-g-t 1/6] tests/gem_ctx_engines: Fix gen6+ check Ville Syrjala
2024-09-23 20:57   ` Lucas De Marchi
2024-09-23 20:45 ` Ville Syrjala [this message]
2024-09-23 20:58   ` [PATCH i-g-t 2/6] tests/kms_frontbuffer_tracking: Simplify tiling vs. platform tests Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 3/6] tests/kms_ccs: Use logical && instead of bitwise & Ville Syrjala
2024-09-23 21:01   ` Lucas De Marchi
2024-09-23 21:32     ` Ville Syrjälä
2024-09-23 20:45 ` [PATCH i-g-t 4/6] tests/xe_ccs: " Ville Syrjala
2024-09-23 21:02   ` Lucas De Marchi
2024-09-24  6:34   ` Zbigniew Kempczyński
2024-09-23 20:45 ` [PATCH i-g-t 5/6] igt: Get rid of AT_LEAST_DISPLAY() Ville Syrjala
2024-09-23 21:02   ` Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 6/6] igt: Get rid of AT_LEAST_GEN() Ville Syrjala
2024-09-23 21:09   ` Lucas De Marchi
2024-09-25 23:39 ` ✓ CI.xeBAT: success for igt: Clean up some Intel platform checks Patchwork
2024-09-25 23:53 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-26  4:10 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-26  9:27 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240923204557.32123-3-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox