Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 4/6] tests/xe_ccs: Use logical && instead of bitwise &
Date: Mon, 23 Sep 2024 23:45:55 +0300	[thread overview]
Message-ID: <20240923204557.32123-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240923204557.32123-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The code appears to want to use a logical AND instead
of a bitwise AND. Make it so.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/intel/xe_ccs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/intel/xe_ccs.c b/tests/intel/xe_ccs.c
index a55ee5abd5b3..e656e5123841 100644
--- a/tests/intel/xe_ccs.c
+++ b/tests/intel/xe_ccs.c
@@ -344,8 +344,8 @@ static void block_copy(int xe,
 	uint64_t bb_size = xe_bb_size(xe, SZ_4K);
 	uint64_t ahnd = intel_allocator_open(xe, ctx->vm, INTEL_ALLOCATOR_RELOC);
 	uint32_t run_id = mid_tiling;
-	uint32_t mid_region = (AT_LEAST_GEN(intel_get_drm_devid(xe), 20) &
-							!xe_has_vram(xe)) ? region1 : region2;
+	uint32_t mid_region = (AT_LEAST_GEN(intel_get_drm_devid(xe), 20) &&
+			       !xe_has_vram(xe)) ? region1 : region2;
 	uint32_t bb;
 	enum blt_compression mid_compression = config->compression;
 	int mid_compression_format = param.compression_format;
@@ -479,8 +479,8 @@ static void block_multicopy(int xe,
 	uint64_t bb_size = xe_bb_size(xe, SZ_4K);
 	uint64_t ahnd = intel_allocator_open(xe, ctx->vm, INTEL_ALLOCATOR_RELOC);
 	uint32_t run_id = mid_tiling;
-	uint32_t mid_region = (AT_LEAST_GEN(intel_get_drm_devid(xe), 20) &
-							!xe_has_vram(xe)) ? region1 : region2;
+	uint32_t mid_region = (AT_LEAST_GEN(intel_get_drm_devid(xe), 20) &&
+			       !xe_has_vram(xe)) ? region1 : region2;
 	uint32_t bb;
 	enum blt_compression mid_compression = config->compression;
 	int mid_compression_format = param.compression_format;
-- 
2.44.2


  parent reply	other threads:[~2024-09-23 20:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 20:45 [PATCH i-g-t 0/6] igt: Clean up some Intel platform checks Ville Syrjala
2024-09-23 20:45 ` [PATCH i-g-t 1/6] tests/gem_ctx_engines: Fix gen6+ check Ville Syrjala
2024-09-23 20:57   ` Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 2/6] tests/kms_frontbuffer_tracking: Simplify tiling vs. platform tests Ville Syrjala
2024-09-23 20:58   ` Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 3/6] tests/kms_ccs: Use logical && instead of bitwise & Ville Syrjala
2024-09-23 21:01   ` Lucas De Marchi
2024-09-23 21:32     ` Ville Syrjälä
2024-09-23 20:45 ` Ville Syrjala [this message]
2024-09-23 21:02   ` [PATCH i-g-t 4/6] tests/xe_ccs: " Lucas De Marchi
2024-09-24  6:34   ` Zbigniew Kempczyński
2024-09-23 20:45 ` [PATCH i-g-t 5/6] igt: Get rid of AT_LEAST_DISPLAY() Ville Syrjala
2024-09-23 21:02   ` Lucas De Marchi
2024-09-23 20:45 ` [PATCH i-g-t 6/6] igt: Get rid of AT_LEAST_GEN() Ville Syrjala
2024-09-23 21:09   ` Lucas De Marchi
2024-09-25 23:39 ` ✓ CI.xeBAT: success for igt: Clean up some Intel platform checks Patchwork
2024-09-25 23:53 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-26  4:10 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-26  9:27 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240923204557.32123-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox