* [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter
@ 2024-10-18 19:06 Swati Sharma
2024-10-18 19:06 ` [PATCH i-g-t v7 1/4] lib/igt_kms: Added "sharpness strength" as crtc property Swati Sharma
` (6 more replies)
0 siblings, 7 replies; 13+ messages in thread
From: Swati Sharma @ 2024-10-18 19:06 UTC (permalink / raw)
To: igt-dev; +Cc: Swati Sharma
New test is added to validate adaptive sharpness filter on
LNL platform. Pipe scaler is repurposed to perform a portion
of this work. This means pipe scaling will be unavailable while
the sharpening function is being used. The other scaler can be
used for plane scaler.
In this series, attempt is made to validate adaptive sharpness
solution which helps in improving the image quality. For this new
CRTC property is added. The user can set this property with desired
sharpness strength value with 0-255. A value of 1 representing
minimum sharpening strength and 255 representing maximum
sharpness strength. A strength value of 0 means no sharpening or
sharpening feature disabled.
KMD: https://patchwork.freedesktop.org/series/138754/
Swati Sharma (4):
lib/igt_kms: Added "sharpness strength" as crtc property
lib/igt_kms: Added func() to return scaling mode name string
tests/kms_sharpness_filter: Add adaptive sharpness filter test
tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness
chamelium filter test
lib/igt_kms.c | 23 +
lib/igt_kms.h | 2 +
.../kms_chamelium_sharpness_filter.c | 250 ++++++
tests/kms_sharpness_filter.c | 750 ++++++++++++++++++
tests/meson.build | 3 +
5 files changed, 1028 insertions(+)
create mode 100644 tests/chamelium/kms_chamelium_sharpness_filter.c
create mode 100644 tests/kms_sharpness_filter.c
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH i-g-t v7 1/4] lib/igt_kms: Added "sharpness strength" as crtc property
2024-10-18 19:06 [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter Swati Sharma
@ 2024-10-18 19:06 ` Swati Sharma
2024-10-23 4:24 ` Nautiyal, Ankit K
2024-10-18 19:06 ` [PATCH i-g-t 2/4] lib/igt_kms: Added func() to return scaling mode name string Swati Sharma
` (5 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Swati Sharma @ 2024-10-18 19:06 UTC (permalink / raw)
To: igt-dev; +Cc: Swati Sharma, Mohammed Thasleem
Added "sharpness strength" as crtc property.
v2: Replace SHARPENESS_STRENGTH with SHARPNESS_STRENGTH. (Nemesa)
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
lib/igt_kms.c | 4 ++++
lib/igt_kms.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index b40470c02..73b024e0b 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -700,6 +700,7 @@ const char * const igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
[IGT_CRTC_OUT_FENCE_PTR] = "OUT_FENCE_PTR",
[IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
[IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
+ [IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
};
const char * const igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = {
@@ -2562,6 +2563,9 @@ static void igt_pipe_reset(igt_pipe_t *pipe)
if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_SCALING_FILTER))
igt_pipe_obj_set_prop_enum(pipe, IGT_CRTC_SCALING_FILTER, "Default");
+ if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_SHARPNESS_STRENGTH))
+ igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_SHARPNESS_STRENGTH, 0);
+
pipe->out_fence_fd = -1;
}
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 25ba50916..9bba0924d 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -163,6 +163,7 @@ enum igt_atomic_crtc_properties {
IGT_CRTC_OUT_FENCE_PTR,
IGT_CRTC_VRR_ENABLED,
IGT_CRTC_SCALING_FILTER,
+ IGT_CRTC_SHARPNESS_STRENGTH,
IGT_NUM_CRTC_PROPS
};
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH i-g-t 2/4] lib/igt_kms: Added func() to return scaling mode name string
2024-10-18 19:06 [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter Swati Sharma
2024-10-18 19:06 ` [PATCH i-g-t v7 1/4] lib/igt_kms: Added "sharpness strength" as crtc property Swati Sharma
@ 2024-10-18 19:06 ` Swati Sharma
2024-10-23 4:47 ` Nautiyal, Ankit K
2024-10-18 19:06 ` [PATCH i-g-t v7 3/4] tests/kms_sharpness_filter: Add adaptive sharpness filter test Swati Sharma
` (4 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Swati Sharma @ 2024-10-18 19:06 UTC (permalink / raw)
To: igt-dev; +Cc: Swati Sharma
Added func() to print scaling mode name string.
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
lib/igt_kms.c | 19 +++++++++++++++++++
lib/igt_kms.h | 1 +
2 files changed, 20 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 73b024e0b..08ad96d2d 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -1040,6 +1040,25 @@ const char *kmstest_scaling_filter_str(int filter)
return find_type_name(scaling_filter_names, filter);
}
+static const struct type_name scaling_modes_names[] = {
+ { DRM_MODE_SCALE_FULLSCREEN, "fullscreen" },
+ { DRM_MODE_SCALE_CENTER, "center" },
+ { DRM_MODE_SCALE_ASPECT, "aspect" },
+ { DRM_MODE_SCALE_NONE, "none" },
+ {}
+};
+
+/**
+ * kmstest_scaling_mode_str:
+ * @mode: SCALING_MODE_* mode value
+ *
+ * Returns: A string representing the scaling mode @mode.
+ */
+const char *kmstest_scaling_mode_str(uint32_t mode)
+{
+ return find_type_name(scaling_modes_names, mode);
+}
+
static const struct type_name dsc_output_format_names[] = {
{ DSC_FORMAT_RGB, "RGB" },
{ DSC_FORMAT_YCBCR420, "YCBCR420" },
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 9bba0924d..cc705763f 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -142,6 +142,7 @@ const char *kmstest_encoder_type_str(int type);
const char *kmstest_connector_status_str(int status);
const char *kmstest_connector_type_str(int type);
const char *kmstest_scaling_filter_str(int filter);
+const char *kmstest_scaling_mode_str(uint32_t mode);
const char *kmstest_dsc_output_format_str(int output_format);
void kmstest_dump_mode(drmModeModeInfo *mode);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH i-g-t v7 3/4] tests/kms_sharpness_filter: Add adaptive sharpness filter test
2024-10-18 19:06 [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter Swati Sharma
2024-10-18 19:06 ` [PATCH i-g-t v7 1/4] lib/igt_kms: Added "sharpness strength" as crtc property Swati Sharma
2024-10-18 19:06 ` [PATCH i-g-t 2/4] lib/igt_kms: Added func() to return scaling mode name string Swati Sharma
@ 2024-10-18 19:06 ` Swati Sharma
2024-10-23 4:20 ` Nautiyal, Ankit K
2024-10-18 19:06 ` [PATCH i-g-t 4/4] tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness chamelium " Swati Sharma
` (3 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Swati Sharma @ 2024-10-18 19:06 UTC (permalink / raw)
To: igt-dev; +Cc: Swati Sharma, Mohammed Thasleem
New test is added to validate adaptive sharpness filter on
LNL platform. Various testcases are added to validate this
feature. These are non CRC based tests and manual verification
is required.
Pipe scaler is repurposed to perform a portion of this work.
This means pipe scaling will be unavailable while the sharpening
function is being used. The other scaler can be used for plane
scaler.
15 subtests are added:
-basic: verify basic functionality
-toggle: switch between enable and disable
-tap: verify different taps selected based on resolution
-modifiers: verify casf with different modifiers
-rotation: verify casf with different rotation
-formats: verify casf with different formats
-dpms: verify casf with dpms
-suspend: verify casf with suspend
-upscale: apply plane scaler and casf together
-downscale: apply plane scaler and casf together
-strength: vary strength and check difference in sharpness
-invalid filter with scaler: enable scaler on 2 planes and attempt
is made to enable casf
-invalid filter with plane: enable 2 NV12 planes and attempt
is made to enable casf
-invalid plane with filter: enable 1 NV12 plane and casf and attempt
is made to enable 2nd NV12 plane
-invalid filter with scaling mode: enable scaling_mode property and attempt
is made to enable casf
TODO: -Enable casf with varying output formats (YCBCR/RGB)
v2: -Updated modifier type to uint64_t.
-Replaced IGT_CRTC_SHARPENESS_STRENGTH with IGT_CRTC_SHARPNESS_STRENGTH.
v3: -Updated setup_fb with height and width.
v4: -Renamed tests/intel/kms_sharpness_filter.c -> tests/kms_sharpness_filter.c (Ankit)
-Added subtest invalid filter with connector. (Ankit)
-Updated documentation. (Bhanu)
-Used driver_close_driver instead close. (Bhanu)
-Added check to avoid debug print for invalid tests and filter strength = 0. (Ankit)
v5: -Instead of using default strength as MAX, use MID value strength.
-Add relevant debug print for test skip.
-Fix indentation.
-Renamed invalid-filter-with-connector -> invalid-filter-with-scaling-mode
-Reworked on invalid-filter-with-scaling-mode(), added provision to
validate other scaling modes.
v6: -Skip test if ret=-EINVAL for downscaling test.
-Change if() for tap subtest.
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/kms_sharpness_filter.c | 750 +++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
2 files changed, 751 insertions(+)
create mode 100644 tests/kms_sharpness_filter.c
diff --git a/tests/kms_sharpness_filter.c b/tests/kms_sharpness_filter.c
new file mode 100644
index 000000000..5640b40d2
--- /dev/null
+++ b/tests/kms_sharpness_filter.c
@@ -0,0 +1,750 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+/**
+ * TEST: kms sharpness filter
+ * Category: Display
+ * Description: Test to validate content adaptive sharpness filter
+ * Driver requirement: xe
+ * Functionality: casf
+ * Mega feature: General Display Features
+ * Test category: functionality test
+ */
+
+#include "igt.h"
+#include "igt_kms.h"
+
+/**
+ * SUBTEST: filter-basic
+ * Description: Verify basic content adaptive sharpness filter.
+ *
+ * SUBTEST: filter-tap
+ * Description: Verify that following a resolution change, distict taps are selected.
+ *
+ * SUBTEST: filter-strength
+ * Description: Verify that varying strength (0-255), affects the degree of sharpeness applied.
+ *
+ * SUBTEST: filter-toggle
+ * Description: Verify toggling between enabling and disabling content adaptive sharpness filter.
+ *
+ * SUBTEST: filter-modifiers
+ * Description: Verify content adaptive sharpness filter with varying modifiers.
+ * Functionality: casf, tiling
+ *
+ * SUBTEST: filter-rotations
+ * Description: Verify content adaptive sharpness filter with varying rotations.
+ * Functionality: casf, rotation
+ *
+ * SUBTEST: filter-formats
+ * Description: Verify content adaptive sharpness filter with varying formats.
+ * Functionality: casf, pixel-format
+ *
+ * SUBTEST: filter-dpms
+ * Description: Verify content adaptive sharpness filter with DPMS.
+ * Functionality: casf, dpms
+ *
+ * SUBTEST: filter-suspend
+ * Description: Verify content adaptive sharpness filter with suspend.
+ * Functionality: casf, suspend
+ *
+ * SUBTEST: filter-scaler-upscale
+ * Description: Verify content adaptive sharpness filter with 1 plane scaler enabled.
+ * Functionality: casf, scaling
+ *
+ * SUBTEST: filter-scaler-downscale
+ * Description: Verify content adaptive sharpness filter with 1 plane scaler enabled.
+ * Functionality: casf, scaling
+ *
+ * SUBTEST: invalid-filter-with-scaler
+ * Description: Negative check for content adaptive sharpness filter
+ * when 2 plane scalers have already been enabled and
+ * attempt is made to enable sharpness filter.
+ * Functionality: casf, scaling
+ *
+ * SUBTEST: invalid-filter-with-plane
+ * Description: Negative check for content adaptive sharpness filter
+ * when 2 NV12 planes have already been enabled and attempt is
+ * made to enable the sharpness filter.
+ * Functionality: casf, plane
+ *
+ * SUBTEST: invalid-plane-with-filter
+ * Description: Negative check for content adaptive sharpness filter
+ * when 1 NV12 plane and sharpness filter have already been enabled
+ * and attempt is made to enable the second NV12 plane.
+ * Functionality: casf, plane
+ *
+ * SUBTEST: invalid-filter-with-scaling-mode
+ * Description: Negative check for content adaptive sharpness filter
+ * when scaling mode is already enabled and attempt is made to enable
+ * sharpness filter.
+ * Functionality: casf, scaling
+*/
+
+IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
+
+/*
+ * Until the CRC support is added test needs to be invoked with
+ * --interactive|--i to manually verify if "sharpened" image
+ * is seen without corruption for each subtest.
+ */
+
+#define TAP_3 3
+#define TAP_5 5
+#define TAP_7 7
+#define DISABLE_FILTER 0
+#define MIN_FILTER_STRENGTH 1
+#define MID_FILTER_STRENGTH 128
+#define MAX_FILTER_STRENGTH 255
+#define MAX_PIXELS_FOR_3_TAP_FILTER (1920 * 1080)
+#define MAX_PIXELS_FOR_5_TAP_FILTER (3840 * 2160)
+#define NROUNDS 10
+#define INVALID_TEST ((type == TEST_INVALID_FILTER_WITH_SCALER) \
+ || (type == TEST_INVALID_FILTER_WITH_PLANE) \
+ || (type == TEST_INVALID_PLANE_WITH_FILTER) \
+ || (type == TEST_INVALID_FILTER_WITH_SCALING_MODE))
+#define SET_PLANES ((type == TEST_FILTER_UPSCALE) \
+ || (type == TEST_FILTER_DOWNSCALE) \
+ || (type == TEST_INVALID_FILTER_WITH_SCALER) \
+ || (type == TEST_INVALID_FILTER_WITH_PLANE) \
+ || (type == TEST_INVALID_FILTER_WITH_SCALING_MODE))
+
+enum test_type {
+ TEST_FILTER_TAP,
+ TEST_FILTER_BASIC,
+ TEST_FILTER_TOGGLE,
+ TEST_FILTER_MODIFIERS,
+ TEST_FILTER_ROTATION,
+ TEST_FILTER_FORMATS,
+ TEST_FILTER_DPMS,
+ TEST_FILTER_SUSPEND,
+ TEST_FILTER_UPSCALE,
+ TEST_FILTER_DOWNSCALE,
+ TEST_FILTER_STRENGTH,
+ TEST_INVALID_FILTER_WITH_SCALER,
+ TEST_INVALID_FILTER_WITH_PLANE,
+ TEST_INVALID_PLANE_WITH_FILTER,
+ TEST_INVALID_FILTER_WITH_SCALING_MODE,
+};
+
+const int filter_strength_list[] = {
+ MIN_FILTER_STRENGTH,
+ (MIN_FILTER_STRENGTH + MID_FILTER_STRENGTH) / 2,
+ MID_FILTER_STRENGTH,
+ (MID_FILTER_STRENGTH + MAX_FILTER_STRENGTH) / 2,
+ MAX_FILTER_STRENGTH,
+};
+const int filter_tap_list[] = {
+ TAP_3,
+ TAP_5,
+ TAP_7,
+};
+static const struct {
+ uint64_t modifier;
+ const char *name;
+} modifiers[] = {
+ { DRM_FORMAT_MOD_LINEAR, "linear", },
+ { I915_FORMAT_MOD_X_TILED, "x-tiled", },
+ { I915_FORMAT_MOD_4_TILED, "4-tiled", },
+};
+static const int formats[] = {
+ DRM_FORMAT_NV12,
+ DRM_FORMAT_RGB565,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_XBGR16161616F,
+};
+static const igt_rotation_t rotations[] = {
+ IGT_ROTATION_0,
+ IGT_ROTATION_180,
+};
+static const uint32_t scaling_modes[] = {
+ DRM_MODE_SCALE_FULLSCREEN,
+ DRM_MODE_SCALE_CENTER,
+ DRM_MODE_SCALE_ASPECT,
+};
+
+typedef struct {
+ int drm_fd;
+ bool limited;
+ enum pipe pipe_id;
+ struct igt_fb fb[4];
+ igt_pipe_t *pipe;
+ igt_display_t display;
+ igt_output_t *output;
+ igt_plane_t *plane[4];
+ drmModeModeInfo *mode;
+ int filter_strength;
+ int filter_tap;
+ uint64_t modifier;
+ const char *modifier_name;
+ uint32_t format;
+ igt_rotation_t rotation;
+ uint32_t scaling_mode;
+} data_t;
+
+static void set_filter_strength_on_pipe(data_t *data)
+{
+ igt_pipe_set_prop_value(&data->display, data->pipe_id,
+ IGT_CRTC_SHARPNESS_STRENGTH,
+ data->filter_strength);
+}
+
+static bool has_scaling_mode(igt_output_t *output)
+{
+ return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
+ igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
+}
+
+static drmModeModeInfo *get_mode(igt_output_t *output, int tap)
+{
+ drmModeConnector *connector = output->config.connector;
+ drmModeModeInfo *mode = NULL;
+ uint64_t total_pixels = 0;
+
+ /*
+ * TAP 3: mode->hdisplay <= 1920 && mode->vdisplay <= 1080
+ * TAP 5: mode->hdisplay > 1920 && mode->vdisplay > 1080
+ * TAP 7: mode->hdisplay >= 3840 && mode->vdisplay >= 2160
+ */
+ switch (tap) {
+ case TAP_3:
+ for (int i = 0; i < connector->count_modes; i++) {
+ total_pixels = connector->modes[i].hdisplay * connector->modes[i].vdisplay;
+
+ if (total_pixels <= MAX_PIXELS_FOR_3_TAP_FILTER) {
+ mode = &connector->modes[i];
+ break;
+ }
+ }
+ break;
+ case TAP_5:
+ for (int i = 0; i < connector->count_modes; i++) {
+ total_pixels = connector->modes[i].hdisplay * connector->modes[i].vdisplay;
+
+ if (total_pixels > MAX_PIXELS_FOR_3_TAP_FILTER &&
+ total_pixels <= MAX_PIXELS_FOR_5_TAP_FILTER) {
+ mode = &connector->modes[i];
+ break;
+ }
+ }
+ break;
+ case TAP_7:
+ for (int i = 0; i < connector->count_modes; i++) {
+ total_pixels = connector->modes[i].hdisplay * connector->modes[i].vdisplay;
+
+ if (total_pixels > MAX_PIXELS_FOR_5_TAP_FILTER) {
+ mode = &connector->modes[i];
+ break;
+ }
+ }
+ break;
+ default:
+ igt_assert(0);
+ }
+
+ return mode;
+}
+
+static void paint_image(igt_fb_t *fb)
+{
+ cairo_t *cr = igt_get_cairo_ctx(fb->fd, fb);
+ int img_x, img_y, img_w, img_h;
+ const char *file = "1080p-left.png";
+
+ img_x = img_y = 0;
+ img_w = fb->width;
+ img_h = fb->height;
+
+ igt_paint_image(cr, file, img_x, img_y, img_w, img_h);
+
+ igt_put_cairo_ctx(cr);
+}
+
+static void setup_fb(int fd, int width, int height, uint32_t format,
+ uint64_t modifier, struct igt_fb *fb)
+{
+ int fb_id;
+
+ fb_id = igt_create_fb(fd, width, height, format, modifier, fb);
+ igt_assert(fb_id);
+
+ paint_image(fb);
+}
+
+static void cleanup_fbs(data_t *data)
+{
+ for (int i = 0; i < ARRAY_SIZE(data->fb); i++)
+ igt_remove_fb(data->drm_fd, &data->fb[i]);
+}
+
+static void cleanup(data_t *data)
+{
+ igt_display_reset(&data->display);
+
+ cleanup_fbs(data);
+}
+
+static void set_planes(data_t *data, enum test_type type)
+{
+ int ret;
+ drmModeModeInfo *mode = data->mode;
+ igt_output_t *output = data->output;
+
+ data->plane[1] = igt_output_get_plane(output, 1);
+ data->plane[2] = igt_output_get_plane(output, 2);
+
+ if (type == TEST_FILTER_UPSCALE) {
+ setup_fb(data->drm_fd, 20, 20, data->format, data->modifier, &data->fb[1]);
+ igt_plane_set_fb(data->plane[1], &data->fb[1]);
+ igt_plane_set_size(data->plane[1], mode->hdisplay, mode->vdisplay);
+ }
+
+ if (type == TEST_FILTER_DOWNSCALE) {
+ setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[1]);
+ igt_plane_set_fb(data->plane[1], &data->fb[1]);
+ igt_plane_set_size(data->plane[1], mode->hdisplay * 0.75, mode->vdisplay * 0.75);
+ }
+
+ if (type == TEST_INVALID_FILTER_WITH_SCALER) {
+ setup_fb(data->drm_fd, 20, 20, data->format, data->modifier, &data->fb[1]);
+ setup_fb(data->drm_fd, 20, 20, data->format, data->modifier, &data->fb[2]);
+ igt_plane_set_fb(data->plane[1], &data->fb[1]);
+ igt_plane_set_fb(data->plane[2], &data->fb[2]);
+ igt_plane_set_size(data->plane[1], mode->hdisplay, mode->vdisplay);
+ igt_plane_set_size(data->plane[2], mode->hdisplay, mode->vdisplay);
+ }
+
+ if (type == TEST_INVALID_FILTER_WITH_PLANE) {
+ setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[1]);
+ setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[2]);
+ igt_plane_set_fb(data->plane[1], &data->fb[1]);
+ igt_plane_set_fb(data->plane[2], &data->fb[2]);
+ }
+
+ if (type == TEST_INVALID_PLANE_WITH_FILTER) {
+ setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[1]);
+ igt_plane_set_fb(data->plane[1], &data->fb[1]);
+ }
+
+ if (type == TEST_INVALID_FILTER_WITH_SCALING_MODE) {
+ setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[1]);
+ setup_fb(data->drm_fd, 640, 480, data->format, data->modifier, &data->fb[2]);
+ igt_plane_set_fb(data->plane[1], &data->fb[1]);
+ igt_plane_set_fb(data->plane[2], &data->fb[2]);
+
+ ret = igt_display_try_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+ igt_assert_eq(ret, 0);
+
+ mode->hdisplay = 640;
+ mode->vdisplay = 480;
+
+ igt_output_override_mode(data->output, mode);
+ igt_plane_set_fb(data->plane[2], NULL);
+ igt_plane_set_fb(data->plane[1], &data->fb[2]);
+
+ igt_output_set_prop_value(data->output, IGT_CONNECTOR_SCALING_MODE, data->scaling_mode);
+ }
+}
+
+static void test_sharpness_filter(data_t *data, enum test_type type)
+{
+ igt_output_t *output = data->output;
+ drmModeModeInfo *mode = data->mode;
+ int height = mode->hdisplay;
+ int width = mode->vdisplay;
+ int ret;
+
+ igt_display_reset(&data->display);
+ igt_output_set_pipe(output, data->pipe_id);
+
+ if (type == TEST_FILTER_TAP) {
+ mode = get_mode(output, data->filter_tap);
+ igt_require(mode != NULL);
+ igt_output_override_mode(output, mode);
+ }
+
+ data->plane[0] = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY);
+ igt_skip_on_f(!igt_plane_has_format_mod(data->plane[0], data->format, data->modifier),
+ "No requested format/modifier on pipe %s\n", kmstest_pipe_name(data->pipe_id));
+
+ setup_fb(data->drm_fd, height, width, data->format, data->modifier, &data->fb[0]);
+ igt_plane_set_fb(data->plane[0], &data->fb[0]);
+
+ if (igt_plane_has_rotation(data->plane[0], data->rotation))
+ igt_plane_set_rotation(data->plane[0], data->rotation);
+ else
+ igt_skip("No requested rotation on pipe %s\n", kmstest_pipe_name(data->pipe_id));
+
+ if (type == TEST_INVALID_FILTER_WITH_SCALING_MODE)
+ igt_require_f(has_scaling_mode(output), "No connecter scaling mode found on %s\n", output->name);
+
+ if (SET_PLANES)
+ set_planes(data, type);
+
+ /* Set filter strength property */
+ set_filter_strength_on_pipe(data);
+
+ if (!INVALID_TEST && data->filter_strength != 0)
+ igt_debug("Sharpened image should be observed for filter strength > 0\n");
+
+ if (type == TEST_INVALID_FILTER_WITH_SCALING_MODE)
+ ret = igt_display_try_commit_atomic(&data->display, 0, NULL);
+ else
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+
+ if (type == TEST_FILTER_DPMS) {
+ kmstest_set_connector_dpms(data->drm_fd,
+ output->config.connector,
+ DRM_MODE_DPMS_OFF);
+ kmstest_set_connector_dpms(data->drm_fd,
+ output->config.connector,
+ DRM_MODE_DPMS_ON);
+ }
+
+ if (type == TEST_FILTER_SUSPEND)
+ igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
+ SUSPEND_TEST_NONE);
+
+ if (type == TEST_INVALID_PLANE_WITH_FILTER) {
+ data->plane[3] = igt_output_get_plane(data->output, 3);
+ setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[3]);
+ igt_plane_set_fb(data->plane[3], &data->fb[3]);
+
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ }
+
+ if (type == TEST_FILTER_DOWNSCALE)
+ igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
+ "Scaling op not supported, cdclk limits might be exceeded.\n");
+
+ if (INVALID_TEST)
+ igt_assert_eq(ret, -EINVAL);
+ else
+ igt_assert_eq(ret, 0);
+
+ cleanup(data);
+}
+
+static bool has_sharpness_filter(igt_pipe_t *pipe)
+{
+ return igt_pipe_obj_has_prop(pipe, IGT_CRTC_SHARPNESS_STRENGTH);
+}
+
+static void
+run_sharpness_filter_test(data_t *data, enum test_type type)
+{
+ igt_display_t *display = &data->display;
+ igt_output_t *output;
+ enum pipe pipe;
+ char name[40];
+
+ for_each_pipe_with_valid_output(display, pipe, output) {
+ igt_display_reset(display);
+
+ data->output = output;
+ data->pipe_id = pipe;
+ data->pipe = &display->pipes[data->pipe_id];
+ data->mode = igt_output_get_mode(data->output);
+
+ if (!has_sharpness_filter(data->pipe)) {
+ igt_info("%s: Doesn't support IGT_CRTC_SHARPNESS_STRENGTH.\n",
+ kmstest_pipe_name(pipe));
+ continue;
+ }
+
+ igt_output_set_pipe(output, pipe);
+
+ if (!intel_pipe_output_combo_valid(display)) {
+ igt_output_set_pipe(output, PIPE_NONE);
+ continue;
+ }
+
+ switch (type) {
+ case TEST_FILTER_BASIC:
+ snprintf(name, sizeof(name), "-basic");
+ break;
+ case TEST_FILTER_TAP:
+ snprintf(name, sizeof(name), "-tap-%d", data->filter_tap);
+ break;
+ case TEST_FILTER_TOGGLE:
+ snprintf(name, sizeof(name), "-toggle");
+ break;
+ case TEST_FILTER_MODIFIERS:
+ snprintf(name, sizeof(name), "-%s", data->modifier_name);
+ break;
+ case TEST_FILTER_ROTATION:
+ snprintf(name, sizeof(name), "-%srot", igt_plane_rotation_name(data->rotation));
+ break;
+ case TEST_FILTER_FORMATS:
+ snprintf(name, sizeof(name), "-%s", igt_format_str(data->format));
+ break;
+ case TEST_FILTER_DPMS:
+ snprintf(name, sizeof(name), "-dpms");
+ break;
+ case TEST_FILTER_SUSPEND:
+ snprintf(name, sizeof(name), "-suspend");
+ break;
+ case TEST_FILTER_UPSCALE:
+ snprintf(name, sizeof(name), "-upscale");
+ break;
+ case TEST_FILTER_DOWNSCALE:
+ snprintf(name, sizeof(name), "-downscale");
+ break;
+ case TEST_INVALID_FILTER_WITH_SCALER:
+ snprintf(name, sizeof(name), "-invalid-filter-with-scaler");
+ break;
+ case TEST_INVALID_FILTER_WITH_PLANE:
+ snprintf(name, sizeof(name), "-invalid-filter-with-plane");
+ break;
+ case TEST_INVALID_PLANE_WITH_FILTER:
+ snprintf(name, sizeof(name), "-invalid-plane-with-filter");
+ break;
+ case TEST_FILTER_STRENGTH:
+ snprintf(name, sizeof(name), "-strength-%d", data->filter_strength);
+ break;
+ case TEST_INVALID_FILTER_WITH_SCALING_MODE:
+ snprintf(name, sizeof(name), "-invalid-filter-with-scaling-mode-%s", kmstest_scaling_mode_str(data->scaling_mode));
+ break;
+ default:
+ igt_assert(0);
+ }
+
+ igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(data->pipe_id), data->output->name, name)
+ test_sharpness_filter(data, type);
+
+ if (data->limited)
+ break;
+ }
+}
+
+static int opt_handler(int opt, int opt_index, void *_data)
+{
+ data_t *data = _data;
+
+ switch (opt) {
+ case 'l':
+ data->limited = true;
+ break;
+ default:
+ return IGT_OPT_HANDLER_ERROR;
+ }
+
+ return IGT_OPT_HANDLER_SUCCESS;
+}
+
+static const char help_str[] =
+ " --limited|-l\t\tLimit execution to 1 valid pipe-output combo\n";
+
+data_t data = {};
+
+igt_main_args("l", NULL, help_str, opt_handler, &data)
+{
+ igt_fixture {
+ data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+
+ kmstest_set_vt_graphics_mode();
+
+ igt_display_require(&data.display, data.drm_fd);
+ igt_require(data.display.is_atomic);
+ igt_display_require_output(&data.display);
+ }
+
+ igt_describe("Verify basic content adaptive sharpness filter.");
+ igt_subtest_with_dynamic("filter-basic") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_FILTER_BASIC);
+ }
+
+ igt_describe("Verify that following a resolution change, "
+ "distict taps are selected.");
+ igt_subtest_with_dynamic("filter-tap") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ for (int k = 0; k < ARRAY_SIZE(filter_tap_list); k++) {
+ data.filter_tap = filter_tap_list[k];
+
+ run_sharpness_filter_test(&data, TEST_FILTER_TAP);
+ }
+ }
+
+ igt_describe("Verify that varying strength(0-255), affects "
+ "the degree of sharpeness applied.");
+ igt_subtest_with_dynamic("filter-strength") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+
+ for (int k = 0; k < ARRAY_SIZE(filter_strength_list); k++) {
+ data.filter_strength = filter_strength_list[k];
+
+ run_sharpness_filter_test(&data, TEST_FILTER_STRENGTH);
+ }
+ }
+
+ igt_describe("Verify toggling between enabling and disabling "
+ "content adaptive sharpness filter.");
+ igt_subtest_with_dynamic("filter-toggle") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+
+ for (int k = 0; k < NROUNDS; k++) {
+ data.filter_strength = DISABLE_FILTER;
+ run_sharpness_filter_test(&data, TEST_FILTER_TOGGLE);
+ data.filter_strength = MAX_FILTER_STRENGTH;
+ run_sharpness_filter_test(&data, TEST_FILTER_TOGGLE);
+ }
+ }
+
+ igt_describe("Verify content adaptive sharpness filter with "
+ "varying modifiers.");
+ igt_subtest_with_dynamic("filter-modifiers") {
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ for (int k = 0; k < ARRAY_SIZE(modifiers); k++) {
+ data.modifier = modifiers[k].modifier;
+ data.modifier_name = modifiers[k].name;
+
+ run_sharpness_filter_test(&data, TEST_FILTER_MODIFIERS);
+ }
+ }
+
+ igt_describe("Verify content adaptive sharpness filter with "
+ "varying rotations.");
+ igt_subtest_with_dynamic("filter-rotations") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ for (int k = 0; k < ARRAY_SIZE(rotations); k++) {
+ data.rotation = rotations[k];
+
+ run_sharpness_filter_test(&data, TEST_FILTER_ROTATION);
+ }
+ }
+
+ igt_describe("Verify content adaptive sharpness filter with "
+ "varying formats.");
+ igt_subtest_with_dynamic("filter-formats") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ for (int k = 0; k < ARRAY_SIZE(formats); k++) {
+ data.format = formats[k];
+
+ run_sharpness_filter_test(&data, TEST_FILTER_FORMATS);
+ }
+ }
+
+ igt_describe("Verify content adaptive sharpness filter "
+ "with DPMS.");
+ igt_subtest_with_dynamic("filter-dpms") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_FILTER_DPMS);
+ }
+
+ igt_describe("Verify content adaptive sharpness filter "
+ "with suspend.");
+ igt_subtest_with_dynamic("filter-suspend") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_FILTER_SUSPEND);
+ }
+
+ igt_describe("Verify content adaptive sharpness filter "
+ "with 1 plane scaler enabled.");
+ igt_subtest_with_dynamic("filter-scaler-upscale") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_FILTER_UPSCALE);
+ }
+
+ igt_describe("Verify content adaptive sharpness filter "
+ "with 1 plane scaler enabled.");
+ igt_subtest_with_dynamic("filter-scaler-downscale") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_FILTER_DOWNSCALE);
+ }
+
+ igt_describe("Negative check for content adaptive sharpness filter "
+ "when 2 plane scalers have already been enabled and "
+ "attempt is made to enable sharpness filter.");
+ igt_subtest_with_dynamic("invalid-filter-with-scaler") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_INVALID_FILTER_WITH_SCALER);
+ }
+
+ igt_describe("Negative check for content adaptive sharpness filter "
+ "when 2 NV12 planes have already been enabled and attempt is "
+ "made to enable the sharpness filter.");
+ igt_subtest_with_dynamic("invalid-filter-with-plane") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_NV12;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_INVALID_FILTER_WITH_PLANE);
+ }
+
+ igt_describe("Negative check for content adaptive sharpness filter "
+ "when 1 NV12 plane and sharpness filter have already been enabled "
+ "and attempt is made to enable the second NV12 plane.");
+ igt_subtest_with_dynamic("invalid-plane-with-filter") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_NV12;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ run_sharpness_filter_test(&data, TEST_INVALID_PLANE_WITH_FILTER);
+ }
+
+ igt_describe("Negative check for content adaptive sharpness filter "
+ "when scaling mode is already enabled and attempt is made "
+ "to enable sharpness filter.");
+ igt_subtest_with_dynamic("invalid-filter-with-scaling-mode") {
+ data.modifier = DRM_FORMAT_MOD_LINEAR;
+ data.rotation = IGT_ROTATION_0;
+ data.format = DRM_FORMAT_XRGB8888;
+ data.filter_strength = MID_FILTER_STRENGTH;
+
+ for (int k = 0; k < ARRAY_SIZE(scaling_modes); k++) {
+ data.scaling_mode = scaling_modes[k];
+
+ run_sharpness_filter_test(&data, TEST_INVALID_FILTER_WITH_SCALING_MODE);
+ }
+ }
+
+ igt_fixture {
+ igt_display_fini(&data.display);
+ drm_close_driver(data.drm_fd);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index e5d8852f3..7f5bc68d3 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -58,6 +58,7 @@ test_progs = [
'kms_sequence',
'kms_setmode',
'kms_sysfs_edid_timing',
+ 'kms_sharpness_filter',
'kms_tiled_display',
'kms_tv_load_detect',
'kms_universal_plane',
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH i-g-t 4/4] tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness chamelium filter test
2024-10-18 19:06 [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter Swati Sharma
` (2 preceding siblings ...)
2024-10-18 19:06 ` [PATCH i-g-t v7 3/4] tests/kms_sharpness_filter: Add adaptive sharpness filter test Swati Sharma
@ 2024-10-18 19:06 ` Swati Sharma
2024-10-22 12:20 ` Kamil Konieczny
2024-11-11 13:20 ` Nautiyal, Ankit K
2024-10-18 19:39 ` ✓ CI.xeBAT: success for Add new test to validate adaptive sharpness filter (rev8) Patchwork
` (2 subsequent siblings)
6 siblings, 2 replies; 13+ messages in thread
From: Swati Sharma @ 2024-10-18 19:06 UTC (permalink / raw)
To: igt-dev; +Cc: Swati Sharma
Add new chamelium based sharpness test. Basic test is added where
we have tried comparing frame dump of unsharped and sharped image.
After, sharpness filter is applied its expected both frame dumps
will be different.
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
.../kms_chamelium_sharpness_filter.c | 250 ++++++++++++++++++
tests/meson.build | 2 +
2 files changed, 252 insertions(+)
create mode 100644 tests/chamelium/kms_chamelium_sharpness_filter.c
diff --git a/tests/chamelium/kms_chamelium_sharpness_filter.c b/tests/chamelium/kms_chamelium_sharpness_filter.c
new file mode 100644
index 000000000..a60d22b63
--- /dev/null
+++ b/tests/chamelium/kms_chamelium_sharpness_filter.c
@@ -0,0 +1,250 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+/**
+ * TEST: kms chamelium sharpness filter
+ * Category: Display
+ * Description: Test to validate content adaptive sharpness filter using Chamelium
+ * Driver requirement: xe
+ * Functionality: chamelium, casf
+ * Mega feature: General Display Features
+ * Test category: functionality test
+ */
+
+#include "igt.h"
+#include "igt_kms.h"
+
+/**
+ * SUBTEST: filter-basic
+ * Description: Verify basic content adaptive sharpness filter.
+ */
+
+IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter using Chamelium");
+
+#define DISABLE_FILTER 0
+#define MIN_FILTER_STRENGTH 1
+#define MID_FILTER_STRENGTH 128
+#define MAX_FILTER_STRENGTH 255
+
+typedef struct {
+ int drm_fd;
+ enum pipe pipe_id;
+ struct igt_fb fb, fb_ref;
+ igt_display_t display;
+ igt_output_t *output;
+ igt_plane_t *primary;
+ drmModeModeInfo *mode;
+ int filter_strength;
+ struct chamelium *chamelium;
+ struct chamelium_port **ports;
+ int port_count;
+} data_t;
+
+static bool pipe_output_combo_valid(data_t *data, enum pipe pipe)
+{
+ bool ret = true;
+
+ igt_output_set_pipe(data->output, pipe);
+ if (!intel_pipe_output_combo_valid(&data->display))
+ ret = false;
+ igt_output_set_pipe(data->output, PIPE_NONE);
+
+ return ret;
+}
+
+static void disable_filter_strength_on_pipe(data_t *data)
+{
+ igt_pipe_set_prop_value(&data->display, data->pipe_id,
+ IGT_CRTC_SHARPNESS_STRENGTH,
+ DISABLE_FILTER);
+}
+
+static void set_filter_strength_on_pipe(data_t *data)
+{
+ igt_pipe_set_prop_value(&data->display, data->pipe_id,
+ IGT_CRTC_SHARPNESS_STRENGTH,
+ data->filter_strength);
+}
+
+static void paint_image(igt_fb_t *fb)
+{
+ cairo_t *cr = igt_get_cairo_ctx(fb->fd, fb);
+ int img_x, img_y, img_w, img_h;
+ const char *file = "1080p-left.png";
+
+ img_x = img_y = 0;
+ img_w = fb->width;
+ img_h = fb->height;
+
+ igt_paint_image(cr, file, img_x, img_y, img_w, img_h);
+
+ igt_put_cairo_ctx(cr);
+}
+
+static void setup_fb(int fd, int width, int height, uint32_t format,
+ uint64_t modifier, struct igt_fb *fb)
+{
+ int fb_id;
+
+ fb_id = igt_create_fb(fd, width, height, format, modifier, fb);
+ igt_assert(fb_id);
+
+ paint_image(fb);
+}
+
+static void cleanup(data_t *data)
+{
+ igt_remove_fb(data->drm_fd, &data->fb);
+ igt_remove_fb(data->drm_fd, &data->fb_ref);
+ igt_output_set_pipe(data->output, PIPE_NONE);
+ igt_output_override_mode(data->output, NULL);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+}
+
+
+static bool test_t(data_t *data, igt_plane_t *primary,
+ struct chamelium_port *port)
+{
+ igt_output_t *output = data->output;
+ drmModeModeInfo *mode = data->mode;
+ struct chamelium_frame_dump *dump;
+ int height = mode->hdisplay;
+ int width = mode->vdisplay;
+ bool ret = false;
+
+ igt_output_set_pipe(output, data->pipe_id);
+
+ setup_fb(data->drm_fd, height, width, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fb_ref);
+ setup_fb(data->drm_fd, height, width, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fb);
+
+ igt_plane_set_fb(data->primary, &data->fb_ref);
+ disable_filter_strength_on_pipe(data);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+
+ igt_plane_set_fb(data->primary, &data->fb);
+ set_filter_strength_on_pipe(data);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
+
+ igt_debug("Reading frame dumps from Chamelium...\n");
+ chamelium_capture(data->chamelium, port, 0, 0, 0, 0, 1);
+ dump = chamelium_read_captured_frame(data->chamelium, 0);
+
+ ret = chamelium_frame_match_or_dump(data->chamelium, port,
+ dump, &data->fb_ref,
+ CHAMELIUM_CHECK_ANALOG);
+ chamelium_destroy_frame_dump(dump);
+ cleanup(data);
+
+ return ret;
+}
+
+static int test_setup(data_t *data, enum pipe p)
+{
+ igt_pipe_t *pipe;
+ int i = 0;
+
+ igt_display_reset(&data->display);
+ igt_modeset_disable_all_outputs(&data->display);
+ chamelium_reset_state(&data->display, data->chamelium, NULL,
+ data->ports, data->port_count);
+
+ pipe = &data->display.pipes[p];
+ igt_require(pipe->n_planes >= 0);
+
+ data->primary = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
+ igt_assert(data->primary);
+
+ /*
+ * Prefer to run this test on HDMI connector if its connected, since on DP we
+ * sometimes face DP FSM issue
+ */
+ for_each_valid_output_on_pipe(&data->display, p, data->output) {
+ for (i = 0; i < data->port_count; i++) {
+ if ((data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+ data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) &&
+ strcmp(data->output->name, chamelium_port_get_name(data->ports[i])) == 0)
+ return i;
+ }
+ }
+
+ for_each_valid_output_on_pipe(&data->display, p, data->output) {
+ for (i = 0; i < data->port_count; i++) {
+ if (strcmp(data->output->name,
+ chamelium_port_get_name(data->ports[i])) == 0)
+ return i;
+ }
+ }
+
+ return -1;
+}
+
+static void test_sharpness_filter(data_t *data, enum pipe p)
+{
+ int port_idx = test_setup(data, p);
+
+ igt_require(port_idx >= 0);
+ igt_require(igt_pipe_obj_has_prop(&data->display.pipes[p], IGT_CRTC_SHARPNESS_STRENGTH));
+
+ if (!pipe_output_combo_valid(data, p))
+ return;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)
+ igt_assert_f(test_t(data, data->primary, data->ports[port_idx]) == 0, "No sharpness observed.\n");
+}
+
+static void
+run_sharpness_filter_test(data_t *data)
+{
+ igt_display_t *display = &data->display;
+ enum pipe pipe;
+
+ igt_describe("Verify basic content adaptive sharpness filter.");
+ igt_subtest_with_dynamic("filter-basic") {
+ for_each_pipe(display, pipe) {
+ data->filter_strength = MID_FILTER_STRENGTH;
+ test_sharpness_filter(data, pipe);
+ }
+ }
+}
+
+igt_main
+{
+ data_t data = {};
+
+ igt_fixture {
+ data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+
+ igt_display_require(&data.display, data.drm_fd);
+ igt_require(data.display.is_atomic);
+
+ igt_chamelium_allow_fsm_handling = false;
+
+ /* we need to initalize chamelium after igt_display_require */
+ data.chamelium = chamelium_init(data.drm_fd, &data.display);
+ igt_require(data.chamelium);
+
+ data.ports = chamelium_get_ports(data.chamelium,
+ &data.port_count);
+
+ if (!data.port_count)
+ igt_skip("No ports connected\n");
+ /*
+ * We don't cause any harm by plugging
+ * discovered ports, just incase they are not plugged
+ * we currently skip in test_setup
+ */
+ for(int i = 0; i < data.port_count; i++)
+ chamelium_plug(data.chamelium, data.ports[i]);
+
+ kmstest_set_vt_graphics_mode();
+ }
+
+ run_sharpness_filter_test(&data);
+
+ igt_fixture {
+ igt_display_fini(&data.display);
+ drm_close_driver(data.drm_fd);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index 7f5bc68d3..1fa47d09d 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -335,6 +335,7 @@ chamelium_progs = [
'kms_chamelium_edid',
'kms_chamelium_frames',
'kms_chamelium_hpd',
+ 'kms_chamelium_sharpness_filter',
]
test_deps = [ igt_deps ]
@@ -360,6 +361,7 @@ extra_sources = {
'kms_chamelium_edid': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
'kms_chamelium_frames': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
'kms_chamelium_hpd': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
+ 'kms_chamelium_sharpness_filter': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
'kms_dsc': [ join_paths ('intel', 'kms_dsc_helper.c') ],
'kms_psr2_sf': [ join_paths ('intel', 'kms_dsc_helper.c') ],
}
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* ✓ CI.xeBAT: success for Add new test to validate adaptive sharpness filter (rev8)
2024-10-18 19:06 [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter Swati Sharma
` (3 preceding siblings ...)
2024-10-18 19:06 ` [PATCH i-g-t 4/4] tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness chamelium " Swati Sharma
@ 2024-10-18 19:39 ` Patchwork
2024-10-18 19:41 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-19 12:08 ` ✗ CI.xeFULL: " Patchwork
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2024-10-18 19:39 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4542 bytes --]
== Series Details ==
Series: Add new test to validate adaptive sharpness filter (rev8)
URL : https://patchwork.freedesktop.org/series/130218/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_8080_BAT -> XEIGTPW_11939_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in XEIGTPW_11939_BAT that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-7: [PASS][1] -> [FAIL][2] ([Intel XE#1861])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html
* igt@xe_evict@evict-beng-small:
- bat-adlp-7: NOTRUN -> [SKIP][3] ([Intel XE#261] / [Intel XE#688]) +15 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-adlp-7/igt@xe_evict@evict-beng-small.html
* igt@xe_exec_fault_mode@twice-bindexecqueue-userptr:
- bat-dg2-oem2: NOTRUN -> [SKIP][4] ([Intel XE#288]) +32 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-dg2-oem2/igt@xe_exec_fault_mode@twice-bindexecqueue-userptr.html
* igt@xe_exec_fault_mode@twice-userptr-invalidate-prefetch:
- bat-adlp-7: NOTRUN -> [SKIP][5] ([Intel XE#288]) +32 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-adlp-7/igt@xe_exec_fault_mode@twice-userptr-invalidate-prefetch.html
* igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit:
- bat-bmg-1: [PASS][6] -> [INCOMPLETE][7] ([Intel XE#2874] / [Intel XE#2998]) +1 other test incomplete
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/bat-bmg-1/igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit.html
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-bmg-1/igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit.html
* igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit:
- bat-dg2-oem2: NOTRUN -> [SKIP][8] ([Intel XE#2229])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-dg2-oem2/igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit.html
- bat-adlp-7: NOTRUN -> [SKIP][9] ([Intel XE#2229])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-adlp-7/igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit.html
#### Possible fixes ####
* igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit:
- bat-adlp-7: [INCOMPLETE][10] ([Intel XE#2874]) -> [PASS][11] +1 other test pass
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/bat-adlp-7/igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit.html
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-adlp-7/igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit.html
- bat-dg2-oem2: [INCOMPLETE][12] ([Intel XE#2874]) -> [PASS][13] +1 other test pass
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/bat-dg2-oem2/igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit.html
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/bat-dg2-oem2/igt@xe_live_ktest@xe_bo@xe_bo_shrink_kunit.html
[Intel XE#1861]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1861
[Intel XE#2229]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2229
[Intel XE#261]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/261
[Intel XE#2874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2874
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#2998]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2998
[Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
Build changes
-------------
* IGT: IGT_8080 -> IGTPW_11939
* Linux: xe-2091-c1837d4e9af4e9df3109960341105c035b441667 -> xe-2093-cebb76fe419dd92609fb86e59c9671387c5325a3
IGTPW_11939: b0417f829d6e4a0b235de9d7d95068d0c4fbaeb1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8080: 20fcbc59241a16c84d12f4f6ba390fb46fd65a36 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-2091-c1837d4e9af4e9df3109960341105c035b441667: c1837d4e9af4e9df3109960341105c035b441667
xe-2093-cebb76fe419dd92609fb86e59c9671387c5325a3: cebb76fe419dd92609fb86e59c9671387c5325a3
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/index.html
[-- Attachment #2: Type: text/html, Size: 5555 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✗ Fi.CI.BAT: failure for Add new test to validate adaptive sharpness filter (rev8)
2024-10-18 19:06 [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter Swati Sharma
` (4 preceding siblings ...)
2024-10-18 19:39 ` ✓ CI.xeBAT: success for Add new test to validate adaptive sharpness filter (rev8) Patchwork
@ 2024-10-18 19:41 ` Patchwork
2024-10-19 12:08 ` ✗ CI.xeFULL: " Patchwork
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2024-10-18 19:41 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 3705 bytes --]
== Series Details ==
Series: Add new test to validate adaptive sharpness filter (rev8)
URL : https://patchwork.freedesktop.org/series/130218/
State : failure
== Summary ==
CI Bug Log - changes from IGT_8080 -> IGTPW_11939
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_11939 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_11939, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11939/index.html
Participating hosts (43 -> 40)
------------------------------
Missing (3): bat-rplp-1 fi-snb-2520m bat-dg1-6
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_11939:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@uncore:
- bat-jsl-3: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8080/bat-jsl-3/igt@i915_selftest@live@uncore.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11939/bat-jsl-3/igt@i915_selftest@live@uncore.html
Known issues
------------
Here are the changes found in IGTPW_11939 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][3] -> [ABORT][4] ([i915#12216]) +1 other test abort
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8080/bat-mtlp-8/igt@i915_selftest@live.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11939/bat-mtlp-8/igt@i915_selftest@live.html
- bat-jsl-3: [PASS][5] -> [DMESG-WARN][6] ([i915#12434])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8080/bat-jsl-3/igt@i915_selftest@live.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11939/bat-jsl-3/igt@i915_selftest@live.html
#### Possible fixes ####
* igt@i915_selftest@live:
- bat-arlh-2: [ABORT][7] ([i915#12133]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8080/bat-arlh-2/igt@i915_selftest@live.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11939/bat-arlh-2/igt@i915_selftest@live.html
* igt@i915_selftest@live@workarounds:
- bat-arlh-2: [ABORT][9] ([i915#12061]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8080/bat-arlh-2/igt@i915_selftest@live@workarounds.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11939/bat-arlh-2/igt@i915_selftest@live@workarounds.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
[i915#12216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12216
[i915#12434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12434
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_8080 -> IGTPW_11939
* Linux: CI_DRM_15559 -> CI_DRM_15561
CI-20190529: 20190529
CI_DRM_15559: c1837d4e9af4e9df3109960341105c035b441667 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_15561: cebb76fe419dd92609fb86e59c9671387c5325a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_11939: b0417f829d6e4a0b235de9d7d95068d0c4fbaeb1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8080: 20fcbc59241a16c84d12f4f6ba390fb46fd65a36 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11939/index.html
[-- Attachment #2: Type: text/html, Size: 4410 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✗ CI.xeFULL: failure for Add new test to validate adaptive sharpness filter (rev8)
2024-10-18 19:06 [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter Swati Sharma
` (5 preceding siblings ...)
2024-10-18 19:41 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2024-10-19 12:08 ` Patchwork
6 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2024-10-19 12:08 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 67603 bytes --]
== Series Details ==
Series: Add new test to validate adaptive sharpness filter (rev8)
URL : https://patchwork.freedesktop.org/series/130218/
State : failure
== Summary ==
CI Bug Log - changes from XEIGT_8080_full -> XEIGTPW_11939_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with XEIGTPW_11939_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_11939_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in XEIGTPW_11939_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_chamelium_sharpness_filter@filter-basic (NEW):
- shard-dg2-set2: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_chamelium_sharpness_filter@filter-basic.html
* igt@kms_pm_rpm@universal-planes@plane-77:
- shard-lnl: [PASS][2] -> [DMESG-WARN][3]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-4/igt@kms_pm_rpm@universal-planes@plane-77.html
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-3/igt@kms_pm_rpm@universal-planes@plane-77.html
* igt@kms_sharpness_filter@filter-toggle (NEW):
- shard-lnl: NOTRUN -> [SKIP][4] +14 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-1/igt@kms_sharpness_filter@filter-toggle.html
* igt@kms_sharpness_filter@invalid-filter-with-scaling-mode (NEW):
- {shard-bmg}: NOTRUN -> [SKIP][5] +14 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-2/igt@kms_sharpness_filter@invalid-filter-with-scaling-mode.html
* igt@xe_vm@large-misaligned-binds-268435456:
- shard-dg2-set2: NOTRUN -> [DMESG-WARN][6]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@xe_vm@large-misaligned-binds-268435456.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-modifiers:
- {shard-bmg}: [SKIP][7] ([Intel XE#3007]) -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-4/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-modifiers.html
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-5/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-modifiers.html
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers:
- {shard-bmg}: [SKIP][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-8/igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers.html
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-2/igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers.html
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers@pipe-c:
- {shard-bmg}: NOTRUN -> [DMESG-WARN][11] +11 other tests dmesg-warn
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-2/igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers@pipe-c.html
* igt@kms_vblank@wait-busy:
- {shard-bmg}: [PASS][12] -> [INCOMPLETE][13] +1 other test incomplete
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-1/igt@kms_vblank@wait-busy.html
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-8/igt@kms_vblank@wait-busy.html
New tests
---------
New tests have been introduced between XEIGT_8080_full and XEIGTPW_11939_full:
### New IGT tests (16) ###
* igt@kms_chamelium_sharpness_filter@filter-basic:
- Statuses : 3 skip(s)
- Exec time: [0.0] s
* igt@kms_sharpness_filter@filter-basic:
- Statuses : 3 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_sharpness_filter@filter-dpms:
- Statuses : 3 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_sharpness_filter@filter-formats:
- Statuses : 3 skip(s)
- Exec time: [0.00, 0.01] s
* igt@kms_sharpness_filter@filter-modifiers:
- Statuses : 3 skip(s)
- Exec time: [0.00, 0.01] s
* igt@kms_sharpness_filter@filter-rotations:
- Statuses : 2 skip(s)
- Exec time: [0.00] s
* igt@kms_sharpness_filter@filter-scaler-downscale:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_sharpness_filter@filter-scaler-upscale:
- Statuses : 3 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_sharpness_filter@filter-strength:
- Statuses : 3 skip(s)
- Exec time: [0.00, 0.01] s
* igt@kms_sharpness_filter@filter-suspend:
- Statuses : 3 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_sharpness_filter@filter-tap:
- Statuses : 3 skip(s)
- Exec time: [0.00, 0.01] s
* igt@kms_sharpness_filter@filter-toggle:
- Statuses : 3 skip(s)
- Exec time: [0.01, 0.03] s
* igt@kms_sharpness_filter@invalid-filter-with-plane:
- Statuses : 2 skip(s)
- Exec time: [0.0, 0.00] s
* igt@kms_sharpness_filter@invalid-filter-with-scaler:
- Statuses : 2 skip(s)
- Exec time: [0.00] s
* igt@kms_sharpness_filter@invalid-filter-with-scaling-mode:
- Statuses : 3 skip(s)
- Exec time: [0.00, 0.01] s
* igt@kms_sharpness_filter@invalid-plane-with-filter:
- Statuses : 3 skip(s)
- Exec time: [0.00] s
Known issues
------------
Here are the changes found in XEIGTPW_11939_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-dg2-set2: NOTRUN -> [SKIP][14] ([Intel XE#623])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180:
- shard-dg2-set2: [PASS][15] -> [SKIP][16] ([Intel XE#2351] / [Intel XE#2890]) +2 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180.html
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- shard-dg2-set2: NOTRUN -> [SKIP][17] ([Intel XE#316]) +3 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-dg2-set2: NOTRUN -> [SKIP][18] ([Intel XE#1124]) +4 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
* igt@kms_bw@connected-linear-tiling-2-displays-2160x1440p:
- shard-dg2-set2: NOTRUN -> [SKIP][19] ([Intel XE#367]) +1 other test skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_bw@connected-linear-tiling-2-displays-2160x1440p.html
* igt@kms_ccs@bad-aux-stride-4-tiled-mtl-rc-ccs@pipe-b-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][20] ([Intel XE#787]) +69 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@kms_ccs@bad-aux-stride-4-tiled-mtl-rc-ccs@pipe-b-dp-4.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs:
- shard-dg2-set2: NOTRUN -> [SKIP][21] ([Intel XE#2907]) +2 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs@pipe-d-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][22] ([Intel XE#455] / [Intel XE#787]) +18 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs@pipe-d-dp-4.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6:
- shard-dg2-set2: [PASS][23] -> [INCOMPLETE][24] ([Intel XE#1195])
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6.html
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6.html
* igt@kms_cdclk@mode-transition@pipe-d-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][25] ([Intel XE#314]) +3 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_cdclk@mode-transition@pipe-d-dp-4.html
* igt@kms_cdclk@plane-scaling@pipe-b-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][26] ([Intel XE#1152]) +3 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_cdclk@plane-scaling@pipe-b-dp-4.html
* igt@kms_chamelium_color@gamma:
- shard-dg2-set2: NOTRUN -> [SKIP][27] ([Intel XE#306]) +2 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-466/igt@kms_chamelium_color@gamma.html
* igt@kms_chamelium_hpd@hdmi-hpd:
- shard-dg2-set2: NOTRUN -> [SKIP][28] ([Intel XE#373]) +5 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_chamelium_hpd@hdmi-hpd.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-dg2-set2: NOTRUN -> [SKIP][29] ([Intel XE#307])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-466/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_cursor_crc@cursor-rapid-movement-256x85:
- shard-dg2-set2: [PASS][30] -> [SKIP][31] ([Intel XE#2423] / [i915#2575]) +6 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-434/igt@kms_cursor_crc@cursor-rapid-movement-256x85.html
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_cursor_crc@cursor-rapid-movement-256x85.html
* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-dg2-set2: NOTRUN -> [SKIP][32] ([Intel XE#2423] / [i915#2575]) +3 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-dg2-set2: [PASS][33] -> [FAIL][34] ([Intel XE#1475])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-464/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
- shard-lnl: [PASS][35] -> [FAIL][36] ([Intel XE#1475])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-3/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1:
- shard-lnl: [PASS][37] -> [FAIL][38] ([Intel XE#886]) +5 other tests fail
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-5/igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1.html
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-4/igt@kms_flip@wf_vblank-ts-check-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling:
- shard-dg2-set2: [PASS][39] -> [SKIP][40] ([Intel XE#2890]) +1 other test skip
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-436/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling.html
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling:
- shard-dg2-set2: NOTRUN -> [SKIP][41] ([Intel XE#455]) +26 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling.html
* igt@kms_frontbuffer_tracking@drrs-1p-primscrn-cur-indfb-onoff:
- shard-dg2-set2: NOTRUN -> [SKIP][42] ([Intel XE#651]) +17 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-432/igt@kms_frontbuffer_tracking@drrs-1p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@drrs-2p-pri-indfb-multidraw:
- shard-dg2-set2: NOTRUN -> [SKIP][43] ([Intel XE#2890])
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_frontbuffer_tracking@drrs-2p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-linear:
- shard-dg2-set2: NOTRUN -> [SKIP][44] ([Intel XE#653]) +21 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_frontbuffer_tracking@fbcpsr-tiling-linear.html
* igt@kms_getfb@getfb-reject-ccs:
- shard-dg2-set2: NOTRUN -> [SKIP][45] ([Intel XE#605])
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_getfb@getfb-reject-ccs.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-6:
- shard-dg2-set2: [PASS][46] -> [FAIL][47] ([Intel XE#361])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-435/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-6.html
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-6.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c:
- shard-dg2-set2: NOTRUN -> [SKIP][48] ([Intel XE#2763]) +2 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d:
- shard-dg2-set2: NOTRUN -> [SKIP][49] ([Intel XE#2763] / [Intel XE#455])
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-d.html
* igt@kms_pm_dc@dc5-psr:
- shard-lnl: [PASS][50] -> [FAIL][51] ([Intel XE#718])
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-1/igt@kms_pm_dc@dc5-psr.html
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-7/igt@kms_pm_dc@dc5-psr.html
* igt@kms_pm_rpm@legacy-planes-dpms:
- shard-dg2-set2: [PASS][52] -> [SKIP][53] ([Intel XE#2446])
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-435/igt@kms_pm_rpm@legacy-planes-dpms.html
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_pm_rpm@legacy-planes-dpms.html
* igt@kms_pm_rpm@universal-planes:
- shard-lnl: [PASS][54] -> [DMESG-WARN][55] ([Intel XE#2042])
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-4/igt@kms_pm_rpm@universal-planes.html
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-3/igt@kms_pm_rpm@universal-planes.html
* igt@kms_psr2_sf@pr-overlay-primary-update-sf-dmg-area:
- shard-dg2-set2: NOTRUN -> [SKIP][56] ([Intel XE#1489]) +3 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@kms_psr2_sf@pr-overlay-primary-update-sf-dmg-area.html
* igt@kms_psr@fbc-psr-sprite-render:
- shard-dg2-set2: NOTRUN -> [SKIP][57] ([Intel XE#2850] / [Intel XE#929]) +5 other tests skip
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_psr@fbc-psr-sprite-render.html
* igt@kms_sharpness_filter@filter-scaler-downscale (NEW):
- {shard-bmg}: NOTRUN -> [SKIP][58] ([Intel XE#3007])
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-5/igt@kms_sharpness_filter@filter-scaler-downscale.html
* igt@kms_universal_plane@cursor-fb-leak:
- shard-lnl: [PASS][59] -> [FAIL][60] ([Intel XE#899]) +1 other test fail
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-7/igt@kms_universal_plane@cursor-fb-leak.html
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-7/igt@kms_universal_plane@cursor-fb-leak.html
* igt@kms_vrr@cmrr:
- shard-dg2-set2: NOTRUN -> [SKIP][61] ([Intel XE#2168])
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_vrr@cmrr.html
* igt@kms_vrr@flip-basic-fastset:
- shard-lnl: [PASS][62] -> [FAIL][63] ([Intel XE#2443]) +1 other test fail
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-4/igt@kms_vrr@flip-basic-fastset.html
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-4/igt@kms_vrr@flip-basic-fastset.html
* igt@xe_compute_preempt@compute-preempt-many:
- shard-dg2-set2: NOTRUN -> [SKIP][64] ([Intel XE#1280] / [Intel XE#455]) +1 other test skip
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@xe_compute_preempt@compute-preempt-many.html
* igt@xe_exec_balancer@once-parallel-rebind:
- shard-dg2-set2: [PASS][65] -> [SKIP][66] ([Intel XE#1130]) +16 other tests skip
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@xe_exec_balancer@once-parallel-rebind.html
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_exec_balancer@once-parallel-rebind.html
* igt@xe_exec_compute_mode@twice-bindexecqueue-userptr-invalidate-race:
- shard-lnl: [PASS][67] -> [DMESG-WARN][68] ([Intel XE#2687])
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-8/igt@xe_exec_compute_mode@twice-bindexecqueue-userptr-invalidate-race.html
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-6/igt@xe_exec_compute_mode@twice-bindexecqueue-userptr-invalidate-race.html
* igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-userptr-invalidate-race:
- shard-dg2-set2: NOTRUN -> [SKIP][69] ([Intel XE#288]) +10 other tests skip
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_exec_fault_mode@many-execqueues-bindexecqueue-userptr-invalidate-race.html
* igt@xe_exec_fault_mode@many-execqueues-rebind:
- shard-dg2-set2: NOTRUN -> [SKIP][70] ([Intel XE#1130]) +3 other tests skip
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_exec_fault_mode@many-execqueues-rebind.html
* igt@xe_exec_reset@parallel-gt-reset:
- shard-dg2-set2: NOTRUN -> [TIMEOUT][71] ([Intel XE#2105])
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-432/igt@xe_exec_reset@parallel-gt-reset.html
* igt@xe_exec_reset@virtual-close-fd:
- shard-dg2-set2: [PASS][72] -> [FAIL][73] ([Intel XE#1081])
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@xe_exec_reset@virtual-close-fd.html
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@xe_exec_reset@virtual-close-fd.html
* igt@xe_exec_sip_eudebug@breakpoint-writesip:
- shard-dg2-set2: NOTRUN -> [SKIP][74] ([Intel XE#2905]) +5 other tests skip
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@xe_exec_sip_eudebug@breakpoint-writesip.html
* igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit:
- shard-dg2-set2: NOTRUN -> [SKIP][75] ([Intel XE#2229])
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit.html
* igt@xe_live_ktest@xe_mocs@xe_live_mocs_kernel_kunit:
- shard-dg2-set2: NOTRUN -> [FAIL][76] ([Intel XE#1999]) +2 other tests fail
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_live_ktest@xe_mocs@xe_live_mocs_kernel_kunit.html
* igt@xe_oa@missing-sample-flags:
- shard-dg2-set2: NOTRUN -> [SKIP][77] ([Intel XE#2541]) +3 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@xe_oa@missing-sample-flags.html
* igt@xe_pat@pat-index-xe2:
- shard-dg2-set2: NOTRUN -> [SKIP][78] ([Intel XE#977])
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@xe_pat@pat-index-xe2.html
* igt@xe_pat@pat-index-xelpg:
- shard-dg2-set2: NOTRUN -> [SKIP][79] ([Intel XE#979])
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-432/igt@xe_pat@pat-index-xelpg.html
* igt@xe_peer2peer@read@read-gpua-vram01-gpub-system-p2p:
- shard-dg2-set2: NOTRUN -> [FAIL][80] ([Intel XE#1173]) +1 other test fail
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@xe_peer2peer@read@read-gpua-vram01-gpub-system-p2p.html
* igt@xe_pm@s3-vm-bind-prefetch:
- shard-dg2-set2: [PASS][81] -> [ABORT][82] ([Intel XE#1794])
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-466/igt@xe_pm@s3-vm-bind-prefetch.html
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-432/igt@xe_pm@s3-vm-bind-prefetch.html
* igt@xe_pm@s4-basic-exec:
- shard-dg2-set2: NOTRUN -> [ABORT][83] ([Intel XE#1358] / [Intel XE#1794])
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-432/igt@xe_pm@s4-basic-exec.html
* igt@xe_pm_residency@toggle-gt-c6:
- shard-lnl: [PASS][84] -> [FAIL][85] ([Intel XE#958])
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-1/igt@xe_pm_residency@toggle-gt-c6.html
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-7/igt@xe_pm_residency@toggle-gt-c6.html
* igt@xe_query@multigpu-query-engines:
- shard-dg2-set2: NOTRUN -> [SKIP][86] ([Intel XE#944]) +3 other tests skip
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@xe_query@multigpu-query-engines.html
#### Possible fixes ####
* igt@fbdev@write:
- shard-dg2-set2: [SKIP][87] ([Intel XE#2134]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@fbdev@write.html
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@fbdev@write.html
- {shard-bmg}: [SKIP][89] ([Intel XE#2134]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-4/igt@fbdev@write.html
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-2/igt@fbdev@write.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-0:
- {shard-bmg}: [SKIP][91] ([Intel XE#829]) -> [PASS][92] +1 other test pass
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-8/igt@kms_big_fb@4-tiled-64bpp-rotate-0.html
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-7/igt@kms_big_fb@4-tiled-64bpp-rotate-0.html
* igt@kms_big_fb@linear-16bpp-rotate-0:
- shard-dg2-set2: [SKIP][93] ([Intel XE#829]) -> [PASS][94] +1 other test pass
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_big_fb@linear-16bpp-rotate-0.html
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-466/igt@kms_big_fb@linear-16bpp-rotate-0.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- {shard-bmg}: [SKIP][95] ([Intel XE#2231] / [Intel XE#2890]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-4/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-7/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs:
- {shard-bmg}: [FAIL][97] ([Intel XE#2436]) -> [PASS][98] +3 other tests pass
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-7/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs.html
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-8/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs.html
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- {shard-bmg}: [SKIP][99] ([Intel XE#3007]) -> [PASS][100] +5 other tests pass
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-4/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-5/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
- shard-dg2-set2: [SKIP][101] ([Intel XE#2423] / [i915#2575]) -> [PASS][102] +3 other tests pass
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
* igt@kms_dirtyfb@default-dirtyfb-ioctl:
- {shard-bmg}: [SKIP][103] ([Intel XE#2231]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-4/igt@kms_dirtyfb@default-dirtyfb-ioctl.html
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-8/igt@kms_dirtyfb@default-dirtyfb-ioctl.html
* igt@kms_fbcon_fbt@fbc:
- shard-dg2-set2: [SKIP][105] ([Intel XE#2351] / [Intel XE#2890]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_fbcon_fbt@fbc.html
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_fbcon_fbt@fbc.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a6-dp4:
- shard-dg2-set2: [FAIL][107] ([Intel XE#301]) -> [PASS][108] +16 other tests pass
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-434/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a6-dp4.html
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a6-dp4.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-dp2-hdmi-a3:
- {shard-bmg}: [FAIL][109] ([Intel XE#301]) -> [PASS][110] +3 other tests pass
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-1/igt@kms_flip@2x-flip-vs-expired-vblank@ab-dp2-hdmi-a3.html
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-2/igt@kms_flip@2x-flip-vs-expired-vblank@ab-dp2-hdmi-a3.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-dg2-set2: [ABORT][111] ([Intel XE#2625]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-432/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-466/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible@cd-hdmi-a6-dp4:
- shard-dg2-set2: [ABORT][113] -> [PASS][114] +1 other test pass
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-432/igt@kms_flip@2x-flip-vs-suspend-interruptible@cd-hdmi-a6-dp4.html
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-466/igt@kms_flip@2x-flip-vs-suspend-interruptible@cd-hdmi-a6-dp4.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1:
- shard-lnl: [FAIL][115] ([Intel XE#886]) -> [PASS][116] +7 other tests pass
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-6/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-7/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a6:
- shard-dg2-set2: [FAIL][117] ([Intel XE#1204]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-434/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a6.html
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a6.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-dg2-set2: [SKIP][119] ([Intel XE#783]) -> [PASS][120] +1 other test pass
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc.html
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-dg2-set2: [SKIP][121] ([Intel XE#2890]) -> [PASS][122] +3 other tests pass
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move.html
* igt@kms_plane_cursor@viewport:
- shard-dg2-set2: [FAIL][123] ([Intel XE#616]) -> [PASS][124] +1 other test pass
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-464/igt@kms_plane_cursor@viewport.html
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-466/igt@kms_plane_cursor@viewport.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-dp-4:
- shard-dg2-set2: [FAIL][125] ([Intel XE#361]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-435/igt@kms_plane_scaling@intel-max-src-size@pipe-a-dp-4.html
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_plane_scaling@intel-max-src-size@pipe-a-dp-4.html
* igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers:
- shard-dg2-set2: [SKIP][127] -> [PASS][128] +8 other tests pass
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers.html
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_plane_scaling@plane-upscale-factor-0-25-with-modifiers.html
* igt@kms_properties@connector-properties-legacy:
- {shard-bmg}: [SKIP][129] -> [PASS][130] +7 other tests pass
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-8/igt@kms_properties@connector-properties-legacy.html
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-8/igt@kms_properties@connector-properties-legacy.html
* igt@kms_psr@psr2-cursor-blt@edp-1:
- shard-lnl: [FAIL][131] ([Intel XE#2948]) -> [PASS][132] +3 other tests pass
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-7/igt@kms_psr@psr2-cursor-blt@edp-1.html
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-8/igt@kms_psr@psr2-cursor-blt@edp-1.html
* igt@kms_psr@psr2-primary-blt@edp-1:
- shard-lnl: [FAIL][133] ([Intel XE#1649]) -> [PASS][134] +1 other test pass
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-4/igt@kms_psr@psr2-primary-blt@edp-1.html
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-8/igt@kms_psr@psr2-primary-blt@edp-1.html
* igt@kms_rotation_crc@primary-x-tiled-reflect-x-0:
- {shard-bmg}: [INCOMPLETE][135] -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-8/igt@kms_rotation_crc@primary-x-tiled-reflect-x-0.html
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-8/igt@kms_rotation_crc@primary-x-tiled-reflect-x-0.html
* igt@kms_vblank@accuracy-idle:
- shard-lnl: [FAIL][137] ([Intel XE#1523]) -> [PASS][138] +1 other test pass
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-7/igt@kms_vblank@accuracy-idle.html
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-4/igt@kms_vblank@accuracy-idle.html
* igt@kms_vrr@flipline:
- shard-lnl: [FAIL][139] ([Intel XE#2443]) -> [PASS][140] +3 other tests pass
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-8/igt@kms_vrr@flipline.html
[140]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-6/igt@kms_vrr@flipline.html
* igt@xe_evict@evict-beng-mixed-many-threads-small:
- {shard-bmg}: [INCOMPLETE][141] ([Intel XE#1473]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-8/igt@xe_evict@evict-beng-mixed-many-threads-small.html
[142]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-4/igt@xe_evict@evict-beng-mixed-many-threads-small.html
* igt@xe_evict@evict-beng-threads-large:
- shard-dg2-set2: [TIMEOUT][143] ([Intel XE#1473]) -> [PASS][144]
[143]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-466/igt@xe_evict@evict-beng-threads-large.html
[144]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_evict@evict-beng-threads-large.html
* igt@xe_exec_compute_mode@many-userptr-invalidate:
- shard-lnl: [DMESG-WARN][145] ([Intel XE#2687]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-1/igt@xe_exec_compute_mode@many-userptr-invalidate.html
[146]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-8/igt@xe_exec_compute_mode@many-userptr-invalidate.html
* igt@xe_exec_compute_mode@non-blocking:
- {shard-bmg}: [SKIP][147] ([Intel XE#1130]) -> [PASS][148] +14 other tests pass
[147]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-4/igt@xe_exec_compute_mode@non-blocking.html
[148]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-7/igt@xe_exec_compute_mode@non-blocking.html
* igt@xe_exec_reset@parallel-close-fd:
- {shard-bmg}: [FAIL][149] -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-8/igt@xe_exec_reset@parallel-close-fd.html
[150]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-5/igt@xe_exec_reset@parallel-close-fd.html
- shard-dg2-set2: [FAIL][151] -> [PASS][152]
[151]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-436/igt@xe_exec_reset@parallel-close-fd.html
[152]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@xe_exec_reset@parallel-close-fd.html
* igt@xe_module_load@reload-no-display:
- {shard-bmg}: [FAIL][153] ([Intel XE#2136]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-bmg-8/igt@xe_module_load@reload-no-display.html
[154]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-bmg-8/igt@xe_module_load@reload-no-display.html
- shard-dg2-set2: [FAIL][155] ([Intel XE#1204] / [Intel XE#2136]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@xe_module_load@reload-no-display.html
[156]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_module_load@reload-no-display.html
* igt@xe_oa@oa-exponents@ccs-0:
- shard-lnl: [FAIL][157] -> [PASS][158] +2 other tests pass
[157]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-7/igt@xe_oa@oa-exponents@ccs-0.html
[158]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-4/igt@xe_oa@oa-exponents@ccs-0.html
* igt@xe_oa@oa-regs-whitelisted:
- shard-lnl: [FAIL][159] ([Intel XE#2514]) -> [PASS][160] +1 other test pass
[159]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-8/igt@xe_oa@oa-regs-whitelisted.html
[160]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-3/igt@xe_oa@oa-regs-whitelisted.html
* igt@xe_pm@s4-basic:
- shard-dg2-set2: [ABORT][161] ([Intel XE#1358]) -> [PASS][162]
[161]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-432/igt@xe_pm@s4-basic.html
[162]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_pm@s4-basic.html
* igt@xe_pm_residency@idle-residency-on-exec:
- shard-dg2-set2: [INCOMPLETE][163] ([Intel XE#1195]) -> [PASS][164] +1 other test pass
[163]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@xe_pm_residency@idle-residency-on-exec.html
[164]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_pm_residency@idle-residency-on-exec.html
* igt@xe_vm@large-misaligned-binds-268435456:
- shard-lnl: [DMESG-WARN][165] -> [PASS][166]
[165]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-1/igt@xe_vm@large-misaligned-binds-268435456.html
[166]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-7/igt@xe_vm@large-misaligned-binds-268435456.html
* igt@xe_vm@large-userptr-misaligned-binds-2097152:
- shard-dg2-set2: [SKIP][167] ([Intel XE#1130]) -> [PASS][168] +9 other tests pass
[167]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@xe_vm@large-userptr-misaligned-binds-2097152.html
[168]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@xe_vm@large-userptr-misaligned-binds-2097152.html
#### Warnings ####
* igt@kms_big_fb@y-tiled-32bpp-rotate-180:
- shard-dg2-set2: [SKIP][169] ([Intel XE#2890]) -> [SKIP][170] ([Intel XE#1124])
[169]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html
[170]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_big_fb@y-tiled-32bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-dg2-set2: [SKIP][171] ([Intel XE#1124]) -> [SKIP][172] ([Intel XE#2351] / [Intel XE#2890])
[171]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-435/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[172]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- shard-dg2-set2: [SKIP][173] ([Intel XE#829]) -> [SKIP][174] ([Intel XE#1124])
[173]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html
[174]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-270:
- shard-dg2-set2: [SKIP][175] ([Intel XE#1124]) -> [SKIP][176] ([Intel XE#2890])
[175]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-436/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html
[176]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html
* igt@kms_bw@connected-linear-tiling-1-displays-2560x1440p:
- shard-dg2-set2: [SKIP][177] ([Intel XE#2423] / [i915#2575]) -> [SKIP][178] ([Intel XE#367])
[177]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_bw@connected-linear-tiling-1-displays-2560x1440p.html
[178]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_bw@connected-linear-tiling-1-displays-2560x1440p.html
* igt@kms_bw@linear-tiling-1-displays-2160x1440p:
- shard-dg2-set2: [SKIP][179] -> [SKIP][180] ([Intel XE#367])
[179]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_bw@linear-tiling-1-displays-2160x1440p.html
[180]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-432/igt@kms_bw@linear-tiling-1-displays-2160x1440p.html
* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-mc-ccs:
- shard-dg2-set2: [SKIP][181] ([Intel XE#829]) -> [SKIP][182] ([Intel XE#2890])
[181]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_ccs@bad-aux-stride-y-tiled-gen12-mc-ccs.html
[182]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_ccs@bad-aux-stride-y-tiled-gen12-mc-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs:
- shard-dg2-set2: [SKIP][183] ([Intel XE#2890]) -> [SKIP][184] ([Intel XE#455] / [Intel XE#787])
[183]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs.html
[184]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-mc-ccs.html
* igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs:
- shard-dg2-set2: [SKIP][185] ([Intel XE#455] / [Intel XE#787]) -> [SKIP][186] ([Intel XE#2351] / [Intel XE#2890])
[185]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-436/igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs.html
[186]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs.html
* igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs:
- shard-dg2-set2: [INCOMPLETE][187] ([Intel XE#1195] / [Intel XE#1727]) -> [INCOMPLETE][188] ([Intel XE#1195])
[187]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs.html
[188]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-dg2-set2: [SKIP][189] ([Intel XE#314]) -> [SKIP][190] ([Intel XE#2351] / [Intel XE#2890])
[189]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_cdclk@mode-transition-all-outputs.html
[190]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode:
- shard-dg2-set2: [SKIP][191] ([Intel XE#373]) -> [SKIP][192] ([Intel XE#2423] / [i915#2575])
[191]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-436/igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode.html
[192]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode.html
* igt@kms_chamelium_hpd@dp-hpd-storm-disable:
- shard-dg2-set2: [SKIP][193] ([Intel XE#2423] / [i915#2575]) -> [SKIP][194] ([Intel XE#373])
[193]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_chamelium_hpd@dp-hpd-storm-disable.html
[194]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_chamelium_hpd@dp-hpd-storm-disable.html
* igt@kms_content_protection@dp-mst-type-1:
- shard-dg2-set2: [SKIP][195] -> [SKIP][196] ([Intel XE#307])
[195]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_content_protection@dp-mst-type-1.html
[196]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_content_protection@dp-mst-type-1.html
* igt@kms_content_protection@lic-type-1:
- shard-dg2-set2: [SKIP][197] ([Intel XE#2423] / [i915#2575]) -> [SKIP][198] ([Intel XE#455])
[197]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_content_protection@lic-type-1.html
[198]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-432/igt@kms_content_protection@lic-type-1.html
* igt@kms_cursor_crc@cursor-sliding-max-size:
- shard-dg2-set2: [SKIP][199] ([Intel XE#455]) -> [SKIP][200] ([Intel XE#2423] / [i915#2575]) +1 other test skip
[199]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-464/igt@kms_cursor_crc@cursor-sliding-max-size.html
[200]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_cursor_crc@cursor-sliding-max-size.html
* igt@kms_dirtyfb@drrs-dirtyfb-ioctl:
- shard-dg2-set2: [SKIP][201] ([Intel XE#455]) -> [SKIP][202] ([Intel XE#2890])
[201]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_dirtyfb@drrs-dirtyfb-ioctl.html
[202]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_dirtyfb@drrs-dirtyfb-ioctl.html
* igt@kms_dsc@dsc-fractional-bpp-with-bpc:
- shard-dg2-set2: [SKIP][203] ([Intel XE#2351] / [Intel XE#2890]) -> [SKIP][204] ([Intel XE#455])
[203]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_dsc@dsc-fractional-bpp-with-bpc.html
[204]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_dsc@dsc-fractional-bpp-with-bpc.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling:
- shard-dg2-set2: [SKIP][205] -> [SKIP][206] ([Intel XE#2890])
[205]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling.html
[206]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling:
- shard-dg2-set2: [SKIP][207] ([Intel XE#2890]) -> [SKIP][208] ([Intel XE#455])
[207]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling.html
[208]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling.html
* igt@kms_frontbuffer_tracking@drrs-1p-offscren-pri-shrfb-draw-blt:
- shard-dg2-set2: [SKIP][209] ([Intel XE#2351] / [Intel XE#2890]) -> [SKIP][210] ([Intel XE#651])
[209]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_frontbuffer_tracking@drrs-1p-offscren-pri-shrfb-draw-blt.html
[210]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@kms_frontbuffer_tracking@drrs-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@drrs-1p-primscrn-cur-indfb-draw-blt:
- shard-dg2-set2: [SKIP][211] -> [SKIP][212] ([Intel XE#651]) +1 other test skip
[211]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_frontbuffer_tracking@drrs-1p-primscrn-cur-indfb-draw-blt.html
[212]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-464/igt@kms_frontbuffer_tracking@drrs-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-pri-indfb-draw-blt:
- shard-dg2-set2: [SKIP][213] ([Intel XE#651]) -> [SKIP][214] ([Intel XE#2890]) +4 other tests skip
[213]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-464/igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-pri-indfb-draw-blt.html
[214]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-spr-indfb-fullscreen:
- shard-dg2-set2: [SKIP][215] ([Intel XE#651]) -> [SKIP][216] ([Intel XE#2351] / [Intel XE#2890])
[215]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-spr-indfb-fullscreen.html
[216]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-spr-indfb-fullscreen.html
* igt@kms_frontbuffer_tracking@fbcdrrs-tiling-linear:
- shard-dg2-set2: [SKIP][217] ([Intel XE#2890]) -> [SKIP][218] ([Intel XE#651]) +1 other test skip
[217]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_frontbuffer_tracking@fbcdrrs-tiling-linear.html
[218]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@kms_frontbuffer_tracking@fbcdrrs-tiling-linear.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-dg2-set2: [SKIP][219] ([Intel XE#2890]) -> [SKIP][220] ([Intel XE#653])
[219]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc.html
[220]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-fullscreen:
- shard-dg2-set2: [SKIP][221] -> [SKIP][222] ([Intel XE#653])
[221]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-fullscreen.html
[222]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-432/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-fullscreen.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-dg2-set2: [SKIP][223] ([Intel XE#783]) -> [SKIP][224] ([Intel XE#653])
[223]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc.html
[224]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-466/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-dg2-set2: [SKIP][225] ([Intel XE#2351] / [Intel XE#2890]) -> [SKIP][226] ([Intel XE#653]) +1 other test skip
[225]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html
[226]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- shard-dg2-set2: [SKIP][227] ([Intel XE#653]) -> [SKIP][228] ([Intel XE#2890]) +1 other test skip
[227]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html
[228]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-onoff:
- shard-dg2-set2: [SKIP][229] ([Intel XE#653]) -> [SKIP][230] ([Intel XE#2351] / [Intel XE#2890])
[229]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-434/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-onoff.html
[230]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_joiner@basic-big-joiner:
- shard-dg2-set2: [SKIP][231] ([Intel XE#346]) -> [SKIP][232] ([Intel XE#2890])
[231]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-466/igt@kms_joiner@basic-big-joiner.html
[232]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_joiner@basic-big-joiner.html
* igt@kms_joiner@basic-force-ultra-joiner:
- shard-dg2-set2: [SKIP][233] ([Intel XE#2890]) -> [SKIP][234] ([Intel XE#2925])
[233]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_joiner@basic-force-ultra-joiner.html
[234]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-436/igt@kms_joiner@basic-force-ultra-joiner.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25:
- shard-dg2-set2: [SKIP][235] -> [SKIP][236] ([Intel XE#2763] / [Intel XE#455])
[235]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25.html
[236]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25.html
* igt@kms_pm_backlight@fade:
- shard-dg2-set2: [SKIP][237] ([Intel XE#870]) -> [SKIP][238] ([Intel XE#2890])
[237]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-434/igt@kms_pm_backlight@fade.html
[238]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_pm_backlight@fade.html
* igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf:
- shard-dg2-set2: [SKIP][239] -> [SKIP][240] ([Intel XE#1489]) +1 other test skip
[239]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf.html
[240]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf.html
* igt@kms_psr@fbc-pr-cursor-plane-move:
- shard-dg2-set2: [SKIP][241] ([Intel XE#2850] / [Intel XE#929]) -> [SKIP][242] ([Intel XE#2890])
[241]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-432/igt@kms_psr@fbc-pr-cursor-plane-move.html
[242]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_psr@fbc-pr-cursor-plane-move.html
* igt@kms_psr@fbc-pr-cursor-render:
- shard-dg2-set2: [SKIP][243] ([Intel XE#2890]) -> [SKIP][244] ([Intel XE#2850] / [Intel XE#929])
[243]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_psr@fbc-pr-cursor-render.html
[244]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-435/igt@kms_psr@fbc-pr-cursor-render.html
* igt@kms_psr@fbc-pr-no-drrs:
- shard-dg2-set2: [SKIP][245] ([Intel XE#2850] / [Intel XE#929]) -> [SKIP][246] ([Intel XE#2351] / [Intel XE#2890])
[245]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-436/igt@kms_psr@fbc-pr-no-drrs.html
[246]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_psr@fbc-pr-no-drrs.html
* igt@kms_psr@pr-sprite-blt:
- shard-dg2-set2: [SKIP][247] -> [SKIP][248] ([Intel XE#2850] / [Intel XE#929]) +1 other test skip
[247]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_psr@pr-sprite-blt.html
[248]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-466/igt@kms_psr@pr-sprite-blt.html
* igt@kms_psr@psr-cursor-render:
- shard-dg2-set2: [SKIP][249] ([Intel XE#2351] / [Intel XE#2890]) -> [SKIP][250] ([Intel XE#2850] / [Intel XE#929])
[249]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@kms_psr@psr-cursor-render.html
[250]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@kms_psr@psr-cursor-render.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-dg2-set2: [FAIL][251] ([Intel XE#1729]) -> [SKIP][252] ([Intel XE#362])
[251]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-464/igt@kms_tiled_display@basic-test-pattern.html
[252]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-463/igt@kms_tiled_display@basic-test-pattern.html
* igt@kms_vrr@max-min:
- shard-dg2-set2: [SKIP][253] -> [SKIP][254] ([Intel XE#455])
[253]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-433/igt@kms_vrr@max-min.html
[254]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@kms_vrr@max-min.html
* igt@xe_copy_basic@mem-copy-linear-0x369:
- shard-dg2-set2: [SKIP][255] ([Intel XE#1123]) -> [SKIP][256] ([Intel XE#1130])
[255]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-432/igt@xe_copy_basic@mem-copy-linear-0x369.html
[256]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_copy_basic@mem-copy-linear-0x369.html
* igt@xe_eudebug@multiple-sessions:
- shard-dg2-set2: [SKIP][257] ([Intel XE#2905]) -> [SKIP][258] ([Intel XE#1130]) +3 other tests skip
[257]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-464/igt@xe_eudebug@multiple-sessions.html
[258]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_eudebug@multiple-sessions.html
* igt@xe_eudebug_online@breakpoint-not-in-debug-mode:
- shard-dg2-set2: [SKIP][259] ([Intel XE#1130]) -> [SKIP][260] ([Intel XE#2905])
[259]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@xe_eudebug_online@breakpoint-not-in-debug-mode.html
[260]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@xe_eudebug_online@breakpoint-not-in-debug-mode.html
* igt@xe_exec_compute_mode@once-bindexecqueue-userptr-invalidate-race:
- shard-lnl: [DMESG-WARN][261] ([Intel XE#2687]) -> [FAIL][262] ([Intel XE#2754])
[261]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-5/igt@xe_exec_compute_mode@once-bindexecqueue-userptr-invalidate-race.html
[262]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-5/igt@xe_exec_compute_mode@once-bindexecqueue-userptr-invalidate-race.html
* igt@xe_exec_fault_mode@once-rebind:
- shard-dg2-set2: [SKIP][263] ([Intel XE#288]) -> [SKIP][264] ([Intel XE#1130]) +3 other tests skip
[263]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-436/igt@xe_exec_fault_mode@once-rebind.html
[264]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_exec_fault_mode@once-rebind.html
* igt@xe_exec_fault_mode@twice-userptr-prefetch:
- shard-dg2-set2: [SKIP][265] ([Intel XE#1130]) -> [SKIP][266] ([Intel XE#288]) +2 other tests skip
[265]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@xe_exec_fault_mode@twice-userptr-prefetch.html
[266]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-464/igt@xe_exec_fault_mode@twice-userptr-prefetch.html
* igt@xe_oa@closed-fd-and-unmapped-access:
- shard-dg2-set2: [SKIP][267] ([Intel XE#1130]) -> [SKIP][268] ([Intel XE#2541])
[267]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@xe_oa@closed-fd-and-unmapped-access.html
[268]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-433/igt@xe_oa@closed-fd-and-unmapped-access.html
* igt@xe_pm@d3cold-multiple-execs:
- shard-dg2-set2: [SKIP][269] ([Intel XE#1130]) -> [SKIP][270] ([Intel XE#2284] / [Intel XE#366])
[269]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-463/igt@xe_pm@d3cold-multiple-execs.html
[270]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_pm@d3cold-multiple-execs.html
* igt@xe_query@multigpu-query-uc-fw-version-huc:
- shard-dg2-set2: [SKIP][271] ([Intel XE#944]) -> [SKIP][272] ([Intel XE#1130])
[271]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-dg2-435/igt@xe_query@multigpu-query-uc-fw-version-huc.html
[272]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-dg2-434/igt@xe_query@multigpu-query-uc-fw-version-huc.html
* igt@xe_wedged@basic-wedged:
- shard-lnl: [DMESG-WARN][273] ([Intel XE#2919]) -> [ABORT][274] ([Intel XE#3119])
[273]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8080/shard-lnl-3/igt@xe_wedged@basic-wedged.html
[274]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/shard-lnl-6/igt@xe_wedged@basic-wedged.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#1081]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1081
[Intel XE#1123]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1123
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1130]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1130
[Intel XE#1152]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1152
[Intel XE#1173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1173
[Intel XE#1195]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1195
[Intel XE#1204]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1204
[Intel XE#1280]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1280
[Intel XE#1358]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1358
[Intel XE#1473]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1473
[Intel XE#1475]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1475
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499
[Intel XE#1508]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1508
[Intel XE#1523]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1523
[Intel XE#1649]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1649
[Intel XE#1695]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1695
[Intel XE#1727]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1727
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#1794]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1794
[Intel XE#1999]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1999
[Intel XE#2042]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2042
[Intel XE#2105]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2105
[Intel XE#2134]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2134
[Intel XE#2136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2136
[Intel XE#2168]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2168
[Intel XE#2229]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2229
[Intel XE#2231]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2231
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2244]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2244
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2284]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2284
[Intel XE#2293]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2293
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2325]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2325
[Intel XE#2333]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2333
[Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
[Intel XE#2351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2351
[Intel XE#2380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2380
[Intel XE#2390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2390
[Intel XE#2423]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2423
[Intel XE#2436]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2436
[Intel XE#2443]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2443
[Intel XE#2446]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2446
[Intel XE#2514]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2514
[Intel XE#2541]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2541
[Intel XE#2566]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2566
[Intel XE#2625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2625
[Intel XE#2687]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2687
[Intel XE#2724]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2724
[Intel XE#2754]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2754
[Intel XE#2763]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2763
[Intel XE#2791]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2791
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2890]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2890
[Intel XE#2905]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2905
[Intel XE#2907]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2907
[Intel XE#2919]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2919
[Intel XE#2925]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2925
[Intel XE#2934]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2934
[Intel XE#2948]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2948
[Intel XE#3007]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3007
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#306]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/306
[Intel XE#307]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/307
[Intel XE#3119]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3119
[Intel XE#314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/314
[Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
[Intel XE#346]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/346
[Intel XE#361]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/361
[Intel XE#362]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/362
[Intel XE#366]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/366
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#605]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/605
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#623]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/623
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#718]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/718
[Intel XE#756]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/756
[Intel XE#783]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/783
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#829]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/829
[Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870
[Intel XE#877]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/877
[Intel XE#886]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/886
[Intel XE#899]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/899
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
[Intel XE#958]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/958
[Intel XE#977]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/977
[Intel XE#979]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/979
[i915#2575]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2575
Build changes
-------------
* IGT: IGT_8080 -> IGTPW_11939
* Linux: xe-2091-c1837d4e9af4e9df3109960341105c035b441667 -> xe-2093-cebb76fe419dd92609fb86e59c9671387c5325a3
IGTPW_11939: b0417f829d6e4a0b235de9d7d95068d0c4fbaeb1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8080: 20fcbc59241a16c84d12f4f6ba390fb46fd65a36 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-2091-c1837d4e9af4e9df3109960341105c035b441667: c1837d4e9af4e9df3109960341105c035b441667
xe-2093-cebb76fe419dd92609fb86e59c9671387c5325a3: cebb76fe419dd92609fb86e59c9671387c5325a3
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11939/index.html
[-- Attachment #2: Type: text/html, Size: 80452 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH i-g-t 4/4] tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness chamelium filter test
2024-10-18 19:06 ` [PATCH i-g-t 4/4] tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness chamelium " Swati Sharma
@ 2024-10-22 12:20 ` Kamil Konieczny
2024-11-11 13:20 ` Nautiyal, Ankit K
1 sibling, 0 replies; 13+ messages in thread
From: Kamil Konieczny @ 2024-10-22 12:20 UTC (permalink / raw)
To: igt-dev; +Cc: Swati Sharma, Louis Chauvet
Hi Swati,
On 2024-10-19 at 00:36:27 +0530, Swati Sharma wrote:
imho you could simplify subject:
tests/chamelium/kms_chamelium_sharpness_filter: Add basic test
> Add new chamelium based sharpness test. Basic test is added where
> we have tried comparing frame dump of unsharped and sharped image.
> After, sharpness filter is applied its expected both frame dumps
s/,//
> will be different.
Adding Louis on Cc: Louis Chauvet <louis.chauvet@bootlin.com>
Regards,
Kamil
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> .../kms_chamelium_sharpness_filter.c | 250 ++++++++++++++++++
> tests/meson.build | 2 +
> 2 files changed, 252 insertions(+)
> create mode 100644 tests/chamelium/kms_chamelium_sharpness_filter.c
>
> diff --git a/tests/chamelium/kms_chamelium_sharpness_filter.c b/tests/chamelium/kms_chamelium_sharpness_filter.c
> new file mode 100644
> index 000000000..a60d22b63
> --- /dev/null
> +++ b/tests/chamelium/kms_chamelium_sharpness_filter.c
> @@ -0,0 +1,250 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2024 Intel Corporation
> + */
> +
> +/**
> + * TEST: kms chamelium sharpness filter
> + * Category: Display
> + * Description: Test to validate content adaptive sharpness filter using Chamelium
> + * Driver requirement: xe
> + * Functionality: chamelium, casf
> + * Mega feature: General Display Features
> + * Test category: functionality test
> + */
> +
> +#include "igt.h"
> +#include "igt_kms.h"
> +
> +/**
> + * SUBTEST: filter-basic
> + * Description: Verify basic content adaptive sharpness filter.
> + */
> +
> +IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter using Chamelium");
> +
> +#define DISABLE_FILTER 0
> +#define MIN_FILTER_STRENGTH 1
> +#define MID_FILTER_STRENGTH 128
> +#define MAX_FILTER_STRENGTH 255
> +
> +typedef struct {
> + int drm_fd;
> + enum pipe pipe_id;
> + struct igt_fb fb, fb_ref;
> + igt_display_t display;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + drmModeModeInfo *mode;
> + int filter_strength;
> + struct chamelium *chamelium;
> + struct chamelium_port **ports;
> + int port_count;
> +} data_t;
> +
> +static bool pipe_output_combo_valid(data_t *data, enum pipe pipe)
> +{
> + bool ret = true;
> +
> + igt_output_set_pipe(data->output, pipe);
> + if (!intel_pipe_output_combo_valid(&data->display))
> + ret = false;
> + igt_output_set_pipe(data->output, PIPE_NONE);
> +
> + return ret;
> +}
> +
> +static void disable_filter_strength_on_pipe(data_t *data)
> +{
> + igt_pipe_set_prop_value(&data->display, data->pipe_id,
> + IGT_CRTC_SHARPNESS_STRENGTH,
> + DISABLE_FILTER);
> +}
> +
> +static void set_filter_strength_on_pipe(data_t *data)
> +{
> + igt_pipe_set_prop_value(&data->display, data->pipe_id,
> + IGT_CRTC_SHARPNESS_STRENGTH,
> + data->filter_strength);
> +}
> +
> +static void paint_image(igt_fb_t *fb)
> +{
> + cairo_t *cr = igt_get_cairo_ctx(fb->fd, fb);
> + int img_x, img_y, img_w, img_h;
> + const char *file = "1080p-left.png";
> +
> + img_x = img_y = 0;
> + img_w = fb->width;
> + img_h = fb->height;
> +
> + igt_paint_image(cr, file, img_x, img_y, img_w, img_h);
> +
> + igt_put_cairo_ctx(cr);
> +}
> +
> +static void setup_fb(int fd, int width, int height, uint32_t format,
> + uint64_t modifier, struct igt_fb *fb)
> +{
> + int fb_id;
> +
> + fb_id = igt_create_fb(fd, width, height, format, modifier, fb);
> + igt_assert(fb_id);
> +
> + paint_image(fb);
> +}
> +
> +static void cleanup(data_t *data)
> +{
> + igt_remove_fb(data->drm_fd, &data->fb);
> + igt_remove_fb(data->drm_fd, &data->fb_ref);
> + igt_output_set_pipe(data->output, PIPE_NONE);
> + igt_output_override_mode(data->output, NULL);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +}
> +
> +
> +static bool test_t(data_t *data, igt_plane_t *primary,
> + struct chamelium_port *port)
> +{
> + igt_output_t *output = data->output;
> + drmModeModeInfo *mode = data->mode;
> + struct chamelium_frame_dump *dump;
> + int height = mode->hdisplay;
> + int width = mode->vdisplay;
> + bool ret = false;
> +
> + igt_output_set_pipe(output, data->pipe_id);
> +
> + setup_fb(data->drm_fd, height, width, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fb_ref);
> + setup_fb(data->drm_fd, height, width, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fb);
> +
> + igt_plane_set_fb(data->primary, &data->fb_ref);
> + disable_filter_strength_on_pipe(data);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +
> + igt_plane_set_fb(data->primary, &data->fb);
> + set_filter_strength_on_pipe(data);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +
> + igt_debug("Reading frame dumps from Chamelium...\n");
> + chamelium_capture(data->chamelium, port, 0, 0, 0, 0, 1);
> + dump = chamelium_read_captured_frame(data->chamelium, 0);
> +
> + ret = chamelium_frame_match_or_dump(data->chamelium, port,
> + dump, &data->fb_ref,
> + CHAMELIUM_CHECK_ANALOG);
> + chamelium_destroy_frame_dump(dump);
> + cleanup(data);
> +
> + return ret;
> +}
> +
> +static int test_setup(data_t *data, enum pipe p)
> +{
> + igt_pipe_t *pipe;
> + int i = 0;
> +
> + igt_display_reset(&data->display);
> + igt_modeset_disable_all_outputs(&data->display);
> + chamelium_reset_state(&data->display, data->chamelium, NULL,
> + data->ports, data->port_count);
> +
> + pipe = &data->display.pipes[p];
> + igt_require(pipe->n_planes >= 0);
> +
> + data->primary = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + igt_assert(data->primary);
> +
> + /*
> + * Prefer to run this test on HDMI connector if its connected, since on DP we
> + * sometimes face DP FSM issue
> + */
> + for_each_valid_output_on_pipe(&data->display, p, data->output) {
> + for (i = 0; i < data->port_count; i++) {
> + if ((data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
> + data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) &&
> + strcmp(data->output->name, chamelium_port_get_name(data->ports[i])) == 0)
> + return i;
> + }
> + }
> +
> + for_each_valid_output_on_pipe(&data->display, p, data->output) {
> + for (i = 0; i < data->port_count; i++) {
> + if (strcmp(data->output->name,
> + chamelium_port_get_name(data->ports[i])) == 0)
> + return i;
> + }
> + }
> +
> + return -1;
> +}
> +
> +static void test_sharpness_filter(data_t *data, enum pipe p)
> +{
> + int port_idx = test_setup(data, p);
> +
> + igt_require(port_idx >= 0);
> + igt_require(igt_pipe_obj_has_prop(&data->display.pipes[p], IGT_CRTC_SHARPNESS_STRENGTH));
> +
> + if (!pipe_output_combo_valid(data, p))
> + return;
> +
> + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)
> + igt_assert_f(test_t(data, data->primary, data->ports[port_idx]) == 0, "No sharpness observed.\n");
> +}
> +
> +static void
> +run_sharpness_filter_test(data_t *data)
> +{
> + igt_display_t *display = &data->display;
> + enum pipe pipe;
> +
> + igt_describe("Verify basic content adaptive sharpness filter.");
> + igt_subtest_with_dynamic("filter-basic") {
> + for_each_pipe(display, pipe) {
> + data->filter_strength = MID_FILTER_STRENGTH;
> + test_sharpness_filter(data, pipe);
> + }
> + }
> +}
> +
> +igt_main
> +{
> + data_t data = {};
> +
> + igt_fixture {
> + data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> +
> + igt_display_require(&data.display, data.drm_fd);
> + igt_require(data.display.is_atomic);
> +
> + igt_chamelium_allow_fsm_handling = false;
> +
> + /* we need to initalize chamelium after igt_display_require */
> + data.chamelium = chamelium_init(data.drm_fd, &data.display);
> + igt_require(data.chamelium);
> +
> + data.ports = chamelium_get_ports(data.chamelium,
> + &data.port_count);
> +
> + if (!data.port_count)
> + igt_skip("No ports connected\n");
> + /*
> + * We don't cause any harm by plugging
> + * discovered ports, just incase they are not plugged
> + * we currently skip in test_setup
> + */
> + for(int i = 0; i < data.port_count; i++)
> + chamelium_plug(data.chamelium, data.ports[i]);
> +
> + kmstest_set_vt_graphics_mode();
> + }
> +
> + run_sharpness_filter_test(&data);
> +
> + igt_fixture {
> + igt_display_fini(&data.display);
> + drm_close_driver(data.drm_fd);
> + }
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index 7f5bc68d3..1fa47d09d 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -335,6 +335,7 @@ chamelium_progs = [
> 'kms_chamelium_edid',
> 'kms_chamelium_frames',
> 'kms_chamelium_hpd',
> + 'kms_chamelium_sharpness_filter',
> ]
>
> test_deps = [ igt_deps ]
> @@ -360,6 +361,7 @@ extra_sources = {
> 'kms_chamelium_edid': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
> 'kms_chamelium_frames': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
> 'kms_chamelium_hpd': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
> + 'kms_chamelium_sharpness_filter': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
> 'kms_dsc': [ join_paths ('intel', 'kms_dsc_helper.c') ],
> 'kms_psr2_sf': [ join_paths ('intel', 'kms_dsc_helper.c') ],
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH i-g-t v7 3/4] tests/kms_sharpness_filter: Add adaptive sharpness filter test
2024-10-18 19:06 ` [PATCH i-g-t v7 3/4] tests/kms_sharpness_filter: Add adaptive sharpness filter test Swati Sharma
@ 2024-10-23 4:20 ` Nautiyal, Ankit K
0 siblings, 0 replies; 13+ messages in thread
From: Nautiyal, Ankit K @ 2024-10-23 4:20 UTC (permalink / raw)
To: Swati Sharma, igt-dev; +Cc: Mohammed Thasleem
On 10/19/2024 12:36 AM, Swati Sharma wrote:
> New test is added to validate adaptive sharpness filter on
> LNL platform. Various testcases are added to validate this
> feature. These are non CRC based tests and manual verification
> is required.
>
> Pipe scaler is repurposed to perform a portion of this work.
> This means pipe scaling will be unavailable while the sharpening
> function is being used. The other scaler can be used for plane
> scaler.
>
> 15 subtests are added:
> -basic: verify basic functionality
> -toggle: switch between enable and disable
> -tap: verify different taps selected based on resolution
> -modifiers: verify casf with different modifiers
> -rotation: verify casf with different rotation
> -formats: verify casf with different formats
> -dpms: verify casf with dpms
> -suspend: verify casf with suspend
> -upscale: apply plane scaler and casf together
> -downscale: apply plane scaler and casf together
> -strength: vary strength and check difference in sharpness
> -invalid filter with scaler: enable scaler on 2 planes and attempt
> is made to enable casf
> -invalid filter with plane: enable 2 NV12 planes and attempt
> is made to enable casf
> -invalid plane with filter: enable 1 NV12 plane and casf and attempt
> is made to enable 2nd NV12 plane
> -invalid filter with scaling mode: enable scaling_mode property and attempt
> is made to enable casf
>
> TODO: -Enable casf with varying output formats (YCBCR/RGB)
>
> v2: -Updated modifier type to uint64_t.
> -Replaced IGT_CRTC_SHARPENESS_STRENGTH with IGT_CRTC_SHARPNESS_STRENGTH.
> v3: -Updated setup_fb with height and width.
> v4: -Renamed tests/intel/kms_sharpness_filter.c -> tests/kms_sharpness_filter.c (Ankit)
> -Added subtest invalid filter with connector. (Ankit)
> -Updated documentation. (Bhanu)
> -Used driver_close_driver instead close. (Bhanu)
> -Added check to avoid debug print for invalid tests and filter strength = 0. (Ankit)
> v5: -Instead of using default strength as MAX, use MID value strength.
> -Add relevant debug print for test skip.
> -Fix indentation.
> -Renamed invalid-filter-with-connector -> invalid-filter-with-scaling-mode
> -Reworked on invalid-filter-with-scaling-mode(), added provision to
> validate other scaling modes.
> v6: -Skip test if ret=-EINVAL for downscaling test.
> -Change if() for tap subtest.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
> ---
> tests/kms_sharpness_filter.c | 750 +++++++++++++++++++++++++++++++++++
> tests/meson.build | 1 +
> 2 files changed, 751 insertions(+)
> create mode 100644 tests/kms_sharpness_filter.c
>
> diff --git a/tests/kms_sharpness_filter.c b/tests/kms_sharpness_filter.c
> new file mode 100644
> index 000000000..5640b40d2
> --- /dev/null
> +++ b/tests/kms_sharpness_filter.c
> @@ -0,0 +1,750 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2024 Intel Corporation
> + */
> +
> +/**
> + * TEST: kms sharpness filter
> + * Category: Display
> + * Description: Test to validate content adaptive sharpness filter
> + * Driver requirement: xe
> + * Functionality: casf
> + * Mega feature: General Display Features
> + * Test category: functionality test
> + */
> +
> +#include "igt.h"
> +#include "igt_kms.h"
> +
> +/**
> + * SUBTEST: filter-basic
> + * Description: Verify basic content adaptive sharpness filter.
> + *
> + * SUBTEST: filter-tap
> + * Description: Verify that following a resolution change, distict taps are selected.
> + *
> + * SUBTEST: filter-strength
> + * Description: Verify that varying strength (0-255), affects the degree of sharpeness applied.
> + *
> + * SUBTEST: filter-toggle
> + * Description: Verify toggling between enabling and disabling content adaptive sharpness filter.
> + *
> + * SUBTEST: filter-modifiers
> + * Description: Verify content adaptive sharpness filter with varying modifiers.
> + * Functionality: casf, tiling
> + *
> + * SUBTEST: filter-rotations
> + * Description: Verify content adaptive sharpness filter with varying rotations.
> + * Functionality: casf, rotation
> + *
> + * SUBTEST: filter-formats
> + * Description: Verify content adaptive sharpness filter with varying formats.
> + * Functionality: casf, pixel-format
> + *
> + * SUBTEST: filter-dpms
> + * Description: Verify content adaptive sharpness filter with DPMS.
> + * Functionality: casf, dpms
> + *
> + * SUBTEST: filter-suspend
> + * Description: Verify content adaptive sharpness filter with suspend.
> + * Functionality: casf, suspend
> + *
> + * SUBTEST: filter-scaler-upscale
> + * Description: Verify content adaptive sharpness filter with 1 plane scaler enabled.
> + * Functionality: casf, scaling
> + *
> + * SUBTEST: filter-scaler-downscale
> + * Description: Verify content adaptive sharpness filter with 1 plane scaler enabled.
> + * Functionality: casf, scaling
> + *
> + * SUBTEST: invalid-filter-with-scaler
> + * Description: Negative check for content adaptive sharpness filter
> + * when 2 plane scalers have already been enabled and
> + * attempt is made to enable sharpness filter.
> + * Functionality: casf, scaling
> + *
> + * SUBTEST: invalid-filter-with-plane
> + * Description: Negative check for content adaptive sharpness filter
> + * when 2 NV12 planes have already been enabled and attempt is
> + * made to enable the sharpness filter.
> + * Functionality: casf, plane
> + *
> + * SUBTEST: invalid-plane-with-filter
> + * Description: Negative check for content adaptive sharpness filter
> + * when 1 NV12 plane and sharpness filter have already been enabled
> + * and attempt is made to enable the second NV12 plane.
> + * Functionality: casf, plane
> + *
> + * SUBTEST: invalid-filter-with-scaling-mode
> + * Description: Negative check for content adaptive sharpness filter
> + * when scaling mode is already enabled and attempt is made to enable
> + * sharpness filter.
> + * Functionality: casf, scaling
> +*/
> +
> +IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
> +
> +/*
> + * Until the CRC support is added test needs to be invoked with
> + * --interactive|--i to manually verify if "sharpened" image
> + * is seen without corruption for each subtest.
> + */
> +
> +#define TAP_3 3
> +#define TAP_5 5
> +#define TAP_7 7
> +#define DISABLE_FILTER 0
> +#define MIN_FILTER_STRENGTH 1
> +#define MID_FILTER_STRENGTH 128
> +#define MAX_FILTER_STRENGTH 255
> +#define MAX_PIXELS_FOR_3_TAP_FILTER (1920 * 1080)
> +#define MAX_PIXELS_FOR_5_TAP_FILTER (3840 * 2160)
> +#define NROUNDS 10
> +#define INVALID_TEST ((type == TEST_INVALID_FILTER_WITH_SCALER) \
> + || (type == TEST_INVALID_FILTER_WITH_PLANE) \
> + || (type == TEST_INVALID_PLANE_WITH_FILTER) \
> + || (type == TEST_INVALID_FILTER_WITH_SCALING_MODE))
> +#define SET_PLANES ((type == TEST_FILTER_UPSCALE) \
> + || (type == TEST_FILTER_DOWNSCALE) \
> + || (type == TEST_INVALID_FILTER_WITH_SCALER) \
> + || (type == TEST_INVALID_FILTER_WITH_PLANE) \
> + || (type == TEST_INVALID_FILTER_WITH_SCALING_MODE))
> +
> +enum test_type {
> + TEST_FILTER_TAP,
> + TEST_FILTER_BASIC,
> + TEST_FILTER_TOGGLE,
> + TEST_FILTER_MODIFIERS,
> + TEST_FILTER_ROTATION,
> + TEST_FILTER_FORMATS,
> + TEST_FILTER_DPMS,
> + TEST_FILTER_SUSPEND,
> + TEST_FILTER_UPSCALE,
> + TEST_FILTER_DOWNSCALE,
> + TEST_FILTER_STRENGTH,
> + TEST_INVALID_FILTER_WITH_SCALER,
> + TEST_INVALID_FILTER_WITH_PLANE,
> + TEST_INVALID_PLANE_WITH_FILTER,
> + TEST_INVALID_FILTER_WITH_SCALING_MODE,
> +};
> +
> +const int filter_strength_list[] = {
> + MIN_FILTER_STRENGTH,
> + (MIN_FILTER_STRENGTH + MID_FILTER_STRENGTH) / 2,
> + MID_FILTER_STRENGTH,
> + (MID_FILTER_STRENGTH + MAX_FILTER_STRENGTH) / 2,
> + MAX_FILTER_STRENGTH,
> +};
> +const int filter_tap_list[] = {
> + TAP_3,
> + TAP_5,
> + TAP_7,
> +};
> +static const struct {
> + uint64_t modifier;
> + const char *name;
> +} modifiers[] = {
> + { DRM_FORMAT_MOD_LINEAR, "linear", },
> + { I915_FORMAT_MOD_X_TILED, "x-tiled", },
> + { I915_FORMAT_MOD_4_TILED, "4-tiled", },
> +};
> +static const int formats[] = {
> + DRM_FORMAT_NV12,
> + DRM_FORMAT_RGB565,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_XBGR16161616F,
> +};
> +static const igt_rotation_t rotations[] = {
> + IGT_ROTATION_0,
> + IGT_ROTATION_180,
> +};
> +static const uint32_t scaling_modes[] = {
> + DRM_MODE_SCALE_FULLSCREEN,
> + DRM_MODE_SCALE_CENTER,
> + DRM_MODE_SCALE_ASPECT,
> +};
> +
> +typedef struct {
> + int drm_fd;
> + bool limited;
> + enum pipe pipe_id;
> + struct igt_fb fb[4];
> + igt_pipe_t *pipe;
> + igt_display_t display;
> + igt_output_t *output;
> + igt_plane_t *plane[4];
> + drmModeModeInfo *mode;
> + int filter_strength;
> + int filter_tap;
> + uint64_t modifier;
> + const char *modifier_name;
> + uint32_t format;
> + igt_rotation_t rotation;
> + uint32_t scaling_mode;
> +} data_t;
> +
> +static void set_filter_strength_on_pipe(data_t *data)
> +{
> + igt_pipe_set_prop_value(&data->display, data->pipe_id,
> + IGT_CRTC_SHARPNESS_STRENGTH,
> + data->filter_strength);
> +}
> +
> +static bool has_scaling_mode(igt_output_t *output)
> +{
> + return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
> + igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
> +}
> +
> +static drmModeModeInfo *get_mode(igt_output_t *output, int tap)
I think we can optimize this.
We are currently looping through the modes for multiple pipes x multiple
taps.
Instead just like filter_taps_list we can have corresponding mode_list
which we can prepare before the test.
Something like:
int get_modes(igt_output_t *output, drmModeModeInfo *mode_list, int
max_modes)
which can fill the modes and return number of modes filled (we may or
may not find modes for each tap).
Then we can just use the modes from this mode_list.
Regards,
Ankit
> +{
> + drmModeConnector *connector = output->config.connector;
> + drmModeModeInfo *mode = NULL;
> + uint64_t total_pixels = 0;
> +
> + /*
> + * TAP 3: mode->hdisplay <= 1920 && mode->vdisplay <= 1080
> + * TAP 5: mode->hdisplay > 1920 && mode->vdisplay > 1080
> + * TAP 7: mode->hdisplay >= 3840 && mode->vdisplay >= 2160
> + */
> + switch (tap) {
> + case TAP_3:
> + for (int i = 0; i < connector->count_modes; i++) {
> + total_pixels = connector->modes[i].hdisplay * connector->modes[i].vdisplay;
> +
> + if (total_pixels <= MAX_PIXELS_FOR_3_TAP_FILTER) {
> + mode = &connector->modes[i];
> + break;
> + }
> + }
> + break;
> + case TAP_5:
> + for (int i = 0; i < connector->count_modes; i++) {
> + total_pixels = connector->modes[i].hdisplay * connector->modes[i].vdisplay;
> +
> + if (total_pixels > MAX_PIXELS_FOR_3_TAP_FILTER &&
> + total_pixels <= MAX_PIXELS_FOR_5_TAP_FILTER) {
> + mode = &connector->modes[i];
> + break;
> + }
> + }
> + break;
> + case TAP_7:
> + for (int i = 0; i < connector->count_modes; i++) {
> + total_pixels = connector->modes[i].hdisplay * connector->modes[i].vdisplay;
> +
> + if (total_pixels > MAX_PIXELS_FOR_5_TAP_FILTER) {
> + mode = &connector->modes[i];
> + break;
> + }
> + }
> + break;
> + default:
> + igt_assert(0);
> + }
> +
> + return mode;
> +}
> +
> +static void paint_image(igt_fb_t *fb)
> +{
> + cairo_t *cr = igt_get_cairo_ctx(fb->fd, fb);
> + int img_x, img_y, img_w, img_h;
> + const char *file = "1080p-left.png";
> +
> + img_x = img_y = 0;
> + img_w = fb->width;
> + img_h = fb->height;
> +
> + igt_paint_image(cr, file, img_x, img_y, img_w, img_h);
> +
> + igt_put_cairo_ctx(cr);
> +}
> +
> +static void setup_fb(int fd, int width, int height, uint32_t format,
> + uint64_t modifier, struct igt_fb *fb)
> +{
> + int fb_id;
> +
> + fb_id = igt_create_fb(fd, width, height, format, modifier, fb);
> + igt_assert(fb_id);
> +
> + paint_image(fb);
> +}
> +
> +static void cleanup_fbs(data_t *data)
> +{
> + for (int i = 0; i < ARRAY_SIZE(data->fb); i++)
> + igt_remove_fb(data->drm_fd, &data->fb[i]);
> +}
> +
> +static void cleanup(data_t *data)
> +{
> + igt_display_reset(&data->display);
> +
> + cleanup_fbs(data);
> +}
> +
> +static void set_planes(data_t *data, enum test_type type)
> +{
> + int ret;
> + drmModeModeInfo *mode = data->mode;
> + igt_output_t *output = data->output;
> +
> + data->plane[1] = igt_output_get_plane(output, 1);
> + data->plane[2] = igt_output_get_plane(output, 2);
> +
> + if (type == TEST_FILTER_UPSCALE) {
> + setup_fb(data->drm_fd, 20, 20, data->format, data->modifier, &data->fb[1]);
> + igt_plane_set_fb(data->plane[1], &data->fb[1]);
> + igt_plane_set_size(data->plane[1], mode->hdisplay, mode->vdisplay);
> + }
> +
> + if (type == TEST_FILTER_DOWNSCALE) {
> + setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[1]);
> + igt_plane_set_fb(data->plane[1], &data->fb[1]);
> + igt_plane_set_size(data->plane[1], mode->hdisplay * 0.75, mode->vdisplay * 0.75);
> + }
> +
> + if (type == TEST_INVALID_FILTER_WITH_SCALER) {
> + setup_fb(data->drm_fd, 20, 20, data->format, data->modifier, &data->fb[1]);
> + setup_fb(data->drm_fd, 20, 20, data->format, data->modifier, &data->fb[2]);
> + igt_plane_set_fb(data->plane[1], &data->fb[1]);
> + igt_plane_set_fb(data->plane[2], &data->fb[2]);
> + igt_plane_set_size(data->plane[1], mode->hdisplay, mode->vdisplay);
> + igt_plane_set_size(data->plane[2], mode->hdisplay, mode->vdisplay);
> + }
> +
> + if (type == TEST_INVALID_FILTER_WITH_PLANE) {
> + setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[1]);
> + setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[2]);
> + igt_plane_set_fb(data->plane[1], &data->fb[1]);
> + igt_plane_set_fb(data->plane[2], &data->fb[2]);
> + }
> +
> + if (type == TEST_INVALID_PLANE_WITH_FILTER) {
> + setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[1]);
> + igt_plane_set_fb(data->plane[1], &data->fb[1]);
> + }
> +
> + if (type == TEST_INVALID_FILTER_WITH_SCALING_MODE) {
> + setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[1]);
> + setup_fb(data->drm_fd, 640, 480, data->format, data->modifier, &data->fb[2]);
> + igt_plane_set_fb(data->plane[1], &data->fb[1]);
> + igt_plane_set_fb(data->plane[2], &data->fb[2]);
> +
> + ret = igt_display_try_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> + igt_assert_eq(ret, 0);
> +
> + mode->hdisplay = 640;
> + mode->vdisplay = 480;
> +
> + igt_output_override_mode(data->output, mode);
> + igt_plane_set_fb(data->plane[2], NULL);
> + igt_plane_set_fb(data->plane[1], &data->fb[2]);
> +
> + igt_output_set_prop_value(data->output, IGT_CONNECTOR_SCALING_MODE, data->scaling_mode);
> + }
> +}
> +
> +static void test_sharpness_filter(data_t *data, enum test_type type)
> +{
> + igt_output_t *output = data->output;
> + drmModeModeInfo *mode = data->mode;
> + int height = mode->hdisplay;
> + int width = mode->vdisplay;
> + int ret;
> +
> + igt_display_reset(&data->display);
> + igt_output_set_pipe(output, data->pipe_id);
> +
> + if (type == TEST_FILTER_TAP) {
> + mode = get_mode(output, data->filter_tap);
> + igt_require(mode != NULL);
> + igt_output_override_mode(output, mode);
> + }
> +
> + data->plane[0] = igt_pipe_get_plane_type(data->pipe, DRM_PLANE_TYPE_PRIMARY);
> + igt_skip_on_f(!igt_plane_has_format_mod(data->plane[0], data->format, data->modifier),
> + "No requested format/modifier on pipe %s\n", kmstest_pipe_name(data->pipe_id));
> +
> + setup_fb(data->drm_fd, height, width, data->format, data->modifier, &data->fb[0]);
> + igt_plane_set_fb(data->plane[0], &data->fb[0]);
> +
> + if (igt_plane_has_rotation(data->plane[0], data->rotation))
> + igt_plane_set_rotation(data->plane[0], data->rotation);
> + else
> + igt_skip("No requested rotation on pipe %s\n", kmstest_pipe_name(data->pipe_id));
> +
> + if (type == TEST_INVALID_FILTER_WITH_SCALING_MODE)
> + igt_require_f(has_scaling_mode(output), "No connecter scaling mode found on %s\n", output->name);
> +
> + if (SET_PLANES)
> + set_planes(data, type);
> +
> + /* Set filter strength property */
> + set_filter_strength_on_pipe(data);
> +
> + if (!INVALID_TEST && data->filter_strength != 0)
> + igt_debug("Sharpened image should be observed for filter strength > 0\n");
> +
> + if (type == TEST_INVALID_FILTER_WITH_SCALING_MODE)
> + ret = igt_display_try_commit_atomic(&data->display, 0, NULL);
> + else
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> +
> + if (type == TEST_FILTER_DPMS) {
> + kmstest_set_connector_dpms(data->drm_fd,
> + output->config.connector,
> + DRM_MODE_DPMS_OFF);
> + kmstest_set_connector_dpms(data->drm_fd,
> + output->config.connector,
> + DRM_MODE_DPMS_ON);
> + }
> +
> + if (type == TEST_FILTER_SUSPEND)
> + igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> + SUSPEND_TEST_NONE);
> +
> + if (type == TEST_INVALID_PLANE_WITH_FILTER) {
> + data->plane[3] = igt_output_get_plane(data->output, 3);
> + setup_fb(data->drm_fd, mode->hdisplay, mode->vdisplay, data->format, data->modifier, &data->fb[3]);
> + igt_plane_set_fb(data->plane[3], &data->fb[3]);
> +
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + }
> +
> + if (type == TEST_FILTER_DOWNSCALE)
> + igt_skip_on_f(ret == -ERANGE || ret == -EINVAL,
> + "Scaling op not supported, cdclk limits might be exceeded.\n");
> +
> + if (INVALID_TEST)
> + igt_assert_eq(ret, -EINVAL);
> + else
> + igt_assert_eq(ret, 0);
> +
> + cleanup(data);
> +}
> +
> +static bool has_sharpness_filter(igt_pipe_t *pipe)
> +{
> + return igt_pipe_obj_has_prop(pipe, IGT_CRTC_SHARPNESS_STRENGTH);
> +}
> +
> +static void
> +run_sharpness_filter_test(data_t *data, enum test_type type)
> +{
> + igt_display_t *display = &data->display;
> + igt_output_t *output;
> + enum pipe pipe;
> + char name[40];
> +
> + for_each_pipe_with_valid_output(display, pipe, output) {
> + igt_display_reset(display);
> +
> + data->output = output;
> + data->pipe_id = pipe;
> + data->pipe = &display->pipes[data->pipe_id];
> + data->mode = igt_output_get_mode(data->output);
> +
> + if (!has_sharpness_filter(data->pipe)) {
> + igt_info("%s: Doesn't support IGT_CRTC_SHARPNESS_STRENGTH.\n",
> + kmstest_pipe_name(pipe));
> + continue;
> + }
> +
> + igt_output_set_pipe(output, pipe);
> +
> + if (!intel_pipe_output_combo_valid(display)) {
> + igt_output_set_pipe(output, PIPE_NONE);
> + continue;
> + }
> +
> + switch (type) {
> + case TEST_FILTER_BASIC:
> + snprintf(name, sizeof(name), "-basic");
> + break;
> + case TEST_FILTER_TAP:
> + snprintf(name, sizeof(name), "-tap-%d", data->filter_tap);
> + break;
> + case TEST_FILTER_TOGGLE:
> + snprintf(name, sizeof(name), "-toggle");
> + break;
> + case TEST_FILTER_MODIFIERS:
> + snprintf(name, sizeof(name), "-%s", data->modifier_name);
> + break;
> + case TEST_FILTER_ROTATION:
> + snprintf(name, sizeof(name), "-%srot", igt_plane_rotation_name(data->rotation));
> + break;
> + case TEST_FILTER_FORMATS:
> + snprintf(name, sizeof(name), "-%s", igt_format_str(data->format));
> + break;
> + case TEST_FILTER_DPMS:
> + snprintf(name, sizeof(name), "-dpms");
> + break;
> + case TEST_FILTER_SUSPEND:
> + snprintf(name, sizeof(name), "-suspend");
> + break;
> + case TEST_FILTER_UPSCALE:
> + snprintf(name, sizeof(name), "-upscale");
> + break;
> + case TEST_FILTER_DOWNSCALE:
> + snprintf(name, sizeof(name), "-downscale");
> + break;
> + case TEST_INVALID_FILTER_WITH_SCALER:
> + snprintf(name, sizeof(name), "-invalid-filter-with-scaler");
> + break;
> + case TEST_INVALID_FILTER_WITH_PLANE:
> + snprintf(name, sizeof(name), "-invalid-filter-with-plane");
> + break;
> + case TEST_INVALID_PLANE_WITH_FILTER:
> + snprintf(name, sizeof(name), "-invalid-plane-with-filter");
> + break;
> + case TEST_FILTER_STRENGTH:
> + snprintf(name, sizeof(name), "-strength-%d", data->filter_strength);
> + break;
> + case TEST_INVALID_FILTER_WITH_SCALING_MODE:
> + snprintf(name, sizeof(name), "-invalid-filter-with-scaling-mode-%s", kmstest_scaling_mode_str(data->scaling_mode));
> + break;
> + default:
> + igt_assert(0);
> + }
> +
> + igt_dynamic_f("pipe-%s-%s%s", kmstest_pipe_name(data->pipe_id), data->output->name, name)
> + test_sharpness_filter(data, type);
> +
> + if (data->limited)
> + break;
> + }
> +}
> +
> +static int opt_handler(int opt, int opt_index, void *_data)
> +{
> + data_t *data = _data;
> +
> + switch (opt) {
> + case 'l':
> + data->limited = true;
> + break;
> + default:
> + return IGT_OPT_HANDLER_ERROR;
> + }
> +
> + return IGT_OPT_HANDLER_SUCCESS;
> +}
> +
> +static const char help_str[] =
> + " --limited|-l\t\tLimit execution to 1 valid pipe-output combo\n";
> +
> +data_t data = {};
> +
> +igt_main_args("l", NULL, help_str, opt_handler, &data)
> +{
> + igt_fixture {
> + data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> +
> + kmstest_set_vt_graphics_mode();
> +
> + igt_display_require(&data.display, data.drm_fd);
> + igt_require(data.display.is_atomic);
> + igt_display_require_output(&data.display);
> + }
> +
> + igt_describe("Verify basic content adaptive sharpness filter.");
> + igt_subtest_with_dynamic("filter-basic") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_BASIC);
> + }
> +
> + igt_describe("Verify that following a resolution change, "
> + "distict taps are selected.");
> + igt_subtest_with_dynamic("filter-tap") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + for (int k = 0; k < ARRAY_SIZE(filter_tap_list); k++) {
> + data.filter_tap = filter_tap_list[k];
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_TAP);
> + }
> + }
> +
> + igt_describe("Verify that varying strength(0-255), affects "
> + "the degree of sharpeness applied.");
> + igt_subtest_with_dynamic("filter-strength") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> +
> + for (int k = 0; k < ARRAY_SIZE(filter_strength_list); k++) {
> + data.filter_strength = filter_strength_list[k];
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_STRENGTH);
> + }
> + }
> +
> + igt_describe("Verify toggling between enabling and disabling "
> + "content adaptive sharpness filter.");
> + igt_subtest_with_dynamic("filter-toggle") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> +
> + for (int k = 0; k < NROUNDS; k++) {
> + data.filter_strength = DISABLE_FILTER;
> + run_sharpness_filter_test(&data, TEST_FILTER_TOGGLE);
> + data.filter_strength = MAX_FILTER_STRENGTH;
> + run_sharpness_filter_test(&data, TEST_FILTER_TOGGLE);
> + }
> + }
> +
> + igt_describe("Verify content adaptive sharpness filter with "
> + "varying modifiers.");
> + igt_subtest_with_dynamic("filter-modifiers") {
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + for (int k = 0; k < ARRAY_SIZE(modifiers); k++) {
> + data.modifier = modifiers[k].modifier;
> + data.modifier_name = modifiers[k].name;
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_MODIFIERS);
> + }
> + }
> +
> + igt_describe("Verify content adaptive sharpness filter with "
> + "varying rotations.");
> + igt_subtest_with_dynamic("filter-rotations") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + for (int k = 0; k < ARRAY_SIZE(rotations); k++) {
> + data.rotation = rotations[k];
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_ROTATION);
> + }
> + }
> +
> + igt_describe("Verify content adaptive sharpness filter with "
> + "varying formats.");
> + igt_subtest_with_dynamic("filter-formats") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + for (int k = 0; k < ARRAY_SIZE(formats); k++) {
> + data.format = formats[k];
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_FORMATS);
> + }
> + }
> +
> + igt_describe("Verify content adaptive sharpness filter "
> + "with DPMS.");
> + igt_subtest_with_dynamic("filter-dpms") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_DPMS);
> + }
> +
> + igt_describe("Verify content adaptive sharpness filter "
> + "with suspend.");
> + igt_subtest_with_dynamic("filter-suspend") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_SUSPEND);
> + }
> +
> + igt_describe("Verify content adaptive sharpness filter "
> + "with 1 plane scaler enabled.");
> + igt_subtest_with_dynamic("filter-scaler-upscale") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_UPSCALE);
> + }
> +
> + igt_describe("Verify content adaptive sharpness filter "
> + "with 1 plane scaler enabled.");
> + igt_subtest_with_dynamic("filter-scaler-downscale") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + run_sharpness_filter_test(&data, TEST_FILTER_DOWNSCALE);
> + }
> +
> + igt_describe("Negative check for content adaptive sharpness filter "
> + "when 2 plane scalers have already been enabled and "
> + "attempt is made to enable sharpness filter.");
> + igt_subtest_with_dynamic("invalid-filter-with-scaler") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + run_sharpness_filter_test(&data, TEST_INVALID_FILTER_WITH_SCALER);
> + }
> +
> + igt_describe("Negative check for content adaptive sharpness filter "
> + "when 2 NV12 planes have already been enabled and attempt is "
> + "made to enable the sharpness filter.");
> + igt_subtest_with_dynamic("invalid-filter-with-plane") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_NV12;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + run_sharpness_filter_test(&data, TEST_INVALID_FILTER_WITH_PLANE);
> + }
> +
> + igt_describe("Negative check for content adaptive sharpness filter "
> + "when 1 NV12 plane and sharpness filter have already been enabled "
> + "and attempt is made to enable the second NV12 plane.");
> + igt_subtest_with_dynamic("invalid-plane-with-filter") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_NV12;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + run_sharpness_filter_test(&data, TEST_INVALID_PLANE_WITH_FILTER);
> + }
> +
> + igt_describe("Negative check for content adaptive sharpness filter "
> + "when scaling mode is already enabled and attempt is made "
> + "to enable sharpness filter.");
> + igt_subtest_with_dynamic("invalid-filter-with-scaling-mode") {
> + data.modifier = DRM_FORMAT_MOD_LINEAR;
> + data.rotation = IGT_ROTATION_0;
> + data.format = DRM_FORMAT_XRGB8888;
> + data.filter_strength = MID_FILTER_STRENGTH;
> +
> + for (int k = 0; k < ARRAY_SIZE(scaling_modes); k++) {
> + data.scaling_mode = scaling_modes[k];
> +
> + run_sharpness_filter_test(&data, TEST_INVALID_FILTER_WITH_SCALING_MODE);
> + }
> + }
> +
> + igt_fixture {
> + igt_display_fini(&data.display);
> + drm_close_driver(data.drm_fd);
> + }
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index e5d8852f3..7f5bc68d3 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -58,6 +58,7 @@ test_progs = [
> 'kms_sequence',
> 'kms_setmode',
> 'kms_sysfs_edid_timing',
> + 'kms_sharpness_filter',
> 'kms_tiled_display',
> 'kms_tv_load_detect',
> 'kms_universal_plane',
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH i-g-t v7 1/4] lib/igt_kms: Added "sharpness strength" as crtc property
2024-10-18 19:06 ` [PATCH i-g-t v7 1/4] lib/igt_kms: Added "sharpness strength" as crtc property Swati Sharma
@ 2024-10-23 4:24 ` Nautiyal, Ankit K
0 siblings, 0 replies; 13+ messages in thread
From: Nautiyal, Ankit K @ 2024-10-23 4:24 UTC (permalink / raw)
To: Swati Sharma, igt-dev; +Cc: Mohammed Thasleem
On 10/19/2024 12:36 AM, Swati Sharma wrote:
> Added "sharpness strength" as crtc property.
>
> v2: Replace SHARPENESS_STRENGTH with SHARPNESS_STRENGTH. (Nemesa)
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
LGTM
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> lib/igt_kms.c | 4 ++++
> lib/igt_kms.h | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index b40470c02..73b024e0b 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -700,6 +700,7 @@ const char * const igt_crtc_prop_names[IGT_NUM_CRTC_PROPS] = {
> [IGT_CRTC_OUT_FENCE_PTR] = "OUT_FENCE_PTR",
> [IGT_CRTC_VRR_ENABLED] = "VRR_ENABLED",
> [IGT_CRTC_SCALING_FILTER] = "SCALING_FILTER",
> + [IGT_CRTC_SHARPNESS_STRENGTH] = "SHARPNESS_STRENGTH",
> };
>
> const char * const igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = {
> @@ -2562,6 +2563,9 @@ static void igt_pipe_reset(igt_pipe_t *pipe)
> if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_SCALING_FILTER))
> igt_pipe_obj_set_prop_enum(pipe, IGT_CRTC_SCALING_FILTER, "Default");
>
> + if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_SHARPNESS_STRENGTH))
> + igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_SHARPNESS_STRENGTH, 0);
> +
> pipe->out_fence_fd = -1;
> }
>
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 25ba50916..9bba0924d 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -163,6 +163,7 @@ enum igt_atomic_crtc_properties {
> IGT_CRTC_OUT_FENCE_PTR,
> IGT_CRTC_VRR_ENABLED,
> IGT_CRTC_SCALING_FILTER,
> + IGT_CRTC_SHARPNESS_STRENGTH,
> IGT_NUM_CRTC_PROPS
> };
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH i-g-t 2/4] lib/igt_kms: Added func() to return scaling mode name string
2024-10-18 19:06 ` [PATCH i-g-t 2/4] lib/igt_kms: Added func() to return scaling mode name string Swati Sharma
@ 2024-10-23 4:47 ` Nautiyal, Ankit K
0 siblings, 0 replies; 13+ messages in thread
From: Nautiyal, Ankit K @ 2024-10-23 4:47 UTC (permalink / raw)
To: Swati Sharma, igt-dev
On 10/19/2024 12:36 AM, Swati Sharma wrote:
> Added func() to print scaling mode name string.
Nitpick: use Add in commit message and the subject to maintain the
imperative mood.
Same for previous patch.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> lib/igt_kms.c | 19 +++++++++++++++++++
> lib/igt_kms.h | 1 +
> 2 files changed, 20 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 73b024e0b..08ad96d2d 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1040,6 +1040,25 @@ const char *kmstest_scaling_filter_str(int filter)
> return find_type_name(scaling_filter_names, filter);
> }
>
> +static const struct type_name scaling_modes_names[] = {
> + { DRM_MODE_SCALE_FULLSCREEN, "fullscreen" },
> + { DRM_MODE_SCALE_CENTER, "center" },
> + { DRM_MODE_SCALE_ASPECT, "aspect" },
> + { DRM_MODE_SCALE_NONE, "none" },
> + {}
> +};
> +
> +/**
> + * kmstest_scaling_mode_str:
> + * @mode: SCALING_MODE_* mode value
> + *
> + * Returns: A string representing the scaling mode @mode.
> + */
> +const char *kmstest_scaling_mode_str(uint32_t mode)
This can simply be int. find_type_name expects int.
Otherwise looks good to me. Perhaps we can also use this in
kms_scaling_mode, for consistency.
With above minor things fixed, this is:
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Regards,
Ankit
> +{
> + return find_type_name(scaling_modes_names, mode);
> +}
> +
> static const struct type_name dsc_output_format_names[] = {
> { DSC_FORMAT_RGB, "RGB" },
> { DSC_FORMAT_YCBCR420, "YCBCR420" },
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 9bba0924d..cc705763f 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -142,6 +142,7 @@ const char *kmstest_encoder_type_str(int type);
> const char *kmstest_connector_status_str(int status);
> const char *kmstest_connector_type_str(int type);
> const char *kmstest_scaling_filter_str(int filter);
> +const char *kmstest_scaling_mode_str(uint32_t mode);
> const char *kmstest_dsc_output_format_str(int output_format);
>
> void kmstest_dump_mode(drmModeModeInfo *mode);
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH i-g-t 4/4] tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness chamelium filter test
2024-10-18 19:06 ` [PATCH i-g-t 4/4] tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness chamelium " Swati Sharma
2024-10-22 12:20 ` Kamil Konieczny
@ 2024-11-11 13:20 ` Nautiyal, Ankit K
1 sibling, 0 replies; 13+ messages in thread
From: Nautiyal, Ankit K @ 2024-11-11 13:20 UTC (permalink / raw)
To: Swati Sharma, igt-dev
On 10/19/2024 12:36 AM, Swati Sharma wrote:
> Add new chamelium based sharpness test. Basic test is added where
> we have tried comparing frame dump of unsharped and sharped image.
> After, sharpness filter is applied its expected both frame dumps
> will be different.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> .../kms_chamelium_sharpness_filter.c | 250 ++++++++++++++++++
> tests/meson.build | 2 +
> 2 files changed, 252 insertions(+)
> create mode 100644 tests/chamelium/kms_chamelium_sharpness_filter.c
>
> diff --git a/tests/chamelium/kms_chamelium_sharpness_filter.c b/tests/chamelium/kms_chamelium_sharpness_filter.c
> new file mode 100644
> index 000000000..a60d22b63
> --- /dev/null
> +++ b/tests/chamelium/kms_chamelium_sharpness_filter.c
> @@ -0,0 +1,250 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2024 Intel Corporation
> + */
> +
> +/**
> + * TEST: kms chamelium sharpness filter
> + * Category: Display
> + * Description: Test to validate content adaptive sharpness filter using Chamelium
> + * Driver requirement: xe
> + * Functionality: chamelium, casf
> + * Mega feature: General Display Features
> + * Test category: functionality test
> + */
> +
> +#include "igt.h"
> +#include "igt_kms.h"
> +
> +/**
> + * SUBTEST: filter-basic
> + * Description: Verify basic content adaptive sharpness filter.
> + */
> +
> +IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter using Chamelium");
> +
> +#define DISABLE_FILTER 0
> +#define MIN_FILTER_STRENGTH 1
> +#define MID_FILTER_STRENGTH 128
> +#define MAX_FILTER_STRENGTH 255
MIN/MAX_FILTER_STRENGTH are not used.
> +
> +typedef struct {
> + int drm_fd;
> + enum pipe pipe_id;
> + struct igt_fb fb, fb_ref;
> + igt_display_t display;
> + igt_output_t *output;
> + igt_plane_t *primary;
> + drmModeModeInfo *mode;
> + int filter_strength;
> + struct chamelium *chamelium;
> + struct chamelium_port **ports;
> + int port_count;
> +} data_t;
> +
> +static bool pipe_output_combo_valid(data_t *data, enum pipe pipe)
> +{
> + bool ret = true;
> +
> + igt_output_set_pipe(data->output, pipe);
> + if (!intel_pipe_output_combo_valid(&data->display))
> + ret = false;
Alignment doesn't seem right.
> + igt_output_set_pipe(data->output, PIPE_NONE);
> +
> + return ret;
> +}
> +
> +static void disable_filter_strength_on_pipe(data_t *data)
> +{
> + igt_pipe_set_prop_value(&data->display, data->pipe_id,
> + IGT_CRTC_SHARPNESS_STRENGTH,
> + DISABLE_FILTER);
> +}
> +
> +static void set_filter_strength_on_pipe(data_t *data)
> +{
> + igt_pipe_set_prop_value(&data->display, data->pipe_id,
> + IGT_CRTC_SHARPNESS_STRENGTH,
> + data->filter_strength);
> +}
> +
> +static void paint_image(igt_fb_t *fb)
> +{
> + cairo_t *cr = igt_get_cairo_ctx(fb->fd, fb);
> + int img_x, img_y, img_w, img_h;
> + const char *file = "1080p-left.png";
> +
> + img_x = img_y = 0;
> + img_w = fb->width;
> + img_h = fb->height;
> +
> + igt_paint_image(cr, file, img_x, img_y, img_w, img_h);
> +
> + igt_put_cairo_ctx(cr);
> +}
> +
> +static void setup_fb(int fd, int width, int height, uint32_t format,
> + uint64_t modifier, struct igt_fb *fb)
> +{
> + int fb_id;
> +
> + fb_id = igt_create_fb(fd, width, height, format, modifier, fb);
> + igt_assert(fb_id);
> +
> + paint_image(fb);
> +}
> +
> +static void cleanup(data_t *data)
> +{
> + igt_remove_fb(data->drm_fd, &data->fb);
> + igt_remove_fb(data->drm_fd, &data->fb_ref);
> + igt_output_set_pipe(data->output, PIPE_NONE);
> + igt_output_override_mode(data->output, NULL);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +}
> +
> +
> +static bool test_t(data_t *data, igt_plane_t *primary,
> + struct chamelium_port *port)
> +{
> + igt_output_t *output = data->output;
> + drmModeModeInfo *mode = data->mode;
> + struct chamelium_frame_dump *dump;
> + int height = mode->hdisplay;
> + int width = mode->vdisplay;
> + bool ret = false;
> +
> + igt_output_set_pipe(output, data->pipe_id);
> +
> + setup_fb(data->drm_fd, height, width, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fb_ref);
> + setup_fb(data->drm_fd, height, width, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &data->fb);
> +
> + igt_plane_set_fb(data->primary, &data->fb_ref);
> + disable_filter_strength_on_pipe(data);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
We dont need to do commit with fb_ref.
> +
> + igt_plane_set_fb(data->primary, &data->fb);
> + set_filter_strength_on_pipe(data);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +
> + igt_debug("Reading frame dumps from Chamelium...\n");
> + chamelium_capture(data->chamelium, port, 0, 0, 0, 0, 1);
> + dump = chamelium_read_captured_frame(data->chamelium, 0);
> +
> + ret = chamelium_frame_match_or_dump(data->chamelium, port,
> + dump, &data->fb_ref,
> + CHAMELIUM_CHECK_ANALOG);
> + chamelium_destroy_frame_dump(dump);
> + cleanup(data);
> +
> + return ret;
> +}
> +
> +static int test_setup(data_t *data, enum pipe p)
> +{
> + igt_pipe_t *pipe;
> + int i = 0;
> +
> + igt_display_reset(&data->display);
> + igt_modeset_disable_all_outputs(&data->display);
> + chamelium_reset_state(&data->display, data->chamelium, NULL,
> + data->ports, data->port_count);
> +
> + pipe = &data->display.pipes[p];
> + igt_require(pipe->n_planes >= 0);
> +
> + data->primary = igt_pipe_get_plane_type(pipe, DRM_PLANE_TYPE_PRIMARY);
> + igt_assert(data->primary);
> +
> + /*
> + * Prefer to run this test on HDMI connector if its connected, since on DP we
> + * sometimes face DP FSM issue
> + */
> + for_each_valid_output_on_pipe(&data->display, p, data->output) {
> + for (i = 0; i < data->port_count; i++) {
> + if ((data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
> + data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) &&
> + strcmp(data->output->name, chamelium_port_get_name(data->ports[i])) == 0)
> + return i;
> + }
> + }
> +
> + for_each_valid_output_on_pipe(&data->display, p, data->output) {
> + for (i = 0; i < data->port_count; i++) {
> + if (strcmp(data->output->name,
> + chamelium_port_get_name(data->ports[i])) == 0)
> + return i;
> + }
> + }
> +
> + return -1;
> +}
> +
> +static void test_sharpness_filter(data_t *data, enum pipe p)
> +{
> + int port_idx = test_setup(data, p);
> +
> + igt_require(port_idx >= 0);
> + igt_require(igt_pipe_obj_has_prop(&data->display.pipes[p], IGT_CRTC_SHARPNESS_STRENGTH));
> +
> + if (!pipe_output_combo_valid(data, p))
> + return;
> +
> + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(p), data->output->name)
> + igt_assert_f(test_t(data, data->primary, data->ports[port_idx]) == 0, "No sharpness observed.\n");
> +}
> +
> +static void
> +run_sharpness_filter_test(data_t *data)
> +{
> + igt_display_t *display = &data->display;
> + enum pipe pipe;
> +
> + igt_describe("Verify basic content adaptive sharpness filter.");
> + igt_subtest_with_dynamic("filter-basic") {
> + for_each_pipe(display, pipe) {
> + data->filter_strength = MID_FILTER_STRENGTH;
> + test_sharpness_filter(data, pipe);
I think we need to set data->pipe_id here. It doesnt seem to be set, but
is used to track the pipe.
Regards,
Ankit
> + }
> + }
> +}
> +
> +igt_main
> +{
> + data_t data = {};
> +
> + igt_fixture {
> + data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> +
> + igt_display_require(&data.display, data.drm_fd);
> + igt_require(data.display.is_atomic);
> +
> + igt_chamelium_allow_fsm_handling = false;
> +
> + /* we need to initalize chamelium after igt_display_require */
> + data.chamelium = chamelium_init(data.drm_fd, &data.display);
> + igt_require(data.chamelium);
> +
> + data.ports = chamelium_get_ports(data.chamelium,
> + &data.port_count);
> +
> + if (!data.port_count)
> + igt_skip("No ports connected\n");
> + /*
> + * We don't cause any harm by plugging
> + * discovered ports, just incase they are not plugged
> + * we currently skip in test_setup
> + */
> + for(int i = 0; i < data.port_count; i++)
> + chamelium_plug(data.chamelium, data.ports[i]);
> +
> + kmstest_set_vt_graphics_mode();
> + }
> +
> + run_sharpness_filter_test(&data);
> +
> + igt_fixture {
> + igt_display_fini(&data.display);
> + drm_close_driver(data.drm_fd);
> + }
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index 7f5bc68d3..1fa47d09d 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -335,6 +335,7 @@ chamelium_progs = [
> 'kms_chamelium_edid',
> 'kms_chamelium_frames',
> 'kms_chamelium_hpd',
> + 'kms_chamelium_sharpness_filter',
> ]
>
> test_deps = [ igt_deps ]
> @@ -360,6 +361,7 @@ extra_sources = {
> 'kms_chamelium_edid': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
> 'kms_chamelium_frames': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
> 'kms_chamelium_hpd': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
> + 'kms_chamelium_sharpness_filter': [ join_paths ('chamelium', 'kms_chamelium_helper.c') ],
> 'kms_dsc': [ join_paths ('intel', 'kms_dsc_helper.c') ],
> 'kms_psr2_sf': [ join_paths ('intel', 'kms_dsc_helper.c') ],
> }
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2024-11-11 13:20 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 19:06 [PATCH i-g-t v7 0/4] Add new test to validate adaptive sharpness filter Swati Sharma
2024-10-18 19:06 ` [PATCH i-g-t v7 1/4] lib/igt_kms: Added "sharpness strength" as crtc property Swati Sharma
2024-10-23 4:24 ` Nautiyal, Ankit K
2024-10-18 19:06 ` [PATCH i-g-t 2/4] lib/igt_kms: Added func() to return scaling mode name string Swati Sharma
2024-10-23 4:47 ` Nautiyal, Ankit K
2024-10-18 19:06 ` [PATCH i-g-t v7 3/4] tests/kms_sharpness_filter: Add adaptive sharpness filter test Swati Sharma
2024-10-23 4:20 ` Nautiyal, Ankit K
2024-10-18 19:06 ` [PATCH i-g-t 4/4] tests/chamelium/kms_chamelium_sharpness_filter: Add adaptive sharpness chamelium " Swati Sharma
2024-10-22 12:20 ` Kamil Konieczny
2024-11-11 13:20 ` Nautiyal, Ankit K
2024-10-18 19:39 ` ✓ CI.xeBAT: success for Add new test to validate adaptive sharpness filter (rev8) Patchwork
2024-10-18 19:41 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-19 12:08 ` ✗ CI.xeFULL: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox