From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH i-g-t 2/9] tests/intel/perf_pmu: Remove trial unload
Date: Mon, 4 Nov 2024 22:18:38 -0800 [thread overview]
Message-ID: <20241105061845.2486557-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20241105061845.2486557-1-lucas.demarchi@intel.com>
Remove the trial module so there are no more users of
__igt_i915_driver_unload() and thus i915 can start sharing the xe logic.
Later when perf_pmu_unregister() is fixed in the kernel, a new check can
be added for trying to unbind the device while still having open events.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
tests/intel/perf_pmu.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/tests/intel/perf_pmu.c b/tests/intel/perf_pmu.c
index bfa2d501a..f916ded53 100644
--- a/tests/intel/perf_pmu.c
+++ b/tests/intel/perf_pmu.c
@@ -2282,7 +2282,6 @@ static void test_unload(unsigned int num_engines)
int fd[4 + num_engines * 3], i;
uint64_t *buf;
int count = 0, ret;
- char *who = NULL;
int i915;
i915 = __drm_open_driver(DRIVER_INTEL);
@@ -2337,23 +2336,19 @@ static void test_unload(unsigned int num_engines)
igt_debug("Read %d events from perf and trial unload\n", count);
pmu_read_multi(fd[0], count, buf);
- ret = __igt_i915_driver_unload(&who);
- igt_debug("__igt_i915_driver_unload: ret %d who %s\n", ret, who);
- igt_assert(ret != 0 && !strcmp(who, "i915"));
- free(who);
- pmu_read_multi(fd[0], count, buf);
igt_debug("Close perf\n");
-
for (i = 0; i < count; i++)
close(fd[i]);
+ igt_debug("Final unload\n");
+ /* After perf is closed, we should be able to remove the module */
+ ret = igt_i915_driver_unload();
+ igt_assert_eq(ret, 0);
+
free(buf);
}
igt_waitchildren();
-
- igt_debug("Final unload\n");
- igt_assert_eq(__igt_i915_driver_unload(NULL), 0);
}
static void pmu_read(int i915)
--
2.47.0
next prev parent reply other threads:[~2024-11-05 6:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 6:18 [PATCH i-g-t 0/9] i915: unload refactors Lucas De Marchi
2024-11-05 6:18 ` [PATCH i-g-t 1/9] lib/igt_kmod: Remove unused module_ref Lucas De Marchi
2024-11-06 22:09 ` [i-g-t,1/9] " Taylor, Clinton A
2024-11-05 6:18 ` Lucas De Marchi [this message]
2024-11-19 1:15 ` [PATCH i-g-t 2/9] tests/intel/perf_pmu: Remove trial unload Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 3/9] lib/igt_kmod: Share xe's unload logic with i915 Lucas De Marchi
2024-11-19 1:20 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 4/9] lib/igt_kmod: Remove unused low level __igt_intel_driver_unload() Lucas De Marchi
2024-11-19 1:21 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 5/9] tests/core_hotunplug: Stop unloading audio Lucas De Marchi
2024-11-19 1:23 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 6/9] tests/device_reset: " Lucas De Marchi
2024-11-19 1:24 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 7/9] lib: Remove unused audio-related helpers Lucas De Marchi
2024-11-19 1:28 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 8/9] i915_module_load: Stop caring about snd Lucas De Marchi
2024-11-19 1:34 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 9/9] xe_module_load: " Lucas De Marchi
2024-11-19 1:35 ` Matt Roper
2024-11-05 9:30 ` ✓ Fi.CI.BAT: success for i915: unload refactors Patchwork
2024-11-05 9:34 ` ✓ CI.xeBAT: " Patchwork
2024-11-06 4:37 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-06 9:39 ` ✗ CI.xeFULL: " Patchwork
2024-11-06 17:11 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105061845.2486557-3-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox