Re: [PATCH i-g-t 9/9] xe_module_load: Stop caring about snd

[Matt Roper <matthew.d.roper@intel.com>]

On Mon, Nov 04, 2024 at 10:18:45PM -0800, Lucas De Marchi wrote:
> Just handle xe and it should work.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  tests/intel/xe_module_load.c | 40 ------------------------------------
>  1 file changed, 40 deletions(-)
> 
> diff --git a/tests/intel/xe_module_load.c b/tests/intel/xe_module_load.c
> index 83e37430f..b91da5c32 100644
> --- a/tests/intel/xe_module_load.c
> +++ b/tests/intel/xe_module_load.c
> @@ -36,52 +36,12 @@
>  #define BAR_SIZE_SHIFT 20
>  #define MIN_BAR_SIZE 256
>  
> -static void file_write(const char *ptr, size_t size, size_t nmemb,
> -                       FILE *fp)
> -{
> -	int count;
> -
> -	count = fwrite(ptr, size, nmemb, fp);
> -	if (count == size * nmemb)
> -		return;
> -
> -	igt_debug("Can't update hda dynamic debug with : %s\n", ptr);
> -}
> -
> -static void hda_dynamic_debug(bool enable)
> -{
> -	FILE *fp;
> -	static const char snd_hda_intel_on[] = "module snd_hda_intel +pf";
> -	static const char snd_hda_core_on[] = "module snd_hda_core +pf";
> -
> -	static const char snd_hda_intel_off[] = "module snd_hda_intel =_";
> -	static const char snd_hda_core_off[] = "module snd_hda_core =_";
> -
> -	fp = fopen("/sys/kernel/debug/dynamic_debug/control", "w");
> -	if (!fp) {
> -		igt_debug("hda dynamic debug not available\n");
> -		return;
> -	}
> -
> -	if (enable) {
> -		file_write(snd_hda_intel_on, 1, sizeof(snd_hda_intel_on), fp);
> -		file_write(snd_hda_core_on, 1, sizeof(snd_hda_core_on), fp);
> -	} else {
> -		file_write(snd_hda_intel_off, 1, sizeof(snd_hda_intel_off), fp);
> -		file_write(snd_hda_core_off, 1, sizeof(snd_hda_core_off), fp);
> -	}
> -
> -	fclose(fp);
> -}
> -
>  static void load_and_check_xe(const char *opts)
>  {
>  	int error;
>  	int drm_fd;
>  
> -	hda_dynamic_debug(true);
>  	error = igt_xe_driver_load(opts);
> -	hda_dynamic_debug(false);
>  
>  	igt_assert_eq(error, 0);
>  
> -- 
> 2.47.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation