From: "Taylor, Clinton A" <clinton.a.taylor@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>
Subject: Re: [i-g-t,1/9] lib/igt_kmod: Remove unused module_ref
Date: Wed, 6 Nov 2024 22:09:38 +0000 [thread overview]
Message-ID: <b622f6105e24386fdc6e42681a37947075bde709.camel@intel.com> (raw)
In-Reply-To: <20241105061845.2486557-2-lucas.demarchi@intel.com>
Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>
-Clint
On Mon, 2024-11-04 at 22:18 -0800, Lucas De Marchi wrote:
> This is unused since commit 03706cd84099 ("lib/igt_kmod: remove the
> conditional audio removal code"). Nuke it.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> lib/igt_kmod.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index fb83f17c0..d031bfe18 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -593,14 +593,6 @@ static int igt_always_unload_audio_driver(char **who)
> return 0;
> }
>
> -struct module_ref {
> - char *name;
> - unsigned long mem;
> - unsigned int ref_count;
> - unsigned int num_required;
> - unsigned int *required_by;
> -};
> -
> int igt_audio_driver_unload(char **who)
> {
> /*
next prev parent reply other threads:[~2024-11-06 22:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 6:18 [PATCH i-g-t 0/9] i915: unload refactors Lucas De Marchi
2024-11-05 6:18 ` [PATCH i-g-t 1/9] lib/igt_kmod: Remove unused module_ref Lucas De Marchi
2024-11-06 22:09 ` Taylor, Clinton A [this message]
2024-11-05 6:18 ` [PATCH i-g-t 2/9] tests/intel/perf_pmu: Remove trial unload Lucas De Marchi
2024-11-19 1:15 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 3/9] lib/igt_kmod: Share xe's unload logic with i915 Lucas De Marchi
2024-11-19 1:20 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 4/9] lib/igt_kmod: Remove unused low level __igt_intel_driver_unload() Lucas De Marchi
2024-11-19 1:21 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 5/9] tests/core_hotunplug: Stop unloading audio Lucas De Marchi
2024-11-19 1:23 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 6/9] tests/device_reset: " Lucas De Marchi
2024-11-19 1:24 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 7/9] lib: Remove unused audio-related helpers Lucas De Marchi
2024-11-19 1:28 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 8/9] i915_module_load: Stop caring about snd Lucas De Marchi
2024-11-19 1:34 ` Matt Roper
2024-11-05 6:18 ` [PATCH i-g-t 9/9] xe_module_load: " Lucas De Marchi
2024-11-19 1:35 ` Matt Roper
2024-11-05 9:30 ` ✓ Fi.CI.BAT: success for i915: unload refactors Patchwork
2024-11-05 9:34 ` ✓ CI.xeBAT: " Patchwork
2024-11-06 4:37 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-06 9:39 ` ✗ CI.xeFULL: " Patchwork
2024-11-06 17:11 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b622f6105e24386fdc6e42681a37947075bde709.camel@intel.com \
--to=clinton.a.taylor@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox