Re: [PATCH i-g-t 6/9] tests/device_reset: Stop unloading audio

[Matt Roper <matthew.d.roper@intel.com>]

On Mon, Nov 04, 2024 at 10:18:42PM -0800, Lucas De Marchi wrote:
> Not needed anymore and test should succeed when unbinding the device
> from the driver.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  tests/device_reset.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index 40681931c..668ba8526 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -64,7 +64,6 @@ struct device_fds {
>  		int slot_dir; /* pci hotplug slots fd */
>  	} fds;
>  	char dev_bus_addr[DEV_BUS_ADDR_LEN];
> -	char *snd_driver;
>  };
>  
>  static int __open_sysfs_dir(int fd, const char* path)
> @@ -345,9 +344,6 @@ static bool has_cold_reset(int slot_dir, const char **reason)
>  /* Unbind the driver from the device */
>  static void driver_unbind(struct device_fds *dev)
>  {
> -	if (is_i915_device(dev->fds.dev))
> -		igt_audio_driver_unload(&dev->snd_driver);
> -
>  	igt_debug("unbind the driver from the device\n");
>  	igt_assert(igt_sysfs_set(dev->fds.drv_dir, "unbind",
>  		   dev->dev_bus_addr));
> @@ -359,9 +355,6 @@ static void driver_bind(struct device_fds *dev)
>  	igt_debug("rebind the driver to the device\n");
>  	igt_abort_on_f(!igt_sysfs_set(dev->fds.drv_dir, "bind",
>  		       dev->dev_bus_addr), "driver rebind failed");
> -
> -	if (dev->snd_driver)
> -		igt_kmod_load(dev->snd_driver, NULL);
>  }
>  
>  /* Initiate device reset */
> -- 
> 2.47.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation