Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests/kms_async_flips: Only check joiner mode on intel device
@ 2024-12-10 22:39 george.zhang
  2024-12-10 23:17 ` ✓ i915.CI.BAT: success for tests/kms_async_flips: Only check joiner mode on intel device (rev2) Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: george.zhang @ 2024-12-10 22:39 UTC (permalink / raw)
  To: igt-dev
  Cc: santhosh.reddy.guddati, sunpeng.li, chiahsuan.chung, alex.hung,
	George Zhang

From: George Zhang <george.zhang@amd.com>

The joiner mode check causes the kms_async_flip tests to fail on
non-intel devices. Added a guard to only check the joiner mode if
running on intel device.

v2: Moved guard to within is_joiner_mode function

Signed-off-by: George Zhang <george.zhang@amd.com>
---
 lib/igt_kms.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 43ca2d4c2..3d061abc5 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6467,6 +6467,9 @@ bool is_joiner_mode(int drm_fd, igt_output_t *output)
 	int max_dotclock;
 	drmModeModeInfo mode;
 
+        if (!is_intel_device(drm_fd))
+                return false;
+
 	max_dotclock = igt_get_max_dotclock(drm_fd);
 	is_joiner = bigjoiner_mode_found(drm_fd,
 					 output->config.connector,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] tests/kms_async_flips: Only check joiner mode on intel device
@ 2024-12-10 20:12 george.zhang
  0 siblings, 0 replies; 9+ messages in thread
From: george.zhang @ 2024-12-10 20:12 UTC (permalink / raw)
  To: igt-dev
  Cc: santhosh.reddy.guddati, sunpeng.li, chiahsuan.chung, alex.hung,
	George Zhang

From: George Zhang <george.zhang@amd.com>

The joiner mode check causes the kms_async_flip tests to fail on
non-intel devices. Added a guard to only check the joiner mode if
running on intel device.

Signed-off-by: George Zhang <george.zhang@amd.com>
---
 tests/kms_async_flips.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 4a72be7b5..5e7c64d73 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -706,8 +706,9 @@ static void run_test(data_t *data, void (*test)(data_t *))
 			 * FIXME: joiner+async flip is busted currently in KMD.
 			 * Remove this check once the issues are fixed in KMD.
 			 */
-			igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
-				      "Skipping, async flip not supported on joiner mode\n");
+                        if (is_intel_device(data->drm_fd))
+			    igt_skip_on_f(is_joiner_mode(data->drm_fd, data->output),
+				          "Skipping, async flip not supported on joiner mode\n");
 			test_init_fbs(data);
 			test(data);
 		}
@@ -733,10 +734,11 @@ static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))
 				       * FIXME: joiner+async flip is busted currently in KMD.
 				       * Remove this check once the issues are fixed in KMD.
 				       */
-				      igt_skip_on_f(is_joiner_mode(data->drm_fd,
+                                        if (is_intel_device(data->drm_fd))
+				            igt_skip_on_f(is_joiner_mode(data->drm_fd,
 								   data->output),
-						    "Skipping, async flip not supported "
-						    "on joiner mode\n");
+						          "Skipping, async flip not supported "
+						          "on joiner mode\n");
 				      test_init_fbs(data);
 				      test(data);
 			}
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-12-12  6:59 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-10 22:39 [PATCH] tests/kms_async_flips: Only check joiner mode on intel device george.zhang
2024-12-10 23:17 ` ✓ i915.CI.BAT: success for tests/kms_async_flips: Only check joiner mode on intel device (rev2) Patchwork
2024-12-10 23:50 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-11  0:18 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-11  1:56 ` [PATCH] tests/kms_async_flips: Only check joiner mode on intel device Reddy Guddati, Santhosh
2024-12-11  2:55 ` ✗ Xe.CI.Full: failure for tests/kms_async_flips: Only check joiner mode on intel device (rev2) Patchwork
2024-12-11  9:47 ` [PATCH] tests/kms_async_flips: Only check joiner mode on intel device Kamil Konieczny
2024-12-12  6:59 ` ✓ i915.CI.Full: success for tests/kms_async_flips: Only check joiner mode on intel device (rev2) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-12-10 20:12 [PATCH] tests/kms_async_flips: Only check joiner mode on intel device george.zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox