From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: igt-dev@lists.freedesktop.org, Ashutosh Dixit <ashutosh.dixit@intel.com>
Subject: [PATCH i-g-t CI run 06/14] tests/intel/xe_oa: Rewrite the polling small buf test
Date: Tue, 18 Feb 2025 12:28:04 -0800 [thread overview]
Message-ID: <20250218202812.1679653-7-umesh.nerlige.ramappa@intel.com> (raw)
In-Reply-To: <20250218202812.1679653-1-umesh.nerlige.ramappa@intel.com>
Use mmio reads as a side-channel to determine if reports are available
and ensure that poll will return with POLLIN set. Then provide a small
buffer to force ENOSPC error. Then poll with a timeout of 0 to check if
POLLIN is still set.
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/intel/xe_oa.c | 64 +++++++++++++++++++++++++--------------------
1 file changed, 35 insertions(+), 29 deletions(-)
diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index aaf92308a..5792ffec2 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -2216,7 +2216,6 @@ static void test_polling(uint64_t requested_oa_period,
*/
static void test_polling_small_buf(void)
{
- int oa_exponent = max_oa_exponent_for_period_lte(40 * 1000); /* 40us */
uint64_t properties[] = {
DRM_XE_OA_PROPERTY_OA_UNIT_ID, 0,
@@ -2226,50 +2225,57 @@ static void test_polling_small_buf(void)
/* OA unit configuration */
DRM_XE_OA_PROPERTY_OA_METRIC_SET, default_test_set->perf_oa_metrics_set,
DRM_XE_OA_PROPERTY_OA_FORMAT, __ff(default_test_set->perf_oa_format),
- DRM_XE_OA_PROPERTY_OA_PERIOD_EXPONENT, oa_exponent,
+ DRM_XE_OA_PROPERTY_OA_PERIOD_EXPONENT, oa_exponent_default,
DRM_XE_OA_PROPERTY_OA_DISABLED, true,
};
struct intel_xe_oa_open_prop param = {
.num_properties = ARRAY_SIZE(properties) / 2,
.properties_ptr = to_user_pointer(properties),
};
- uint32_t test_duration = 80 * 1000 * 1000;
- int sample_size = get_oa_format(default_test_set->perf_oa_format).size;
- int n_expected_reports = test_duration / oa_exponent_to_ns(oa_exponent);
- int n_expect_read_bytes = n_expected_reports * sample_size;
- struct timespec ts = {};
- int n_bytes_read = 0;
- uint32_t n_polls = 0;
+ int report_size = get_oa_format(default_test_set->perf_oa_format).size;
+ u32 oa_tail, prev_tail;
+ struct pollfd pollfd;
+ uint8_t buf[10];
+ int ret, i = 0;
+
+ intel_register_access_init(&mmio_data,
+ igt_device_get_pci_device(drm_fd), 0);
stream_fd = __perf_open(drm_fd, ¶m, true /* prevent_pm */);
set_fd_flags(stream_fd, O_CLOEXEC | O_NONBLOCK);
- do_ioctl(stream_fd, DRM_XE_OBSERVATION_IOCTL_ENABLE, 0);
-
- while (igt_nsec_elapsed(&ts) < test_duration) {
- struct pollfd pollfd = { .fd = stream_fd, .events = POLLIN };
- ppoll(&pollfd, 1, NULL, NULL);
- if (pollfd.revents & POLLIN) {
- uint8_t buf[1024];
- int ret;
+#define OAG_OATAILPTR (0xdb04)
+ /* Save the current tail */
+ prev_tail = oa_tail = intel_register_read(&mmio_data, OAG_OATAILPTR);
- ret = read(stream_fd, buf, sizeof(buf));
- if (ret >= 0)
- n_bytes_read += ret;
- }
+ /* Kickstart the capture */
+ do_ioctl(stream_fd, DRM_XE_OBSERVATION_IOCTL_ENABLE, 0);
- n_polls++;
+ /* Wait for 5 reports */
+ while ((oa_tail - prev_tail) < (5 * report_size)) {
+ usleep(1000);
+ oa_tail = intel_register_read(&mmio_data, OAG_OATAILPTR);
+ if (i++ > 10)
+ break;
}
- igt_info("Read %d expected %d (%.2f%% of the expected number), polls=%u\n",
- n_bytes_read, n_expect_read_bytes,
- n_bytes_read * 100.0f / n_expect_read_bytes,
- n_polls);
+ intel_register_access_fini(&mmio_data);
- __perf_close(stream_fd);
+ /* Just read one report and expect ENOSPC */
+ pollfd.fd = stream_fd;
+ pollfd.events = POLLIN;
+ poll(&pollfd, 1, 1000);
+ igt_assert(pollfd.revents & POLLIN);
+ errno = 0;
+ ret = read(stream_fd, buf, sizeof(buf));
+ igt_assert_eq(ret, -1);
+ igt_assert_eq(errno, ENOSPC);
- igt_assert(abs(n_expect_read_bytes - n_bytes_read) <
- 0.20 * n_expect_read_bytes);
+ /* Poll with 0 timeout and expect POLLIN flag to be set */
+ poll(&pollfd, 1, 0);
+ igt_assert(pollfd.revents & POLLIN);
+
+ __perf_close(stream_fd);
}
static int
--
2.34.1
next prev parent reply other threads:[~2025-02-18 20:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 20:27 [PATCH i-g-t CI run 00/14] CI run only Umesh Nerlige Ramappa
2025-02-18 20:27 ` [PATCH i-g-t CI run 01/14] tests/intel/xe_oa: Use static for global variables Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 02/14] tests/intel/xe_oa: Drop unused macro Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 03/14] tests/intel/xe_oa: Rename oa_exp_1_millisec to oa_exponent_default Umesh Nerlige Ramappa
2025-02-22 0:24 ` Dixit, Ashutosh
2025-02-22 0:29 ` Umesh Nerlige Ramappa
2025-02-22 0:31 ` Dixit, Ashutosh
2025-02-18 20:28 ` [PATCH i-g-t CI run 04/14] tests/intel/xe_oa: Use default exponent for some tests Umesh Nerlige Ramappa
2025-02-22 0:29 ` Dixit, Ashutosh
2025-02-22 0:37 ` Umesh Nerlige Ramappa
2025-02-22 0:43 ` Dixit, Ashutosh
2025-02-22 0:46 ` Umesh Nerlige Ramappa
2025-02-22 3:39 ` Dixit, Ashutosh
2025-02-18 20:28 ` [PATCH i-g-t CI run 05/14] tests/intel/xe_oa: Use same render copy width and height across tests Umesh Nerlige Ramappa
2025-02-18 20:28 ` Umesh Nerlige Ramappa [this message]
2025-02-24 20:11 ` [PATCH i-g-t CI run 06/14] tests/intel/xe_oa: Rewrite the polling small buf test Dixit, Ashutosh
2025-02-24 22:56 ` Umesh Nerlige Ramappa
2025-02-25 0:02 ` Umesh Nerlige Ramappa
2025-02-25 4:30 ` Dixit, Ashutosh
2025-02-18 20:28 ` [PATCH i-g-t CI run 07/14] tests/intel/xe_oa: Simplify the buffer-fill test Umesh Nerlige Ramappa
2025-02-24 21:31 ` Dixit, Ashutosh
2025-02-18 20:28 ` [PATCH i-g-t CI run 08/14] tests/intel/xe_oa: Use default buffer size for non-zero reason Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 09/14] tests/intel/xe_oa: Test oa buffer sizes Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 10/14] tests/intel/xe_oa: Rewrite enable-disable test Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 11/14] tests/intel/xe_oa: Enable unprivileged-single-ctx-counters and fix it Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 12/14] tests/intel/xe_oa: Fix mmio_trigger_reports testing Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 13/14] tests/intel/xe_oa: Set boundaries for OA exponent test Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 14/14] tests/intel/xe_oa: Try largest buffer size and Xe1 Umesh Nerlige Ramappa
2025-02-18 23:35 ` ✓ Xe.CI.BAT: success for CI run only Patchwork
2025-02-18 23:40 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-19 18:05 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218202812.1679653-7-umesh.nerlige.ramappa@intel.com \
--to=umesh.nerlige.ramappa@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox