Re: [PATCH i-g-t CI run 04/14] tests/intel/xe_oa: Use default exponent for some tests

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 21 Feb 2025 16:46:54 -0800, Umesh Nerlige Ramappa wrote:
>
> On Fri, Feb 21, 2025 at 04:43:46PM -0800, Dixit, Ashutosh wrote:
> > On Fri, 21 Feb 2025 16:37:53 -0800, Umesh Nerlige Ramappa wrote:
> >>
> >> On Fri, Feb 21, 2025 at 04:29:00PM -0800, Dixit, Ashutosh wrote:
> >> > On Tue, 18 Feb 2025 12:28:02 -0800, Umesh Nerlige Ramappa wrote:
> >> >>
> >> >> Use the default exponent for below tests:
> >> >>
> >> >> oa-tlb-validate
> >> >> short-reads
> >> >> stress-open-close
> >> >> mmio-triggered-reports
> >> >
> >> > Why? Let's add a reason in the commit message, for all the patches, even
> >> > if, in this case, it might be "because it doesn't matter what exponent is
> >> > used".
> >>
> >> That's open for discussion in this review. My reasoning:
> >>
> >> Other than the stress-open-close, none of the other tests actually depend
> >> on the oa exponent, so we might as well use one value everywhere.
> >
> > Yeah that's what I thought.
> >
> >>
> >> >
> >> > Because these tests were ported from i915 I myself don't quite understand
> >> > why some of these tests do what the do. So it will help if we could
> >> > document why we are making the changes we are making, and, when needed,
> >> > what the effect of the changes is going to be.
> >>
> >> There is one patch on top of this series which should adjust the exponent
> >> value for all tests so that they run quickly on simulation.  Maybe I should
> >> post the v2 with that patch so the context is clear, otherwise, I agree
> >> that the reason for these changes is unclear.
> >
> > Either way, or just state on the patch something like: "this would allow
> > these tests to run in a reasonable time on slower platforms".
>
> will do
> >
> > Oops, should have commented on the original series, but ended up commenting
> > on the CI series :/
>
> Either should be fine. Both series are identical except that the CI one
> forces 128MB buffer-size test and also runs on DG2.

I went ahead and copied this discussion into the original series and also
added the R-b there so that they can be picked up from a single place.

Thanks.
--
Ashutosh