From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t CI run 04/14] tests/intel/xe_oa: Use default exponent for some tests
Date: Fri, 21 Feb 2025 16:29:00 -0800 [thread overview]
Message-ID: <85eczqom9f.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250218202812.1679653-5-umesh.nerlige.ramappa@intel.com>
On Tue, 18 Feb 2025 12:28:02 -0800, Umesh Nerlige Ramappa wrote:
>
> Use the default exponent for below tests:
>
> oa-tlb-validate
> short-reads
> stress-open-close
> mmio-triggered-reports
Why? Let's add a reason in the commit message, for all the patches, even
if, in this case, it might be "because it doesn't matter what exponent is
used".
Because these tests were ported from i915 I myself don't quite understand
why some of these tests do what the do. So it will help if we could
document why we are making the changes we are making, and, when needed,
what the effect of the changes is going to be.
Thanks.
--
Ashutosh
next prev parent reply other threads:[~2025-02-22 0:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 20:27 [PATCH i-g-t CI run 00/14] CI run only Umesh Nerlige Ramappa
2025-02-18 20:27 ` [PATCH i-g-t CI run 01/14] tests/intel/xe_oa: Use static for global variables Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 02/14] tests/intel/xe_oa: Drop unused macro Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 03/14] tests/intel/xe_oa: Rename oa_exp_1_millisec to oa_exponent_default Umesh Nerlige Ramappa
2025-02-22 0:24 ` Dixit, Ashutosh
2025-02-22 0:29 ` Umesh Nerlige Ramappa
2025-02-22 0:31 ` Dixit, Ashutosh
2025-02-18 20:28 ` [PATCH i-g-t CI run 04/14] tests/intel/xe_oa: Use default exponent for some tests Umesh Nerlige Ramappa
2025-02-22 0:29 ` Dixit, Ashutosh [this message]
2025-02-22 0:37 ` Umesh Nerlige Ramappa
2025-02-22 0:43 ` Dixit, Ashutosh
2025-02-22 0:46 ` Umesh Nerlige Ramappa
2025-02-22 3:39 ` Dixit, Ashutosh
2025-02-18 20:28 ` [PATCH i-g-t CI run 05/14] tests/intel/xe_oa: Use same render copy width and height across tests Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 06/14] tests/intel/xe_oa: Rewrite the polling small buf test Umesh Nerlige Ramappa
2025-02-24 20:11 ` Dixit, Ashutosh
2025-02-24 22:56 ` Umesh Nerlige Ramappa
2025-02-25 0:02 ` Umesh Nerlige Ramappa
2025-02-25 4:30 ` Dixit, Ashutosh
2025-02-18 20:28 ` [PATCH i-g-t CI run 07/14] tests/intel/xe_oa: Simplify the buffer-fill test Umesh Nerlige Ramappa
2025-02-24 21:31 ` Dixit, Ashutosh
2025-02-18 20:28 ` [PATCH i-g-t CI run 08/14] tests/intel/xe_oa: Use default buffer size for non-zero reason Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 09/14] tests/intel/xe_oa: Test oa buffer sizes Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 10/14] tests/intel/xe_oa: Rewrite enable-disable test Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 11/14] tests/intel/xe_oa: Enable unprivileged-single-ctx-counters and fix it Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 12/14] tests/intel/xe_oa: Fix mmio_trigger_reports testing Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 13/14] tests/intel/xe_oa: Set boundaries for OA exponent test Umesh Nerlige Ramappa
2025-02-18 20:28 ` [PATCH i-g-t CI run 14/14] tests/intel/xe_oa: Try largest buffer size and Xe1 Umesh Nerlige Ramappa
2025-02-18 23:35 ` ✓ Xe.CI.BAT: success for CI run only Patchwork
2025-02-18 23:40 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-19 18:05 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85eczqom9f.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox