public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] tests/intel/xe_exec_multi_queue: No engines in virtual test expected
@ 2026-01-15 20:18 Jonathan Cavitt
  2026-01-15 22:07 ` ✓ Xe.CI.BAT: success for tests/intel/xe_exec_multi_queue: No engines in virtual test expected (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Jonathan Cavitt @ 2026-01-15 20:18 UTC (permalink / raw)
  To: igt-dev
  Cc: saurabhg.gupta, alex.zuo, jonathan.cavitt,
	niranjana.vishwanathapura, priyanka.dandamudi, stuart.summers

In the xe_exec_multi_queue@virtual test, we currently assert that at
least one engine with a given class on a given GT ID exists.  However,
the way we generate these class and GT ID pairs is through brute-force
(I.E. list all engine classes that support multi queue, then list all GT
IDs, to generate all pairs).  This frequently results in invalid class
and GT ID pairs.

While a smart solution that only generates valid class and GT ID
pairings would be preferred here, doing so would probably be overkill,
so just remove the igt_assert case and exit silently if no engines are
found.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Cc: Stuart Summers <stuart.summers@intel.com>
---
 tests/intel/xe_exec_multi_queue.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/intel/xe_exec_multi_queue.c b/tests/intel/xe_exec_multi_queue.c
index 6bc6f9f63b..9a02744967 100644
--- a/tests/intel/xe_exec_multi_queue.c
+++ b/tests/intel/xe_exec_multi_queue.c
@@ -995,7 +995,9 @@ test_exec_virtual(int fd, int gt, int class)
 
 		eci[n++] = *hwe;
 	}
-	igt_assert(n);
+
+	if (!n)
+		return;
 
 	test_exec(fd, eci, n, n, n, 0);
 	test_exec(fd, eci, n, n, n, PREEMPT_MODE);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] tests/intel/xe_exec_multi_queue: No engines in virtual test expected
@ 2026-01-13 21:15 Jonathan Cavitt
  2026-01-15 20:07 ` Niranjana Vishwanathapura
  0 siblings, 1 reply; 9+ messages in thread
From: Jonathan Cavitt @ 2026-01-13 21:15 UTC (permalink / raw)
  To: igt-dev
  Cc: saurabhg.gupta, alex.zuo, jonathan.cavitt,
	niranjana.vishwanathapura, priyanka.dandamudi, stuart.summers

In the xe_exec_multi_queue@virtual test, we currently assert that at
least one engine with a given class on a given GT ID exists.  However,
the way we generate these class and GT ID pairs is through brute-force
(I.E. list all engine classes that support multi queue, then list all GT
IDs, to generate all pairs).  This frequently results in invalid class
and GT pairs (E.G. attempting to find RCS on GT ID 1).

While a smart solution that only generates valid class and GT ID
pairings would be preferred here, doing so would probably be overkill,
so just remove the igt_assert case and exit silently if no engines are
found.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Cc: Stuart Summers <stuart.summers@intel.com>
---
 tests/intel/xe_exec_multi_queue.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/intel/xe_exec_multi_queue.c b/tests/intel/xe_exec_multi_queue.c
index 6bc6f9f63b..9a02744967 100644
--- a/tests/intel/xe_exec_multi_queue.c
+++ b/tests/intel/xe_exec_multi_queue.c
@@ -995,7 +995,9 @@ test_exec_virtual(int fd, int gt, int class)
 
 		eci[n++] = *hwe;
 	}
-	igt_assert(n);
+
+	if (!n)
+		return;
 
 	test_exec(fd, eci, n, n, n, 0);
 	test_exec(fd, eci, n, n, n, PREEMPT_MODE);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-01-20 16:20 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 20:18 [PATCH] tests/intel/xe_exec_multi_queue: No engines in virtual test expected Jonathan Cavitt
2026-01-15 22:07 ` ✓ Xe.CI.BAT: success for tests/intel/xe_exec_multi_queue: No engines in virtual test expected (rev2) Patchwork
2026-01-15 22:24 ` ✓ i915.CI.BAT: " Patchwork
2026-01-16  2:06 ` ✗ Xe.CI.Full: failure " Patchwork
2026-01-20 16:06   ` Cavitt, Jonathan
2026-01-20 16:20     ` Matt Roper
2026-01-16  3:07 ` ✗ i915.CI.Full: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-01-13 21:15 [PATCH] tests/intel/xe_exec_multi_queue: No engines in virtual test expected Jonathan Cavitt
2026-01-15 20:07 ` Niranjana Vishwanathapura

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox