Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Nemesa Garg" <nemesa.garg@intel.com>,
	"Karthik B S" <karthik.b.s@intel.com>,
	"Mohammed Thasleem" <mohammed.thasleem@intel.com>,
	"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v5 14/17] tests/intel/kms_ccs: split outer test loop into two
Date: Thu, 10 Sep 2026 22:14:10 +0200	[thread overview]
Message-ID: <20260910201413.2730574-15-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260910201413.2730574-1-michal.grzelak@intel.com>

for_each_crtc_with_valid_output() iterates over every crtc with
connected output. Split it into two loops. This is needed to handle per
output and per crtc cases.

v4->v5
- fix indentation (Mohammed)

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 tests/intel/kms_ccs.c | 58 +++++++++++++++++++++----------------------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/tests/intel/kms_ccs.c b/tests/intel/kms_ccs.c
index 4d0bda6a78..1a922792c5 100644
--- a/tests/intel/kms_ccs.c
+++ b/tests/intel/kms_ccs.c
@@ -1152,47 +1152,47 @@ static void test_output(data_t *data, const int testnum)
 					      "Older than Xe2 platform needed.\n");
 			}
 
-			for_each_crtc_with_valid_output(&data->display, crtc,
-							data->output) {
-				data->crtc = crtc;
-				igt_display_reset(&data->display);
+			for_each_connected_output(&data->display, data->output) {
+				for_each_crtc(&data->display, crtc) {
+					if (!igt_crtc_connector_valid(crtc, data->output))
+						continue;
 
-				igt_output_set_crtc(data->output,
-						    crtc);
-				if (!intel_pipe_output_combo_valid(&data->display))
-					continue;
+					data->crtc = crtc;
+					igt_display_reset(&data->display);
 
-				igt_dynamic_f("pipe-%s-%s",
-							    igt_crtc_name(crtc),
-							    data->output->name) {
-					int valid_tests = 0;
+					igt_output_set_crtc(data->output, crtc);
+					if (!intel_pipe_output_combo_valid(&data->display))
+						continue;
 
-					if (data->flags == TEST_RANDOM)
-						igt_info("Testing with seed %d\n", data->seed);
+					igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc), data->output->name) {
+						int valid_tests = 0;
 
-					if (data->flags & TEST_ALL_PLANES) {
-						igt_display_require_output_on_crtc(crtc);
+						if (data->flags == TEST_RANDOM)
+							igt_info("Testing with seed %d\n", data->seed);
 
-						for_each_plane_on_crtc(crtc,
-								       data->plane) {
-							if (skip_plane(data, data->plane))
-								continue;
+						if (data->flags & TEST_ALL_PLANES) {
+							igt_display_require_output_on_crtc(crtc);
 
+							for_each_plane_on_crtc(crtc, data->plane) {
+								if (skip_plane(data, data->plane))
+									continue;
+
+								for (int j = 0; j < ARRAY_SIZE(formats); j++) {
+									data->format = formats[j];
+									valid_tests += test_ccs(data);
+								}
+							}
+						} else {
 							for (int j = 0; j < ARRAY_SIZE(formats); j++) {
 								data->format = formats[j];
 								valid_tests += test_ccs(data);
 							}
 						}
-					} else {
-						for (int j = 0; j < ARRAY_SIZE(formats); j++) {
-							data->format = formats[j];
-							valid_tests += test_ccs(data);
-						}
+						igt_require_f(valid_tests > 0,
+							      "no valid tests for %s on pipe %s\n",
+							      ccs_modifiers[i].str,
+							      igt_crtc_name(crtc));
 					}
-					igt_require_f(valid_tests > 0,
-						      "no valid tests for %s on pipe %s\n",
-						      ccs_modifiers[i].str,
-						      igt_crtc_name(crtc));
 				}
 			}
 		}
-- 
2.45.2


  parent reply	other threads:[~2026-09-10 20:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 20:13 [PATCH i-g-t v5 00/17] tests: limiting suspend tests Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 01/17] lib/igt_aux: remove typos Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 02/17] lib/igt_kms: s/pipe/crtc/ Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 03/17] tests/kms_async_flips: split outer test loop into two Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 04/17] tests/kms_async_flips: limit S/R to first and last CRTC Michał Grzelak
2026-09-11  7:15   ` Jani Nikula
2026-09-10 20:14 ` [PATCH i-g-t v5 05/17] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `suspend` Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 06/17] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `fliptrack` Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 07/17] tests/kms_pipe_crc_basic: limit #crtcs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 08/17] tests/kms_psr: limit #outputs " Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 09/17] tests/kms_vblank: split outer test loop into two Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 10/17] tests/kms_vblank: limit #outputs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 11/17] tests/kms_sharpness_filter: fix typo Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 12/17] tests/kms_sharpness_filter: limit #outputs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 13/17] tests/kms_sharpness_filter: limit #crtcs " Michał Grzelak
2026-09-10 20:14 ` Michał Grzelak [this message]
2026-09-10 20:14 ` [PATCH i-g-t v5 15/17] tests/intel/kms_ccs: limit #outputs " Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 16/17] tests/intel/kms_ccs: limit #crtcs " Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 17/17] tests/kms_hdr: run on 3 outputs when testing suspend Michał Grzelak
2026-09-11  1:25 ` ✓ Xe.CI.BAT: success for tests: limiting suspend tests (rev4) Patchwork
2026-09-11  1:42 ` ✓ i915.CI.BAT: " Patchwork
2026-09-11 12:13 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-11 22:57 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910201413.2730574-15-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=mohammed.thasleem@intel.com \
    --cc=nemesa.garg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox