From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Nemesa Garg" <nemesa.garg@intel.com>,
"Karthik B S" <karthik.b.s@intel.com>,
"Mohammed Thasleem" <mohammed.thasleem@intel.com>,
"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v5 05/17] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `suspend`
Date: Thu, 10 Sep 2026 22:14:01 +0200 [thread overview]
Message-ID: <20260910201413.2730574-6-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260910201413.2730574-1-michal.grzelak@intel.com>
igt@kms_frontbuffer_tracking uses TEST_MODE_ITER_BEGIN(t) which consists
of nested for loops. However many loops can be omitted due to continue
statements. This obfuscates following the execution of any given
codepath. Replace TEST_MODE_ITER_BEGIN(t) for fliptrack tests with macro
definition and remove loops that are skipped.
v1->v2
- remove blank line (Mohammed)
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/intel/kms_frontbuffer_tracking.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index dd7d3188fe..dc8ef069b8 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -4646,12 +4646,19 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
}
TEST_MODE_ITER_END
- TEST_MODE_ITER_BEGIN(t)
- if (t.pipes != PIPE_SINGLE ||
- t.screen != SCREEN_PRIM ||
- t.plane != PLANE_PRI ||
- t.fbs != FBS_INDIVIDUAL ||
- t.method != IGT_DRAW_BLT)
+ t.format = FORMAT_DEFAULT;
+ t.flip = FLIP_PAGEFLIP;
+ t.tiling = opt.tiling;
+ t.pipes = PIPE_SINGLE;
+ t.screen = SCREEN_PRIM;
+ t.plane = PLANE_PRI;
+ t.fbs = FBS_INDIVIDUAL;
+ t.method = IGT_DRAW_BLT;
+
+ for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
+ if (!opt.show_hidden && t.feature == FEATURE_NONE)
+ continue;
+ if ((t.feature & FEATURE_PSR) && (t.feature & FEATURE_DRRS))
continue;
igt_subtest_f("%s-modesetfrombusy", feature_str(t.feature))
@@ -4712,7 +4719,7 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
igt_require(igt_draw_supports_method(drm.fd, t.method));
suspend_subtest(&t);
}
- TEST_MODE_ITER_END
+ }
t.pipes = PIPE_SINGLE;
t.screen = SCREEN_PRIM;
--
2.45.2
next prev parent reply other threads:[~2026-09-10 20:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 20:13 [PATCH i-g-t v5 00/17] tests: limiting suspend tests Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 01/17] lib/igt_aux: remove typos Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 02/17] lib/igt_kms: s/pipe/crtc/ Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 03/17] tests/kms_async_flips: split outer test loop into two Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 04/17] tests/kms_async_flips: limit S/R to first and last CRTC Michał Grzelak
2026-09-11 7:15 ` Jani Nikula
2026-09-10 20:14 ` Michał Grzelak [this message]
2026-09-10 20:14 ` [PATCH i-g-t v5 06/17] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `fliptrack` Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 07/17] tests/kms_pipe_crc_basic: limit #crtcs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 08/17] tests/kms_psr: limit #outputs " Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 09/17] tests/kms_vblank: split outer test loop into two Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 10/17] tests/kms_vblank: limit #outputs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 11/17] tests/kms_sharpness_filter: fix typo Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 12/17] tests/kms_sharpness_filter: limit #outputs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 13/17] tests/kms_sharpness_filter: limit #crtcs " Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 14/17] tests/intel/kms_ccs: split outer test loop into two Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 15/17] tests/intel/kms_ccs: limit #outputs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 16/17] tests/intel/kms_ccs: limit #crtcs " Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 17/17] tests/kms_hdr: run on 3 outputs when testing suspend Michał Grzelak
2026-09-11 1:25 ` ✓ Xe.CI.BAT: success for tests: limiting suspend tests (rev4) Patchwork
2026-09-11 1:42 ` ✓ i915.CI.BAT: " Patchwork
2026-09-11 12:13 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-11 22:57 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910201413.2730574-6-michal.grzelak@intel.com \
--to=michal.grzelak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=mohammed.thasleem@intel.com \
--cc=nemesa.garg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox