Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Nemesa Garg" <nemesa.garg@intel.com>,
	"Karthik B S" <karthik.b.s@intel.com>,
	"Mohammed Thasleem" <mohammed.thasleem@intel.com>,
	"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v5 08/17] tests/kms_psr: limit #outputs tested during suspend
Date: Thu, 10 Sep 2026 22:14:04 +0200	[thread overview]
Message-ID: <20260910201413.2730574-9-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260910201413.2730574-1-michal.grzelak@intel.com>

We are iterating through each output while testing suspend. This results
in extended execution time. In turn this leads to hitting CI enforced
timeout.

By default limit number of tested outputs to 2. Test each connected
output when passing command-line parameter.

v3->v4
- indent `case' at same level as switch (Mohammed)

v2->v3
- remove blank line (Mohammed)
- change output format of help string (Mohammed)

v1->v2
- s/OUTPUT_LIMIT/SUSPEND_OUTPUT_LIMIT/ (Mohammed)
- fix typos (Mohammed)
- fix off-by-one error (Mohammed)

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 tests/intel/kms_psr.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/tests/intel/kms_psr.c b/tests/intel/kms_psr.c
index 7b02dd2072..c8e3ed2e7b 100644
--- a/tests/intel/kms_psr.c
+++ b/tests/intel/kms_psr.c
@@ -275,6 +275,8 @@
  * @plane-move:         Move plane position
  */
 
+#define SUSPEND_OUTPUT_LIMIT 2
+
 enum operations {
 	PAGE_FLIP,
 	MMAP_GTT,
@@ -318,6 +320,7 @@ typedef struct {
 	drmModeModeInfo *mode;
 	igt_output_t *output;
 	bool fbc_flag;
+	bool all_outputs;
 } data_t;
 
 static void create_cursor_fb(data_t *data)
@@ -767,9 +770,27 @@ static void dpms_off_on(data_t *data)
 				   DRM_MODE_DPMS_ON);
 }
 
+static int opt_handler(int opt, int opt_index, void *opt_data)
+{
+	data_t *data = opt_data;
+
+	switch (opt) {
+	case 'o':
+		data->all_outputs = true;
+		break;
+	default:
+		return IGT_OPT_HANDLER_ERROR;
+	}
+
+	return IGT_OPT_HANDLER_SUCCESS;
+}
+
 data_t data = {};
 
-int igt_main()
+const char *help_str =
+	"  -o \tRun on all connectors. (By default suspend subtests will run on 2 connectors)\n";
+
+int igt_main_args("o", NULL, help_str, opt_handler, &data)
 {
 	int z, y;
 	enum operations op;
@@ -945,10 +966,15 @@ int igt_main()
 				     "performed with suspend resume cycles");
 			igt_subtest_with_dynamic_f("%s%ssuspend", append_fbc_subtest[y],
 						   append_subtest_name[z]) {
+				int output_count = 0;
+
 				for_each_connected_output(&data.display, output) {
 					if (!psr_sink_support(data.drm_fd, data.debugfs_fd,
 							      data.op_psr_mode, output))
 						continue;
+					if (!data.all_outputs && output_count >= SUSPEND_OUTPUT_LIMIT)
+						continue;
+					output_count++;
 					igt_display_reset(&data.display);
 					data.output = output;
 					igt_dynamic_f("%s", data.output->name) {
-- 
2.45.2


  parent reply	other threads:[~2026-09-10 20:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 20:13 [PATCH i-g-t v5 00/17] tests: limiting suspend tests Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 01/17] lib/igt_aux: remove typos Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 02/17] lib/igt_kms: s/pipe/crtc/ Michał Grzelak
2026-09-10 20:13 ` [PATCH i-g-t v5 03/17] tests/kms_async_flips: split outer test loop into two Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 04/17] tests/kms_async_flips: limit S/R to first and last CRTC Michał Grzelak
2026-09-11  7:15   ` Jani Nikula
2026-09-10 20:14 ` [PATCH i-g-t v5 05/17] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `suspend` Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 06/17] tests/kms_frontbuffer_tracking: remove TEST_MODE_ITER_BEGIN() from `fliptrack` Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 07/17] tests/kms_pipe_crc_basic: limit #crtcs tested during suspend Michał Grzelak
2026-09-10 20:14 ` Michał Grzelak [this message]
2026-09-10 20:14 ` [PATCH i-g-t v5 09/17] tests/kms_vblank: split outer test loop into two Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 10/17] tests/kms_vblank: limit #outputs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 11/17] tests/kms_sharpness_filter: fix typo Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 12/17] tests/kms_sharpness_filter: limit #outputs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 13/17] tests/kms_sharpness_filter: limit #crtcs " Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 14/17] tests/intel/kms_ccs: split outer test loop into two Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 15/17] tests/intel/kms_ccs: limit #outputs tested during suspend Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 16/17] tests/intel/kms_ccs: limit #crtcs " Michał Grzelak
2026-09-10 20:14 ` [PATCH i-g-t v5 17/17] tests/kms_hdr: run on 3 outputs when testing suspend Michał Grzelak
2026-09-11  1:25 ` ✓ Xe.CI.BAT: success for tests: limiting suspend tests (rev4) Patchwork
2026-09-11  1:42 ` ✓ i915.CI.BAT: " Patchwork
2026-09-11 12:13 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-11 22:57 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910201413.2730574-9-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=mohammed.thasleem@intel.com \
    --cc=nemesa.garg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox