Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2] tests/intel/xe_exec_atomic: Skip on unsupported config
@ 2024-01-29  8:01 Nirmoy Das
  2024-01-29  8:47 ` Kamil Konieczny
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Nirmoy Das @ 2024-01-29  8:01 UTC (permalink / raw)
  To: igt-dev; +Cc: Nirmoy Das

Atomics on system memory for dGPU is not functional
at this moment hence skip on such configuration.

v2: remove the skip_on.

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 tests/intel/xe_exec_atomic.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/intel/xe_exec_atomic.c b/tests/intel/xe_exec_atomic.c
index 7ee80816c..48c70ec72 100644
--- a/tests/intel/xe_exec_atomic.c
+++ b/tests/intel/xe_exec_atomic.c
@@ -112,9 +112,8 @@ static void basic_inst(int fd, int inst_type, struct drm_xe_engine_class_instanc
 
 static bool has_atomics(int fd, uint32_t region)
 {
-	/* System memory atomics on PVC doesn't work */
-	if (region == system_memory(fd) &&
-	    IS_PONTEVECCHIO(intel_get_drm_devid(fd)))
+	/* System memory atomics on dGPU is not functional as of now */
+	if (region == system_memory(fd) && xe_has_vram(fd))
 		return false;
 
 	return true;
@@ -135,8 +134,8 @@ igt_main
 			uint64_t memreg = all_memory_regions(fd), region;
 
 			xe_for_each_mem_region(fd, memreg, region) {
-
-				igt_skip_on(!has_atomics(fd, region));
+				if (!has_atomics(fd, region))
+					continue;
 
 				igt_dynamic_f("Engine-%s-Instance-%d-Tile-%d-%s-memory",
 					      xe_engine_class_string(hwe->engine_class),
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-01-30  0:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-29  8:01 [PATCH i-g-t v2] tests/intel/xe_exec_atomic: Skip on unsupported config Nirmoy Das
2024-01-29  8:47 ` Kamil Konieczny
2024-01-29  9:09   ` Nirmoy Das
2024-01-29 10:55     ` Kamil Konieczny
2024-01-29 11:03       ` Nirmoy Das
2024-01-29 11:12         ` Kamil Konieczny
2024-01-29 11:28           ` Nirmoy Das
2024-01-29 12:04 ` ✓ Fi.CI.BAT: success for tests/intel/xe_exec_atomic: Skip on unsupported config (rev2) Patchwork
2024-01-29 12:14 ` ✓ CI.xeBAT: " Patchwork
2024-01-30  0:47 ` ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox