Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2 0/4] test/kms_colorop_helper: don't request colorop updates indefinitely
@ 2026-06-02 21:06 Melissa Wen
  2026-06-02 21:06 ` [PATCH i-g-t v2 1/4] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
                   ` (7 more replies)
  0 siblings, 8 replies; 13+ messages in thread
From: Melissa Wen @ 2026-06-02 21:06 UTC (permalink / raw)
  To: Petri Latvala, Arkadiusz Hiler, Kamil Konieczny,
	Juha-Pekka Heikkila, Bhanuprakash Modem, Ashutosh Dixit,
	Karthik B S
  Cc: igt-dev, kernel-dev, Chaitanya Kumar Borah, Alex Hung,
	Swati Sharma, John Harrison, Rodrigo Siqueira, Simon Ser,
	Xaver Hugl, Harry Wentland, Uma Shankar

After committing colorop settings, colorops are still flagged as
changed, even if there is no new request for updates. The first patch
clear colorop flag after commit so that the next patch doesn't try to
re-submit changes on inactive color pipeline. The second patch prevents
colorop to be marked as changed just because it was checking if a
property enum value is supported.

These changes are consistent with the current expecation of allowing
property changes in colorop that are part of a current active color
pipeline or a color pipeline that will be activated or deactived in the
same atomic commit; but rejecting attempts to change inactive colorops.

There are two new patches: patch 3 fixes kms_properties to match colorop
update requirements of an active plane color pipeline. Patch 4 just
ensure that kms_color_pipeline expects an intel device and will not run
otherwise. As color validation works better with writeback then CRC,
other devices should prefer kms_colorop if they have writeback support.
If not, they should work on adapting kms_color_pipeline
according to their specs.

Lemme know your thought!

Melissa

Melissa Wen (4):
  lib/igt_kms: clear colorop-changed flag after commit
  test/kms_colorop_helper: only check if a given enum value exist
  tests/kms_properties: check colorop properties on active color
    pipelines
  tests/kms_color_pipeline: skip if not an intel device

 lib/igt_kms.c              | 41 ++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h              |  4 ++++
 tests/kms_color_pipeline.c |  1 +
 tests/kms_colorop_helper.c |  4 +++-
 tests/kms_properties.c     | 26 ++++++++++++++++++++++--
 5 files changed, 73 insertions(+), 3 deletions(-)

-- 
2.53.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-07-31  8:28 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-02 21:06 [PATCH i-g-t v2 0/4] test/kms_colorop_helper: don't request colorop updates indefinitely Melissa Wen
2026-06-02 21:06 ` [PATCH i-g-t v2 1/4] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
2026-07-31  8:25   ` Borah, Chaitanya Kumar
2026-06-02 21:06 ` [PATCH i-g-t v2 2/4] test/kms_colorop_helper: only check if a given enum value exist Melissa Wen
2026-07-31  8:26   ` Borah, Chaitanya Kumar
2026-06-02 21:06 ` [PATCH i-g-t v2 3/4] tests/kms_properties: check colorop properties on active color pipelines Melissa Wen
2026-07-31  8:27   ` Borah, Chaitanya Kumar
2026-06-02 21:06 ` [PATCH i-g-t v2 4/4] tests/kms_color_pipeline: skip if not an intel device Melissa Wen
2026-07-31  8:27   ` Borah, Chaitanya Kumar
2026-06-03  6:51 ` ✓ Xe.CI.BAT: success for test/kms_colorop_helper: don't request colorop updates indefinitely Patchwork
2026-06-03  6:57 ` ✓ i915.CI.BAT: " Patchwork
2026-06-03 18:25 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-04  3:33 ` ✗ i915.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox