[PATCH i-g-t 0/4] tests/kms_dirtyfb: few fbc related updates

[PATCH i-g-t 0/4] tests/kms_dirtyfb: few fbc related updates

[Vinod Govindapillai]

Add check if the plan size is within FBC enforced restrictions otherwise
skip the test. Some updates to FBC debug prints to make debugging easier.
And disable PSR feature only if psr is supported by the sink

Vinod Govindapillai (4):
  lib/i915/fbc: print current fbc status if cannot be enabled
  lib/i915/fbc: add fbc frame size check helper
  tests/kms_dirtyfb: disable psr feature only if psr possible
  tests/kms_dirtyfb: ensure plane size is within fbc supported limit

 lib/i915/intel_fbc.c      | 42 ++++++++++++++++++++++++++++++++++++++-
 lib/i915/intel_fbc.h      |  1 +
 tests/intel/kms_dirtyfb.c | 14 +++++++++++--
 3 files changed, 54 insertions(+), 3 deletions(-)

-- 
2.34.1

[PATCH i-g-t 1/4] lib/i915/fbc: print current fbc status if cannot be enabled

[Vinod Govindapillai]

Print the current fbc status if the fbc is not enabled after
the timeout.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 lib/i915/intel_fbc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
index 3fac60087..07ed7f469 100644
--- a/lib/i915/intel_fbc.c
+++ b/lib/i915/intel_fbc.c
@@ -92,6 +92,10 @@ bool intel_fbc_is_enabled(int device, enum pipe pipe, int log_level)
 bool intel_fbc_wait_until_enabled(int device, enum pipe pipe)
 {
 	char last_fbc_buf[FBC_STATUS_BUF_LEN] = {'\0'};
+	bool enabled = igt_wait(_intel_fbc_is_enabled(device, pipe, IGT_LOG_DEBUG, last_fbc_buf), 2000, 1);
 
-	return igt_wait(_intel_fbc_is_enabled(device, pipe, IGT_LOG_DEBUG, last_fbc_buf), 2000, 1);
+	if (!enabled)
+		igt_info("FBC is not enabled: \n%s\n", last_fbc_buf);
+
+	return enabled;
 }
-- 
2.34.1

[PATCH i-g-t 2/4] lib/i915/fbc: add fbc frame size check helper

[Vinod Govindapillai]

Add a helper function to check maximum plane size fbc can be
supported in a display version.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 lib/i915/intel_fbc.c | 36 ++++++++++++++++++++++++++++++++++++
 lib/i915/intel_fbc.h |  1 +
 2 files changed, 37 insertions(+)

diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
index 07ed7f469..992e9c4de 100644
--- a/lib/i915/intel_fbc.c
+++ b/lib/i915/intel_fbc.c
@@ -99,3 +99,39 @@ bool intel_fbc_wait_until_enabled(int device, enum pipe pipe)
 
 	return enabled;
 }
+
+/**
+ * intel_fbc_plane_size_supported
+ *
+ * @fd: fd of the device
+ * @width: width of the plane
+ * @height: height of the plane
+ *
+ * Checks if the plane size supported for FBC
+ *
+ * Returns:
+ * true if plane size is within the range as per the FBC supported size restrictions per platform
+ */
+bool intel_fbc_plane_size_supported(int fd, uint32_t width, uint32_t height)
+{
+	const uint32_t dev_id = intel_get_drm_devid(fd);
+	const struct intel_device_info *info = intel_get_device_info(dev_id);
+	int ver = info->graphics_ver;
+	unsigned int max_w, max_h;
+
+	if (ver >= 10) {
+		max_w = 5120;
+		max_h = 4096;
+	} else if (ver >= 8 || IS_HASWELL(fd)) {
+		max_w = 4096;
+		max_h = 4096;
+	} else if (IS_G4X(fd) || ver >= 5) {
+		max_w = 4096;
+		max_h = 2048;
+	} else {
+		max_w = 2048;
+		max_h = 1536;
+	}
+
+	return width <= max_w && height <= max_h;
+}
diff --git a/lib/i915/intel_fbc.h b/lib/i915/intel_fbc.h
index 995dc7f1e..f05b351f6 100644
--- a/lib/i915/intel_fbc.h
+++ b/lib/i915/intel_fbc.h
@@ -14,5 +14,6 @@
 bool intel_fbc_supported_on_chipset(int device, enum pipe pipe);
 bool intel_fbc_wait_until_enabled(int device, enum pipe pipe);
 bool intel_fbc_is_enabled(int device, enum pipe pipe, int log_level);
+bool intel_fbc_plane_size_supported(int device, uint32_t width, uint32_t height);
 
 #endif
-- 
2.34.1

[PATCH i-g-t 3/4] tests/kms_dirtyfb: disable psr feature only if psr possible

[Vinod Govindapillai]

When kms_dirtyfb tests are executed on cases where PSR is not
possible the tests are getting skipped. This is because igt_skip
is use in psr_set function. So avoid calling the psr_disable if
not necessary.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 tests/intel/kms_dirtyfb.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 6121599ec..2a32fab56 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -169,7 +169,10 @@ static void check_feature(data_t *data)
 static void disable_features(data_t *data)
 {
 	intel_fbc_disable(data->drm_fd);
-	psr_disable(data->drm_fd, data->debugfs_fd, NULL);
+
+	if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL))
+		psr_disable(data->drm_fd, data->debugfs_fd, NULL);
+
 	intel_drrs_disable(data->drm_fd, data->pipe);
 }
 
-- 
2.34.1

[PATCH i-g-t 4/4] tests/kms_dirtyfb: ensure plane size is within fbc supported limit

[Vinod Govindapillai]

When FBC tests are performed, ensure that plane size is within the
FBC supported plane size limit. Skip the iteration if the plane
size is bigger that FBC enforced restrictions.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 tests/intel/kms_dirtyfb.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index 2a32fab56..83042e206 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -102,7 +102,14 @@ static bool check_support(data_t *data)
 	case FEATURE_NONE:
 		return true;
 	case FEATURE_FBC:
-		return intel_fbc_supported_on_chipset(data->drm_fd, data->pipe);
+		drmModeModeInfo *mode = igt_output_get_mode(data->output);
+
+		if (!intel_fbc_supported_on_chipset(data->drm_fd, data->pipe))
+			return false;
+
+		return intel_fbc_plane_size_supported(data->drm_fd,
+						      mode->hdisplay,
+						      mode->vdisplay);
 	case FEATURE_PSR:
 		if (data->output->config.connector->connector_type !=
 		    DRM_MODE_CONNECTOR_eDP)
-- 
2.34.1

RE: [PATCH i-g-t 1/4] lib/i915/fbc: print current fbc status if cannot be enabled

[Cavitt, Jonathan]

-----Original Message-----
From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vinod Govindapillai
Sent: Friday, June 7, 2024 7:57 AM
To: igt-dev@lists.freedesktop.org
Cc: Govindapillai, Vinod <vinod.govindapillai@intel.com>; Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
Subject: [PATCH i-g-t 1/4] lib/i915/fbc: print current fbc status if cannot be enabled
> 
> Print the current fbc status if the fbc is not enabled after
> the timeout.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

Seems like a good debug step.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
-Jonathan Cavitt

> ---
>  lib/i915/intel_fbc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
> index 3fac60087..07ed7f469 100644
> --- a/lib/i915/intel_fbc.c
> +++ b/lib/i915/intel_fbc.c
> @@ -92,6 +92,10 @@ bool intel_fbc_is_enabled(int device, enum pipe pipe, int log_level)
>  bool intel_fbc_wait_until_enabled(int device, enum pipe pipe)
>  {
>  	char last_fbc_buf[FBC_STATUS_BUF_LEN] = {'\0'};
> +	bool enabled = igt_wait(_intel_fbc_is_enabled(device, pipe, IGT_LOG_DEBUG, last_fbc_buf), 2000, 1);
>  
> -	return igt_wait(_intel_fbc_is_enabled(device, pipe, IGT_LOG_DEBUG, last_fbc_buf), 2000, 1);
> +	if (!enabled)
> +		igt_info("FBC is not enabled: \n%s\n", last_fbc_buf);
> +
> +	return enabled;
>  }
> -- 
> 2.34.1
> 
> 

RE: [PATCH i-g-t 2/4] lib/i915/fbc: add fbc frame size check helper

[Cavitt, Jonathan]

-----Original Message-----
From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vinod Govindapillai
Sent: Friday, June 7, 2024 7:58 AM
To: igt-dev@lists.freedesktop.org
Cc: Govindapillai, Vinod <vinod.govindapillai@intel.com>; Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
Subject: [PATCH i-g-t 2/4] lib/i915/fbc: add fbc frame size check helper
> 
> Add a helper function to check maximum plane size fbc can be
> supported in a display version.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
>  lib/i915/intel_fbc.c | 36 ++++++++++++++++++++++++++++++++++++
>  lib/i915/intel_fbc.h |  1 +
>  2 files changed, 37 insertions(+)
> 
> diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
> index 07ed7f469..992e9c4de 100644
> --- a/lib/i915/intel_fbc.c
> +++ b/lib/i915/intel_fbc.c
> @@ -99,3 +99,39 @@ bool intel_fbc_wait_until_enabled(int device, enum pipe pipe)
>  
>  	return enabled;
>  }
> +
> +/**
> + * intel_fbc_plane_size_supported
> + *
> + * @fd: fd of the device
> + * @width: width of the plane
> + * @height: height of the plane
> + *
> + * Checks if the plane size supported for FBC
> + *
> + * Returns:
> + * true if plane size is within the range as per the FBC supported size restrictions per platform
> + */
> +bool intel_fbc_plane_size_supported(int fd, uint32_t width, uint32_t height)
> +{
> +	const uint32_t dev_id = intel_get_drm_devid(fd);
> +	const struct intel_device_info *info = intel_get_device_info(dev_id);
> +	int ver = info->graphics_ver;
> +	unsigned int max_w, max_h;
> +
> +	if (ver >= 10) {
> +		max_w = 5120;
> +		max_h = 4096;
> +	} else if (ver >= 8 || IS_HASWELL(fd)) {
> +		max_w = 4096;
> +		max_h = 4096;
> +	} else if (IS_G4X(fd) || ver >= 5) {
> +		max_w = 4096;
> +		max_h = 2048;
> +	} else {
> +		max_w = 2048;
> +		max_h = 1536;
> +	}
> +
> +	return width <= max_w && height <= max_h;
> +}

It might also be helpful to have a separate function that returns the max fcb
plane size supported as a raw value in case any tests wanted to operate on the
full fcb plane.  Say:

int intel_fbc_max_plane_size(int device, uint32_t *width, uint32_t *height)

This could store the width and height generated above and be used as a helper
function for intel_fbc_plane_size_supported.  I also don't know if fcb could be
unsupported at some point, but the int return value could be used for any errors.

This is just something to consider.  I won't block on it:
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
-Jonathan Cavitt


> diff --git a/lib/i915/intel_fbc.h b/lib/i915/intel_fbc.h
> index 995dc7f1e..f05b351f6 100644
> --- a/lib/i915/intel_fbc.h
> +++ b/lib/i915/intel_fbc.h
> @@ -14,5 +14,6 @@
>  bool intel_fbc_supported_on_chipset(int device, enum pipe pipe);
>  bool intel_fbc_wait_until_enabled(int device, enum pipe pipe);
>  bool intel_fbc_is_enabled(int device, enum pipe pipe, int log_level);
> +bool intel_fbc_plane_size_supported(int device, uint32_t width, uint32_t height);
>  
>  #endif
> -- 
> 2.34.1
> 
> 

RE: [PATCH i-g-t 3/4] tests/kms_dirtyfb: disable psr feature only if psr possible

[Cavitt, Jonathan]

-----Original Message-----
From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vinod Govindapillai
Sent: Friday, June 7, 2024 7:58 AM
To: igt-dev@lists.freedesktop.org
Cc: Govindapillai, Vinod <vinod.govindapillai@intel.com>; Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
Subject: [PATCH i-g-t 3/4] tests/kms_dirtyfb: disable psr feature only if psr possible
> 
> When kms_dirtyfb tests are executed on cases where PSR is not
> possible the tests are getting skipped. This is because igt_skip
> is use in psr_set function. So avoid calling the psr_disable if
> not necessary.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
-Jonathan Cavitt

> ---
>  tests/intel/kms_dirtyfb.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 6121599ec..2a32fab56 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -169,7 +169,10 @@ static void check_feature(data_t *data)
>  static void disable_features(data_t *data)
>  {
>  	intel_fbc_disable(data->drm_fd);
> -	psr_disable(data->drm_fd, data->debugfs_fd, NULL);
> +
> +	if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL))
> +		psr_disable(data->drm_fd, data->debugfs_fd, NULL);
> +
>  	intel_drrs_disable(data->drm_fd, data->pipe);
>  }
>  
> -- 
> 2.34.1
> 
> 

RE: [PATCH i-g-t 4/4] tests/kms_dirtyfb: ensure plane size is within fbc supported limit

[Cavitt, Jonathan]

-----Original Message-----
From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vinod Govindapillai
Sent: Friday, June 7, 2024 7:58 AM
To: igt-dev@lists.freedesktop.org
Cc: Govindapillai, Vinod <vinod.govindapillai@intel.com>; Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
Subject: [PATCH i-g-t 4/4] tests/kms_dirtyfb: ensure plane size is within fbc supported limit
> 
> When FBC tests are performed, ensure that plane size is within the
> FBC supported plane size limit. Skip the iteration if the plane
> size is bigger that FBC enforced restrictions.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
-Jonathan Cavitt

> ---
>  tests/intel/kms_dirtyfb.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 2a32fab56..83042e206 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -102,7 +102,14 @@ static bool check_support(data_t *data)
>  	case FEATURE_NONE:
>  		return true;
>  	case FEATURE_FBC:
> -		return intel_fbc_supported_on_chipset(data->drm_fd, data->pipe);
> +		drmModeModeInfo *mode = igt_output_get_mode(data->output);
> +
> +		if (!intel_fbc_supported_on_chipset(data->drm_fd, data->pipe))
> +			return false;
> +
> +		return intel_fbc_plane_size_supported(data->drm_fd,
> +						      mode->hdisplay,
> +						      mode->vdisplay);
>  	case FEATURE_PSR:
>  		if (data->output->config.connector->connector_type !=
>  		    DRM_MODE_CONNECTOR_eDP)
> -- 
> 2.34.1
> 
> 

✗ Fi.CI.BUILD: failure for tests/kms_dirtyfb: few fbc related updates

[Patchwork]

== Series Details ==

Series: tests/kms_dirtyfb: few fbc related updates
URL   : https://patchwork.freedesktop.org/series/134620/
State : failure

== Summary ==

IGT patchset build failed on latest successful build
73618605b4370cf902267aaf1d25666ff5e26112 test/intel/xe_exec_reset: Synchronize cm-gt-reset gt resets

Tail of build.log:
[582/1679] Compiling C object 'tests/59830eb@@kms_flip_tiling@exe/intel_kms_flip_tiling.c.o'.
[583/1679] Compiling C object 'tests/59830eb@@kms_pm_lpsp@exe/intel_kms_pm_lpsp.c.o'.
[584/1679] Compiling C object 'tests/59830eb@@xe_compute@exe/intel_xe_compute.c.o'.
[585/1679] Compiling C object 'tests/59830eb@@i915_pipe_stress@exe/intel_i915_pipe_stress.c.o'.
[586/1679] Compiling C object 'tests/59830eb@@kms_big_joiner@exe/intel_kms_big_joiner.c.o'.
[587/1679] Compiling C object 'tests/59830eb@@xe_wedged@exe/intel_xe_wedged.c.o'.
[588/1679] Compiling C object 'tests/59830eb@@kms_pm_backlight@exe/intel_kms_pm_backlight.c.o'.
[589/1679] Compiling C object 'tests/59830eb@@kms_flip_scaled_crc@exe/intel_kms_flip_scaled_crc.c.o'.
[590/1679] Compiling C object 'tests/59830eb@@sysfs_timeslice_duration@exe/intel_sysfs_timeslice_duration.c.o'.
[591/1679] Compiling C object 'tests/59830eb@@kms_psr_stress_test@exe/intel_kms_psr_stress_test.c.o'.
[592/1679] Compiling C object 'tests/59830eb@@xe_copy_basic@exe/intel_xe_copy_basic.c.o'.
[593/1679] Compiling C object 'tests/59830eb@@kms_psr2_su@exe/intel_kms_psr2_su.c.o'.
[594/1679] Compiling C object 'tests/59830eb@@kms_busy@exe/intel_kms_busy.c.o'.
[595/1679] Compiling C object 'tests/59830eb@@xe_dma_buf_sync@exe/intel_xe_dma_buf_sync.c.o'.
[596/1679] Compiling C object 'tests/59830eb@@gem_mmap_gtt@exe/intel_gem_mmap_gtt.c.o'.
[597/1679] Compiling C object 'tests/59830eb@@i915_pm_rc6_residency@exe/intel_i915_pm_rc6_residency.c.o'.
[598/1679] Compiling C object 'tests/59830eb@@gem_reset_stats@exe/intel_gem_reset_stats.c.o'.
[599/1679] Compiling C object 'tests/59830eb@@xe_exec_atomic@exe/intel_xe_exec_atomic.c.o'.
[600/1679] Compiling C object 'tests/59830eb@@xe_debugfs@exe/intel_xe_debugfs.c.o'.
[601/1679] Compiling C object 'tests/59830eb@@xe_create@exe/intel_xe_create.c.o'.
[602/1679] Compiling C object 'lib/76b5a35@@igt-igt_fb_c@sta/igt_fb.c.o'.
[603/1679] Compiling C object 'tests/59830eb@@xe_drm_fdinfo@exe/intel_xe_drm_fdinfo.c.o'.
[604/1679] Compiling C object 'tests/59830eb@@kms_pm_dc@exe/intel_kms_pm_dc.c.o'.
[605/1679] Compiling C object 'tests/59830eb@@xe_evict_ccs@exe/intel_xe_evict_ccs.c.o'.
[606/1679] Compiling C object 'tests/59830eb@@kms_big_fb@exe/intel_kms_big_fb.c.o'.
[607/1679] Compiling C object 'tests/59830eb@@kms_ccs@exe/intel_kms_ccs.c.o'.
[608/1679] Compiling C object 'tests/59830eb@@kms_psr@exe/intel_kms_psr.c.o'.
[609/1679] Compiling C object 'lib/76b5a35@@igt-igt_kms_c@sta/igt_kms.c.o'.
[610/1679] Compiling C object 'tests/59830eb@@xe_exec_fault_mode@exe/intel_xe_exec_fault_mode.c.o'.
[611/1679] Compiling C object 'tests/59830eb@@xe_exec_basic@exe/intel_xe_exec_basic.c.o'.
[612/1679] Compiling C object 'tests/59830eb@@i915_pm_rps@exe/intel_i915_pm_rps.c.o'.
[613/1679] Compiling C object 'tests/59830eb@@gem_sync@exe/intel_gem_sync.c.o'.
[614/1679] Compiling C object 'tests/59830eb@@gem_pxp@exe/intel_gem_pxp.c.o'.
[615/1679] Compiling C object 'tests/59830eb@@xe_exec_balancer@exe/intel_xe_exec_balancer.c.o'.
[616/1679] Compiling C object 'tests/59830eb@@gem_softpin@exe/intel_gem_softpin.c.o'.
[617/1679] Compiling C object 'tests/59830eb@@i915_pm_rpm@exe/intel_i915_pm_rpm.c.o'.
[618/1679] Compiling C object 'tests/59830eb@@xe_ccs@exe/intel_xe_ccs.c.o'.
[619/1679] Compiling C object 'tests/59830eb@@xe_evict@exe/intel_xe_evict.c.o'.
[620/1679] Compiling C object 'tests/59830eb@@kms_pm_rpm@exe/intel_kms_pm_rpm.c.o'.
[621/1679] Compiling C object 'tests/59830eb@@i915_query@exe/intel_i915_query.c.o'.
[622/1679] Compiling C object 'tests/59830eb@@gem_exec_balancer@exe/intel_gem_exec_balancer.c.o'.
[623/1679] Compiling C object 'tests/59830eb@@kms_psr2_sf@exe/intel_kms_psr2_sf.c.o'.
[624/1679] Generating i915-perf-equations with a custom command.
[625/1679] Compiling C object 'tests/59830eb@@gem_userptr_blits@exe/intel_gem_userptr_blits.c.o'.
[626/1679] Compiling C object 'tests/59830eb@@gem_exec_fence@exe/intel_gem_exec_fence.c.o'.
[627/1679] Compiling C object 'tests/59830eb@@kms_frontbuffer_tracking@exe/intel_kms_frontbuffer_tracking.c.o'.
[628/1679] Compiling C object 'tests/59830eb@@perf_pmu@exe/intel_perf_pmu.c.o'.
[629/1679] Compiling C object 'tests/59830eb@@perf@exe/intel_perf.c.o'.
[630/1679] Compiling C object 'tests/59830eb@@gem_exec_schedule@exe/intel_gem_exec_schedule.c.o'.
ninja: build stopped: subcommand failed.

✗ GitLab.Pipeline: warning for tests/kms_dirtyfb: few fbc related updates

[Patchwork]

== Series Details ==

Series: tests/kms_dirtyfb: few fbc related updates
URL   : https://patchwork.freedesktop.org/series/134620/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1196494 for the overview.

build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646339):
  [2/607] Generating sysfs_timeslice_duration.testlist with a meson_exe.py custom command.
  [3/607] Generating kms_big_joiner.testlist with a meson_exe.py custom command.
  [4/607] Generating kms_big_fb.testlist with a meson_exe.py custom command.
  [5/607] Linking target tests/kms_cdclk.
  [6/607] Generating kms_cdclk.testlist with a meson_exe.py custom command.
  [7/607] Generating kms_busy.testlist with a meson_exe.py custom command.
  [8/607] Compiling C object 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  cc -Itests/59830eb@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/x86_64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -I/usr/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread  -MD -MQ 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c: In function ‘check_support’:
  ../tests/intel/kms_dirtyfb.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
     drmModeModeInfo *mode = igt_output_get_mode(data->output);
     ^~~~~~~~~~~~~~~
  ninja: build stopped: subcommand failed.
  section_end:1717798079:step_script
  section_start:1717798079:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798080:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646342):
  [951/1424] Compiling C object 'tests/59830eb@@kms_dsc@exe/intel_kms_dsc.c.o'.
  [952/1424] Compiling C object 'tests/59830eb@@kms_busy@exe/intel_kms_busy.c.o'.
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/752] Generating version.h with a custom command.
  [2/474] Linking target tests/kms_big_fb.
  [3/474] Compiling C object 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  /usr/bin/aarch64-linux-gnu-gcc -Itests/59830eb@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/aarch64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread  -MD -MQ 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c: In function ‘check_support’:
  ../tests/intel/kms_dirtyfb.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
     drmModeModeInfo *mode = igt_output_get_mode(data->output);
     ^~~~~~~~~~~~~~~
  ninja: build stopped: subcommand failed.
  section_end:1717798075:step_script
  section_start:1717798075:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798077:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646341):
  [949/1424] Linking target tests/kms_cdclk.
  [950/1424] Compiling C object 'tests/59830eb@@kms_ccs@exe/intel_kms_ccs.c.o'.
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/754] Generating version.h with a custom command.
  [2/476] Linking target tests/kms_big_joiner.
  [3/476] Compiling C object 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  /usr/bin/arm-linux-gnueabihf-gcc -Itests/59830eb@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/arm-linux-gnueabihf -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread  -MD -MQ 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c: In function ‘check_support’:
  ../tests/intel/kms_dirtyfb.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
     drmModeModeInfo *mode = igt_output_get_mode(data->output);
     ^~~~~~~~~~~~~~~
  ninja: build stopped: subcommand failed.
  section_end:1717798075:step_script
  section_start:1717798075:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798076:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646343):
  [3/476] Generating symbol file 'lib/76b5a35@@i915_perf@sha/libi915_perf.so.1.5.symbols'.
  [4/476] Linking target tests/core_hotunplug.
  [5/476] Linking target tests/gem_barrier_race.
  [6/476] Linking target tests/perf.
  [7/476] Linking target tests/kms_ccs.
  [8/476] Linking target tests/kms_busy.
  [9/476] Compiling C object 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  /usr/bin/mips-linux-gnu-gcc -Itests/59830eb@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/mips-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/mips-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread  -MD -MQ 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c: In function ‘check_support’:
  ../tests/intel/kms_dirtyfb.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
     drmModeModeInfo *mode = igt_output_get_mode(data->output);
     ^~~~~~~~~~~~~~~
  ninja: build stopped: subcommand failed.
  section_end:1717798086:step_script
  section_start:1717798086:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798087:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646334):
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/1129] Generating version.h with a custom command.
  [2/604] Generating kms_big_fb.testlist with a meson_exe.py custom command.
  [3/604] Generating kms_busy.testlist with a meson_exe.py custom command.
  [4/604] Generating kms_ccs.testlist with a meson_exe.py custom command.
  [5/604] Compiling C object 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  cc -Itests/59830eb@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread -MD -MQ 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c: In function ‘check_support’:
  ../tests/intel/kms_dirtyfb.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
    105 |   drmModeModeInfo *mode = igt_output_get_mode(data->output);
        |   ^~~~~~~~~~~~~~~
  ninja: build stopped: subcommand failed.
  section_end:1717798082:step_script
  section_start:1717798082:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798083:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646338):
  [6/604] Compiling C object 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  clang -Itests/59830eb@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread -MD -MQ 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c:105:3: error: expected expression
                  drmModeModeInfo *mode = igt_output_get_mode(data->output);
                  ^
  ../tests/intel/kms_dirtyfb.c:111:13: error: use of undeclared identifier 'mode'
                                                        mode->hdisplay,
                                                        ^
  ../tests/intel/kms_dirtyfb.c:112:13: error: use of undeclared identifier 'mode'
                                                        mode->vdisplay);
                                                        ^
  3 errors generated.
  ninja: build stopped: subcommand failed.
  section_end:1717798096:step_script
  section_start:1717798096:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798097:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-no-libdrm-nouveau has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646337):
  ninja: Entering directory `build'
  [1/999] Generating version.h with a custom command.
  [2/484] Generating kms_big_fb.testlist with a meson_exe.py custom command.
  [3/484] Generating kms_busy.testlist with a meson_exe.py custom command.
  [4/484] Linking target tests/kms_ccs.
  [5/484] Generating kms_ccs.testlist with a meson_exe.py custom command.
  [6/484] Compiling C object 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  cc -Itests/59830eb@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread -MD -MQ 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c: In function ‘check_support’:
  ../tests/intel/kms_dirtyfb.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
    105 |   drmModeModeInfo *mode = igt_output_get_mode(data->output);
        |   ^~~~~~~~~~~~~~~
  ninja: build stopped: subcommand failed.
  section_end:1717798088:step_script
  section_start:1717798088:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798089:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-no-libunwind has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646335):
  [3/611] Generating kms_big_fb.testlist with a meson_exe.py custom command.
  [4/611] Generating kms_big_joiner.testlist with a meson_exe.py custom command.
  [5/611] Linking target tests/kms_busy.
  [6/611] Generating kms_busy.testlist with a meson_exe.py custom command.
  [7/611] Linking target tests/kms_ccs.
  [8/611] Generating kms_ccs.testlist with a meson_exe.py custom command.
  [9/611] Compiling C object 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  cc -Itests/59830eb@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/libunwind -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread -MD -MQ 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/59830eb@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c: In function ‘check_support’:
  ../tests/intel/kms_dirtyfb.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
    105 |   drmModeModeInfo *mode = igt_output_get_mode(data->output);
        |   ^~~~~~~~~~~~~~~
  ninja: build stopped: subcommand failed.
  section_end:1717798090:step_script
  section_start:1717798090:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798092:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/59646336):
  [3/610] Linking target tests/kms_big_fb.
  [4/610] Generating kms_big_fb.testlist with a meson_exe.py custom command.
  [5/610] Generating kms_big_joiner.testlist with a meson_exe.py custom command.
  [6/610] Generating kms_busy.testlist with a meson_exe.py custom command.
  [7/610] Linking target tests/kms_ccs.
  [8/610] Generating kms_ccs.testlist with a meson_exe.py custom command.
  [9/610] Compiling C object 'tests/tests@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o'.
  FAILED: tests/tests@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o 
  cc -Itests/tests@@kms_dirtyfb@exe -Itests -I../tests -I../include -I../include/drm-uapi -I../include/linux-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/valgrind -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -D_LARGEFILE64_SOURCE=1 -pthread  -MD -MQ 'tests/tests@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -MF 'tests/tests@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o.d' -o 'tests/tests@@kms_dirtyfb@exe/intel_kms_dirtyfb.c.o' -c ../tests/intel/kms_dirtyfb.c
  ../tests/intel/kms_dirtyfb.c: In function ‘check_support’:
  ../tests/intel/kms_dirtyfb.c:105:3: error: a label can only be part of a statement and a declaration is not a statement
    105 |   drmModeModeInfo *mode = igt_output_get_mode(data->output);
        |   ^~~~~~~~~~~~~~~
  ninja: build stopped: subcommand failed.
  section_end:1717798082:step_script
  section_start:1717798082:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1717798083:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1196494

Re: [PATCH i-g-t 2/4] lib/i915/fbc: add fbc frame size check helper

[Govindapillai, Vinod]

On Fri, 2024-06-07 at 20:42 +0000, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Vinod Govindapillai
> Sent: Friday, June 7, 2024 7:58 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Govindapillai, Vinod <vinod.govindapillai@intel.com>; Heikkila, Juha-pekka
> <juha-pekka.heikkila@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
> Subject: [PATCH i-g-t 2/4] lib/i915/fbc: add fbc frame size check helper
> > 
> > Add a helper function to check maximum plane size fbc can be
> > supported in a display version.
> > 
> > Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> > ---
> >  lib/i915/intel_fbc.c | 36 ++++++++++++++++++++++++++++++++++++
> >  lib/i915/intel_fbc.h |  1 +
> >  2 files changed, 37 insertions(+)
> > 
> > diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
> > index 07ed7f469..992e9c4de 100644
> > --- a/lib/i915/intel_fbc.c
> > +++ b/lib/i915/intel_fbc.c
> > @@ -99,3 +99,39 @@ bool intel_fbc_wait_until_enabled(int device, enum pipe pipe)
> >  
> >         return enabled;
> >  }
> > +
> > +/**
> > + * intel_fbc_plane_size_supported
> > + *
> > + * @fd: fd of the device
> > + * @width: width of the plane
> > + * @height: height of the plane
> > + *
> > + * Checks if the plane size supported for FBC
> > + *
> > + * Returns:
> > + * true if plane size is within the range as per the FBC supported size restrictions per
> > platform
> > + */
> > +bool intel_fbc_plane_size_supported(int fd, uint32_t width, uint32_t height)
> > +{
> > +       const uint32_t dev_id = intel_get_drm_devid(fd);
> > +       const struct intel_device_info *info = intel_get_device_info(dev_id);
> > +       int ver = info->graphics_ver;
> > +       unsigned int max_w, max_h;
> > +
> > +       if (ver >= 10) {
> > +               max_w = 5120;
> > +               max_h = 4096;
> > +       } else if (ver >= 8 || IS_HASWELL(fd)) {
> > +               max_w = 4096;
> > +               max_h = 4096;
> > +       } else if (IS_G4X(fd) || ver >= 5) {
> > +               max_w = 4096;
> > +               max_h = 2048;
> > +       } else {
> > +               max_w = 2048;
> > +               max_h = 1536;
> > +       }
> > +
> > +       return width <= max_w && height <= max_h;
> > +}
> 
> It might also be helpful to have a separate function that returns the max fcb
> plane size supported as a raw value in case any tests wanted to operate on the
> full fcb plane.  Say:
> 
> int intel_fbc_max_plane_size(int device, uint32_t *width, uint32_t *height)
> 
> This could store the width and height generated above and be used as a helper
> function for intel_fbc_plane_size_supported.  I also don't know if fcb could be
> unsupported at some point, but the int return value could be used for any errors.

Thanks for the good suggestion! I have now updated the patch series. There was a build issue as well
related to another patch in the prev series.

I cant think of a error case when the size check is performed! So right now not returning any error
code! Any FBC support related error scenario should be handled outside of this size check I think.

BR
Vinod
> 
> This is just something to consider.  I won't block on it:
> Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> -Jonathan Cavitt
> 
> 
> > diff --git a/lib/i915/intel_fbc.h b/lib/i915/intel_fbc.h
> > index 995dc7f1e..f05b351f6 100644
> > --- a/lib/i915/intel_fbc.h
> > +++ b/lib/i915/intel_fbc.h
> > @@ -14,5 +14,6 @@
> >  bool intel_fbc_supported_on_chipset(int device, enum pipe pipe);
> >  bool intel_fbc_wait_until_enabled(int device, enum pipe pipe);
> >  bool intel_fbc_is_enabled(int device, enum pipe pipe, int log_level);
> > +bool intel_fbc_plane_size_supported(int device, uint32_t width, uint32_t height);
> >  
> >  #endif
> > -- 
> > 2.34.1
> > 
> >