Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/gem_exec_params: Fix context within which batch is executed
@ 2021-08-25  7:51 Zbigniew Kempczyński
  2021-08-25  8:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Zbigniew Kempczyński @ 2021-08-25  7:51 UTC (permalink / raw)
  To: igt-dev; +Cc: Zbigniew Kempczyński, Ashutosh Dixit, Jason Ekstrand

With new intel_ctx_t we're responsible to set execbuf rsvd1 (context) id
field. As same field exists for exec object there's risk to mechanically
set improper field and compiler won't complain.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>
---
 tests/i915/gem_exec_params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c
index ba79791a1..d247b8a61 100644
--- a/tests/i915/gem_exec_params.c
+++ b/tests/i915/gem_exec_params.c
@@ -334,11 +334,11 @@ static void test_larger_than_life_batch(int fd)
 	const intel_ctx_t *ctx = intel_ctx_create_all_physical(fd);
 	struct drm_i915_gem_exec_object2 exec = {
 		.handle = batch_create_size(fd, size),
-		.rsvd1 = ctx->id,
 	};
 	struct drm_i915_gem_execbuffer2 execbuf = {
 		.buffers_ptr = to_user_pointer(&exec),
 		.buffer_count = 1,
+		.rsvd1 = ctx->id,
 	};
 
 	/*
-- 
2.26.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-08-25 18:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-25  7:51 [igt-dev] [PATCH i-g-t] tests/gem_exec_params: Fix context within which batch is executed Zbigniew Kempczyński
2021-08-25  8:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-08-25 14:35 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-08-25 17:36   ` Zbigniew Kempczyński
2021-08-25 18:05     ` Vudum, Lakshminarayana
2021-08-25 17:51 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2021-08-25 18:48 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox