* [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence
2022-02-19 0:10 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
@ 2022-02-19 0:10 ` Jasmine Newsome
2022-02-19 0:20 ` Dixit, Ashutosh
0 siblings, 1 reply; 13+ messages in thread
From: Jasmine Newsome @ 2022-02-19 0:10 UTC (permalink / raw)
To: igt-dev; +Cc: jasmine.newsome
The spin all test relied on context persistence unecessarily by trying
to destroy contexts while keeping spinners active.
The current implementation of context persistence in i915 can cause
failures, and persistence is not needed for this test.
Moving intel_ctx_destroy after igt_spin_end.
Signed-off-by: Jasmine Newsome <jasmine.newsome@intel.com>
---
tests/i915/gem_spin_batch.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
index 653812c7..0835a122 100644
--- a/tests/i915/gem_spin_batch.c
+++ b/tests/i915/gem_spin_batch.c
@@ -143,6 +143,7 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
const struct intel_execution_engine2 *e;
intel_ctx_cfg_t cfg = ctx->cfg;
struct igt_spin *spin, *n;
+ const intel_ctx_t *local_ctx;
uint64_t ahnd;
IGT_LIST_HEAD(list);
@@ -151,18 +152,16 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
continue;
if (flags & PARALLEL_SPIN_NEW_CTX)
- ctx = intel_ctx_create(i915, &cfg);
+ local_ctx = intel_ctx_create(i915, &cfg);
ahnd = get_reloc_ahnd(i915, ctx->id);
/* Prevent preemption so only one is allowed on each engine */
spin = igt_spin_new(i915,
.ahnd = ahnd,
- .ctx = ctx,
+ .ctx = (flags & PARALLEL_SPIN_NEW_CTX) ? local_ctx : ctx,
.engine = e->flags,
.flags = (IGT_SPIN_POLL_RUN |
IGT_SPIN_NO_PREEMPTION));
- if (flags & PARALLEL_SPIN_NEW_CTX)
- intel_ctx_destroy(i915, ctx);
igt_spin_busywait_until_started(spin);
igt_list_move(&spin->link, &list);
@@ -172,7 +171,9 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
igt_assert(gem_bo_busy(i915, spin->handle));
ahnd = spin->ahnd;
igt_spin_end(spin);
- gem_sync(i915, spin->handle);
+ if (flags & PARALLEL_SPIN_NEW_CTX)
+ intel_ctx_destroy(i915, spin->opts.ctx);
+ gem_sync(i915, spin->handle);
igt_spin_free(i915, spin);
put_ahnd(ahnd);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence
2022-02-19 0:10 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
@ 2022-02-19 0:20 ` Dixit, Ashutosh
0 siblings, 0 replies; 13+ messages in thread
From: Dixit, Ashutosh @ 2022-02-19 0:20 UTC (permalink / raw)
To: Jasmine Newsome; +Cc: igt-dev
On Fri, 18 Feb 2022 16:10:13 -0800, Jasmine Newsome wrote:
>
> diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
> index 653812c7..0835a122 100644
> --- a/tests/i915/gem_spin_batch.c
> +++ b/tests/i915/gem_spin_batch.c
> @@ -143,6 +143,7 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> const struct intel_execution_engine2 *e;
> intel_ctx_cfg_t cfg = ctx->cfg;
> struct igt_spin *spin, *n;
> + const intel_ctx_t *local_ctx;
Don't need local_ctx, let's overwrite ctx as before.
> uint64_t ahnd;
> IGT_LIST_HEAD(list);
>
> @@ -151,18 +152,16 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> continue;
>
> if (flags & PARALLEL_SPIN_NEW_CTX)
> - ctx = intel_ctx_create(i915, &cfg);
> + local_ctx = intel_ctx_create(i915, &cfg);
Don't need this change.
> ahnd = get_reloc_ahnd(i915, ctx->id);
>
> /* Prevent preemption so only one is allowed on each engine */
> spin = igt_spin_new(i915,
> .ahnd = ahnd,
> - .ctx = ctx,
> + .ctx = (flags & PARALLEL_SPIN_NEW_CTX) ? local_ctx : ctx,
Don't need this change.
> .engine = e->flags,
> .flags = (IGT_SPIN_POLL_RUN |
> IGT_SPIN_NO_PREEMPTION));
> - if (flags & PARALLEL_SPIN_NEW_CTX)
> - intel_ctx_destroy(i915, ctx);
>
> igt_spin_busywait_until_started(spin);
> igt_list_move(&spin->link, &list);
> @@ -172,7 +171,9 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> igt_assert(gem_bo_busy(i915, spin->handle));
> ahnd = spin->ahnd;
> igt_spin_end(spin);
> - gem_sync(i915, spin->handle);
> + if (flags & PARALLEL_SPIN_NEW_CTX)
> + intel_ctx_destroy(i915, spin->opts.ctx);
> + gem_sync(i915, spin->handle);
This line still has spaces not tabs. Rest of the patch is great!
> igt_spin_free(i915, spin);
> put_ahnd(ahnd);
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch
@ 2022-02-19 1:32 Jasmine Newsome
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner Jasmine Newsome
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Jasmine Newsome @ 2022-02-19 1:32 UTC (permalink / raw)
To: igt-dev; +Cc: jasmine.newsome
Saving more context info for added convenience in spinner.
Also adding a fix to remove context persistence from
gem_spin_batch in order to pass test on GuC enabled
platforms.
Signed-off-by: Jasmine Newsome <jasmine.newsome@intel.com>
Jasmine Newsome (2):
lib/igt_dummyload: Save spin->opts as part of the spinner
tests/i915/gem_spin_batch: Removing context persistence
lib/igt_dummyload.c | 1 +
lib/igt_dummyload.h | 43 ++++++++++++++++++++-----------------
tests/i915/gem_spin_batch.c | 4 ++--
3 files changed, 26 insertions(+), 22 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner
2022-02-19 1:32 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
@ 2022-02-19 1:32 ` Jasmine Newsome
2022-02-22 19:49 ` Dixit, Ashutosh
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
` (2 subsequent siblings)
3 siblings, 1 reply; 13+ messages in thread
From: Jasmine Newsome @ 2022-02-19 1:32 UTC (permalink / raw)
To: igt-dev; +Cc: jasmine.newsome
Save igt_spin_factory info in igt_spin. This will allow
for access to the actual context within the spinner.
Previously, only the context id was accessible. This
might help make spinner code cleaner.
Signed-off-by: Jasmine Newsome <jasmine.newsome@intel.com>
---
lib/igt_dummyload.c | 1 +
lib/igt_dummyload.h | 43 +++++++++++++++++++++++--------------------
2 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/lib/igt_dummyload.c b/lib/igt_dummyload.c
index 645db922..0b2be154 100644
--- a/lib/igt_dummyload.c
+++ b/lib/igt_dummyload.c
@@ -421,6 +421,7 @@ emit_recursive_batch(igt_spin_t *spin,
}
spin->cmd_precondition = *spin->condition;
+ spin->opts = *opts;
return fence_fd;
}
diff --git a/lib/igt_dummyload.h b/lib/igt_dummyload.h
index f0205261..af9e6a43 100644
--- a/lib/igt_dummyload.h
+++ b/lib/igt_dummyload.h
@@ -33,6 +33,28 @@
#include "i915_drm.h"
#include "intel_ctx.h"
+
+/**
+ * igt_spin_factory_t:
+ * @ctx_id: GEM context handle
+ * @ctx: intel_ctx_t context wrapper
+ * @dependency: GEM object to depend on
+ * @engine: Flags describing the engine to execute on
+ * @flags: Set of IGT_SPIN_* flags
+ * @fence: In-fence to wait on
+ *
+ * A factory struct which contains creation parameters for an igt_spin_t.
+ */
+typedef struct igt_spin_factory {
+ uint32_t ctx_id;
+ const intel_ctx_t *ctx;
+ uint32_t dependency;
+ unsigned int engine;
+ unsigned int flags;
+ int fence;
+ uint64_t ahnd;
+} igt_spin_factory_t;
+
typedef struct igt_spin {
struct igt_list_head link;
@@ -60,28 +82,9 @@ typedef struct igt_spin {
#define SPIN_CLFLUSH (1 << 0)
uint64_t ahnd;
+ struct igt_spin_factory opts;
} igt_spin_t;
-/**
- * igt_spin_factory_t:
- * @ctx_id: GEM context handle
- * @ctx: intel_ctx_t context wrapper
- * @dependency: GEM object to depend on
- * @engine: Flags describing the engine to execute on
- * @flags: Set of IGT_SPIN_* flags
- * @fence: In-fence to wait on
- *
- * A factory struct which contains creation parameters for an igt_spin_t.
- */
-typedef struct igt_spin_factory {
- uint32_t ctx_id;
- const intel_ctx_t *ctx;
- uint32_t dependency;
- unsigned int engine;
- unsigned int flags;
- int fence;
- uint64_t ahnd;
-} igt_spin_factory_t;
#define IGT_SPIN_FENCE_IN (1 << 0)
#define IGT_SPIN_FENCE_SUBMIT (1 << 1)
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence
2022-02-19 1:32 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner Jasmine Newsome
@ 2022-02-19 1:32 ` Jasmine Newsome
2022-02-19 2:39 ` Dixit, Ashutosh
2022-02-21 11:54 ` Tvrtko Ursulin
2022-02-19 2:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix for gem_spin_batch (rev3) Patchwork
2022-02-19 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 2 replies; 13+ messages in thread
From: Jasmine Newsome @ 2022-02-19 1:32 UTC (permalink / raw)
To: igt-dev; +Cc: jasmine.newsome
The spin all test relied on context persistence unecessarily by trying
to destroy contexts while keeping spinners active.
The current implementation of context persistence in i915 can cause
failures, and persistence is not needed for this test.
Moving intel_ctx_destroy after igt_spin_end.
Signed-off-by: Jasmine Newsome <jasmine.newsome@intel.com>
---
tests/i915/gem_spin_batch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
index 653812c7..707d69b6 100644
--- a/tests/i915/gem_spin_batch.c
+++ b/tests/i915/gem_spin_batch.c
@@ -161,8 +161,6 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
.engine = e->flags,
.flags = (IGT_SPIN_POLL_RUN |
IGT_SPIN_NO_PREEMPTION));
- if (flags & PARALLEL_SPIN_NEW_CTX)
- intel_ctx_destroy(i915, ctx);
igt_spin_busywait_until_started(spin);
igt_list_move(&spin->link, &list);
@@ -172,6 +170,8 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
igt_assert(gem_bo_busy(i915, spin->handle));
ahnd = spin->ahnd;
igt_spin_end(spin);
+ if (flags & PARALLEL_SPIN_NEW_CTX)
+ intel_ctx_destroy(i915, spin->opts.ctx);
gem_sync(i915, spin->handle);
igt_spin_free(i915, spin);
put_ahnd(ahnd);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
@ 2022-02-19 2:39 ` Dixit, Ashutosh
2022-02-21 11:54 ` Tvrtko Ursulin
1 sibling, 0 replies; 13+ messages in thread
From: Dixit, Ashutosh @ 2022-02-19 2:39 UTC (permalink / raw)
To: Jasmine Newsome; +Cc: igt-dev
On Fri, 18 Feb 2022 17:32:15 -0800, Jasmine Newsome wrote:
>
> diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
> index 653812c7..707d69b6 100644
> --- a/tests/i915/gem_spin_batch.c
> +++ b/tests/i915/gem_spin_batch.c
> @@ -161,8 +161,6 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> .engine = e->flags,
> .flags = (IGT_SPIN_POLL_RUN |
> IGT_SPIN_NO_PREEMPTION));
> - if (flags & PARALLEL_SPIN_NEW_CTX)
> - intel_ctx_destroy(i915, ctx);
>
> igt_spin_busywait_until_started(spin);
> igt_list_move(&spin->link, &list);
> @@ -172,6 +170,8 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> igt_assert(gem_bo_busy(i915, spin->handle));
> ahnd = spin->ahnd;
> igt_spin_end(spin);
> + if (flags & PARALLEL_SPIN_NEW_CTX)
> + intel_ctx_destroy(i915, spin->opts.ctx);
To be safe I think we should move this after gem_sync(). Anyway I am fine
with the patches now. Let's see if anyone else has comments/objections,
otherwise I can fix this up before merging.
> gem_sync(i915, spin->handle);
> igt_spin_free(i915, spin);
> put_ahnd(ahnd);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Fix for gem_spin_batch (rev3)
2022-02-19 1:32 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner Jasmine Newsome
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
@ 2022-02-19 2:47 ` Patchwork
2022-02-19 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2022-02-19 2:47 UTC (permalink / raw)
To: Jasmine Newsome; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4054 bytes --]
== Series Details ==
Series: Fix for gem_spin_batch (rev3)
URL : https://patchwork.freedesktop.org/series/100161/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11254 -> IGTPW_6657
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/index.html
Participating hosts (44 -> 42)
------------------------------
Additional (1): fi-pnv-d510
Missing (3): fi-bsw-cyan bat-dg2-8 shard-tglu
Known issues
------------
Here are the changes found in IGTPW_6657 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/fi-bsw-kefka/igt@amdgpu/amd_basic@query-info.html
* igt@i915_selftest@live:
- fi-skl-6600u: NOTRUN -> [FAIL][2] ([i915#4547])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/fi-skl-6600u/igt@i915_selftest@live.html
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][3] ([fdo#109271]) +57 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/fi-pnv-d510/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][4] ([i915#1436] / [i915#4312])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/fi-skl-6600u/igt@runner@aborted.html
- fi-bdw-5557u: NOTRUN -> [FAIL][5] ([i915#2426] / [i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/fi-bdw-5557u/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][6] ([i915#2940]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/fi-bsw-kefka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [DMESG-FAIL][8] ([i915#541]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][10] ([i915#4269]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4897]: https://gitlab.freedesktop.org/drm/intel/issues/4897
[i915#5068]: https://gitlab.freedesktop.org/drm/intel/issues/5068
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6348 -> IGTPW_6657
CI-20190529: 20190529
CI_DRM_11254: 16159219b34bb0c431b00c019892a561292c81e0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6657: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/index.html
IGT_6348: 9cb64a757d2ff1e180b1648e611439d94afd697d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/index.html
[-- Attachment #2: Type: text/html, Size: 4852 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Fix for gem_spin_batch (rev3)
2022-02-19 1:32 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
` (2 preceding siblings ...)
2022-02-19 2:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix for gem_spin_batch (rev3) Patchwork
@ 2022-02-19 20:14 ` Patchwork
3 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2022-02-19 20:14 UTC (permalink / raw)
To: Jasmine Newsome; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30247 bytes --]
== Series Details ==
Series: Fix for gem_spin_batch (rev3)
URL : https://patchwork.freedesktop.org/series/100161/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11254_full -> IGTPW_6657_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/index.html
Participating hosts (13 -> 8)
------------------------------
Missing (5): pig-kbl-iris pig-glk-j5005 pig-skl-6260u shard-rkl shard-dg1
Known issues
------------
Here are the changes found in IGTPW_6657_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][1] ([i915#4991])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl6/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@engines-hostile:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-snb4/igt@gem_ctx_persistence@engines-hostile.html
* igt@gem_ctx_sseu@invalid-sseu:
- shard-tglb: NOTRUN -> [SKIP][3] ([i915#280])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb2/igt@gem_ctx_sseu@invalid-sseu.html
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][4] -> [SKIP][5] ([i915#4525])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-iclb1/igt@gem_exec_balancer@parallel-balancer.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb6/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-kbl: NOTRUN -> [DMESG-WARN][6] ([i915#5076])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl4/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_capture@pi@bcs0:
- shard-iclb: [PASS][7] -> [INCOMPLETE][8] ([i915#3371])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-iclb5/igt@gem_exec_capture@pi@bcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb3/igt@gem_exec_capture@pi@bcs0.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][9] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
- shard-glk: NOTRUN -> [FAIL][10] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
- shard-tglb: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-kbl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
- shard-apl: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#2842]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-iclb: [PASS][18] -> [FAIL][19] ([i915#2849])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [PASS][20] -> [DMESG-WARN][21] ([i915#180]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-apl2/igt@gem_exec_suspend@basic-s3@smem.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-iclb: [PASS][22] -> [INCOMPLETE][23] ([i915#1895])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-iclb2/igt@gem_exec_whisper@basic-queues-forked-all.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb5/igt@gem_exec_whisper@basic-queues-forked-all.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][24] -> [SKIP][25] ([i915#2190])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-tglb8/igt@gem_huc_copy@huc-copy.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl6/igt@gem_lmem_swapping@heavy-verify-random.html
- shard-tglb: NOTRUN -> [SKIP][27] ([i915#4613]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb2/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@random-engines:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#4613]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb8/igt@gem_lmem_swapping@random-engines.html
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl2/igt@gem_lmem_swapping@random-engines.html
- shard-glk: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#4613])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk5/igt@gem_lmem_swapping@random-engines.html
* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][31] ([i915#2658])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl7/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#4270]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb3/igt@gem_pxp@protected-encrypted-src-copy-not-readible.html
* igt@gem_pxp@verify-pxp-stale-ctx-execution:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#4270])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb2/igt@gem_pxp@verify-pxp-stale-ctx-execution.html
* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#768]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb3/igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs.html
* igt@gem_softpin@evict-snoop:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109312])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb4/igt@gem_softpin@evict-snoop.html
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109312])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@gem_softpin@evict-snoop.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3323])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl6/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@input-checking:
- shard-tglb: NOTRUN -> [DMESG-WARN][38] ([i915#4991])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@unsync-overlap:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#3297])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb5/igt@gem_userptr_blits@unsync-overlap.html
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#3297])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb2/igt@gem_userptr_blits@unsync-overlap.html
* igt@gen3_mixed_blits:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109289])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb2/igt@gen3_mixed_blits.html
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#109289])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb6/igt@gen3_mixed_blits.html
* igt@gen9_exec_parse@bb-start-cmd:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#2527] / [i915#2856]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@gen9_exec_parse@bb-start-cmd.html
* igt@gen9_exec_parse@bb-start-far:
- shard-iclb: NOTRUN -> [SKIP][44] ([i915#2856]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb5/igt@gen9_exec_parse@bb-start-far.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#1904])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@i915_pm_dc@dc3co-vpb-simulation.html
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#658])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_lpsp@screens-disabled:
- shard-iclb: NOTRUN -> [SKIP][47] ([i915#1902])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb3/igt@i915_pm_lpsp@screens-disabled.html
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109293] / [fdo#109506]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb4/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#109506] / [i915#2411]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#111644] / [i915#1397] / [i915#2411])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb5/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#110892])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb2/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@i915_selftest@live@gt_lrc:
- shard-tglb: NOTRUN -> [DMESG-FAIL][52] ([i915#2373])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- shard-tglb: NOTRUN -> [DMESG-FAIL][53] ([i915#1759])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@forcewake:
- shard-kbl: NOTRUN -> [INCOMPLETE][54] ([i915#636])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl4/igt@i915_suspend@forcewake.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#1769])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271]) +108 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl3/igt@kms_big_fb@linear-16bpp-rotate-90.html
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#110725] / [fdo#111614]) +5 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb3/igt@kms_big_fb@linear-16bpp-rotate-90.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][58] -> [DMESG-WARN][59] ([i915#118]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-glk8/igt@kms_big_fb@linear-32bpp-rotate-180.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk9/igt@kms_big_fb@linear-32bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#111614]) +4 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#3777]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
- shard-glk: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#3777])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#110723])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb7/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#3777]) +4 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#111615]) +5 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#3886]) +12 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl7/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#3886]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk1/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#3886]) +6 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl7/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109278] / [i915#3886]) +5 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#3689] / [i915#3886]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb5/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#3689]) +6 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#111615] / [i915#3689]) +6 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [fdo#111827]) +26 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl1/igt@kms_chamelium@hdmi-hpd-storm.html
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109284] / [fdo#111827]) +13 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@kms_chamelium@vga-hpd-after-suspend.html
* igt@kms_color@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109278] / [i915#1149])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb2/igt@kms_color@pipe-d-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][76] ([fdo#109271] / [fdo#111827]) +5 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-snb2/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109284] / [fdo#111827]) +8 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb3/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
- shard-glk: NOTRUN -> [SKIP][78] ([fdo#109271] / [fdo#111827]) +5 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk8/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +7 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl1/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-d-gamma:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb2/igt@kms_color_chamelium@pipe-d-gamma.html
* igt@kms_content_protection@content_type_change:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109300] / [fdo#111066]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb5/igt@kms_content_protection@content_type_change.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#3116])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb8/igt@kms_content_protection@dp-mst-lic-type-1.html
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#3116] / [i915#3299])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb2/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@srm:
- shard-glk: NOTRUN -> [SKIP][84] ([fdo#109271]) +61 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk4/igt@kms_content_protection@srm.html
- shard-kbl: NOTRUN -> [TIMEOUT][85] ([i915#1319])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl4/igt@kms_content_protection@srm.html
- shard-apl: NOTRUN -> [TIMEOUT][86] ([i915#1319])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl8/igt@kms_content_protection@srm.html
* igt@kms_content_protection@uevent:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#1063]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb5/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109278] / [fdo#109279]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#3359]) +6 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb5/igt@kms_cursor_crc@pipe-b-cursor-32x10-random.html
* igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#3319])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-32x32-offscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
- shard-tglb: NOTRUN -> [SKIP][91] ([fdo#109279] / [i915#3359]) +6 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#109274] / [fdo#111825]) +8 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb3/igt@kms_cursor_legacy@cursora-vs-flipb-atomic.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
- shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109274] / [fdo#109278])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb5/igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size.html
* igt@kms_cursor_legacy@pipe-d-single-move:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109278]) +26 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb4/igt@kms_cursor_legacy@pipe-d-single-move.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][95] -> [INCOMPLETE][96] ([i915#180])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-rmfb:
- shard-iclb: NOTRUN -> [SKIP][97] ([fdo#109274]) +3 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb4/igt@kms_flip@2x-flip-vs-rmfb.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling:
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#3701])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling:
- shard-snb: NOTRUN -> [SKIP][99] ([fdo#109271]) +119 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-snb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109280]) +15 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#109280] / [fdo#111825]) +24 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][102] ([fdo#109271]) +291 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl6/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#1187])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@kms_hdr@static-toggle-dpms.html
- shard-iclb: NOTRUN -> [SKIP][104] ([i915#1187])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb5/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#1839])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
- shard-iclb: NOTRUN -> [SKIP][106] ([i915#1839])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#533])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl3/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#533]) +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][109] ([fdo#108145] / [i915#265]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
- shard-glk: NOTRUN -> [FAIL][110] ([fdo#108145] / [i915#265])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk5/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][111] ([i915#265])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl1/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][112] ([fdo#108145] / [i915#265]) +2 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_lowres@pipe-c-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][113] ([i915#3536])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb4/igt@kms_plane_lowres@pipe-c-tiling-yf.html
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#111615] / [fdo#112054])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@kms_plane_lowres@pipe-c-tiling-yf.html
* igt@kms_plane_lowres@pipe-d-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][115] ([i915#3536])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@kms_plane_lowres@pipe-d-tiling-none.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-kbl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#2733])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl4/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#1911])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb2/igt@kms_psr2_su@page_flip-nv12.html
- shard-apl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#658]) +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl4/igt@kms_psr2_su@page_flip-nv12.html
- shard-glk: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#658]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk1/igt@kms_psr2_su@page_flip-nv12.html
- shard-iclb: NOTRUN -> [SKIP][120] ([fdo#109642] / [fdo#111068] / [i915#658])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb5/igt@kms_psr2_su@page_flip-nv12.html
- shard-kbl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#658]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl1/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr@psr2_basic:
- shard-tglb: NOTRUN -> [FAIL][122] ([i915#132] / [i915#3467]) +4 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb5/igt@kms_psr@psr2_basic.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: NOTRUN -> [SKIP][123] ([fdo#109441]) +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [PASS][124] -> [SKIP][125] ([fdo#109441]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb4/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][126] -> [FAIL][127] ([i915#31])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11254/shard-apl7/igt@kms_setmode@basic.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][128] ([i915#180] / [i915#295])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#2437])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-apl2/igt@kms_writeback@writeback-check-output.html
- shard-iclb: NOTRUN -> [SKIP][130] ([i915#2437])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-iclb8/igt@kms_writeback@writeback-check-output.html
- shard-kbl: NOTRUN -> [SKIP][131] ([fdo#109271] / [i915#2437])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-kbl1/igt@kms_writeback@writeback-check-output.html
- shard-tglb: NOTRUN -> [SKIP][132] ([i915#2437])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-tglb7/igt@kms_writeback@writeback-check-output.html
- shard-glk: NOTRUN -> [SKIP][133] ([fdo#109271] / [i915#2437])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/shard-glk5/igt@kms_writeback@writeback-check-output.html
* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
-
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6657/index.html
[-- Attachment #2: Type: text/html, Size: 33924 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
2022-02-19 2:39 ` Dixit, Ashutosh
@ 2022-02-21 11:54 ` Tvrtko Ursulin
2022-02-23 15:34 ` Newsome, Jasmine
1 sibling, 1 reply; 13+ messages in thread
From: Tvrtko Ursulin @ 2022-02-21 11:54 UTC (permalink / raw)
To: Jasmine Newsome, igt-dev
On 19/02/2022 01:32, Jasmine Newsome wrote:
> The spin all test relied on context persistence unecessarily by trying
> to destroy contexts while keeping spinners active.
> The current implementation of context persistence in i915 can cause
> failures, and persistence is not needed for this test.
Could you please expand a bit on "current implementation" and "can cause
failures"?
Also from the subject of "Removing context persistence" I was expecting
to see usage of I915_CONTEXT_PARAM_PERSISTENCE to actually change the mode.
My concern is that the pattern of destroying contexts while keeping
things active on the GPU is very wide spread in IGT and possibly exists
in userspace as well.
Has the wider story been analysed by the architects here and what is the
plan? Do we actually know no userspace actually depends on it?
[Comes back later, after spotting the cover letter.]
So it's only GuC, not i915, so please say that in this commit message
since cover letters are not saved in git history.
Regards,
Tvrtko
>
> Moving intel_ctx_destroy after igt_spin_end.
>
> Signed-off-by: Jasmine Newsome <jasmine.newsome@intel.com>
> ---
> tests/i915/gem_spin_batch.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
> index 653812c7..707d69b6 100644
> --- a/tests/i915/gem_spin_batch.c
> +++ b/tests/i915/gem_spin_batch.c
> @@ -161,8 +161,6 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> .engine = e->flags,
> .flags = (IGT_SPIN_POLL_RUN |
> IGT_SPIN_NO_PREEMPTION));
> - if (flags & PARALLEL_SPIN_NEW_CTX)
> - intel_ctx_destroy(i915, ctx);
>
> igt_spin_busywait_until_started(spin);
> igt_list_move(&spin->link, &list);
> @@ -172,6 +170,8 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> igt_assert(gem_bo_busy(i915, spin->handle));
> ahnd = spin->ahnd;
> igt_spin_end(spin);
> + if (flags & PARALLEL_SPIN_NEW_CTX)
> + intel_ctx_destroy(i915, spin->opts.ctx);
> gem_sync(i915, spin->handle);
> igt_spin_free(i915, spin);
> put_ahnd(ahnd);
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner Jasmine Newsome
@ 2022-02-22 19:49 ` Dixit, Ashutosh
0 siblings, 0 replies; 13+ messages in thread
From: Dixit, Ashutosh @ 2022-02-22 19:49 UTC (permalink / raw)
To: Jasmine Newsome; +Cc: igt-dev
On Fri, 18 Feb 2022 17:32:14 -0800, Jasmine Newsome wrote:
>
> Save igt_spin_factory info in igt_spin. This will allow
> for access to the actual context within the spinner.
> Previously, only the context id was accessible.
Not sure about the sentence above, not seeing context id as part of
igt_spin_t. Maybe just drop this sentence.
> This might help make spinner code cleaner.
Maybe we can just say something like: Save the opts with which the spin was
created as part of the spin so that the opts are available in case they are
needed. Something like that.
The patch itself is fine, just the commit message needs a tweak. Thanks.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence
2022-02-21 11:54 ` Tvrtko Ursulin
@ 2022-02-23 15:34 ` Newsome, Jasmine
0 siblings, 0 replies; 13+ messages in thread
From: Newsome, Jasmine @ 2022-02-23 15:34 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev@lists.freedesktop.org
On 19/02/2022 01:32, Jasmine Newsome wrote:
> The spin all test relied on context persistence unecessarily by trying
> to destroy contexts while keeping spinners active.
> The current implementation of context persistence in i915 can cause
> failures, and persistence is not needed for this test.
Could you please expand a bit on "current implementation" and "can cause failures"?
Also from the subject of "Removing context persistence" I was expecting to see usage of I915_CONTEXT_PARAM_PERSISTENCE to actually change the mode.
My concern is that the pattern of destroying contexts while keeping things active on the GPU is very wide spread in IGT and possibly exists in userspace as well.
Has the wider story been analysed by the architects here and what is the plan? Do we actually know no userspace actually depends on it?
[Comes back later, after spotting the cover letter.]
So it's only GuC, not i915, so please say that in this commit message since cover letters are not saved in git history.
Regards,
Tvrtko
----------------------------------------------
Ok thanks. I will update the commit message and resend.
Regards,
Jasmine
>
> Moving intel_ctx_destroy after igt_spin_end.
>
> Signed-off-by: Jasmine Newsome <jasmine.newsome@intel.com>
> ---
> tests/i915/gem_spin_batch.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
> index 653812c7..707d69b6 100644
> --- a/tests/i915/gem_spin_batch.c
> +++ b/tests/i915/gem_spin_batch.c
> @@ -161,8 +161,6 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> .engine = e->flags,
> .flags = (IGT_SPIN_POLL_RUN |
> IGT_SPIN_NO_PREEMPTION));
> - if (flags & PARALLEL_SPIN_NEW_CTX)
> - intel_ctx_destroy(i915, ctx);
>
> igt_spin_busywait_until_started(spin);
> igt_list_move(&spin->link, &list); @@ -172,6 +170,8 @@ static void
> spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
> igt_assert(gem_bo_busy(i915, spin->handle));
> ahnd = spin->ahnd;
> igt_spin_end(spin);
> + if (flags & PARALLEL_SPIN_NEW_CTX)
> + intel_ctx_destroy(i915, spin->opts.ctx);
> gem_sync(i915, spin->handle);
> igt_spin_free(i915, spin);
> put_ahnd(ahnd);
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence
2022-02-24 0:42 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
@ 2022-02-24 0:42 ` Jasmine Newsome
2022-02-24 2:51 ` Dixit, Ashutosh
0 siblings, 1 reply; 13+ messages in thread
From: Jasmine Newsome @ 2022-02-24 0:42 UTC (permalink / raw)
To: igt-dev; +Cc: jasmine.newsome
The spin all test relied on context persistence unecessarily by trying
to destroy contexts while keeping spinners active.
The current implementation of context persistence in i915 can cause
failures with GuC enabled, and persistence is not needed for this test.
Moving intel_ctx_destroy after igt_spin_end.
Signed-off-by: Jasmine Newsome <jasmine.newsome@intel.com>
---
tests/i915/gem_spin_batch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_spin_batch.c b/tests/i915/gem_spin_batch.c
index 653812c7..707d69b6 100644
--- a/tests/i915/gem_spin_batch.c
+++ b/tests/i915/gem_spin_batch.c
@@ -161,8 +161,6 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
.engine = e->flags,
.flags = (IGT_SPIN_POLL_RUN |
IGT_SPIN_NO_PREEMPTION));
- if (flags & PARALLEL_SPIN_NEW_CTX)
- intel_ctx_destroy(i915, ctx);
igt_spin_busywait_until_started(spin);
igt_list_move(&spin->link, &list);
@@ -172,6 +170,8 @@ static void spin_all(int i915, const intel_ctx_t *ctx, unsigned int flags)
igt_assert(gem_bo_busy(i915, spin->handle));
ahnd = spin->ahnd;
igt_spin_end(spin);
+ if (flags & PARALLEL_SPIN_NEW_CTX)
+ intel_ctx_destroy(i915, spin->opts.ctx);
gem_sync(i915, spin->handle);
igt_spin_free(i915, spin);
put_ahnd(ahnd);
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence
2022-02-24 0:42 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
@ 2022-02-24 2:51 ` Dixit, Ashutosh
0 siblings, 0 replies; 13+ messages in thread
From: Dixit, Ashutosh @ 2022-02-24 2:51 UTC (permalink / raw)
To: Jasmine Newsome; +Cc: igt-dev
On Wed, 23 Feb 2022 16:42:20 -0800, Jasmine Newsome wrote:
>
> The spin all test relied on context persistence unecessarily by trying
> to destroy contexts while keeping spinners active.
> The current implementation of context persistence in i915 can cause
> failures with GuC enabled, and persistence is not needed for this test.
>
> Moving intel_ctx_destroy after igt_spin_end.
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-02-24 2:52 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-19 1:32 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner Jasmine Newsome
2022-02-22 19:49 ` Dixit, Ashutosh
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
2022-02-19 2:39 ` Dixit, Ashutosh
2022-02-21 11:54 ` Tvrtko Ursulin
2022-02-23 15:34 ` Newsome, Jasmine
2022-02-19 2:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix for gem_spin_batch (rev3) Patchwork
2022-02-19 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-02-24 0:42 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
2022-02-24 0:42 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
2022-02-24 2:51 ` Dixit, Ashutosh
2022-02-19 0:10 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
2022-02-19 0:10 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
2022-02-19 0:20 ` Dixit, Ashutosh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox