[igt-dev] [PATCH i-g-t 1/2] meson: Drop -Wdeclaration-after-statement.

[igt-dev] [PATCH i-g-t 1/2] meson: Drop -Wdeclaration-after-statement.

[Eric Anholt]

Being able to move declarations later is very useful in making clear,
concise code.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meson.build b/meson.build
index 469723dc4633..c5aab78716d5 100644
--- a/meson.build
+++ b/meson.build
@@ -11,7 +11,6 @@ cc = meson.get_compiler('c')
 
 cc_args = [
 	'-Wbad-function-cast',
-	'-Wdeclaration-after-statement',
 	'-Wformat=2',
 # igt_assert(0) in switch statements triggers a bunch of this.
 	'-Wimplicit-fallthrough=0',
-- 
2.20.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/2] v3d: Add tests for hanging V3D using an RCL.

[Eric Anholt]

drm-misc-next recently regressed GPU hang recovery, and these
reproduce those bugs.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 lib/igt_v3d.c             | 126 ++++++++++++++++++++++++++++++++++++++
 lib/igt_v3d.h             |  38 ++++++++++++
 tests/meson.build         |   1 +
 tests/v3d_ci/v3d.testlist |   2 +
 tests/v3d_cl_hang.c       |  73 ++++++++++++++++++++++
 5 files changed, 240 insertions(+)
 create mode 100644 tests/v3d_cl_hang.c

diff --git a/lib/igt_v3d.c b/lib/igt_v3d.c
index 619c072c0e47..9a9f32e0ced4 100644
--- a/lib/igt_v3d.c
+++ b/lib/igt_v3d.c
@@ -124,3 +124,129 @@ void igt_v3d_bo_mmap(int fd, struct v3d_bo *bo)
 				  PROT_READ | PROT_WRITE);
 	igt_assert(bo->map);
 }
+
+void *
+igt_v3d_wait_bo(int fd, uint32_t handle)
+{
+	struct drm_v3d_wait_bo wait_bo = {
+		.handle = handle,
+		.timeout_ns = ~0ull,
+	};
+
+	do_ioctl(fd, DRM_IOCTL_V3D_WAIT_BO, &wait_bo);
+
+	return 0;
+}
+
+void igt_v3d_bo_wait(int fd, struct v3d_bo *bo)
+{
+	igt_v3d_wait_bo(fd, bo->handle);
+}
+
+struct v3d_cl *
+igt_v3d_cl_create(int fd, size_t size)
+{
+	struct v3d_cl *cl = calloc(1, sizeof(*cl));
+
+	cl->fd = fd;
+	cl->bo = igt_v3d_create_bo(fd, size);
+	v3d_cl_reference_bo(cl, cl->bo);
+
+	igt_v3d_bo_mmap(fd, cl->bo);
+	cl->next = cl->bo->map;
+
+	return cl;
+}
+
+/** Creates a simple CL consisting of a single NOP instruction. */
+struct v3d_cl *
+igt_v3d_cl_create_nop(int fd)
+{
+	struct v3d_cl *cl = igt_v3d_cl_create(fd, 1);
+        uint8_t nop_opcode = 1;
+
+	memcpy(cl->next, &nop_opcode, 1);
+	cl->next++;
+
+	return cl;
+}
+
+/**
+ * Creates a simple CL consisting of an infinite loop branching to itself.
+ */
+struct v3d_cl *
+igt_v3d_cl_create_infinite_loop(int fd)
+{
+	struct v3d_cl *cl = igt_v3d_cl_create(fd, 5);
+        uint8_t branch_opcode = 16;
+
+	memcpy(cl->next, &branch_opcode, 1);
+	cl->next++;
+
+	memcpy(cl->next, &cl->bo->offset, 4);
+	cl->next += 4;
+
+	return cl;
+}
+
+void
+igt_v3d_cl_free(struct v3d_cl *cl)
+{
+	igt_v3d_free_bo(cl->fd, cl->bo);
+	free(cl);
+}
+
+void
+igt_v3d_submit_cl(int fd, struct drm_v3d_submit_cl *submit)
+{
+	do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, submit);
+}
+
+void
+igt_v3d_submit_rcl(struct v3d_cl *rcl)
+{
+	struct drm_v3d_submit_cl submit = {
+		.rcl_start = rcl->bo->offset,
+		.rcl_end = rcl->bo->offset + cl_offset(rcl),
+		.bo_handles = (uintptr_t)rcl->handles,
+		.bo_handle_count = rcl->handle_count,
+	};
+	igt_v3d_submit_cl(rcl->fd, &submit);
+}
+
+static bool
+handle_in_list(uint32_t *handles, int handle_count, int handle)
+{
+	for (int i = 0; i < handle_count; i++) {
+		if (handles[i] == handle)
+			return true;
+	}
+	return false;
+}
+
+void
+igt_v3d_submit_bcl_and_rcl(struct v3d_cl *bcl, struct v3d_cl *rcl)
+{
+	uint32_t handles[32];
+	int handle_count = 0;
+
+	/* Merge the two incoming handle lists. */
+	igt_assert(rcl->handle_count + bcl->handle_count <= ARRAY_SIZE(handles));
+	for (int i = 0; i < rcl->handle_count; i++)
+		handles[handle_count++] = rcl->handles[i];
+
+	for (int i = 0; i < bcl->handle_count; i++) {
+		if (!handle_in_list(handles, handle_count, bcl->handles[i]))
+			handles[handle_count++] = bcl->handles[i];
+	}
+
+	struct drm_v3d_submit_cl submit = {
+		.rcl_start = rcl->bo->offset,
+		.rcl_end = rcl->bo->offset + cl_offset(rcl),
+		.bcl_start = bcl->bo->offset,
+		.bcl_end = bcl->bo->offset + cl_offset(bcl),
+		.bo_handles = (uintptr_t)handles,
+		.bo_handle_count = handle_count,
+	};
+	igt_v3d_submit_cl(rcl->fd, &submit);
+}
diff --git a/lib/igt_v3d.h b/lib/igt_v3d.h
index 2042995103cc..7ddbee36a547 100644
--- a/lib/igt_v3d.h
+++ b/lib/igt_v3d.h
@@ -33,6 +33,15 @@ struct v3d_bo {
 	void *map;
 };
 
+struct v3d_cl {
+	int fd;
+	struct v3d_bo *bo;
+	void *next;
+
+	uint32_t handles[32];
+	uint32_t handle_count;
+};
+
 struct v3d_bo *igt_v3d_create_bo(int fd, size_t size);
 void igt_v3d_free_bo(int fd, struct v3d_bo *bo);
 
@@ -40,7 +49,36 @@ void igt_v3d_free_bo(int fd, struct v3d_bo *bo);
 uint32_t igt_v3d_get_bo_offset(int fd, uint32_t handle);
 uint32_t igt_v3d_get_param(int fd, enum drm_v3d_param param);
 void *igt_v3d_mmap_bo(int fd, uint32_t handle, uint32_t size, unsigned prot);
+void *igt_v3d_wait_bo(int fd, uint32_t handle);
+void igt_v3d_submit_cl(int fd, struct drm_v3d_submit_cl *submit);
+void igt_v3d_submit_rcl(struct v3d_cl *rcl);
+void igt_v3d_submit_bcl_and_rcl(struct v3d_cl *bcl, struct v3d_cl *rcl);
 
 void igt_v3d_bo_mmap(int fd, struct v3d_bo *bo);
+void igt_v3d_bo_wait(int fd, struct v3d_bo *bo);
+
+static inline void v3d_cl_reference_bo(struct v3d_cl *cl,
+				       const struct v3d_bo *bo)
+{
+	if (!bo)
+		return;
+
+	for (int i = 0; i < cl->handle_count; i++) {
+		if (cl->handles[i] == bo->handle)
+			return;
+	}
+
+	cl->handles[cl->handle_count++] = bo->handle;
+}
+
+static inline uint32_t cl_offset(struct v3d_cl *cl)
+{
+	return (char *)cl->next - (char *)cl->bo->map;
+}
+
+struct v3d_cl *igt_v3d_cl_create(int fd, size_t size);
+struct v3d_cl *igt_v3d_cl_create_infinite_loop(int fd);
+struct v3d_cl *igt_v3d_cl_create_nop(int fd);
+void igt_v3d_cl_free(struct v3d_cl *cl);
 
 #endif /* IGT_V3D_H */
diff --git a/tests/meson.build b/tests/meson.build
index b8a6e61b3404..92c9e14ca40a 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -82,6 +82,7 @@ test_progs = [
 	'v3d_get_bo_offset',
 	'v3d_get_param',
 	'v3d_mmap',
+	'v3d_cl_hang',
 	'vc4_create_bo',
 	'vc4_dmabuf_poll',
 	'vc4_label_bo',
diff --git a/tests/v3d_ci/v3d.testlist b/tests/v3d_ci/v3d.testlist
index b55e8e571d7d..bf625f788f79 100644
--- a/tests/v3d_ci/v3d.testlist
+++ b/tests/v3d_ci/v3d.testlist
@@ -1,3 +1,5 @@
+igt@v3d_cl_hang@rcl-infinite-loop
+igt@v3d_cl_hang@bcl-infinite-loop
 igt@v3d_get_bo_offset@create-get-offsets
 igt@v3d_get_bo_offset@get-bad-handle
 igt@v3d_get_param@base-params
diff --git a/tests/v3d_cl_hang.c b/tests/v3d_cl_hang.c
new file mode 100644
index 000000000000..6ecc337c2432
--- /dev/null
+++ b/tests/v3d_cl_hang.c
@@ -0,0 +1,73 @@
+/*
+ * Copyright © 2016 Broadcom
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+#include "igt.h"
+#include "igt_v3d.h"
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include "v3d_drm.h"
+
+igt_main
+{
+	int fd;
+
+	igt_fixture {
+		fd = drm_open_driver(DRIVER_V3D);
+	}
+
+	igt_subtest("rcl-infinite-loop") {
+		struct v3d_cl *hang = igt_v3d_cl_create_infinite_loop(fd);
+		struct v3d_cl *nop = igt_v3d_cl_create_nop(fd);
+
+		igt_v3d_submit_rcl(hang);
+
+		igt_v3d_submit_rcl(nop);
+		igt_v3d_bo_wait(fd, nop->bo);
+
+		igt_v3d_cl_free(hang);
+		igt_v3d_cl_free(nop);
+	}
+
+	igt_subtest("bcl-infinite-loop") {
+		struct v3d_cl *hang = igt_v3d_cl_create_infinite_loop(fd);
+		struct v3d_cl *nop = igt_v3d_cl_create_nop(fd);
+
+		igt_v3d_submit_bcl_and_rcl(hang, nop);
+
+		igt_v3d_submit_rcl(nop);
+		igt_v3d_bo_wait(fd, nop->bo);
+
+		igt_v3d_cl_free(hang);
+		igt_v3d_cl_free(nop);
+	}
+
+	igt_fixture
+		close(fd);
+}
-- 
2.20.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] meson: Drop -Wdeclaration-after-statement.

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] meson: Drop -Wdeclaration-after-statement.
URL   : https://patchwork.freedesktop.org/series/53108/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4735 -> IGTPW_2102 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53108/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_2102 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       PASS -> INCOMPLETE ([fdo#107718])

    igt@gem_mmap_gtt@basic-copy:
      fi-glk-dsi:         PASS -> INCOMPLETE ([fdo#103359], [k.org#198133])

    igt@kms_flip@basic-flip-vs-modeset:
      fi-skl-6700hq:      PASS -> DMESG-WARN ([fdo#105998]) +1

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     PASS -> FAIL ([fdo#103191], [fdo#107362])

    
    ==== Possible fixes ====

    igt@kms_chamelium@hdmi-hpd-fast:
      {fi-kbl-7500u}:     FAIL -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      fi-byt-clapper:     FAIL ([fdo#107362]) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-byt-clapper:     FAIL ([fdo#103191], [fdo#107362]) -> PASS +1

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (51 -> 45) ==

  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4735 -> IGTPW_2102

  CI_DRM_5212: db8d567e7cf70aeca866e85972078cd5c9b59cfb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2102: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2102/
  IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@v3d_cl_hang@bcl-infinite-loop
+igt@v3d_cl_hang@rcl-infinite-loop

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2102/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] meson: Drop -Wdeclaration-after-statement.

[Jani Nikula]

On Tue, 27 Nov 2018, Eric Anholt <eric@anholt.net> wrote:
> Being able to move declarations later is very useful in making clear,
> concise code.

I guess you primarily need this in patch 2/2 for declaring the loop
variable in the for statement. I like that, just not the general case of
declarations after statements. Anyway, I'll let others fight the holy
wars on this. ;)

BR,
Jani.

>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  meson.build | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 469723dc4633..c5aab78716d5 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -11,7 +11,6 @@ cc = meson.get_compiler('c')
>  
>  cc_args = [
>  	'-Wbad-function-cast',
> -	'-Wdeclaration-after-statement',
>  	'-Wformat=2',
>  # igt_assert(0) in switch statements triggers a bunch of this.
>  	'-Wimplicit-fallthrough=0',

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] v3d: Add tests for hanging V3D using an RCL.

[Jani Nikula]

On Tue, 27 Nov 2018, Eric Anholt <eric@anholt.net> wrote:
> +/** Creates a simple CL consisting of a single NOP instruction. */
> +struct v3d_cl *
> +igt_v3d_cl_create_nop(int fd)
> +{
> +	struct v3d_cl *cl = igt_v3d_cl_create(fd, 1);
> +        uint8_t nop_opcode = 1;

Not really reviewing this, the indents with spaces just caught my eyes.

> +
> +	memcpy(cl->next, &nop_opcode, 1);
> +	cl->next++;
> +
> +	return cl;
> +}
> +
> +/**
> + * Creates a simple CL consisting of an infinite loop branching to itself.
> + */
> +struct v3d_cl *
> +igt_v3d_cl_create_infinite_loop(int fd)
> +{
> +	struct v3d_cl *cl = igt_v3d_cl_create(fd, 5);
> +        uint8_t branch_opcode = 16;

Ditto here.

BR,
Jani.

> +
> +	memcpy(cl->next, &branch_opcode, 1);
> +	cl->next++;
> +
> +	memcpy(cl->next, &cl->bo->offset, 4);
> +	cl->next += 4;
> +
> +	return cl;
> +}

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] meson: Drop -Wdeclaration-after-statement.

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] meson: Drop -Wdeclaration-after-statement.
URL   : https://patchwork.freedesktop.org/series/53108/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4735_full -> IGTPW_2102_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_2102_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2102_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53108/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_2102_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_fence@basic-await-default:
      shard-hsw:          PASS -> FAIL

    
    ==== Warnings ====

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_2102_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@core_auth@many-magics:
      shard-glk:          PASS -> DMESG-WARN ([fdo#105763], [fdo#106538])

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          PASS -> FAIL ([fdo#106641])

    igt@kms_busy@extended-modeset-hang-newfb-render-b:
      shard-snb:          NOTRUN -> DMESG-WARN ([fdo#107956])

    igt@kms_color@pipe-b-legacy-gamma:
      shard-apl:          PASS -> FAIL ([fdo#104782])

    igt@kms_cursor_crc@cursor-64x64-onscreen:
      shard-apl:          PASS -> FAIL ([fdo#103232])

    igt@kms_cursor_crc@cursor-64x64-sliding:
      shard-glk:          PASS -> FAIL ([fdo#103232]) +1

    igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled:
      shard-glk:          PASS -> FAIL ([fdo#107791])

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL ([fdo#105363])

    igt@kms_flip@modeset-vs-vblank-race-interruptible:
      shard-glk:          PASS -> FAIL ([fdo#103060])

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
      shard-apl:          PASS -> FAIL ([fdo#103167]) +1

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          PASS -> FAIL ([fdo#103167]) +1

    igt@kms_frontbuffer_tracking@fbc-2p-rte:
      shard-glk:          PASS -> FAIL ([fdo#103167], [fdo#105682])

    igt@kms_hdmi_inject@inject-audio:
      shard-snb:          NOTRUN -> INCOMPLETE ([fdo#105411])

    igt@kms_plane@plane-position-covered-pipe-b-planes:
      shard-glk:          PASS -> FAIL ([fdo#103166])
      shard-kbl:          PASS -> FAIL ([fdo#103166])

    igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
      shard-apl:          PASS -> FAIL ([fdo#108145])

    igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
      shard-glk:          NOTRUN -> FAIL ([fdo#108145])

    igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
      shard-glk:          PASS -> FAIL ([fdo#108145]) +1

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-apl:          PASS -> FAIL ([fdo#103166]) +3

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          NOTRUN -> FAIL ([fdo#103925])

    igt@kms_setmode@basic:
      shard-hsw:          PASS -> FAIL ([fdo#99912])

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@vecs0-s3:
      shard-kbl:          INCOMPLETE ([fdo#103665]) -> PASS

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-kbl:          DMESG-WARN ([fdo#107956]) -> PASS

    igt@kms_color@pipe-b-degamma:
      shard-apl:          FAIL ([fdo#104782]) -> PASS

    igt@kms_cursor_crc@cursor-128x128-offscreen:
      shard-glk:          DMESG-WARN ([fdo#105763], [fdo#106538]) -> PASS +1

    igt@kms_cursor_crc@cursor-128x128-random:
      shard-apl:          FAIL ([fdo#103232]) -> PASS +6

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-apl:          FAIL ([fdo#103191], [fdo#103232]) -> PASS +1

    igt@kms_cursor_crc@cursor-size-change:
      shard-glk:          FAIL ([fdo#103232]) -> PASS +3

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL ([fdo#105454], [fdo#106509]) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-kbl:          FAIL ([fdo#103167]) -> PASS +1
      shard-apl:          FAIL ([fdo#103167]) -> PASS +2

    igt@kms_frontbuffer_tracking@fbc-1p-rte:
      shard-apl:          FAIL ([fdo#103167], [fdo#105682]) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
      shard-glk:          FAIL ([fdo#103167]) -> PASS +6

    igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
      shard-glk:          FAIL ([fdo#108145]) -> PASS +1
      shard-kbl:          FAIL ([fdo#108145]) -> PASS
      shard-apl:          FAIL ([fdo#108145]) -> PASS

    igt@kms_plane_lowres@pipe-c-tiling-x:
      shard-hsw:          DMESG-WARN ([fdo#102614]) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-glk:          FAIL ([fdo#103166]) -> PASS +3

    igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
      shard-apl:          FAIL ([fdo#103166]) -> PASS +2

    igt@kms_setmode@basic:
      shard-apl:          FAIL ([fdo#99912]) -> PASS
      shard-kbl:          FAIL ([fdo#99912]) -> PASS

    igt@syncobj_wait@multi-wait-for-submit-unsubmitted-signaled:
      shard-snb:          INCOMPLETE ([fdo#105411]) -> PASS

    
    ==== Warnings ====

    igt@i915_suspend@shrink:
      shard-kbl:          INCOMPLETE ([fdo#103665], [fdo#106886]) -> DMESG-WARN ([fdo#108784])

    
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
  fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107791 https://bugs.freedesktop.org/show_bug.cgi?id=107791
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108784 https://bugs.freedesktop.org/show_bug.cgi?id=108784
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (7 -> 5) ==

  Missing    (2): shard-skl shard-iclb 


== Build changes ==

    * IGT: IGT_4735 -> IGTPW_2102

  CI_DRM_5212: db8d567e7cf70aeca866e85972078cd5c9b59cfb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2102: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2102/
  IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2102/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] v3d: Add tests for hanging V3D using an RCL.

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 413 bytes --]

Jani Nikula <jani.nikula@linux.intel.com> writes:

> On Tue, 27 Nov 2018, Eric Anholt <eric@anholt.net> wrote:
>> +/** Creates a simple CL consisting of a single NOP instruction. */
>> +struct v3d_cl *
>> +igt_v3d_cl_create_nop(int fd)
>> +{
>> +	struct v3d_cl *cl = igt_v3d_cl_create(fd, 1);
>> +        uint8_t nop_opcode = 1;
>
> Not really reviewing this, the indents with spaces just caught my eyes.

Fixed.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev