Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/xe_create: Remove create-invalid-size subtest
@ 2023-10-12  7:01 Zbigniew Kempczyński
  2023-10-12 10:02 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/xe_create: Remove create-invalid-size subtest (rev2) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Zbigniew Kempczyński @ 2023-10-12  7:01 UTC (permalink / raw)
  To: igt-dev; +Cc: Thomas Hellström

Test exercises kernel returns EINVAL on bo create ioctl with unaligned
size what was never merged and according to discussion with Thomas
will never be. Lets remove this test as it is incorrect in this case.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/intel/xe_create.c | 52 -----------------------------------------
 1 file changed, 52 deletions(-)

diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
index 8d845e5c86..541fc2b335 100644
--- a/tests/intel/xe_create.c
+++ b/tests/intel/xe_create.c
@@ -39,54 +39,6 @@ static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t flags,
 	return ret;
 }
 
-/**
- * SUBTEST: create-invalid-size
- * Functionality: ioctl
- * Test category: negative test
- * Description: Verifies xe bo create returns expected error code on invalid
- *              buffer sizes.
- */
-static void create_invalid_size(int fd)
-{
-	struct drm_xe_query_mem_region *memregion;
-	uint64_t memreg = all_memory_regions(fd), region;
-	uint32_t vm;
-	uint32_t handle;
-	int ret;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
-
-	xe_for_each_mem_region(fd, memreg, region) {
-		memregion = xe_mem_region(fd, region);
-
-		/* first try, use half of possible min page size */
-		ret = __create_bo(fd, vm, memregion->min_page_size >> 1,
-				  region, &handle);
-		if (!ret) {
-			gem_close(fd, handle);
-			xe_vm_destroy(fd, vm);
-		}
-		igt_assert_eq(ret, -EINVAL);
-
-		/*
-		 * second try, add page size to min page size if it is
-		 * bigger than page size.
-		 */
-		if (memregion->min_page_size > PAGE_SIZE) {
-			ret = __create_bo(fd, vm,
-					  memregion->min_page_size + PAGE_SIZE,
-					  region, &handle);
-			if (!ret) {
-				gem_close(fd, handle);
-				xe_vm_destroy(fd, vm);
-			}
-			igt_assert_eq(ret, -EINVAL);
-		}
-	}
-
-	xe_vm_destroy(fd, vm);
-}
-
 enum exec_queue_destroy {
 	NOLEAK,
 	LEAK
@@ -214,10 +166,6 @@ igt_main
 	igt_fixture
 		xe = drm_open_driver(DRIVER_XE);
 
-	igt_subtest("create-invalid-size") {
-		create_invalid_size(xe);
-	}
-
 	igt_subtest("create-execqueues-noleak")
 		create_execqueues(xe, NOLEAK);
 
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/xe_create: Remove create-invalid-size subtest
@ 2023-06-26 14:23 Zbigniew Kempczyński
  2023-06-26 15:23 ` Kamil Konieczny
  0 siblings, 1 reply; 8+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-26 14:23 UTC (permalink / raw)
  To: igt-dev

Xe team decided to return real (not requested) bo size on create
ioctl return path. Subtest which tested returning -EINVAL on
not-aligned size is not valid anymore. Lets remove it.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/xe/xe_create.c | 50 --------------------------------------------
 1 file changed, 50 deletions(-)

diff --git a/tests/xe/xe_create.c b/tests/xe/xe_create.c
index b427c51fd5..5c3708b587 100644
--- a/tests/xe/xe_create.c
+++ b/tests/xe/xe_create.c
@@ -42,52 +42,6 @@ static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t flags,
 	return ret;
 }
 
-/**
- * SUBTEST: create-invalid-size
- * Description: Verifies xe bo create returns expected error code on invalid
- *              buffer sizes.
- */
-static void create_invalid_size(int fd)
-{
-	struct drm_xe_query_mem_region *memregion;
-	uint64_t memreg = all_memory_regions(fd), region;
-	uint32_t vm;
-	uint32_t handle;
-	int ret;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
-
-	xe_for_each_mem_region(fd, memreg, region) {
-		memregion = xe_mem_region(fd, region);
-
-		/* first try, use half of possible min page size */
-		ret = __create_bo(fd, vm, memregion->min_page_size >> 1,
-				  region, &handle);
-		if (!ret) {
-			gem_close(fd, handle);
-			xe_vm_destroy(fd, vm);
-		}
-		igt_assert_eq(ret, -EINVAL);
-
-		/*
-		 * second try, add page size to min page size if it is
-		 * bigger than page size.
-		 */
-		if (memregion->min_page_size > PAGE_SIZE) {
-			ret = __create_bo(fd, vm,
-					  memregion->min_page_size + PAGE_SIZE,
-					  region, &handle);
-			if (!ret) {
-				gem_close(fd, handle);
-				xe_vm_destroy(fd, vm);
-			}
-			igt_assert_eq(ret, -EINVAL);
-		}
-	}
-
-	xe_vm_destroy(fd, vm);
-}
-
 enum engine_destroy {
 	NOLEAK,
 	LEAK
@@ -214,10 +168,6 @@ igt_main
 		xe_device_get(xe);
 	}
 
-	igt_subtest("create-invalid-size") {
-		create_invalid_size(xe);
-	}
-
 	igt_subtest("create-engines-noleak")
 		create_engines(xe, NOLEAK);
 
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-10-16 15:19 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-12  7:01 [igt-dev] [PATCH i-g-t] tests/xe_create: Remove create-invalid-size subtest Zbigniew Kempczyński
2023-10-12 10:02 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/xe_create: Remove create-invalid-size subtest (rev2) Patchwork
2023-10-12 10:40 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-10-12 10:43 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-10-13  5:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-16 15:19 ` [igt-dev] [PATCH i-g-t] tests/xe_create: Remove create-invalid-size subtest Thomas Hellström
  -- strict thread matches above, loose matches on Subject: below --
2023-06-26 14:23 Zbigniew Kempczyński
2023-06-26 15:23 ` Kamil Konieczny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox