[igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

[igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

[Nidhi Gupta]

-Cleanup up the display state before starting the subtest.
-Execute the tests only for 5 modes.
-Use primary plane to set the framebuffer.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/kms_invalid_mode.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index f1c3866..492c92c 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -184,6 +184,7 @@ test_output(data_t *data)
 	struct igt_fb fb;
 	int ret;
 	drmModeModeInfo *mode;
+	igt_plane_t *primary;
 
 	igt_display_reset(&data->display);
 	igt_output_set_pipe(output, data->pipe);
@@ -192,7 +193,14 @@ test_output(data_t *data)
 		      DRM_FORMAT_MOD_LINEAR,
 		      &fb);
 
+	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+	igt_plane_set_fb(primary, &fb);
+
 	for_each_connector_mode(output) {
+		igt_output_override_mode(output, NULL);
+		igt_display_commit(&data->display);
+		if (j__ > 5)
+			break;
 		mode = &output->config.connector->modes[j__];
 		igt_require(data->adjust_mode(data, mode));
 		igt_output_override_mode(output, mode);
@@ -200,9 +208,11 @@ test_output(data_t *data)
 		igt_assert(ret == -EINVAL);
 	}
 
+	/* Cleanup */
 	igt_remove_fb(data->drm_fd, &fb);
+	igt_plane_set_fb(primary, NULL);
 	igt_output_override_mode(output, NULL);
-	/*unset_all_crtcs*/
+	igt_output_set_pipe(output, PIPE_NONE);
 	igt_display_commit(&data->display);
 }
 
-- 
1.9.1

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_invalid_mode: Fix the test for legacy platform

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5287 bytes --]

== Series Details ==

Series: tests/kms_invalid_mode: Fix the test for legacy platform
URL   : https://patchwork.freedesktop.org/series/110461/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12333 -> IGTPW_8039
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_8039 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_8039, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/index.html

Participating hosts (38 -> 27)
------------------------------

  Missing    (11): fi-tgl-dsi bat-dg2-8 bat-dg2-9 bat-adlp-6 bat-adlp-4 bat-adln-1 bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-dg2-11 bat-jsl-1 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8039:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@load:
    - fi-bdw-gvtdvm:      [PASS][1] -> [DMESG-WARN][2] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-bdw-gvtdvm/igt@i915_module_load@load.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-bdw-gvtdvm/igt@i915_module_load@load.html

  
Known issues
------------

  Here are the changes found in IGTPW_8039 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_lmem_swapping@basic:
    - fi-apl-guc:         NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-apl-guc/igt@gem_lmem_swapping@basic.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-apl-guc:         NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-apl-guc/igt@kms_chamelium@hdmi-crc-fast.html

  * igt@kms_flip@basic-flip-vs-dpms@b-edp1:
    - fi-icl-u2:          [PASS][5] -> [DMESG-WARN][6] ([i915#4890])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-icl-u2/igt@kms_flip@basic-flip-vs-dpms@b-edp1.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-icl-u2/igt@kms_flip@basic-flip-vs-dpms@b-edp1.html

  * igt@kms_force_connector_basic@force-connector-state:
    - fi-apl-guc:         NOTRUN -> [SKIP][7] ([fdo#109271]) +11 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-apl-guc/igt@kms_force_connector_basic@force-connector-state.html

  * igt@runner@aborted:
    - fi-icl-u2:          NOTRUN -> [FAIL][8] ([i915#4312])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-icl-u2/igt@runner@aborted.html
    - fi-bdw-gvtdvm:      NOTRUN -> [FAIL][9] ([i915#4312])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-bdw-gvtdvm/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@gem_ctx_create@basic-files:
    - {fi-tgl-mst}:       [DMESG-WARN][10] ([i915#6434]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-tgl-mst/igt@gem_ctx_create@basic-files.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-tgl-mst/igt@gem_ctx_create@basic-files.html

  * igt@gem_render_tiled_blits@basic:
    - fi-apl-guc:         [INCOMPLETE][12] -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-apl-guc/igt@gem_render_tiled_blits@basic.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-apl-guc/igt@gem_render_tiled_blits@basic.html

  * igt@gem_tiled_blits@basic:
    - fi-pnv-d510:        [SKIP][14] ([fdo#109271]) -> [PASS][15] +1 similar issue
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12333/fi-pnv-d510/igt@gem_tiled_blits@basic.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/fi-pnv-d510/igt@gem_tiled_blits@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
  [i915#6106]: https://gitlab.freedesktop.org/drm/intel/issues/6106
  [i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7038 -> IGTPW_8039

  CI-20190529: 20190529
  CI_DRM_12333: e7d1d39c197e7f06cf4d1ee19cfd467d6b68e10e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8039: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/index.html
  IGT_7038: 5389b3f3b9b75df6bd8506e4aa3da357fd0c0ab1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

+igt@i915_pm_backlight@fade_with_dpms
+igt@i915_pm_backlight@fade_with_suspend
-igt@i915_pm_backlight@fade-with-dpms
-igt@i915_pm_backlight@fade-with-suspend

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8039/index.html

[-- Attachment #2: Type: text/html, Size: 6358 bytes --]

Re: [igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

[Ville Syrjälä]

On Thu, Nov 03, 2022 at 08:54:58AM +0530, Nidhi Gupta wrote:
> -Cleanup up the display state before starting the subtest.
> -Execute the tests only for 5 modes.
> -Use primary plane to set the framebuffer.

Again multiple patches in the guise of a single patch, with
no justification for any of them. NAK.

I think we just need to put in the revert and start from 
scratch.

> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
>  tests/kms_invalid_mode.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index f1c3866..492c92c 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -184,6 +184,7 @@ test_output(data_t *data)
>  	struct igt_fb fb;
>  	int ret;
>  	drmModeModeInfo *mode;
> +	igt_plane_t *primary;
>  
>  	igt_display_reset(&data->display);
>  	igt_output_set_pipe(output, data->pipe);
> @@ -192,7 +193,14 @@ test_output(data_t *data)
>  		      DRM_FORMAT_MOD_LINEAR,
>  		      &fb);
>  
> +	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> +	igt_plane_set_fb(primary, &fb);
> +
>  	for_each_connector_mode(output) {
> +		igt_output_override_mode(output, NULL);
> +		igt_display_commit(&data->display);
> +		if (j__ > 5)
> +			break;
>  		mode = &output->config.connector->modes[j__];
>  		igt_require(data->adjust_mode(data, mode));
>  		igt_output_override_mode(output, mode);
> @@ -200,9 +208,11 @@ test_output(data_t *data)
>  		igt_assert(ret == -EINVAL);
>  	}
>  
> +	/* Cleanup */
>  	igt_remove_fb(data->drm_fd, &fb);
> +	igt_plane_set_fb(primary, NULL);
>  	igt_output_override_mode(output, NULL);
> -	/*unset_all_crtcs*/
> +	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_display_commit(&data->display);
>  }
>  
> -- 
> 1.9.1

-- 
Ville Syrjälä
Intel

Re: [igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

[Gupta, Nidhi1]

Hi Ville,

It's a small patch, just cleaning up the display state before executing the subtest.

Nidhi

-----Original Message-----
From: Ville Syrjälä <ville.syrjala@linux.intel.com> 
Sent: Thursday, November 3, 2022 3:01 PM
To: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

On Thu, Nov 03, 2022 at 08:54:58AM +0530, Nidhi Gupta wrote:
> -Cleanup up the display state before starting the subtest.
> -Execute the tests only for 5 modes.
> -Use primary plane to set the framebuffer.

Again multiple patches in the guise of a single patch, with no justification for any of them. NAK.

I think we just need to put in the revert and start from scratch.

> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
>  tests/kms_invalid_mode.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c index 
> f1c3866..492c92c 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -184,6 +184,7 @@ test_output(data_t *data)
>  	struct igt_fb fb;
>  	int ret;
>  	drmModeModeInfo *mode;
> +	igt_plane_t *primary;
>  
>  	igt_display_reset(&data->display);
>  	igt_output_set_pipe(output, data->pipe); @@ -192,7 +193,14 @@ 
> test_output(data_t *data)
>  		      DRM_FORMAT_MOD_LINEAR,
>  		      &fb);
>  
> +	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> +	igt_plane_set_fb(primary, &fb);
> +
>  	for_each_connector_mode(output) {
> +		igt_output_override_mode(output, NULL);
> +		igt_display_commit(&data->display);
> +		if (j__ > 5)
> +			break;
>  		mode = &output->config.connector->modes[j__];
>  		igt_require(data->adjust_mode(data, mode));
>  		igt_output_override_mode(output, mode); @@ -200,9 +208,11 @@ 
> test_output(data_t *data)
>  		igt_assert(ret == -EINVAL);
>  	}
>  
> +	/* Cleanup */
>  	igt_remove_fb(data->drm_fd, &fb);
> +	igt_plane_set_fb(primary, NULL);
>  	igt_output_override_mode(output, NULL);
> -	/*unset_all_crtcs*/
> +	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_display_commit(&data->display);
>  }
>  
> --
> 1.9.1

--
Ville Syrjälä
Intel

Re: [igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

[Ville Syrjälä]

On Thu, Nov 03, 2022 at 09:46:57AM +0000, Gupta, Nidhi1 wrote:
> Hi Ville,
> 
> It's a small patch, just cleaning up the display state before executing the subtest.

No, it's three patches, none of which fix the already broken test.

> 
> Nidhi
> 
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com> 
> Sent: Thursday, November 3, 2022 3:01 PM
> To: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform
> 
> On Thu, Nov 03, 2022 at 08:54:58AM +0530, Nidhi Gupta wrote:
> > -Cleanup up the display state before starting the subtest.
> > -Execute the tests only for 5 modes.
> > -Use primary plane to set the framebuffer.
> 
> Again multiple patches in the guise of a single patch, with no justification for any of them. NAK.
> 
> I think we just need to put in the revert and start from scratch.
> 
> > 
> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> > ---
> >  tests/kms_invalid_mode.c | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c index 
> > f1c3866..492c92c 100644
> > --- a/tests/kms_invalid_mode.c
> > +++ b/tests/kms_invalid_mode.c
> > @@ -184,6 +184,7 @@ test_output(data_t *data)
> >  	struct igt_fb fb;
> >  	int ret;
> >  	drmModeModeInfo *mode;
> > +	igt_plane_t *primary;
> >  
> >  	igt_display_reset(&data->display);
> >  	igt_output_set_pipe(output, data->pipe); @@ -192,7 +193,14 @@ 
> > test_output(data_t *data)
> >  		      DRM_FORMAT_MOD_LINEAR,
> >  		      &fb);
> >  
> > +	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> > +	igt_plane_set_fb(primary, &fb);
> > +
> >  	for_each_connector_mode(output) {
> > +		igt_output_override_mode(output, NULL);
> > +		igt_display_commit(&data->display);
> > +		if (j__ > 5)
> > +			break;
> >  		mode = &output->config.connector->modes[j__];
> >  		igt_require(data->adjust_mode(data, mode));
> >  		igt_output_override_mode(output, mode); @@ -200,9 +208,11 @@ 
> > test_output(data_t *data)
> >  		igt_assert(ret == -EINVAL);
> >  	}
> >  
> > +	/* Cleanup */
> >  	igt_remove_fb(data->drm_fd, &fb);
> > +	igt_plane_set_fb(primary, NULL);
> >  	igt_output_override_mode(output, NULL);
> > -	/*unset_all_crtcs*/
> > +	igt_output_set_pipe(output, PIPE_NONE);
> >  	igt_display_commit(&data->display);
> >  }
> >  
> > --
> > 1.9.1
> 
> --
> Ville Syrjälä
> Intel

-- 
Ville Syrjälä
Intel

Re: [igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

[Gupta, Nidhi1]

Hi Ville,

Only this part "igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); "is creating problem, earlier it was drmModesetcrtc,  should I set it back to drmModesetcrtc?

-----Original Message-----
From: Ville Syrjälä <ville.syrjala@linux.intel.com> 
Sent: Thursday, November 3, 2022 3:21 PM
To: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

On Thu, Nov 03, 2022 at 09:46:57AM +0000, Gupta, Nidhi1 wrote:
> Hi Ville,
> 
> It's a small patch, just cleaning up the display state before executing the subtest.

No, it's three patches, none of which fix the already broken test.

> 
> Nidhi
> 
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Thursday, November 3, 2022 3:01 PM
> To: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for 
> legacy platform
> 
> On Thu, Nov 03, 2022 at 08:54:58AM +0530, Nidhi Gupta wrote:
> > -Cleanup up the display state before starting the subtest.
> > -Execute the tests only for 5 modes.
> > -Use primary plane to set the framebuffer.
> 
> Again multiple patches in the guise of a single patch, with no justification for any of them. NAK.
> 
> I think we just need to put in the revert and start from scratch.
> 
> > 
> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> > ---
> >  tests/kms_invalid_mode.c | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c 
> > index f1c3866..492c92c 100644
> > --- a/tests/kms_invalid_mode.c
> > +++ b/tests/kms_invalid_mode.c
> > @@ -184,6 +184,7 @@ test_output(data_t *data)
> >  	struct igt_fb fb;
> >  	int ret;
> >  	drmModeModeInfo *mode;
> > +	igt_plane_t *primary;
> >  
> >  	igt_display_reset(&data->display);
> >  	igt_output_set_pipe(output, data->pipe); @@ -192,7 +193,14 @@ 
> > test_output(data_t *data)
> >  		      DRM_FORMAT_MOD_LINEAR,
> >  		      &fb);
> >  
> > +	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> > +	igt_plane_set_fb(primary, &fb);
> > +
> >  	for_each_connector_mode(output) {
> > +		igt_output_override_mode(output, NULL);
> > +		igt_display_commit(&data->display);
> > +		if (j__ > 5)
> > +			break;
> >  		mode = &output->config.connector->modes[j__];
> >  		igt_require(data->adjust_mode(data, mode));
> >  		igt_output_override_mode(output, mode); @@ -200,9 +208,11 @@ 
> > test_output(data_t *data)
> >  		igt_assert(ret == -EINVAL);
> >  	}
> >  
> > +	/* Cleanup */
> >  	igt_remove_fb(data->drm_fd, &fb);
> > +	igt_plane_set_fb(primary, NULL);
> >  	igt_output_override_mode(output, NULL);
> > -	/*unset_all_crtcs*/
> > +	igt_output_set_pipe(output, PIPE_NONE);
> >  	igt_display_commit(&data->display);
> >  }
> >  
> > --
> > 1.9.1
> 
> --
> Ville Syrjälä
> Intel

--
Ville Syrjälä
Intel

Re: [igt-dev] [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform

[Ville Syrjälä]

On Thu, Nov 03, 2022 at 10:16:31AM +0000, Gupta, Nidhi1 wrote:
> Hi Ville,
> 
> Only this part "igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY); "is creating problem, earlier it was drmModesetcrtc,  should I set it back to drmModesetcrtc?

There is a lot more wrong than that.

> 
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com> 
> Sent: Thursday, November 3, 2022 3:21 PM
> To: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for legacy platform
> 
> On Thu, Nov 03, 2022 at 09:46:57AM +0000, Gupta, Nidhi1 wrote:
> > Hi Ville,
> > 
> > It's a small patch, just cleaning up the display state before executing the subtest.
> 
> No, it's three patches, none of which fix the already broken test.
> 
> > 
> > Nidhi
> > 
> > -----Original Message-----
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Sent: Thursday, November 3, 2022 3:01 PM
> > To: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
> > Cc: igt-dev@lists.freedesktop.org
> > Subject: Re: [PATCH i-g-t] tests/kms_invalid_mode: Fix the test for 
> > legacy platform
> > 
> > On Thu, Nov 03, 2022 at 08:54:58AM +0530, Nidhi Gupta wrote:
> > > -Cleanup up the display state before starting the subtest.
> > > -Execute the tests only for 5 modes.
> > > -Use primary plane to set the framebuffer.
> > 
> > Again multiple patches in the guise of a single patch, with no justification for any of them. NAK.
> > 
> > I think we just need to put in the revert and start from scratch.
> > 
> > > 
> > > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> > > ---
> > >  tests/kms_invalid_mode.c | 12 +++++++++++-
> > >  1 file changed, 11 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c 
> > > index f1c3866..492c92c 100644
> > > --- a/tests/kms_invalid_mode.c
> > > +++ b/tests/kms_invalid_mode.c
> > > @@ -184,6 +184,7 @@ test_output(data_t *data)
> > >  	struct igt_fb fb;
> > >  	int ret;
> > >  	drmModeModeInfo *mode;
> > > +	igt_plane_t *primary;
> > >  
> > >  	igt_display_reset(&data->display);
> > >  	igt_output_set_pipe(output, data->pipe); @@ -192,7 +193,14 @@ 
> > > test_output(data_t *data)
> > >  		      DRM_FORMAT_MOD_LINEAR,
> > >  		      &fb);
> > >  
> > > +	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> > > +	igt_plane_set_fb(primary, &fb);
> > > +
> > >  	for_each_connector_mode(output) {
> > > +		igt_output_override_mode(output, NULL);
> > > +		igt_display_commit(&data->display);
> > > +		if (j__ > 5)
> > > +			break;
> > >  		mode = &output->config.connector->modes[j__];
> > >  		igt_require(data->adjust_mode(data, mode));
> > >  		igt_output_override_mode(output, mode); @@ -200,9 +208,11 @@ 
> > > test_output(data_t *data)
> > >  		igt_assert(ret == -EINVAL);
> > >  	}
> > >  
> > > +	/* Cleanup */
> > >  	igt_remove_fb(data->drm_fd, &fb);
> > > +	igt_plane_set_fb(primary, NULL);
> > >  	igt_output_override_mode(output, NULL);
> > > -	/*unset_all_crtcs*/
> > > +	igt_output_set_pipe(output, PIPE_NONE);
> > >  	igt_display_commit(&data->display);
> > >  }
> > >  
> > > --
> > > 1.9.1
> > 
> > --
> > Ville Syrjälä
> > Intel
> 
> --
> Ville Syrjälä
> Intel

-- 
Ville Syrjälä
Intel