Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] lib/igt_kmod: stop using KMOD_REMOVE_FORCE, again
@ 2024-10-30 23:49 Lucas De Marchi
  2024-10-31  1:57 ` ✓ CI.xeBAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Lucas De Marchi @ 2024-10-30 23:49 UTC (permalink / raw)
  To: igt-dev; +Cc: Lucas De Marchi

Just like done in commit 93ad5b785ea0 ("lib/igt_kmod: stop using
KMOD_REMOVE_FORCE"). From igt perspective, if a module can't be removed,
forcing its removal is not the right thing to do: the test should just
fail and be fixed.

If the kernel actually enforces KMOD_REMOVE_FORCE, then it would just
taint and all tests get aborted. Lastly, our kernel config doesn't have
CONFIG_MODULE_FORCE_UNLOAD set, so this is pointless for multiple times.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/igt_kmod.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 75a0d057c..cc3e5e5b1 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -1409,8 +1409,7 @@ static void __igt_kunit(struct igt_ktest *tst,
 			char glob[1024];
 			int i;
 
-			igt_skip_on(kmod_module_remove_module(tst->kmod,
-							      KMOD_REMOVE_FORCE));
+			igt_skip_on(kmod_module_remove_module(tst->kmod, 0));
 			igt_skip_on(igt_kernel_tainted(&taints));
 
 			igt_assert_lt(snprintf(glob, sizeof(glob), "%s.%s",
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-12-05 14:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-30 23:49 [PATCH i-g-t] lib/igt_kmod: stop using KMOD_REMOVE_FORCE, again Lucas De Marchi
2024-10-31  1:57 ` ✓ CI.xeBAT: success for " Patchwork
2024-10-31  2:01 ` ✓ Fi.CI.BAT: " Patchwork
2024-10-31  3:41 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-31 12:30 ` ✗ Fi.CI.IGT: " Patchwork
2024-11-19 13:36 ` [PATCH i-g-t] " Vivekanandan, Balasubramani
2024-12-05 14:36 ` Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox