[igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[Chris Wilson]

Use the new igt_subtest_with_dynamic to nicely group the dynamic
subtests together.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
 lib/igt_kmod.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 05019c24c..e701545d3 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -21,6 +21,7 @@
  * IN THE SOFTWARE.
  */
 
+#include <ctype.h>
 #include <signal.h>
 #include <errno.h>
 
@@ -602,6 +603,18 @@ void igt_kselftest_fini(struct igt_kselftest *tst)
 	kmod_module_unref(tst->kmod);
 }
 
+static const char *unfilter(const char *filter, const char *name)
+{
+	if (!filter)
+		return name;
+
+	name += strlen(filter);
+	if (!isalpha(*name))
+		name++;
+
+	return name;
+}
+
 void igt_kselftests(const char *module_name,
 		    const char *options,
 		    const char *result,
@@ -618,10 +631,12 @@ void igt_kselftests(const char *module_name,
 		igt_require(igt_kselftest_begin(&tst) == 0);
 
 	igt_kselftest_get_tests(tst.kmod, filter, &tests);
-	igt_list_for_each_entry_safe(tl, tn, &tests, link) {
-		igt_subtest_f("%s", tl->name)
-			igt_kselftest_execute(&tst, tl, options, result);
-		free(tl);
+	igt_subtest_with_dynamic(filter ?: "all") {
+		igt_list_for_each_entry_safe(tl, tn, &tests, link) {
+			igt_dynamic_f("%s", unfilter(filter, tl->name))
+				igt_kselftest_execute(&tst, tl, options, result);
+			free(tl);
+		}
 	}
 
 	igt_fixture {
-- 
2.25.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ GitLab.Pipeline: failure for lib: Update selftests to use dynamic subtests

[Patchwork]

== Series Details ==

Series: lib: Update selftests to use dynamic subtests
URL   : https://patchwork.freedesktop.org/series/73486/
State : failure

== Summary ==

ERROR! This series introduces new undocumented tests:

dmabuf@all
drm_mm@all
i915_selftest@live
i915_selftest@mock
i915_selftest@perf
kms_selftest@all

Can you document them as per the requirement in the [CONTRIBUTING.md]?

[Documentation] has more details on how to do this.

Here are few examples:
https://gitlab.freedesktop.org/drm/igt-gpu-tools/commit/0316695d03aa46108296b27f3982ec93200c7a6e
https://gitlab.freedesktop.org/drm/igt-gpu-tools/commit/443cc658e1e6b492ee17bf4f4d891029eb7a205d

Thanks in advance!

[CONTRIBUTING.md]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/CONTRIBUTING.md#L19
[Documentation]: https://drm.pages.freedesktop.org/igt-gpu-tools/igt-gpu-tools-Core.html#igt-describe

Other than that, pipeline status: SUCCESS.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/108900 for the overview.

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/108900
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib: Update selftests to use dynamic subtests

[Patchwork]

== Series Details ==

Series: lib: Update selftests to use dynamic subtests
URL   : https://patchwork.freedesktop.org/series/73486/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7943 -> IGTPW_4158
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_4158 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4158, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4158:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_evict:
    - fi-cml-u2:          [PASS][1] -> [SKIP][2] +31 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-cml-u2/igt@i915_selftest@live_evict.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-cml-u2/igt@i915_selftest@live_evict.html

  * igt@i915_selftest@live_gt_contexts:
    - fi-icl-guc:         [PASS][3] -> [SKIP][4] +30 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-guc/igt@i915_selftest@live_gt_contexts.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-guc/igt@i915_selftest@live_gt_contexts.html

  * igt@i915_selftest@live_gt_mocs:
    - fi-icl-y:           [PASS][5] -> [SKIP][6] +29 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-y/igt@i915_selftest@live_gt_mocs.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-y/igt@i915_selftest@live_gt_mocs.html

  * igt@i915_selftest@live_hugepages:
    - fi-icl-u2:          [PASS][7] -> [SKIP][8] +30 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-u2/igt@i915_selftest@live_hugepages.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-u2/igt@i915_selftest@live_hugepages.html

  * igt@i915_selftest@live_reset:
    - fi-icl-dsi:         [PASS][9] -> [SKIP][10] +30 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-dsi/igt@i915_selftest@live_reset.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-dsi/igt@i915_selftest@live_reset.html

  * igt@i915_selftest@live_sanitycheck:
    - fi-icl-u3:          [PASS][11] -> [SKIP][12] +30 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html

  * igt@i915_selftest@live_uncore:
    - fi-cml-s:           [PASS][13] -> [SKIP][14] +31 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-cml-s/igt@i915_selftest@live_uncore.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-cml-s/igt@i915_selftest@live_uncore.html

  * igt@runner@aborted:
    - fi-kbl-7500u:       NOTRUN -> [FAIL][15]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-kbl-7500u/igt@runner@aborted.html

  
#### Warnings ####

  * igt@i915_selftest@live_active:
    - fi-icl-y:           [DMESG-FAIL][16] ([i915#765]) -> [SKIP][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-y/igt@i915_selftest@live_active.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-y/igt@i915_selftest@live_active.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_selftest@live_client:
    - {fi-tgl-u}:         [PASS][18] -> [SKIP][19] +31 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-tgl-u/igt@i915_selftest@live_client.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-tgl-u/igt@i915_selftest@live_client.html

  * igt@i915_selftest@live_execlists:
    - {fi-tgl-dsi}:       [PASS][20] -> [SKIP][21] +31 similar issues
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-tgl-dsi/igt@i915_selftest@live_execlists.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-tgl-dsi/igt@i915_selftest@live_execlists.html

  
Known issues
------------

  Here are the changes found in IGTPW_4158 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@dmabuf@dma_fence:
    - fi-ilk-650:         [PASS][22] -> [SKIP][23] ([fdo#109271]) +31 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-ilk-650/igt@dmabuf@dma_fence.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-ilk-650/igt@dmabuf@dma_fence.html

  * igt@dmabuf@sanitycheck:
    - fi-kbl-x1275:       [PASS][24] -> [SKIP][25] ([fdo#109271]) +31 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-kbl-x1275/igt@dmabuf@sanitycheck.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-kbl-x1275/igt@dmabuf@sanitycheck.html

  * igt@i915_selftest@live_active:
    - fi-bdw-5557u:       [PASS][26] -> [SKIP][27] ([fdo#109271]) +31 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-bdw-5557u/igt@i915_selftest@live_active.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-bdw-5557u/igt@i915_selftest@live_active.html

  * igt@i915_selftest@live_coherency:
    - fi-hsw-4770:        [PASS][28] -> [SKIP][29] ([fdo#109271]) +31 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-hsw-4770/igt@i915_selftest@live_coherency.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-hsw-4770/igt@i915_selftest@live_coherency.html

  * igt@i915_selftest@live_dmabuf:
    - fi-hsw-4770r:       [PASS][30] -> [SKIP][31] ([fdo#109271]) +31 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-hsw-4770r/igt@i915_selftest@live_dmabuf.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-hsw-4770r/igt@i915_selftest@live_dmabuf.html

  * igt@i915_selftest@live_execlists:
    - fi-glk-dsi:         [PASS][32] -> [SKIP][33] ([fdo#109271]) +31 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-glk-dsi/igt@i915_selftest@live_execlists.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-glk-dsi/igt@i915_selftest@live_execlists.html
    - fi-gdg-551:         [PASS][34] -> [SKIP][35] ([fdo#109271]) +31 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-gdg-551/igt@i915_selftest@live_execlists.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-gdg-551/igt@i915_selftest@live_execlists.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-apl-guc:         [PASS][36] -> [SKIP][37] ([fdo#109271]) +31 similar issues
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-apl-guc/igt@i915_selftest@live_gem_contexts.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-apl-guc/igt@i915_selftest@live_gem_contexts.html

  * igt@i915_selftest@live_gt_contexts:
    - fi-kbl-r:           [PASS][38] -> [SKIP][39] ([fdo#109271]) +31 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-kbl-r/igt@i915_selftest@live_gt_contexts.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-kbl-r/igt@i915_selftest@live_gt_contexts.html

  * igt@i915_selftest@live_gt_engines:
    - fi-kbl-guc:         [PASS][40] -> [SKIP][41] ([fdo#109271]) +31 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-kbl-guc/igt@i915_selftest@live_gt_engines.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-kbl-guc/igt@i915_selftest@live_gt_engines.html

  * igt@i915_selftest@live_gt_heartbeat:
    - fi-pnv-d510:        [PASS][42] -> [SKIP][43] ([fdo#109271]) +31 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-pnv-d510/igt@i915_selftest@live_gt_heartbeat.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-pnv-d510/igt@i915_selftest@live_gt_heartbeat.html

  * igt@i915_selftest@live_gt_pm:
    - fi-cfl-8700k:       [PASS][44] -> [SKIP][45] ([fdo#109271]) +31 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-cfl-8700k/igt@i915_selftest@live_gt_pm.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-cfl-8700k/igt@i915_selftest@live_gt_pm.html

  * igt@i915_selftest@live_gt_timelines:
    - fi-cfl-guc:         [PASS][46] -> [SKIP][47] ([fdo#109271]) +31 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-cfl-guc/igt@i915_selftest@live_gt_timelines.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-cfl-guc/igt@i915_selftest@live_gt_timelines.html

  * igt@i915_selftest@live_gtt:
    - fi-bwr-2160:        [PASS][48] -> [SKIP][49] ([fdo#109271]) +31 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-bwr-2160/igt@i915_selftest@live_gtt.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-bwr-2160/igt@i915_selftest@live_gtt.html
    - fi-skl-guc:         [PASS][50] -> [SKIP][51] ([fdo#109271]) +31 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-skl-guc/igt@i915_selftest@live_gtt.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-skl-guc/igt@i915_selftest@live_gtt.html

  * igt@i915_selftest@live_late_gt_pm:
    - fi-bsw-kefka:       [PASS][52] -> [SKIP][53] ([fdo#109271]) +31 similar issues
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-bsw-kefka/igt@i915_selftest@live_late_gt_pm.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-bsw-kefka/igt@i915_selftest@live_late_gt_pm.html

  * igt@i915_selftest@live_mman:
    - fi-bxt-dsi:         [PASS][54] -> [SKIP][55] ([fdo#109271]) +31 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-bxt-dsi/igt@i915_selftest@live_mman.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-bxt-dsi/igt@i915_selftest@live_mman.html

  * igt@i915_selftest@live_objects:
    - fi-snb-2600:        [PASS][56] -> [SKIP][57] ([fdo#109271]) +31 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-snb-2600/igt@i915_selftest@live_objects.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-snb-2600/igt@i915_selftest@live_objects.html

  * igt@i915_selftest@live_perf:
    - fi-skl-6700k2:      [PASS][58] -> [SKIP][59] ([fdo#109271]) +31 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-skl-6700k2/igt@i915_selftest@live_perf.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-skl-6700k2/igt@i915_selftest@live_perf.html

  * igt@i915_selftest@live_requests:
    - fi-icl-guc:         [PASS][60] -> [SKIP][61] ([fdo#109644] / [fdo#110464])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-guc/igt@i915_selftest@live_requests.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-guc/igt@i915_selftest@live_requests.html
    - fi-icl-dsi:         [PASS][62] -> [SKIP][63] ([fdo#109644] / [fdo#110464])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-dsi/igt@i915_selftest@live_requests.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-dsi/igt@i915_selftest@live_requests.html
    - fi-icl-u2:          [PASS][64] -> [SKIP][65] ([fdo#109644] / [fdo#110464])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-u2/igt@i915_selftest@live_requests.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-u2/igt@i915_selftest@live_requests.html
    - fi-icl-y:           [PASS][66] -> [SKIP][67] ([fdo#109644] / [fdo#110464])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-y/igt@i915_selftest@live_requests.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-y/igt@i915_selftest@live_requests.html
    - fi-icl-u3:          [PASS][68] -> [SKIP][69] ([fdo#109644] / [fdo#110464])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-icl-u3/igt@i915_selftest@live_requests.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-icl-u3/igt@i915_selftest@live_requests.html

  * igt@i915_selftest@live_reset:
    - fi-snb-2520m:       [PASS][70] -> [SKIP][71] ([fdo#109271]) +31 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-snb-2520m/igt@i915_selftest@live_reset.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-snb-2520m/igt@i915_selftest@live_reset.html

  
#### Possible fixes ####

  * igt@gem_close_race@basic-threads:
    - fi-byt-n2820:       [INCOMPLETE][72] ([i915#45]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-byt-n2820/igt@gem_close_race@basic-threads.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-byt-n2820/igt@gem_close_race@basic-threads.html

  * igt@gem_exec_parallel@basic:
    - {fi-ehl-1}:         [FAIL][74] ([i915#996]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7943/fi-ehl-1/igt@gem_exec_parallel@basic.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/fi-ehl-1/igt@gem_exec_parallel@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109644]: https://bugs.freedesktop.org/show_bug.cgi?id=109644
  [fdo#110464]: https://bugs.freedesktop.org/show_bug.cgi?id=110464
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#765]: https://gitlab.freedesktop.org/drm/intel/issues/765
  [i915#996]: https://gitlab.freedesktop.org/drm/intel/issues/996


Participating hosts (41 -> 44)
------------------------------

  Additional (9): fi-kbl-soraka fi-bsw-n3050 fi-hsw-peppy fi-ivb-3770 fi-cfl-8109u fi-skl-lmem fi-blb-e6850 fi-bsw-nick fi-skl-6600u 
  Missing    (6): fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5442 -> IGTPW_4158

  CI-20190529: 20190529
  CI_DRM_7943: 865945b076689b2e99bc1c52fad95cec05cff9ed @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4158: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/index.html
  IGT_5442: 3f6080996885b997685f08ecb8b416b2dc485290 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@dmabuf@all
+igt@drm_mm@all
+igt@i915_selftest@live
+igt@i915_selftest@mock
+igt@i915_selftest@perf
+igt@kms_selftest@all

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4158/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[Petri Latvala]

On Fri, Feb 14, 2020 at 09:48:29PM +0000, Chris Wilson wrote:
> Use the new igt_subtest_with_dynamic to nicely group the dynamic
> subtests together.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> ---
>  lib/igt_kmod.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 05019c24c..e701545d3 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -21,6 +21,7 @@
>   * IN THE SOFTWARE.
>   */
>  
> +#include <ctype.h>
>  #include <signal.h>
>  #include <errno.h>
>  
> @@ -602,6 +603,18 @@ void igt_kselftest_fini(struct igt_kselftest *tst)
>  	kmod_module_unref(tst->kmod);
>  }
>  
> +static const char *unfilter(const char *filter, const char *name)
> +{
> +	if (!filter)
> +		return name;
> +
> +	name += strlen(filter);
> +	if (!isalpha(*name))
> +		name++;
> +
> +	return name;
> +}
> +
>  void igt_kselftests(const char *module_name,
>  		    const char *options,
>  		    const char *result,
> @@ -618,10 +631,12 @@ void igt_kselftests(const char *module_name,
>  		igt_require(igt_kselftest_begin(&tst) == 0);
>  
>  	igt_kselftest_get_tests(tst.kmod, filter, &tests);
> -	igt_list_for_each_entry_safe(tl, tn, &tests, link) {
> -		igt_subtest_f("%s", tl->name)
> -			igt_kselftest_execute(&tst, tl, options, result);
> -		free(tl);
> +	igt_subtest_with_dynamic(filter ?: "all") {
> +		igt_list_for_each_entry_safe(tl, tn, &tests, link) {
> +			igt_dynamic_f("%s", unfilter(filter, tl->name))
> +				igt_kselftest_execute(&tst, tl, options, result);
> +			free(tl);
> +		}
>  	}



Thanks for starting this, exactly what dynamic subtests are for.

Pre-acked-by: Petri Latvala <petri.latvala@intel.com>

CI side should be made ready before landing this. With kernel
selftests being now launched from statically enumerable subtests,
selftests can be added to fast-feedback.testlist and un-blacklisted
from shards where applicable.

Tomi, what do we run (and what do we want to) in BAT now? Objections
to running selftests in shards mixed in with other tests?

Runtime is a concern if all (FSVO all) selftests are launched with one
entry in a testlist. What is the total runtime on a random platform
for, say, i915_selftest subtests (post patch)? We might need to split
more than just live/mock.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[Petri Latvala]

On Mon, Feb 17, 2020 at 01:01:30PM +0200, Petri Latvala wrote:
> On Fri, Feb 14, 2020 at 09:48:29PM +0000, Chris Wilson wrote:
> > Use the new igt_subtest_with_dynamic to nicely group the dynamic
> > subtests together.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> > ---
> >  lib/igt_kmod.c | 23 +++++++++++++++++++----
> >  1 file changed, 19 insertions(+), 4 deletions(-)
> > 
> > diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> > index 05019c24c..e701545d3 100644
> > --- a/lib/igt_kmod.c
> > +++ b/lib/igt_kmod.c
> > @@ -21,6 +21,7 @@
> >   * IN THE SOFTWARE.
> >   */
> >  
> > +#include <ctype.h>
> >  #include <signal.h>
> >  #include <errno.h>
> >  
> > @@ -602,6 +603,18 @@ void igt_kselftest_fini(struct igt_kselftest *tst)
> >  	kmod_module_unref(tst->kmod);
> >  }
> >  
> > +static const char *unfilter(const char *filter, const char *name)
> > +{
> > +	if (!filter)
> > +		return name;
> > +
> > +	name += strlen(filter);
> > +	if (!isalpha(*name))
> > +		name++;
> > +
> > +	return name;
> > +}
> > +
> >  void igt_kselftests(const char *module_name,
> >  		    const char *options,
> >  		    const char *result,
> > @@ -618,10 +631,12 @@ void igt_kselftests(const char *module_name,
> >  		igt_require(igt_kselftest_begin(&tst) == 0);
> >  
> >  	igt_kselftest_get_tests(tst.kmod, filter, &tests);
> > -	igt_list_for_each_entry_safe(tl, tn, &tests, link) {
> > -		igt_subtest_f("%s", tl->name)
> > -			igt_kselftest_execute(&tst, tl, options, result);
> > -		free(tl);
> > +	igt_subtest_with_dynamic(filter ?: "all") {
> > +		igt_list_for_each_entry_safe(tl, tn, &tests, link) {
> > +			igt_dynamic_f("%s", unfilter(filter, tl->name))
> > +				igt_kselftest_execute(&tst, tl, options, result);
> > +			free(tl);
> > +		}
> >  	}
> 
> 
> 
> Thanks for starting this, exactly what dynamic subtests are for.
> 
> Pre-acked-by: Petri Latvala <petri.latvala@intel.com>
> 
> CI side should be made ready before landing this. With kernel
> selftests being now launched from statically enumerable subtests,
> selftests can be added to fast-feedback.testlist and un-blacklisted
> from shards where applicable.
> 
> Tomi, what do we run (and what do we want to) in BAT now? Objections
> to running selftests in shards mixed in with other tests?
> 
> Runtime is a concern if all (FSVO all) selftests are launched with one
> entry in a testlist. What is the total runtime on a random platform
> for, say, i915_selftest subtests (post patch)? We might need to split
> more than just live/mock.


Oh, and in the same patch you can do this:

Find the ugliest line you can find in tests/igt_command_line.sh and
change it to a prettier one.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[Chris Wilson]

Quoting Petri Latvala (2020-02-17 11:17:28)
> Oh, and in the same patch you can do this:
> 
> Find the ugliest line you can find in tests/igt_command_line.sh and
> change it to a prettier one.

We can just delete it, right? Since with igt_subtest_with_dynamic() we
always define the test group and so --list always reports something.
Right?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[Petri Latvala]

On Mon, Feb 17, 2020 at 11:22:46AM +0000, Chris Wilson wrote:
> Quoting Petri Latvala (2020-02-17 11:17:28)
> > Oh, and in the same patch you can do this:
> > 
> > Find the ugliest line you can find in tests/igt_command_line.sh and
> > change it to a prettier one.
> 
> We can just delete it, right? Since with igt_subtest_with_dynamic() we
> always define the test group and so --list always reports something.
> Right?

The if (and the fi), yes.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[Chris Wilson]

Quoting Petri Latvala (2020-02-17 11:26:59)
> On Mon, Feb 17, 2020 at 11:22:46AM +0000, Chris Wilson wrote:
> > Quoting Petri Latvala (2020-02-17 11:17:28)
> > > Oh, and in the same patch you can do this:
> > > 
> > > Find the ugliest line you can find in tests/igt_command_line.sh and
> > > change it to a prettier one.
> > 
> > We can just delete it, right? Since with igt_subtest_with_dynamic() we
> > always define the test group and so --list always reports something.
> > Right?
> 
> The if (and the fi), yes.

--- a/tests/igt_command_line.sh
+++ b/tests/igt_command_line.sh
@@ -92,10 +92,8 @@ check_test ()
                # Subtest enumeration of kernel selftest launchers depends
                # on the running kernel. If selftests are not enabled,
                # they will output nothing and exit with 0.
-               if [ "$testname" != "i915_selftest" -a "$testname" != "drm_mm" -a "$testname" != "kms_selftest" -a "$testname" != "dmabuf" ]; then
-                       echo "    test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!"
-                       fail $test
-               fi
+               echo "    test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!"
+               fail $test
        fi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[Sarvela, Tomi P]

> From: Latvala, Petri <petri.latvala@intel.com>
> 
> On Fri, Feb 14, 2020 at 09:48:29PM +0000, Chris Wilson wrote:
> > Use the new igt_subtest_with_dynamic to nicely group the dynamic
> > subtests together.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> > ---
> >  lib/igt_kmod.c | 23 +++++++++++++++++++----
> >  1 file changed, 19 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> > index 05019c24c..e701545d3 100644
> > --- a/lib/igt_kmod.c
> > +++ b/lib/igt_kmod.c
> > @@ -21,6 +21,7 @@
> >   * IN THE SOFTWARE.
> >   */
> >
> > +#include <ctype.h>
> >  #include <signal.h>
> >  #include <errno.h>
> >
> > @@ -602,6 +603,18 @@ void igt_kselftest_fini(struct igt_kselftest *tst)
> >  	kmod_module_unref(tst->kmod);
> >  }
> >
> > +static const char *unfilter(const char *filter, const char *name)
> > +{
> > +	if (!filter)
> > +		return name;
> > +
> > +	name += strlen(filter);
> > +	if (!isalpha(*name))
> > +		name++;
> > +
> > +	return name;
> > +}
> > +
> >  void igt_kselftests(const char *module_name,
> >  		    const char *options,
> >  		    const char *result,
> > @@ -618,10 +631,12 @@ void igt_kselftests(const char *module_name,
> >  		igt_require(igt_kselftest_begin(&tst) == 0);
> >
> >  	igt_kselftest_get_tests(tst.kmod, filter, &tests);
> > -	igt_list_for_each_entry_safe(tl, tn, &tests, link) {
> > -		igt_subtest_f("%s", tl->name)
> > -			igt_kselftest_execute(&tst, tl,
> options, result);
> > -		free(tl);
> > +	igt_subtest_with_dynamic(filter ?: "all") {
> > +		igt_list_for_each_entry_safe(tl, tn, &tests, link)
> {
> > +			igt_dynamic_f("%s",
> unfilter(filter, tl->name))
> > +
> 	igt_kselftest_execute(&tst, tl, options, result);
> > +			free(tl);
> > +		}
> >  	}
> 
> 
> Thanks for starting this, exactly what dynamic subtests are for.
> 
> Pre-acked-by: Petri Latvala <petri.latvala@intel.com>
> 
> CI side should be made ready before landing this. With kernel
> selftests being now launched from statically enumerable subtests,
> selftests can be added to fast-feedback.testlist and un-blacklisted
> from shards where applicable.

Acked-by: Tomi Sarvela <tomi.p.sarvela@intel.com>

This is good: the discovery of sub-selftests will be done by the tests, so
we can drop the selftest.testlist and use common blacklist where applicable.

> Tomi, what do we run (and what do we want to) in BAT now? Objections
> to running selftests in shards mixed in with other tests?

BAT is running fast-feedback.testlist and after that from selftests:
igt@i915_selftest@live_*
igt@dmabuf@*

In other words, currently blacklisted selftests in BAT are:
igt@i915_selftest@{mock,perf}_*
igt@drm_mm@*
igt@kms_selftest@*

I don't mind selftests being shuffled through all the other tests, we have
the checks in place for taint/lockdep to recognize hopeless driver states
to force reboot.

> Runtime is a concern if all (FSVO all) selftests are launched with one
> entry in a testlist. What is the total runtime on a random platform
> for, say, i915_selftest subtests (post patch)? We might need to split
> more than just live/mock.

Runtimes for last functional selftest shard are from CI_DRM_7925:
tgl 186s
hsw 762s
glk 223s
icl 177s
kbl 199s
apl 284s
snb 112s
skl 763s

The obvious outliers are SKL and HSW:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-skl10/igt_runner35.txt 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7925/shard-hsw5/igt_runner35.txt 

HSW due to timeout in live_gtt which wasted 10 minutes, SKL due to generic slowness
and in addition couple of drm_mm tests taking > 100s per subtest.
 
Tomi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Update selftests to use dynamic subtests

[Petri Latvala]

On Mon, Feb 17, 2020 at 11:32:17AM +0000, Chris Wilson wrote:
> Quoting Petri Latvala (2020-02-17 11:26:59)
> > On Mon, Feb 17, 2020 at 11:22:46AM +0000, Chris Wilson wrote:
> > > Quoting Petri Latvala (2020-02-17 11:17:28)
> > > > Oh, and in the same patch you can do this:
> > > > 
> > > > Find the ugliest line you can find in tests/igt_command_line.sh and
> > > > change it to a prettier one.
> > > 
> > > We can just delete it, right? Since with igt_subtest_with_dynamic() we
> > > always define the test group and so --list always reports something.
> > > Right?
> > 
> > The if (and the fi), yes.
> 
> --- a/tests/igt_command_line.sh
> +++ b/tests/igt_command_line.sh
> @@ -92,10 +92,8 @@ check_test ()
>                 # Subtest enumeration of kernel selftest launchers depends
>                 # on the running kernel. If selftests are not enabled,
>                 # they will output nothing and exit with 0.
> -               if [ "$testname" != "i915_selftest" -a "$testname" != "drm_mm" -a "$testname" != "kms_selftest" -a "$testname" != "dmabuf" ]; then
> -                       echo "    test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!"
> -                       fail $test
> -               fi
> +               echo "    test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!"
> +               fail $test
>         fi


With all the rejoicing of being able to remove an ugly workaround, I
forgot that the above comment needs to go as well.

Five lines removed still counts as a one-liner, right?

-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v2] lib: Update selftests to use dynamic subtests

[Chris Wilson]

Use the new igt_subtest_with_dynamic to nicely group the dynamic
subtests together.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Acked-by: Petri Latvala <petri.latvala@intel.com>
Acked-by: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
I shall leave it to Tomi or Petri to handle the timing of the push to
make sure CI remains intact :)
---
 lib/igt_kmod.c            | 23 +++++++++++++++++++----
 tests/igt_command_line.sh |  9 ++-------
 2 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 05019c24c..e701545d3 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -21,6 +21,7 @@
  * IN THE SOFTWARE.
  */
 
+#include <ctype.h>
 #include <signal.h>
 #include <errno.h>
 
@@ -602,6 +603,18 @@ void igt_kselftest_fini(struct igt_kselftest *tst)
 	kmod_module_unref(tst->kmod);
 }
 
+static const char *unfilter(const char *filter, const char *name)
+{
+	if (!filter)
+		return name;
+
+	name += strlen(filter);
+	if (!isalpha(*name))
+		name++;
+
+	return name;
+}
+
 void igt_kselftests(const char *module_name,
 		    const char *options,
 		    const char *result,
@@ -618,10 +631,12 @@ void igt_kselftests(const char *module_name,
 		igt_require(igt_kselftest_begin(&tst) == 0);
 
 	igt_kselftest_get_tests(tst.kmod, filter, &tests);
-	igt_list_for_each_entry_safe(tl, tn, &tests, link) {
-		igt_subtest_f("%s", tl->name)
-			igt_kselftest_execute(&tst, tl, options, result);
-		free(tl);
+	igt_subtest_with_dynamic(filter ?: "all") {
+		igt_list_for_each_entry_safe(tl, tn, &tests, link) {
+			igt_dynamic_f("%s", unfilter(filter, tl->name))
+				igt_kselftest_execute(&tst, tl, options, result);
+			free(tl);
+		}
 	}
 
 	igt_fixture {
diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh
index 291b65268..5356877c7 100755
--- a/tests/igt_command_line.sh
+++ b/tests/igt_command_line.sh
@@ -89,13 +89,8 @@ check_test ()
 	fi
 
 	if [ $RET -eq 0 -a -z "$LIST" ]; then
-		# Subtest enumeration of kernel selftest launchers depends
-		# on the running kernel. If selftests are not enabled,
-		# they will output nothing and exit with 0.
-		if [ "$testname" != "i915_selftest" -a "$testname" != "drm_mm" -a "$testname" != "kms_selftest" -a "$testname" != "dmabuf" ]; then
-			echo "    test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!"
-			fail $test
-		fi
+		echo "    test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!"
+		fail $test
 	fi
 }
 
-- 
2.25.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ GitLab.Pipeline: warning for lib: Update selftests to use dynamic subtests (rev3)

[Patchwork]

== Series Details ==

Series: lib: Update selftests to use dynamic subtests (rev3)
URL   : https://patchwork.freedesktop.org/series/73486/
State : warning

== Summary ==

Did not get list of undocumented tests for this run, something is wrong!

Other than that, pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/109461 for the overview.

test:ninja-test-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/1648469):
    [test_root]           Directory that contains the IGT tests. The environment
                          variable IGT_TEST_ROOT will be used if set, overriding
                          this option if given.
  Cannot open /builds/gfx-ci/igt-ci-tags/build/tmpdirxoyF5h/test-list.txt
  -------
  
  Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
  FAILED: meson-test 
  /usr/bin/meson test --no-rebuild --print-errorlogs
  ninja: build stopped: subcommand failed.
  section_end:1581944535:build_script
  ^[[0Ksection_start:1581944535:after_script
  ^[[0Ksection_end:1581944536:after_script
  ^[[0Ksection_start:1581944536:upload_artifacts_on_failure
  ^[[0K^[[32;1mUploading artifacts...^[[0;m
  build: found 1342 matching files                  ^[[0;m 
  Uploading artifacts to coordinator... ok          ^[[0;m  id^[[0;m=1648469 responseStatus^[[0;m=201 Created token^[[0;m=s2fRwncy
  section_end:1581944542:upload_artifacts_on_failure
  ^[[0K^[[31;1mERROR: Job failed: exit code 1
  ^[[0;m

test:ninja-test-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/1648541):
    [test_root]           Directory that contains the IGT tests. The environment
                          variable IGT_TEST_ROOT will be used if set, overriding
                          this option if given.
  Cannot open /builds/gfx-ci/igt-ci-tags/build/tmpdirXjeWz6/test-list.txt
  -------
  
  Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
  FAILED: meson-test 
  /usr/bin/meson test --no-rebuild --print-errorlogs
  ninja: build stopped: subcommand failed.
  section_end:1581944924:build_script
  ^[[0Ksection_start:1581944924:after_script
  ^[[0Ksection_end:1581944926:after_script
  ^[[0Ksection_start:1581944926:upload_artifacts_on_failure
  ^[[0K^[[32;1mUploading artifacts...^[[0;m
  build: found 1342 matching files                  ^[[0;m 
  Uploading artifacts to coordinator... ok          ^[[0;m  id^[[0;m=1648541 responseStatus^[[0;m=201 Created token^[[0;m=QfDnCLqG
  section_end:1581944931:upload_artifacts_on_failure
  ^[[0K^[[31;1mERROR: Job failed: exit code 1
  ^[[0;m

test:ninja-test-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/1648546):
    [test_root]           Directory that contains the IGT tests. The environment
                          variable IGT_TEST_ROOT will be used if set, overriding
                          this option if given.
  Cannot open /builds/gfx-ci/igt-ci-tags/build/tmpdiriG8DYn/test-list.txt
  -------
  
  Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
  FAILED: meson-test 
  /usr/bin/meson test --no-rebuild --print-errorlogs
  ninja: build stopped: subcommand failed.
  section_end:1581945329:build_script
  ^[[0Ksection_start:1581945329:after_script
  ^[[0Ksection_end:1581945331:after_script
  ^[[0Ksection_start:1581945331:upload_artifacts_on_failure
  ^[[0K^[[32;1mUploading artifacts...^[[0;m
  build: found 1342 matching files                  ^[[0;m 
  Uploading artifacts to coordinator... ok          ^[[0;m  id^[[0;m=1648546 responseStatus^[[0;m=201 Created token^[[0;m=XzgWcj2F
  section_end:1581945336:upload_artifacts_on_failure
  ^[[0K^[[31;1mERROR: Job failed: exit code 1
  ^[[0;m

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/109461
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib: Update selftests to use dynamic subtests (rev3)

[Patchwork]

== Series Details ==

Series: lib: Update selftests to use dynamic subtests (rev3)
URL   : https://patchwork.freedesktop.org/series/73486/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5445 -> IGTPW_4165
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_4165 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4165, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4165/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4165:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-r:           NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4165/fi-kbl-r/igt@gem_exec_suspend@basic-s0.html

  
Known issues
------------

  Here are the changes found in IGTPW_4165 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_gtt:
    - fi-bwr-2160:        [PASS][2] -> [SKIP][3] ([fdo#109271]) +31 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5445/fi-bwr-2160/igt@i915_selftest@live_gtt.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4165/fi-bwr-2160/igt@i915_selftest@live_gtt.html

  * igt@i915_selftest@live_mman:
    - fi-gdg-551:         [PASS][4] -> [SKIP][5] ([fdo#109271]) +31 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5445/fi-gdg-551/igt@i915_selftest@live_mman.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4165/fi-gdg-551/igt@i915_selftest@live_mman.html

  
#### Possible fixes ####

  * igt@gem_close_race@basic-threads:
    - fi-byt-n2820:       [INCOMPLETE][6] ([i915#45]) -> [PASS][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5445/fi-byt-n2820/igt@gem_close_race@basic-threads.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4165/fi-byt-n2820/igt@gem_close_race@basic-threads.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45


Participating hosts (51 -> 46)
------------------------------

  Additional (1): fi-kbl-r 
  Missing    (6): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5445 -> IGTPW_4165

  CI-20190529: 20190529
  CI_DRM_7954: d7c1791394faaa869d3442705413dac8c0ecd677 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4165: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4165/index.html
  IGT_5445: 21e523814d692978d6d04ba85eadd67fcbd88b7e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@dmabuf@all
+igt@drm_mm@all
+igt@i915_selftest@live
+igt@i915_selftest@mock
+igt@i915_selftest@perf
+igt@kms_selftest@all

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4165/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev