Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [i-g-t] tests/intel/xe_vm:Reduce n_execs for bind-array-enobufs
@ 2024-10-22 20:11 Jagmeet Randhawa
  2024-10-22 21:05 ` ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Jagmeet Randhawa @ 2024-10-22 20:11 UTC (permalink / raw)
  Cc: igt-dev, jonathan.cavitt, alex.zuo, kamil.konieczny,
	Jagmeet Randhawa

The bind-array-enobufs test in xe_vm.c is intended to trigger
an -ENOBUFS error by submitting an oversized bind array.
After encountering and handling the error, the test reduces
n_execs by half and retries the operation. On some environments
with stricter resource limits (e.g. simulator), halving
n_execs isn't sufficient to prevent the ENOBUFS error on the retry.
Reducing n_execs further to n_execs / 4 allows the test to pass
successfully. This patch modifies the test to reduce n_execs
to n_execs / 4 after an ENOBUFS error is handled. This ensures
compatibility with environments that have tighter resource
constraints while maintaining the test's integrity.

Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
---
 tests/intel/xe_vm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index 7a8740b69..e78ddd0e5 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -957,7 +957,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs,
 		xe_cork_end(&cork);
 		xe_cork_wait_done(&cork);
 		xe_cork_fini(&cork);
-		n_execs = n_execs / 2;
+		n_execs = n_execs / 4;
 	}
 
 	xe_vm_bind_array(fd, vm, bind_exec_queue, bind_ops, n_execs, sync, 1);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread
* [PATCH] [i-g-t, v2] tests/intel/xe_vm: Reduce n_execs for bind-array-enobufs
@ 2024-11-05 20:29 Jagmeet Randhawa
  2024-11-07  1:53 ` ✗ CI.xeFULL: failure for " Patchwork
  0 siblings, 1 reply; 14+ messages in thread
From: Jagmeet Randhawa @ 2024-11-05 20:29 UTC (permalink / raw)
  Cc: igt-dev, jonathan.cavitt, alex.zuo, kamil.konieczny,
	Jagmeet Randhawa

The bind-array-enobufs test in xe_vm.c is intended to trigger
an -ENOBUFS error by submitting an oversized bind array.
After encountering and handling the error, the test reduces
n_execs by half and retries the operation. On some environments
with stricter resource limits (e.g. simulator), halving
n_execs isn't sufficient to prevent the ENOBUFS error on the retry.
Reducing n_execs further to n_execs / 4 allows the test to pass
successfully.

Signed-off-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 tests/intel/xe_vm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index 7a8740b69..e78ddd0e5 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -957,7 +957,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs,
 		xe_cork_end(&cork);
 		xe_cork_wait_done(&cork);
 		xe_cork_fini(&cork);
-		n_execs = n_execs / 2;
+		n_execs = n_execs / 4;
 	}
 
 	xe_vm_bind_array(fd, vm, bind_exec_queue, bind_ops, n_execs, sync, 1);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2024-11-07 20:08 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-22 20:11 [PATCH] [i-g-t] tests/intel/xe_vm:Reduce n_execs for bind-array-enobufs Jagmeet Randhawa
2024-10-22 21:05 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-10-28 16:56   ` Kamil Konieczny
2024-10-22 21:46 ` ✓ CI.xeBAT: success " Patchwork
2024-10-23  4:37 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-28 16:55   ` Kamil Konieczny
2024-11-05 20:33     ` Randhawa, Jagmeet
2024-10-23 14:12 ` [PATCH] [i-g-t] " Cavitt, Jonathan
2024-10-23 20:29   ` Randhawa, Jagmeet
2024-10-23 20:35     ` Cavitt, Jonathan
2024-10-28 16:53 ` Kamil Konieczny
2024-11-05 20:31   ` Randhawa, Jagmeet
  -- strict thread matches above, loose matches on Subject: below --
2024-11-05 20:29 [PATCH] [i-g-t, v2] tests/intel/xe_vm: Reduce " Jagmeet Randhawa
2024-11-07  1:53 ` ✗ CI.xeFULL: failure for " Patchwork
2024-11-07 20:08   ` Randhawa, Jagmeet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox