* [PATCH v1 00/20] gpio: Improvements around device-id arrays
@ 2026-07-14 7:24 Uwe Kleine-König (The Capable Hub)
2026-07-14 7:24 ` [PATCH v1 07/20] gpio: Add missing OF module annotations Uwe Kleine-König (The Capable Hub)
2026-07-14 7:24 ` [PATCH v1 16/20] gpio: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
0 siblings, 2 replies; 5+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-14 7:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Yang Shen, linux-gpio, linux-kernel, Lixu Zhang, Sakari Ailus,
Israel Cepeda, Hans de Goede, Andy Shevchenko, Ray Jui,
Broadcom internal kernel review list, Florian Fainelli,
Scott Branden, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Daire McNamara, Daniel Palmer, Romain Perier, Robert Jarzmik, imx,
linux-arm-kernel, linux-riscv, Mika Westerberg, Andy Shevchenko,
linux-acpi, Hoan Tran, Alan Borzeszkowski,
Enrico Weigelt, metux IT consult, Viresh Kumar, virtualization,
Yinbo Zhu, Thierry Reding, Jonathan Hunter, linux-tegra,
Geert Uytterhoeven, Adrian Ng, Joel Stanley, Andrew Jeffery,
Alban Bedel, James Cowgill, Matt Redfearn, Neil Jones,
Nikolaos Pasaloukos, Doug Berger, Keerthy, Vladimir Zapolskiy,
Piotr Wojtaszczyk, Sven Peter, Janne Grunau, Neal Gompa,
Mathieu Dubois-Briand, André Draszik, Bamvor Jian Zhang,
Marek Behún, Matthias Brugger, AngeloGioacchino Del Regno,
Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture,
Nancy Yuen, Benjamin Fair, Grygorii Strashko, Santosh Shilimkar,
Kevin Hilman, Orson Zhai, Baolin Wang, Chunyan Zhang,
Manivannan Sadhasivam, Heiko Stuebner, Ludovic Desroches,
Paul Walmsley, Samuel Holland, Michael Walle, Maxime Coquelin,
Alexandre Torgue, Nobuhiro Iwamatsu, Shubhrajyoti Datta,
Srinivas Neeli, Michal Simek, Magnus Damm, linux-aspeed, asahi,
linux-mediatek, openbmc, linux-omap, linux-unisoc, linux-rockchip,
linux-stm32, linux-renesas-soc, Michael Buesch,
William Breathitt Gray, Robert Richter
Hello,
the original motivation for this series are the patches that convert the
arrays to use named initializers, see
https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
for the idea behind it. Then the quest grew, due to thinking to convert
all device id arrays in a single series to not bother each subsystem
repeatedly[1], then I spotted a few missing MODULE_DEVICE_TABLE annotations
and decided to fix these. Then I noticed that some driver_data entries
to be unused and then dropped them instead of converting to named
initializers. And as my scripts that do most of these changes also cared
about trailing commas and how the list terminators look, this is also
addressed in this series. And so this grew to 20 patches ...
This is based on yesterday's next and obviously merge window material.
Best regards
Uwe
[1] Of course this only works if no new entries are added that
initialize .driver_data by a positional initializer until I come
around to add the union to the respecive device id struct.
Uwe Kleine-König (The Capable Hub) (20):
gpio: Drop unused assignment of acpi_device_id driver data
gpio: max7301: Drop unused assignment of spi_device_id driver data
gpio: mmio: Drop unused assignment of platform_device_id driver data
gpio: ljca: Drop unused assignment of auxiliary_device_id driver data
gpio: Add missing ACPI module annotations
gpio: sodaville: Add missing pci module annotations
gpio: Add missing OF module annotations
gpio: pxa: Add missing platform module annotations
gpio: Add missing dmi module annotations
gpio: pl061: Use empty initializer for amba_id terminator
gpio: Use named initializers for acpi_device_id array
gpio: Use named initializers for spi_device_id array
gpio: virtio: Use a named initializer for virtio_device_id array
gpio: pcf857x: Use named initializers for of_device_id array
gpio: Unify style of acpi_device_id arrays
gpio: Unify style of of_device_id arrays
gpio: max77620: Unify style of platform_device_id arrays
gpio: Unify style of spi_device_id arrays
gpio: Unify style of pci_device_id arrays
gpio: Unify style of various *_device_id arrays
drivers/gpio/gpio-74x164.c | 4 ++--
drivers/gpio/gpio-adnp.c | 4 ++--
drivers/gpio/gpio-aggregator.c | 2 +-
drivers/gpio/gpio-altera-a10sr.c | 2 +-
drivers/gpio/gpio-altera.c | 4 ++--
drivers/gpio/gpio-amd8111.c | 2 +-
drivers/gpio/gpio-amdpt.c | 8 ++++----
drivers/gpio/gpio-aspeed-sgpio.c | 10 +++++-----
drivers/gpio/gpio-aspeed.c | 10 +++++-----
drivers/gpio/gpio-ath79.c | 2 +-
drivers/gpio/gpio-bcm-kona.c | 1 +
drivers/gpio/gpio-blzp1600.c | 2 +-
drivers/gpio/gpio-brcmstb.c | 2 +-
drivers/gpio/gpio-bt8xx.c | 2 +-
drivers/gpio/gpio-cadence.c | 4 ++--
drivers/gpio/gpio-creg-snps.c | 5 +++--
drivers/gpio/gpio-davinci.c | 6 +++---
drivers/gpio/gpio-dwapb.c | 14 +++++++-------
drivers/gpio/gpio-em.c | 4 ++--
drivers/gpio/gpio-ep93xx.c | 1 +
drivers/gpio/gpio-ftgpio010.c | 3 ++-
drivers/gpio/gpio-graniterapids.c | 4 ++--
drivers/gpio/gpio-grgpio.c | 2 +-
drivers/gpio/gpio-gw-pld.c | 4 ++--
drivers/gpio/gpio-hisi.c | 6 +++---
drivers/gpio/gpio-hlwd.c | 4 ++--
drivers/gpio/gpio-imx-scu.c | 1 +
drivers/gpio/gpio-ixp4xx.c | 4 ++--
drivers/gpio/gpio-ljca.c | 4 ++--
drivers/gpio/gpio-loongson-64bit.c | 4 ++--
drivers/gpio/gpio-lp3943.c | 2 +-
drivers/gpio/gpio-lpc32xx.c | 4 ++--
drivers/gpio/gpio-macsmc.c | 4 ++--
drivers/gpio/gpio-max3191x.c | 12 ++++++------
drivers/gpio/gpio-max7301.c | 2 +-
drivers/gpio/gpio-max7360.c | 8 ++++----
drivers/gpio/gpio-max77620.c | 4 ++--
drivers/gpio/gpio-max77759.c | 2 +-
drivers/gpio/gpio-mb86s7x.c | 2 +-
drivers/gpio/gpio-ml-ioh.c | 2 +-
drivers/gpio/gpio-mlxbf3.c | 4 ++--
drivers/gpio/gpio-mm-lantiq.c | 2 +-
drivers/gpio/gpio-mmio.c | 3 +--
drivers/gpio/gpio-mockup.c | 4 ++--
drivers/gpio/gpio-moxtet.c | 4 ++--
drivers/gpio/gpio-mpc5200.c | 5 +++--
drivers/gpio/gpio-mpc8xxx.c | 25 +++++++++++++------------
drivers/gpio/gpio-mpfs.c | 1 +
drivers/gpio/gpio-mpsse.c | 3 +--
drivers/gpio/gpio-msc313.c | 1 +
drivers/gpio/gpio-mt7621.c | 2 +-
drivers/gpio/gpio-mvebu.c | 1 +
drivers/gpio/gpio-mxc.c | 2 +-
drivers/gpio/gpio-mxs.c | 4 ++--
drivers/gpio/gpio-nomadik.c | 7 ++++---
drivers/gpio/gpio-novalake-events.c | 4 ++--
drivers/gpio/gpio-npcm-sgpio.c | 6 +++---
drivers/gpio/gpio-octeon.c | 2 +-
drivers/gpio/gpio-omap.c | 2 +-
drivers/gpio/gpio-palmas.c | 10 +++++-----
drivers/gpio/gpio-pca953x.c | 3 ++-
drivers/gpio/gpio-pca9570.c | 2 +-
drivers/gpio/gpio-pcf857x.c | 26 +++++++++++++-------------
drivers/gpio/gpio-pci-idio-16.c | 3 ++-
drivers/gpio/gpio-pcie-idio-24.c | 8 +++++---
drivers/gpio/gpio-pisosr.c | 4 ++--
drivers/gpio/gpio-pl061.c | 2 +-
drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
drivers/gpio/gpio-pxa.c | 20 +++++++++++---------
drivers/gpio/gpio-qixis-fpga.c | 3 +--
drivers/gpio/gpio-rda.c | 2 +-
drivers/gpio/gpio-realtek-otto.c | 2 +-
drivers/gpio/gpio-rockchip.c | 4 ++--
drivers/gpio/gpio-sama5d2-piobu.c | 2 +-
drivers/gpio/gpio-sifive.c | 2 +-
drivers/gpio/gpio-sl28cpld.c | 2 +-
drivers/gpio/gpio-sodaville.c | 3 ++-
drivers/gpio/gpio-spear-spics.c | 3 ++-
drivers/gpio/gpio-sprd.c | 2 +-
drivers/gpio/gpio-stmpe.c | 2 +-
drivers/gpio/gpio-stp-xway.c | 2 +-
drivers/gpio/gpio-tegra.c | 2 +-
drivers/gpio/gpio-tegra186.c | 2 +-
drivers/gpio/gpio-thunderx.c | 3 +--
drivers/gpio/gpio-tps65218.c | 2 +-
drivers/gpio/gpio-ts4800.c | 4 ++--
drivers/gpio/gpio-twl4030.c | 4 ++--
drivers/gpio/gpio-usbio.c | 13 +++++++------
drivers/gpio/gpio-vf610.c | 4 ++--
drivers/gpio/gpio-virtio.c | 4 ++--
drivers/gpio/gpio-visconti.c | 2 +-
drivers/gpio/gpio-waveshare-dsi.c | 2 +-
drivers/gpio/gpio-xgene-sb.c | 6 +++---
drivers/gpio/gpio-xgene.c | 10 ++++++----
drivers/gpio/gpio-xgs-iproc.c | 2 +-
drivers/gpio/gpio-xilinx.c | 2 +-
drivers/gpio/gpio-xlp.c | 6 +++---
drivers/gpio/gpio-xra1403.c | 6 +++---
drivers/gpio/gpio-zevio.c | 5 +++--
drivers/gpio/gpio-zynqmp-modepin.c | 2 +-
drivers/gpio/gpiolib-acpi-quirks.c | 3 ++-
101 files changed, 231 insertions(+), 211 deletions(-)
base-commit: 49362394dad7df66c274c867a271394c10ca2bb8
--
2.55.0.11.g153666a7d9bb
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 07/20] gpio: Add missing OF module annotations
2026-07-14 7:24 [PATCH v1 00/20] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
@ 2026-07-14 7:24 ` Uwe Kleine-König (The Capable Hub)
2026-07-14 7:34 ` sashiko-bot
2026-07-14 7:24 ` [PATCH v1 16/20] gpio: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
1 sibling, 1 reply; 5+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-14 7:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Ray Jui, Broadcom internal kernel review list, Florian Fainelli,
Scott Branden, Eugeniy Paltsev, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Imre Kaloz, Conor Dooley,
Daire McNamara, Daniel Palmer, Romain Perier, Robert Jarzmik,
linux-gpio, linux-kernel, imx, linux-arm-kernel, linux-riscv
A driver module matching devices using an of device id table is supposed
to declare that in the module's metadata. Add this information for
several drivers that failed to declare these.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
drivers/gpio/gpio-bcm-kona.c | 1 +
drivers/gpio/gpio-creg-snps.c | 1 +
drivers/gpio/gpio-ep93xx.c | 1 +
drivers/gpio/gpio-ftgpio010.c | 1 +
drivers/gpio/gpio-imx-scu.c | 1 +
drivers/gpio/gpio-ixp4xx.c | 2 +-
drivers/gpio/gpio-mpc5200.c | 1 +
drivers/gpio/gpio-mpc8xxx.c | 1 +
drivers/gpio/gpio-mpfs.c | 1 +
drivers/gpio/gpio-msc313.c | 1 +
drivers/gpio/gpio-mvebu.c | 1 +
drivers/gpio/gpio-nomadik.c | 1 +
drivers/gpio/gpio-pxa.c | 1 +
drivers/gpio/gpio-spear-spics.c | 1 +
drivers/gpio/gpio-xgene.c | 1 +
drivers/gpio/gpio-zevio.c | 1 +
16 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index b0beffe48b7d..9bcbee25f685 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -522,6 +522,7 @@ static struct of_device_id const bcm_kona_gpio_of_match[] = {
{ .compatible = "brcm,kona-gpio" },
{}
};
+MODULE_DEVICE_TABLE(of, bcm_kona_gpio_of_match);
/*
* This lock class tells lockdep that GPIO irqs are in a different
diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
index 157ab90f5ba8..2e159ea41791 100644
--- a/drivers/gpio/gpio-creg-snps.c
+++ b/drivers/gpio/gpio-creg-snps.c
@@ -131,6 +131,7 @@ static const struct of_device_id creg_gpio_ids[] = {
.data = &hsdk_cs_ctl
}, { /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, creg_gpio_ids);
static int creg_gpio_probe(struct platform_device *pdev)
{
diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 8784e433e1ff..278b1093dd22 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -377,6 +377,7 @@ static const struct of_device_id ep93xx_gpio_match[] = {
{ .compatible = "cirrus,ep9301-gpio" },
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, ep93xx_gpio_match);
static struct platform_driver ep93xx_gpio_driver = {
.driver = {
diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
index 11e6907c3b54..e29df8d5e571 100644
--- a/drivers/gpio/gpio-ftgpio010.c
+++ b/drivers/gpio/gpio-ftgpio010.c
@@ -323,6 +323,7 @@ static const struct of_device_id ftgpio_gpio_of_match[] = {
},
{},
};
+MODULE_DEVICE_TABLE(of, ftgpio_gpio_of_match);
static struct platform_driver ftgpio_gpio_driver = {
.driver = {
diff --git a/drivers/gpio/gpio-imx-scu.c b/drivers/gpio/gpio-imx-scu.c
index 0a75afecf9f8..3ebd3d73ed58 100644
--- a/drivers/gpio/gpio-imx-scu.c
+++ b/drivers/gpio/gpio-imx-scu.c
@@ -114,6 +114,7 @@ static const struct of_device_id imx_scu_gpio_dt_ids[] = {
{ .compatible = "fsl,imx8qxp-sc-gpio" },
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, imx_scu_gpio_dt_ids);
static struct platform_driver imx_scu_gpio_driver = {
.driver = {
diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
index 669b139cd499..88d48cfc9017 100644
--- a/drivers/gpio/gpio-ixp4xx.c
+++ b/drivers/gpio/gpio-ixp4xx.c
@@ -341,7 +341,7 @@ static const struct of_device_id ixp4xx_gpio_of_match[] = {
},
{},
};
-
+MODULE_DEVICE_TABLE(of, ixp4xx_gpio_of_match);
static struct platform_driver ixp4xx_gpio_driver = {
.driver = {
diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c
index 00f209157fd0..2c828bc922ae 100644
--- a/drivers/gpio/gpio-mpc5200.c
+++ b/drivers/gpio/gpio-mpc5200.c
@@ -180,6 +180,7 @@ static const struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
{ .compatible = "fsl,mpc5200-gpio-wkup", },
{}
};
+MODULE_DEVICE_TABLE(of, mpc52xx_wkup_gpiochip_match);
static struct platform_driver mpc52xx_wkup_gpiochip_driver = {
.driver = {
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index a6868f673831..ee35da06cbc7 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -318,6 +318,7 @@ static const struct of_device_id mpc8xxx_gpio_ids[] = {
{ .compatible = "fsl,qoriq-gpio", },
{}
};
+MODULE_DEVICE_TABLE(of, mpc8xxx_gpio_ids);
static int mpc8xxx_probe(struct platform_device *pdev)
{
diff --git a/drivers/gpio/gpio-mpfs.c b/drivers/gpio/gpio-mpfs.c
index 7f0751d7b1c4..1078b3018970 100644
--- a/drivers/gpio/gpio-mpfs.c
+++ b/drivers/gpio/gpio-mpfs.c
@@ -295,6 +295,7 @@ static const struct of_device_id mpfs_gpio_of_ids[] = {
},
{ /* end of list */ }
};
+MODULE_DEVICE_TABLE(of, mpfs_gpio_of_ids);
static struct platform_driver mpfs_gpio_driver = {
.probe = mpfs_gpio_probe,
diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c
index 7345afdc78de..38932986dc36 100644
--- a/drivers/gpio/gpio-msc313.c
+++ b/drivers/gpio/gpio-msc313.c
@@ -688,6 +688,7 @@ static const struct of_device_id msc313_gpio_of_match[] = {
#endif
{ }
};
+MODULE_DEVICE_TABLE(of, msc313_gpio_of_match);
/*
* The GPIO controller loses the state of the registers when the
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index 8d3acadb0d68..4d1625be11ec 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -978,6 +978,7 @@ static const struct of_device_id mvebu_gpio_of_match[] = {
/* sentinel */
},
};
+MODULE_DEVICE_TABLE(of, mvebu_gpio_of_match);
static int mvebu_gpio_suspend(struct platform_device *pdev, pm_message_t state)
{
diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
index 208fed631975..90293329b40b 100644
--- a/drivers/gpio/gpio-nomadik.c
+++ b/drivers/gpio/gpio-nomadik.c
@@ -719,6 +719,7 @@ static const struct of_device_id nmk_gpio_match[] = {
{ .compatible = "mobileye,eyeq5-gpio", },
{}
};
+MODULE_DEVICE_TABLE(of, nmk_gpio_match);
static struct platform_driver nmk_gpio_driver = {
.driver = {
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 5d61053e0596..317e3bc925eb 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -583,6 +583,7 @@ static const struct of_device_id pxa_gpio_dt_ids[] = {
{ .compatible = "marvell,pxa1928-gpio", .data = &pxa1928_id, },
{}
};
+MODULE_DEVICE_TABLE(of, pxa_gpio_dt_ids);
static int pxa_gpio_probe_dt(struct platform_device *pdev,
struct pxa_gpio_chip *pchip)
diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
index 96a0e1211500..3099deb2b290 100644
--- a/drivers/gpio/gpio-spear-spics.c
+++ b/drivers/gpio/gpio-spear-spics.c
@@ -157,6 +157,7 @@ static const struct of_device_id spics_gpio_of_match[] = {
{ .compatible = "st,spear-spics-gpio" },
{}
};
+MODULE_DEVICE_TABLE(of, spics_gpio_of_match);
static struct platform_driver spics_gpio_driver = {
.probe = spics_gpio_probe,
diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index ad0f1551c271..b34b0c58b67c 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -191,6 +191,7 @@ static const struct of_device_id xgene_gpio_of_match[] = {
{ .compatible = "apm,xgene-gpio", },
{},
};
+MODULE_DEVICE_TABLE(of, xgene_gpio_of_match);
#ifdef CONFIG_ACPI
static const struct acpi_device_id xgene_gpio_acpi_match[] = {
diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
index 288a86c8294a..f1c5c6a20673 100644
--- a/drivers/gpio/gpio-zevio.c
+++ b/drivers/gpio/gpio-zevio.c
@@ -213,6 +213,7 @@ static const struct of_device_id zevio_gpio_of_match[] = {
{ .compatible = "lsi,zevio-gpio", },
{ },
};
+MODULE_DEVICE_TABLE(of, zevio_gpio_of_match);
static struct platform_driver zevio_gpio_driver = {
.driver = {
--
2.55.0.11.g153666a7d9bb
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v1 16/20] gpio: Unify style of of_device_id arrays
2026-07-14 7:24 [PATCH v1 00/20] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-07-14 7:24 ` [PATCH v1 07/20] gpio: Add missing OF module annotations Uwe Kleine-König (The Capable Hub)
@ 2026-07-14 7:24 ` Uwe Kleine-König (The Capable Hub)
1 sibling, 0 replies; 5+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-14 7:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Geert Uytterhoeven, Adrian Ng, Joel Stanley, Andrew Jeffery,
Alban Bedel, James Cowgill, Matt Redfearn, Neil Jones,
Nikolaos Pasaloukos, Doug Berger, Florian Fainelli,
Broadcom internal kernel review list, Eugeniy Paltsev, Keerthy,
Hoan Tran, Yang Shen, Imre Kaloz, Yinbo Zhu, Vladimir Zapolskiy,
Piotr Wojtaszczyk, Sven Peter, Janne Grunau, Neal Gompa,
Mathieu Dubois-Briand, André Draszik, Bamvor Jian Zhang,
Marek Behún, Matthias Brugger, AngeloGioacchino Del Regno,
Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Avi Fishman, Tomer Maimon, Tali Perry, Patrick Venture,
Nancy Yuen, Benjamin Fair, Grygorii Strashko, Santosh Shilimkar,
Kevin Hilman, Orson Zhai, Baolin Wang, Chunyan Zhang,
Robert Jarzmik, Manivannan Sadhasivam, Heiko Stuebner,
Ludovic Desroches, Paul Walmsley, Samuel Holland, Michael Walle,
Maxime Coquelin, Alexandre Torgue, Thierry Reding,
Jonathan Hunter, Nobuhiro Iwamatsu, Ray Jui, Scott Branden,
Shubhrajyoti Datta, Srinivas Neeli, Michal Simek, Magnus Damm,
linux-gpio, linux-kernel, linux-arm-kernel, linux-aspeed, asahi,
linux-mediatek, imx, openbmc, linux-omap, linux-unisoc,
linux-rockchip, linux-riscv, linux-stm32, linux-tegra,
linux-renesas-soc
Update the various of_device_id arrays to conform to the most used and
generally recommended coding style. That is:
- no comma after the list terminator;
- a comma after an initializer if (and only if) the closing } is not
directly following;
- no explicit zeros in the list terminator;
- a space after an opening { and before a closing }, a single space in
the list terminator;
Adapt the few offenders accordingly.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
drivers/gpio/gpio-74x164.c | 2 +-
drivers/gpio/gpio-adnp.c | 4 ++--
drivers/gpio/gpio-aggregator.c | 2 +-
drivers/gpio/gpio-altera-a10sr.c | 2 +-
drivers/gpio/gpio-altera.c | 4 ++--
drivers/gpio/gpio-aspeed-sgpio.c | 10 +++++-----
drivers/gpio/gpio-aspeed.c | 10 +++++-----
drivers/gpio/gpio-ath79.c | 2 +-
drivers/gpio/gpio-blzp1600.c | 2 +-
drivers/gpio/gpio-brcmstb.c | 2 +-
drivers/gpio/gpio-cadence.c | 4 ++--
drivers/gpio/gpio-creg-snps.c | 4 ++--
drivers/gpio/gpio-davinci.c | 6 +++---
drivers/gpio/gpio-dwapb.c | 4 ++--
drivers/gpio/gpio-em.c | 4 ++--
drivers/gpio/gpio-ftgpio010.c | 2 +-
drivers/gpio/gpio-grgpio.c | 2 +-
drivers/gpio/gpio-gw-pld.c | 4 ++--
drivers/gpio/gpio-hisi.c | 2 +-
drivers/gpio/gpio-hlwd.c | 4 ++--
drivers/gpio/gpio-ixp4xx.c | 2 +-
drivers/gpio/gpio-loongson-64bit.c | 2 +-
drivers/gpio/gpio-lp3943.c | 2 +-
drivers/gpio/gpio-lpc32xx.c | 4 ++--
drivers/gpio/gpio-macsmc.c | 4 ++--
drivers/gpio/gpio-max7360.c | 8 ++++----
drivers/gpio/gpio-max77759.c | 2 +-
drivers/gpio/gpio-mm-lantiq.c | 2 +-
drivers/gpio/gpio-mockup.c | 4 ++--
drivers/gpio/gpio-moxtet.c | 4 ++--
drivers/gpio/gpio-mpc5200.c | 4 ++--
drivers/gpio/gpio-mpc8xxx.c | 22 +++++++++++-----------
drivers/gpio/gpio-mt7621.c | 2 +-
drivers/gpio/gpio-mxc.c | 2 +-
drivers/gpio/gpio-mxs.c | 4 ++--
drivers/gpio/gpio-nomadik.c | 6 +++---
drivers/gpio/gpio-npcm-sgpio.c | 6 +++---
drivers/gpio/gpio-octeon.c | 2 +-
drivers/gpio/gpio-omap.c | 2 +-
drivers/gpio/gpio-palmas.c | 10 +++++-----
drivers/gpio/gpio-pca9570.c | 2 +-
drivers/gpio/gpio-pisosr.c | 2 +-
drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
drivers/gpio/gpio-pxa.c | 18 +++++++++---------
drivers/gpio/gpio-qixis-fpga.c | 3 +--
drivers/gpio/gpio-rda.c | 2 +-
drivers/gpio/gpio-realtek-otto.c | 2 +-
drivers/gpio/gpio-rockchip.c | 4 ++--
drivers/gpio/gpio-sama5d2-piobu.c | 2 +-
drivers/gpio/gpio-sifive.c | 2 +-
drivers/gpio/gpio-sl28cpld.c | 2 +-
drivers/gpio/gpio-spear-spics.c | 2 +-
drivers/gpio/gpio-sprd.c | 2 +-
drivers/gpio/gpio-stmpe.c | 2 +-
drivers/gpio/gpio-stp-xway.c | 2 +-
drivers/gpio/gpio-tegra.c | 2 +-
drivers/gpio/gpio-tps65218.c | 2 +-
drivers/gpio/gpio-ts4800.c | 4 ++--
drivers/gpio/gpio-twl4030.c | 4 ++--
drivers/gpio/gpio-vf610.c | 4 ++--
drivers/gpio/gpio-visconti.c | 2 +-
drivers/gpio/gpio-waveshare-dsi.c | 2 +-
drivers/gpio/gpio-xgene-sb.c | 2 +-
drivers/gpio/gpio-xgene.c | 4 ++--
drivers/gpio/gpio-xgs-iproc.c | 2 +-
drivers/gpio/gpio-xilinx.c | 2 +-
drivers/gpio/gpio-xra1403.c | 2 +-
drivers/gpio/gpio-zevio.c | 4 ++--
drivers/gpio/gpio-zynqmp-modepin.c | 2 +-
69 files changed, 128 insertions(+), 129 deletions(-)
diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
index 5ca61cf5206a..eeed612e7c80 100644
--- a/drivers/gpio/gpio-74x164.c
+++ b/drivers/gpio/gpio-74x164.c
@@ -189,7 +189,7 @@ MODULE_DEVICE_TABLE(spi, gen_74x164_spi_ids);
static const struct of_device_id gen_74x164_dt_ids[] = {
{ .compatible = "fairchild,74hc595" },
{ .compatible = "nxp,74lvc594" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, gen_74x164_dt_ids);
diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c
index 0410e3adbf54..4b5825a49a08 100644
--- a/drivers/gpio/gpio-adnp.c
+++ b/drivers/gpio/gpio-adnp.c
@@ -506,8 +506,8 @@ static const struct i2c_device_id adnp_i2c_id[] = {
MODULE_DEVICE_TABLE(i2c, adnp_i2c_id);
static const struct of_device_id adnp_of_match[] = {
- { .compatible = "ad,gpio-adnp", },
- { },
+ { .compatible = "ad,gpio-adnp" },
+ { }
};
MODULE_DEVICE_TABLE(of, adnp_of_match);
diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c
index 5ce89f52b4b5..872ef6de9c70 100644
--- a/drivers/gpio/gpio-aggregator.c
+++ b/drivers/gpio/gpio-aggregator.c
@@ -1651,7 +1651,7 @@ static const struct of_device_id gpio_aggregator_dt_ids[] = {
* Add GPIO-operated devices controlled from userspace below,
* or use "driver_override" in sysfs.
*/
- {}
+ { }
};
MODULE_DEVICE_TABLE(of, gpio_aggregator_dt_ids);
diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c
index a41e5575ee37..2b06315abe74 100644
--- a/drivers/gpio/gpio-altera-a10sr.c
+++ b/drivers/gpio/gpio-altera-a10sr.c
@@ -96,7 +96,7 @@ static int altr_a10sr_gpio_probe(struct platform_device *pdev)
static const struct of_device_id altr_a10sr_gpio_of_match[] = {
{ .compatible = "altr,a10sr-gpio" },
- { },
+ { }
};
MODULE_DEVICE_TABLE(of, altr_a10sr_gpio_of_match);
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
index 532e3360b70e..f48b8012ee2b 100644
--- a/drivers/gpio/gpio-altera.c
+++ b/drivers/gpio/gpio-altera.c
@@ -257,8 +257,8 @@ static int altera_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id altera_gpio_of_match[] = {
- { .compatible = "altr,pio-1.0", },
- {},
+ { .compatible = "altr,pio-1.0" },
+ { }
};
MODULE_DEVICE_TABLE(of, altera_gpio_of_match);
diff --git a/drivers/gpio/gpio-aspeed-sgpio.c b/drivers/gpio/gpio-aspeed-sgpio.c
index 4225261f61c8..fbde74be8a80 100644
--- a/drivers/gpio/gpio-aspeed-sgpio.c
+++ b/drivers/gpio/gpio-aspeed-sgpio.c
@@ -594,11 +594,11 @@ static const struct aspeed_sgpio_pdata ast2700_sgpiom_pdata = {
};
static const struct of_device_id aspeed_sgpio_of_table[] = {
- { .compatible = "aspeed,ast2400-sgpio", .data = &ast2400_sgpio_pdata, },
- { .compatible = "aspeed,ast2500-sgpio", .data = &ast2400_sgpio_pdata, },
- { .compatible = "aspeed,ast2600-sgpiom", .data = &ast2600_sgpiom_pdata, },
- { .compatible = "aspeed,ast2700-sgpiom", .data = &ast2700_sgpiom_pdata, },
- {}
+ { .compatible = "aspeed,ast2400-sgpio", .data = &ast2400_sgpio_pdata },
+ { .compatible = "aspeed,ast2500-sgpio", .data = &ast2400_sgpio_pdata },
+ { .compatible = "aspeed,ast2600-sgpiom", .data = &ast2600_sgpiom_pdata },
+ { .compatible = "aspeed,ast2700-sgpiom", .data = &ast2700_sgpiom_pdata },
+ { }
};
MODULE_DEVICE_TABLE(of, aspeed_sgpio_of_table);
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index dc53b2decb66..1a7fc65d6279 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1292,11 +1292,11 @@ static const struct aspeed_gpio_config ast2700_config =
};
static const struct of_device_id aspeed_gpio_of_table[] = {
- { .compatible = "aspeed,ast2400-gpio", .data = &ast2400_config, },
- { .compatible = "aspeed,ast2500-gpio", .data = &ast2500_config, },
- { .compatible = "aspeed,ast2600-gpio", .data = &ast2600_config, },
- { .compatible = "aspeed,ast2700-gpio", .data = &ast2700_config, },
- {}
+ { .compatible = "aspeed,ast2400-gpio", .data = &ast2400_config },
+ { .compatible = "aspeed,ast2500-gpio", .data = &ast2500_config },
+ { .compatible = "aspeed,ast2600-gpio", .data = &ast2600_config },
+ { .compatible = "aspeed,ast2700-gpio", .data = &ast2700_config },
+ { }
};
MODULE_DEVICE_TABLE(of, aspeed_gpio_of_table);
diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index aa37579c9608..5270f9121749 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -210,7 +210,7 @@ static void ath79_gpio_irq_handler(struct irq_desc *desc)
static const struct of_device_id ath79_gpio_of_match[] = {
{ .compatible = "qca,ar7100-gpio" },
{ .compatible = "qca,ar9340-gpio" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, ath79_gpio_of_match);
diff --git a/drivers/gpio/gpio-blzp1600.c b/drivers/gpio/gpio-blzp1600.c
index 0f8c826ba876..ddb50f02224f 100644
--- a/drivers/gpio/gpio-blzp1600.c
+++ b/drivers/gpio/gpio-blzp1600.c
@@ -270,7 +270,7 @@ static int blzp1600_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id blzp1600_gpio_of_match[] = {
- { .compatible = "blaize,blzp1600-gpio", },
+ { .compatible = "blaize,blzp1600-gpio" },
{ /* Sentinel */ },
};
MODULE_DEVICE_TABLE(of, blzp1600_gpio_of_match);
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index 44ca798cf832..60dec669ca67 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -787,7 +787,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
static const struct of_device_id brcmstb_gpio_of_match[] = {
{ .compatible = "brcm,brcmstb-gpio" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, brcmstb_gpio_of_match);
diff --git a/drivers/gpio/gpio-cadence.c b/drivers/gpio/gpio-cadence.c
index d7790fc35c22..1f275af8ecdb 100644
--- a/drivers/gpio/gpio-cadence.c
+++ b/drivers/gpio/gpio-cadence.c
@@ -170,11 +170,11 @@ static const struct irq_chip cdns_gpio_irqchip = {
static const struct of_device_id cdns_of_ids[] = {
{
.compatible = "axiado,ax3000-gpio",
- .data = &ax3000_gpio_quirks
+ .data = &ax3000_gpio_quirks,
},
{
.compatible = "cdns,gpio-r1p02",
- .data = &cdns_default_quirks
+ .data = &cdns_default_quirks,
},
{ /* sentinel */ },
};
diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
index 2e159ea41791..6834191d9294 100644
--- a/drivers/gpio/gpio-creg-snps.c
+++ b/drivers/gpio/gpio-creg-snps.c
@@ -125,10 +125,10 @@ static const struct creg_layout axs10x_flsh_cs_ctl = {
static const struct of_device_id creg_gpio_ids[] = {
{
.compatible = "snps,creg-gpio-axs10x",
- .data = &axs10x_flsh_cs_ctl
+ .data = &axs10x_flsh_cs_ctl,
}, {
.compatible = "snps,creg-gpio-hsdk",
- .data = &hsdk_cs_ctl
+ .data = &hsdk_cs_ctl,
}, { /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, creg_gpio_ids);
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 270cd7c88812..b7429d778856 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -668,9 +668,9 @@ static DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
davinci_gpio_resume);
static const struct of_device_id davinci_gpio_ids[] = {
- { .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
- { .compatible = "ti,am654-gpio", keystone_gpio_get_irq_chip},
- { .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip},
+ { .compatible = "ti,keystone-gpio", .data = keystone_gpio_get_irq_chip },
+ { .compatible = "ti,am654-gpio", .data = keystone_gpio_get_irq_chip },
+ { .compatible = "ti,dm6441-gpio", .data = davinci_gpio_get_irq_chip },
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, davinci_gpio_ids);
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index e159c3f98f1c..a5ecb73d8b31 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -713,8 +713,8 @@ static int dwapb_get_clks(struct dwapb_gpio *gpio)
}
static const struct of_device_id dwapb_of_match[] = {
- { .compatible = "snps,dw-apb-gpio", .data = (void *)GPIO_REG_OFFSET_V1},
- { .compatible = "apm,xgene-gpio-v2", .data = (void *)GPIO_REG_OFFSET_V2},
+ { .compatible = "snps,dw-apb-gpio", .data = (void *)GPIO_REG_OFFSET_V1 },
+ { .compatible = "apm,xgene-gpio-v2", .data = (void *)GPIO_REG_OFFSET_V2 },
{ /* Sentinel */ }
};
MODULE_DEVICE_TABLE(of, dwapb_of_match);
diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c
index a214b0672726..b660a0c7cfc8 100644
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@ -357,8 +357,8 @@ static int em_gio_probe(struct platform_device *pdev)
}
static const struct of_device_id em_gio_dt_ids[] = {
- { .compatible = "renesas,em-gio", },
- {},
+ { .compatible = "renesas,em-gio" },
+ { }
};
MODULE_DEVICE_TABLE(of, em_gio_dt_ids);
diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
index e29df8d5e571..da30e3d927b9 100644
--- a/drivers/gpio/gpio-ftgpio010.c
+++ b/drivers/gpio/gpio-ftgpio010.c
@@ -321,7 +321,7 @@ static const struct of_device_id ftgpio_gpio_of_match[] = {
{
.compatible = "faraday,ftgpio010",
},
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, ftgpio_gpio_of_match);
diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
index e4fa84e22726..fbbe201cce4c 100644
--- a/drivers/gpio/gpio-grgpio.c
+++ b/drivers/gpio/gpio-grgpio.c
@@ -444,7 +444,7 @@ static int grgpio_probe(struct platform_device *ofdev)
static const struct of_device_id grgpio_match[] = {
{.name = "GAISLER_GPIO"},
{.name = "01_01a"},
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, grgpio_match);
diff --git a/drivers/gpio/gpio-gw-pld.c b/drivers/gpio/gpio-gw-pld.c
index bf1f91c3c4a8..96a7e11ff667 100644
--- a/drivers/gpio/gpio-gw-pld.c
+++ b/drivers/gpio/gpio-gw-pld.c
@@ -115,8 +115,8 @@ static const struct i2c_device_id gw_pld_id[] = {
MODULE_DEVICE_TABLE(i2c, gw_pld_id);
static const struct of_device_id gw_pld_dt_ids[] = {
- { .compatible = "gateworks,pld-gpio", },
- { },
+ { .compatible = "gateworks,pld-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, gw_pld_dt_ids);
diff --git a/drivers/gpio/gpio-hisi.c b/drivers/gpio/gpio-hisi.c
index f03df71e3296..b75b52607711 100644
--- a/drivers/gpio/gpio-hisi.c
+++ b/drivers/gpio/gpio-hisi.c
@@ -228,7 +228,7 @@ static const struct acpi_device_id hisi_gpio_acpi_match[] = {
MODULE_DEVICE_TABLE(acpi, hisi_gpio_acpi_match);
static const struct of_device_id hisi_gpio_dts_match[] = {
- { .compatible = "hisilicon,ascend910-gpio", },
+ { .compatible = "hisilicon,ascend910-gpio" },
{ }
};
MODULE_DEVICE_TABLE(of, hisi_gpio_dts_match);
diff --git a/drivers/gpio/gpio-hlwd.c b/drivers/gpio/gpio-hlwd.c
index 043ce5ef3b07..663a8d05719a 100644
--- a/drivers/gpio/gpio-hlwd.c
+++ b/drivers/gpio/gpio-hlwd.c
@@ -303,8 +303,8 @@ static int hlwd_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id hlwd_gpio_match[] = {
- { .compatible = "nintendo,hollywood-gpio", },
- {},
+ { .compatible = "nintendo,hollywood-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, hlwd_gpio_match);
diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
index 88d48cfc9017..e791ba19928a 100644
--- a/drivers/gpio/gpio-ixp4xx.c
+++ b/drivers/gpio/gpio-ixp4xx.c
@@ -339,7 +339,7 @@ static const struct of_device_id ixp4xx_gpio_of_match[] = {
{
.compatible = "intel,ixp4xx-gpio",
},
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, ixp4xx_gpio_of_match);
diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
index d76c3cf177d1..edcff2fa8adc 100644
--- a/drivers/gpio/gpio-loongson-64bit.c
+++ b/drivers/gpio/gpio-loongson-64bit.c
@@ -519,7 +519,7 @@ static const struct of_device_id loongson_gpio_of_match[] = {
.compatible = "loongson,ls3a6000-gpio",
.data = &loongson_gpio_ls3a6000_data,
},
- {}
+ { }
};
MODULE_DEVICE_TABLE(of, loongson_gpio_of_match);
diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
index e8e00daff7df..ab84f83aec86 100644
--- a/drivers/gpio/gpio-lp3943.c
+++ b/drivers/gpio/gpio-lp3943.c
@@ -209,7 +209,7 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id lp3943_gpio_of_match[] = {
- { .compatible = "ti,lp3943-gpio", },
+ { .compatible = "ti,lp3943-gpio" },
{ }
};
MODULE_DEVICE_TABLE(of, lp3943_gpio_of_match);
diff --git a/drivers/gpio/gpio-lpc32xx.c b/drivers/gpio/gpio-lpc32xx.c
index 37fc54fc7385..2dde79e45aae 100644
--- a/drivers/gpio/gpio-lpc32xx.c
+++ b/drivers/gpio/gpio-lpc32xx.c
@@ -532,8 +532,8 @@ static int lpc32xx_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id lpc32xx_gpio_of_match[] = {
- { .compatible = "nxp,lpc3220-gpio", },
- { },
+ { .compatible = "nxp,lpc3220-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, lpc32xx_gpio_of_match);
diff --git a/drivers/gpio/gpio-macsmc.c b/drivers/gpio/gpio-macsmc.c
index b0952d066a9d..4afc73da2bee 100644
--- a/drivers/gpio/gpio-macsmc.c
+++ b/drivers/gpio/gpio-macsmc.c
@@ -274,8 +274,8 @@ static int macsmc_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id macsmc_gpio_of_table[] = {
- { .compatible = "apple,smc-gpio", },
- {}
+ { .compatible = "apple,smc-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, macsmc_gpio_of_table);
diff --git a/drivers/gpio/gpio-max7360.c b/drivers/gpio/gpio-max7360.c
index d12cf1dc8d57..a5a8f89e6c71 100644
--- a/drivers/gpio/gpio-max7360.c
+++ b/drivers/gpio/gpio-max7360.c
@@ -232,12 +232,12 @@ static int max7360_gpio_probe(struct platform_device *pdev)
static const struct of_device_id max7360_gpio_of_match[] = {
{
.compatible = "maxim,max7360-gpo",
- .data = &max7360_gpio_col_plat
+ .data = &max7360_gpio_col_plat,
}, {
.compatible = "maxim,max7360-gpio",
- .data = &max7360_gpio_port_plat
- }, {
- }
+ .data = &max7360_gpio_port_plat,
+ },
+ { }
};
MODULE_DEVICE_TABLE(of, max7360_gpio_of_match);
diff --git a/drivers/gpio/gpio-max77759.c b/drivers/gpio/gpio-max77759.c
index da3c77dd574e..b2259d875751 100644
--- a/drivers/gpio/gpio-max77759.c
+++ b/drivers/gpio/gpio-max77759.c
@@ -495,7 +495,7 @@ static int max77759_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id max77759_gpio_of_id[] = {
- { .compatible = "maxim,max77759-gpio", },
+ { .compatible = "maxim,max77759-gpio" },
{ }
};
MODULE_DEVICE_TABLE(of, max77759_gpio_of_id);
diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c
index 1bd98c50a459..f48dc24151b1 100644
--- a/drivers/gpio/gpio-mm-lantiq.c
+++ b/drivers/gpio/gpio-mm-lantiq.c
@@ -134,7 +134,7 @@ static int ltq_mm_probe(struct platform_device *pdev)
static const struct of_device_id ltq_mm_match[] = {
{ .compatible = "lantiq,gpio-mm" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, ltq_mm_match);
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 1c6a2f3414f1..c26a97f8deac 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -487,8 +487,8 @@ static int gpio_mockup_probe(struct platform_device *pdev)
}
static const struct of_device_id gpio_mockup_of_match[] = {
- { .compatible = "gpio-mockup", },
- {},
+ { .compatible = "gpio-mockup" },
+ { }
};
MODULE_DEVICE_TABLE(of, gpio_mockup_of_match);
diff --git a/drivers/gpio/gpio-moxtet.c b/drivers/gpio/gpio-moxtet.c
index 4eb9f1a2779b..d87e9f4bd037 100644
--- a/drivers/gpio/gpio-moxtet.c
+++ b/drivers/gpio/gpio-moxtet.c
@@ -152,8 +152,8 @@ static int moxtet_gpio_probe(struct device *dev)
}
static const struct of_device_id moxtet_gpio_dt_ids[] = {
- { .compatible = "cznic,moxtet-gpio", },
- {},
+ { .compatible = "cznic,moxtet-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, moxtet_gpio_dt_ids);
diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c
index 2c828bc922ae..14f6b0d5ccfc 100644
--- a/drivers/gpio/gpio-mpc5200.c
+++ b/drivers/gpio/gpio-mpc5200.c
@@ -177,8 +177,8 @@ static int mpc52xx_wkup_gpiochip_probe(struct platform_device *ofdev)
}
static const struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
- { .compatible = "fsl,mpc5200-gpio-wkup", },
- {}
+ { .compatible = "fsl,mpc5200-gpio-wkup" },
+ { }
};
MODULE_DEVICE_TABLE(of, mpc52xx_wkup_gpiochip_match);
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index e79312a7d5a4..fb280d87c578 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -306,17 +306,17 @@ static const struct mpc8xxx_gpio_devtype mpc8xxx_gpio_devtype_default = {
};
static const struct of_device_id mpc8xxx_gpio_ids[] = {
- { .compatible = "fsl,mpc8314-gpio", },
- { .compatible = "fsl,mpc8349-gpio", },
- { .compatible = "fsl,mpc8572-gpio", .data = &mpc8572_gpio_devtype, },
- { .compatible = "fsl,mpc8610-gpio", },
- { .compatible = "fsl,mpc5121-gpio", .data = &mpc512x_gpio_devtype, },
- { .compatible = "fsl,mpc5125-gpio", .data = &mpc5125_gpio_devtype, },
- { .compatible = "fsl,pq3-gpio", },
- { .compatible = "fsl,ls1028a-gpio", },
- { .compatible = "fsl,ls1088a-gpio", },
- { .compatible = "fsl,qoriq-gpio", },
- {}
+ { .compatible = "fsl,mpc8314-gpio" },
+ { .compatible = "fsl,mpc8349-gpio" },
+ { .compatible = "fsl,mpc8572-gpio", .data = &mpc8572_gpio_devtype },
+ { .compatible = "fsl,mpc8610-gpio" },
+ { .compatible = "fsl,mpc5121-gpio", .data = &mpc512x_gpio_devtype },
+ { .compatible = "fsl,mpc5125-gpio", .data = &mpc5125_gpio_devtype },
+ { .compatible = "fsl,pq3-gpio" },
+ { .compatible = "fsl,ls1028a-gpio" },
+ { .compatible = "fsl,ls1088a-gpio" },
+ { .compatible = "fsl,qoriq-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, mpc8xxx_gpio_ids);
diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c
index 87086c322f08..7992167c0eb0 100644
--- a/drivers/gpio/gpio-mt7621.c
+++ b/drivers/gpio/gpio-mt7621.c
@@ -487,7 +487,7 @@ mt7621_gpio_probe(struct platform_device *pdev)
static const struct of_device_id mt7621_gpio_match[] = {
{ .compatible = "mediatek,mt7621-gpio" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, mt7621_gpio_match);
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 7e2690d92df6..671e43102d78 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -138,7 +138,7 @@ static struct mxc_gpio_hwdata imx35_gpio_hwdata = {
#define GPIO_INT_BOTH_EDGES 0x4
static const struct of_device_id mxc_gpio_dt_ids[] = {
- { .compatible = "fsl,imx1-gpio", .data = &imx1_imx21_gpio_hwdata },
+ { .compatible = "fsl,imx1-gpio", .data = &imx1_imx21_gpio_hwdata },
{ .compatible = "fsl,imx21-gpio", .data = &imx1_imx21_gpio_hwdata },
{ .compatible = "fsl,imx31-gpio", .data = &imx31_gpio_hwdata },
{ .compatible = "fsl,imx35-gpio", .data = &imx35_gpio_hwdata },
diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
index 5635694bf9f4..f2808fe8a3e8 100644
--- a/drivers/gpio/gpio-mxs.c
+++ b/drivers/gpio/gpio-mxs.c
@@ -250,8 +250,8 @@ static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
}
static const struct of_device_id mxs_gpio_dt_ids[] = {
- { .compatible = "fsl,imx23-gpio", .data = (void *) IMX23_GPIO, },
- { .compatible = "fsl,imx28-gpio", .data = (void *) IMX28_GPIO, },
+ { .compatible = "fsl,imx23-gpio", .data = (void *)IMX23_GPIO },
+ { .compatible = "fsl,imx28-gpio", .data = (void *)IMX28_GPIO },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, mxs_gpio_dt_ids);
diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
index 90293329b40b..32390bc00649 100644
--- a/drivers/gpio/gpio-nomadik.c
+++ b/drivers/gpio/gpio-nomadik.c
@@ -715,9 +715,9 @@ static int nmk_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id nmk_gpio_match[] = {
- { .compatible = "st,nomadik-gpio", },
- { .compatible = "mobileye,eyeq5-gpio", },
- {}
+ { .compatible = "st,nomadik-gpio" },
+ { .compatible = "mobileye,eyeq5-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, nmk_gpio_match);
diff --git a/drivers/gpio/gpio-npcm-sgpio.c b/drivers/gpio/gpio-npcm-sgpio.c
index 83c77a2c0623..99f57bcf2b9c 100644
--- a/drivers/gpio/gpio-npcm-sgpio.c
+++ b/drivers/gpio/gpio-npcm-sgpio.c
@@ -596,9 +596,9 @@ static const struct npcm_clk_cfg npcm845_sgpio_pdata = {
};
static const struct of_device_id npcm_sgpio_of_table[] = {
- { .compatible = "nuvoton,npcm750-sgpio", .data = &npcm750_sgpio_pdata, },
- { .compatible = "nuvoton,npcm845-sgpio", .data = &npcm845_sgpio_pdata, },
- {}
+ { .compatible = "nuvoton,npcm750-sgpio", .data = &npcm750_sgpio_pdata },
+ { .compatible = "nuvoton,npcm845-sgpio", .data = &npcm845_sgpio_pdata },
+ { }
};
MODULE_DEVICE_TABLE(of, npcm_sgpio_of_table);
diff --git a/drivers/gpio/gpio-octeon.c b/drivers/gpio/gpio-octeon.c
index 777e20c608dc..2854443226b7 100644
--- a/drivers/gpio/gpio-octeon.c
+++ b/drivers/gpio/gpio-octeon.c
@@ -121,7 +121,7 @@ static const struct of_device_id octeon_gpio_match[] = {
{
.compatible = "cavium,octeon-3860-gpio",
},
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, octeon_gpio_match);
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index e39723b5901b..015cf0f542ec 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1393,7 +1393,7 @@ static const struct of_device_id omap_gpio_match[] = {
.compatible = "ti,omap2-gpio",
.data = &omap2_pdata,
},
- { },
+ { }
};
MODULE_DEVICE_TABLE(of, omap_gpio_match);
diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c
index e64ee0487718..ebf2a29d8210 100644
--- a/drivers/gpio/gpio-palmas.c
+++ b/drivers/gpio/gpio-palmas.c
@@ -151,11 +151,11 @@ static const struct palmas_device_data tps80036_dev_data = {
};
static const struct of_device_id of_palmas_gpio_match[] = {
- { .compatible = "ti,palmas-gpio", .data = &palmas_dev_data,},
- { .compatible = "ti,tps65913-gpio", .data = &palmas_dev_data,},
- { .compatible = "ti,tps65914-gpio", .data = &palmas_dev_data,},
- { .compatible = "ti,tps80036-gpio", .data = &tps80036_dev_data,},
- { },
+ { .compatible = "ti,palmas-gpio", .data = &palmas_dev_data },
+ { .compatible = "ti,tps65913-gpio", .data = &palmas_dev_data },
+ { .compatible = "ti,tps65914-gpio", .data = &palmas_dev_data },
+ { .compatible = "ti,tps80036-gpio", .data = &tps80036_dev_data },
+ { }
};
MODULE_DEVICE_TABLE(of, of_palmas_gpio_match);
diff --git a/drivers/gpio/gpio-pca9570.c b/drivers/gpio/gpio-pca9570.c
index db027c10494f..8f4f97d723fd 100644
--- a/drivers/gpio/gpio-pca9570.c
+++ b/drivers/gpio/gpio-pca9570.c
@@ -171,7 +171,7 @@ static const struct i2c_device_id pca9570_id_table[] = {
MODULE_DEVICE_TABLE(i2c, pca9570_id_table);
static const struct of_device_id pca9570_of_match_table[] = {
- { .compatible = "dlg,slg7xl45106", .data = &slg7xl45106_gpio},
+ { .compatible = "dlg,slg7xl45106", .data = &slg7xl45106_gpio },
{ .compatible = "nxp,pca9570", .data = &pca9570_gpio },
{ .compatible = "nxp,pca9571", .data = &pca9571_gpio },
{ /* sentinel */ }
diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c
index 75a8f3efaf94..bb533070f46b 100644
--- a/drivers/gpio/gpio-pisosr.c
+++ b/drivers/gpio/gpio-pisosr.c
@@ -156,7 +156,7 @@ static const struct spi_device_id pisosr_gpio_id_table[] = {
MODULE_DEVICE_TABLE(spi, pisosr_gpio_id_table);
static const struct of_device_id pisosr_gpio_of_match_table[] = {
- { .compatible = "pisosr-gpio", },
+ { .compatible = "pisosr-gpio" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, pisosr_gpio_of_match_table);
diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
index cb015fb5c946..8012ca4299f6 100644
--- a/drivers/gpio/gpio-pmic-eic-sprd.c
+++ b/drivers/gpio/gpio-pmic-eic-sprd.c
@@ -362,7 +362,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
}
static const struct of_device_id sprd_pmic_eic_of_match[] = {
- { .compatible = "sprd,sc2731-eic", },
+ { .compatible = "sprd,sc2731-eic" },
{ /* end of list */ }
};
MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 7aaed5b30e7e..8bcbc76905a2 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -573,15 +573,15 @@ static const struct irq_domain_ops pxa_irq_domain_ops = {
#ifdef CONFIG_OF
static const struct of_device_id pxa_gpio_dt_ids[] = {
- { .compatible = "intel,pxa25x-gpio", .data = &pxa25x_id, },
- { .compatible = "intel,pxa26x-gpio", .data = &pxa26x_id, },
- { .compatible = "intel,pxa27x-gpio", .data = &pxa27x_id, },
- { .compatible = "intel,pxa3xx-gpio", .data = &pxa3xx_id, },
- { .compatible = "marvell,pxa93x-gpio", .data = &pxa93x_id, },
- { .compatible = "marvell,mmp-gpio", .data = &mmp_id, },
- { .compatible = "marvell,mmp2-gpio", .data = &mmp2_id, },
- { .compatible = "marvell,pxa1928-gpio", .data = &pxa1928_id, },
- {}
+ { .compatible = "intel,pxa25x-gpio", .data = &pxa25x_id },
+ { .compatible = "intel,pxa26x-gpio", .data = &pxa26x_id },
+ { .compatible = "intel,pxa27x-gpio", .data = &pxa27x_id },
+ { .compatible = "intel,pxa3xx-gpio", .data = &pxa3xx_id },
+ { .compatible = "marvell,pxa93x-gpio", .data = &pxa93x_id },
+ { .compatible = "marvell,mmp-gpio", .data = &mmp_id },
+ { .compatible = "marvell,mmp2-gpio", .data = &mmp2_id },
+ { .compatible = "marvell,pxa1928-gpio", .data = &pxa1928_id },
+ { }
};
MODULE_DEVICE_TABLE(of, pxa_gpio_dt_ids);
diff --git a/drivers/gpio/gpio-qixis-fpga.c b/drivers/gpio/gpio-qixis-fpga.c
index b590572ac2bd..00bef538f94f 100644
--- a/drivers/gpio/gpio-qixis-fpga.c
+++ b/drivers/gpio/gpio-qixis-fpga.c
@@ -91,8 +91,7 @@ static const struct of_device_id qixis_cpld_gpio_of_match[] = {
.compatible = "fsl,ls1046aqds-fpga-gpio-stat-pres2",
.data = &ls1046aqds_stat_pres2_cfg,
},
-
- {}
+ { }
};
MODULE_DEVICE_TABLE(of, qixis_cpld_gpio_of_match);
diff --git a/drivers/gpio/gpio-rda.c b/drivers/gpio/gpio-rda.c
index 7bbc6f0ce4c8..c9aaf2ae6f12 100644
--- a/drivers/gpio/gpio-rda.c
+++ b/drivers/gpio/gpio-rda.c
@@ -280,7 +280,7 @@ static int rda_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id rda_gpio_of_match[] = {
- { .compatible = "rda,8810pl-gpio", },
+ { .compatible = "rda,8810pl-gpio" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, rda_gpio_of_match);
diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
index 4a606bad5848..b54e5fe9af88 100644
--- a/drivers/gpio/gpio-realtek-otto.c
+++ b/drivers/gpio/gpio-realtek-otto.c
@@ -356,7 +356,7 @@ static const struct of_device_id realtek_gpio_of_match[] = {
.compatible = "realtek,rtl9607-gpio",
.data = (void *)GPIO_PORTS_REVERSED,
},
- {}
+ { }
};
MODULE_DEVICE_TABLE(of, realtek_gpio_of_match);
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index 77b239a9a601..0f46ff095a24 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -806,9 +806,9 @@ static void rockchip_gpio_remove(struct platform_device *pdev)
}
static const struct of_device_id rockchip_gpio_match[] = {
- { .compatible = "rockchip,gpio-bank", },
+ { .compatible = "rockchip,gpio-bank" },
{ .compatible = "rockchip,rk3188-gpio-bank0" },
- { },
+ { }
};
static struct platform_driver rockchip_gpio_driver = {
diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c
index 5005688f6e67..ab8655e9a518 100644
--- a/drivers/gpio/gpio-sama5d2-piobu.c
+++ b/drivers/gpio/gpio-sama5d2-piobu.c
@@ -228,7 +228,7 @@ static int sama5d2_piobu_probe(struct platform_device *pdev)
static const struct of_device_id sama5d2_piobu_ids[] = {
{ .compatible = "atmel,sama5d2-secumod" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, sama5d2_piobu_ids);
diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
index e9a992cd4b9c..5b719b9f7650 100644
--- a/drivers/gpio/gpio-sifive.c
+++ b/drivers/gpio/gpio-sifive.c
@@ -258,7 +258,7 @@ static int sifive_gpio_probe(struct platform_device *pdev)
static const struct of_device_id sifive_gpio_match[] = {
{ .compatible = "sifive,gpio0" },
{ .compatible = "sifive,fu540-c000-gpio" },
- { },
+ { }
};
MODULE_DEVICE_TABLE(of, sifive_gpio_match);
diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c
index ca7a9b9bcf48..ac9cf23a865f 100644
--- a/drivers/gpio/gpio-sl28cpld.c
+++ b/drivers/gpio/gpio-sl28cpld.c
@@ -141,7 +141,7 @@ static const struct of_device_id sl28cpld_gpio_of_match[] = {
{ .compatible = "kontron,sl28cpld-gpio", .data = (void *)SL28CPLD_GPIO },
{ .compatible = "kontron,sl28cpld-gpi", .data = (void *)SL28CPLD_GPI },
{ .compatible = "kontron,sl28cpld-gpo", .data = (void *)SL28CPLD_GPO },
- {}
+ { }
};
MODULE_DEVICE_TABLE(of, sl28cpld_gpio_of_match);
diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
index 3099deb2b290..6df67b6bdf34 100644
--- a/drivers/gpio/gpio-spear-spics.c
+++ b/drivers/gpio/gpio-spear-spics.c
@@ -155,7 +155,7 @@ static int spics_gpio_probe(struct platform_device *pdev)
static const struct of_device_id spics_gpio_of_match[] = {
{ .compatible = "st,spear-spics-gpio" },
- {}
+ { }
};
MODULE_DEVICE_TABLE(of, spics_gpio_of_match);
diff --git a/drivers/gpio/gpio-sprd.c b/drivers/gpio/gpio-sprd.c
index 042a83f60eaa..7ddbe0eb500d 100644
--- a/drivers/gpio/gpio-sprd.c
+++ b/drivers/gpio/gpio-sprd.c
@@ -261,7 +261,7 @@ static int sprd_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id sprd_gpio_of_match[] = {
- { .compatible = "sprd,sc9860-gpio", },
+ { .compatible = "sprd,sc9860-gpio" },
{ /* end of list */ }
};
MODULE_DEVICE_TABLE(of, sprd_gpio_of_match);
diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
index 6faf30347a36..e88cc6ff9ec0 100644
--- a/drivers/gpio/gpio-stmpe.c
+++ b/drivers/gpio/gpio-stmpe.c
@@ -533,7 +533,7 @@ static int stmpe_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id stmpe_gpio_of_matches[] = {
- { .compatible = "st,stmpe-gpio", },
+ { .compatible = "st,stmpe-gpio" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, stmpe_gpio_of_matches);
diff --git a/drivers/gpio/gpio-stp-xway.c b/drivers/gpio/gpio-stp-xway.c
index 78d6c78d4aab..37c480c1f031 100644
--- a/drivers/gpio/gpio-stp-xway.c
+++ b/drivers/gpio/gpio-stp-xway.c
@@ -315,7 +315,7 @@ static int xway_stp_probe(struct platform_device *pdev)
static const struct of_device_id xway_stp_match[] = {
{ .compatible = "lantiq,gpio-stp-xway" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, xway_stp_match);
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index fa6c8ee92093..d42b644000b2 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -669,7 +669,7 @@ static const struct dev_pm_ops tegra_gpio_pm_ops = {
};
static const struct of_device_id tegra_pmc_of_match[] = {
- { .compatible = "nvidia,tegra210-pmc", },
+ { .compatible = "nvidia,tegra210-pmc" },
{ /* sentinel */ },
};
diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c
index bf85663349fb..79e13adeb21e 100644
--- a/drivers/gpio/gpio-tps65218.c
+++ b/drivers/gpio/gpio-tps65218.c
@@ -196,7 +196,7 @@ static int tps65218_gpio_probe(struct platform_device *pdev)
static const struct of_device_id tps65218_dt_match[] = {
{ .compatible = "ti,tps65218-gpio" },
- { }
+ { }
};
MODULE_DEVICE_TABLE(of, tps65218_dt_match);
diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
index 0207c2b813f4..a67f6808ea16 100644
--- a/drivers/gpio/gpio-ts4800.c
+++ b/drivers/gpio/gpio-ts4800.c
@@ -48,8 +48,8 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id ts4800_gpio_of_match[] = {
- { .compatible = "technologic,ts4800-gpio", },
- {},
+ { .compatible = "technologic,ts4800-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, ts4800_gpio_of_match);
diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c
index a851702befde..d61bf331395d 100644
--- a/drivers/gpio/gpio-twl4030.c
+++ b/drivers/gpio/gpio-twl4030.c
@@ -604,8 +604,8 @@ static int gpio_twl4030_probe(struct platform_device *pdev)
}
static const struct of_device_id twl_gpio_match[] = {
- { .compatible = "ti,twl4030-gpio", },
- { },
+ { .compatible = "ti,twl4030-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, twl_gpio_match);
diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index adfa2c2d5873..0b67194de573 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -79,8 +79,8 @@ static const struct fsl_gpio_soc_data imx8ulp_data = {
static const struct of_device_id vf610_gpio_dt_ids[] = {
{ .compatible = "fsl,vf610-gpio", .data = &vf610_data },
- { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data, },
- { .compatible = "fsl,imx8ulp-gpio", .data = &imx8ulp_data, },
+ { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data },
+ { .compatible = "fsl,imx8ulp-gpio", .data = &imx8ulp_data },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, vf610_gpio_dt_ids);
diff --git a/drivers/gpio/gpio-visconti.c b/drivers/gpio/gpio-visconti.c
index 6d5d829634ad..59e57b8e8604 100644
--- a/drivers/gpio/gpio-visconti.c
+++ b/drivers/gpio/gpio-visconti.c
@@ -219,7 +219,7 @@ static int visconti_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id visconti_gpio_of_match[] = {
- { .compatible = "toshiba,gpio-tmpv7708", },
+ { .compatible = "toshiba,gpio-tmpv7708" },
{ /* end of table */ }
};
MODULE_DEVICE_TABLE(of, visconti_gpio_of_match);
diff --git a/drivers/gpio/gpio-waveshare-dsi.c b/drivers/gpio/gpio-waveshare-dsi.c
index 38f52351bb58..bb862f450140 100644
--- a/drivers/gpio/gpio-waveshare-dsi.c
+++ b/drivers/gpio/gpio-waveshare-dsi.c
@@ -190,7 +190,7 @@ static int waveshare_gpio_probe(struct i2c_client *i2c)
static const struct of_device_id waveshare_gpio_dt_ids[] = {
{ .compatible = "waveshare,dsi-touch-gpio" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, waveshare_gpio_dt_ids);
diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c
index 30b6e9f3f8ba..b1e0008679d0 100644
--- a/drivers/gpio/gpio-xgene-sb.c
+++ b/drivers/gpio/gpio-xgene-sb.c
@@ -334,7 +334,7 @@ static void xgene_gpio_sb_remove(struct platform_device *pdev)
static const struct of_device_id xgene_gpio_sb_of_match[] = {
{ .compatible = "apm,xgene-gpio-sb" },
- {}
+ { }
};
MODULE_DEVICE_TABLE(of, xgene_gpio_sb_of_match);
diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c
index f4adf2962557..2aa0432dab7f 100644
--- a/drivers/gpio/gpio-xgene.c
+++ b/drivers/gpio/gpio-xgene.c
@@ -188,8 +188,8 @@ static int xgene_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id xgene_gpio_of_match[] = {
- { .compatible = "apm,xgene-gpio", },
- {},
+ { .compatible = "apm,xgene-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, xgene_gpio_of_match);
diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
index 77eb29dcc217..211e64b793a6 100644
--- a/drivers/gpio/gpio-xgs-iproc.c
+++ b/drivers/gpio/gpio-xgs-iproc.c
@@ -310,7 +310,7 @@ static void iproc_gpio_remove(struct platform_device *pdev)
static const struct of_device_id bcm_iproc_gpio_of_match[] = {
{ .compatible = "brcm,iproc-gpio-cca" },
- {}
+ { }
};
MODULE_DEVICE_TABLE(of, bcm_iproc_gpio_of_match);
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 532205175827..7a03a7301540 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -667,7 +667,7 @@ static int xgpio_probe(struct platform_device *pdev)
}
static const struct of_device_id xgpio_of_match[] = {
- { .compatible = "xlnx,xps-gpio-1.00.a", },
+ { .compatible = "xlnx,xps-gpio-1.00.a" },
{ /* end of list */ },
};
diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c
index 3713475bdb75..03c216d6d03f 100644
--- a/drivers/gpio/gpio-xra1403.c
+++ b/drivers/gpio/gpio-xra1403.c
@@ -192,7 +192,7 @@ MODULE_DEVICE_TABLE(spi, xra1403_ids);
static const struct of_device_id xra1403_spi_of_match[] = {
{ .compatible = "exar,xra1403" },
- {},
+ { }
};
MODULE_DEVICE_TABLE(of, xra1403_spi_of_match);
diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
index f1c5c6a20673..78c6988b5027 100644
--- a/drivers/gpio/gpio-zevio.c
+++ b/drivers/gpio/gpio-zevio.c
@@ -210,8 +210,8 @@ static int zevio_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id zevio_gpio_of_match[] = {
- { .compatible = "lsi,zevio-gpio", },
- { },
+ { .compatible = "lsi,zevio-gpio" },
+ { }
};
MODULE_DEVICE_TABLE(of, zevio_gpio_of_match);
diff --git a/drivers/gpio/gpio-zynqmp-modepin.c b/drivers/gpio/gpio-zynqmp-modepin.c
index 5e651482e985..dcf41101a1e6 100644
--- a/drivers/gpio/gpio-zynqmp-modepin.c
+++ b/drivers/gpio/gpio-zynqmp-modepin.c
@@ -145,7 +145,7 @@ static int modepin_gpio_probe(struct platform_device *pdev)
}
static const struct of_device_id modepin_platform_id[] = {
- { .compatible = "xlnx,zynqmp-gpio-modepin", },
+ { .compatible = "xlnx,zynqmp-gpio-modepin" },
{ }
};
MODULE_DEVICE_TABLE(of, modepin_platform_id);
--
2.55.0.11.g153666a7d9bb
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 07/20] gpio: Add missing OF module annotations
2026-07-14 7:24 ` [PATCH v1 07/20] gpio: Add missing OF module annotations Uwe Kleine-König (The Capable Hub)
@ 2026-07-14 7:34 ` sashiko-bot
2026-07-14 8:09 ` Uwe Kleine-König (The Capable Hub)
0 siblings, 1 reply; 5+ messages in thread
From: sashiko-bot @ 2026-07-14 7:34 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub); +Cc: Frank.Li, imx
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missing MODULE_DEVICE_TABLE export for the mpc52xx_simple_gpiochip_match table.
--
--- Patch [7]: [PATCH v1 07/20] gpio: Add missing OF module annotations ---
commit 292bbbdcede3ce86fe1309d514a852f272c27bac
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
gpio: Add missing OF module annotations
A driver module matching devices using an of device id table is supposed
to declare that in the module's metadata. Add this information for
several drivers that failed to declare these.
[ ... ]
> diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c
> index 00f209157fd0f..2c828bc922ae3 100644
> --- a/drivers/gpio/gpio-mpc5200.c
> +++ b/drivers/gpio/gpio-mpc5200.c
> @@ -180,6 +180,7 @@ static const struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
> { .compatible = "fsl,mpc5200-gpio-wkup", },
> {}
> };
> +MODULE_DEVICE_TABLE(of, mpc52xx_wkup_gpiochip_match);
>
> static struct platform_driver mpc52xx_wkup_gpiochip_driver = {
> .driver = {
[Severity: High]
This isn't a bug introduced by this patch, but since the patch focuses on
adding missing OF module annotations, should it also add one for the second
match table in this same file?
Further down in drivers/gpio/gpio-mpc5200.c, mpc52xx_simple_gpiochip_match
is also missing an export:
static const struct of_device_id mpc52xx_simple_gpiochip_match[] = {
{ .compatible = "fsl,mpc5200-gpio", },
{}
};
static struct platform_driver mpc52xx_simple_gpiochip_driver = {
.driver = {
.name = "mpc5200-gpio",
.of_match_table = mpc52xx_simple_gpiochip_match,
...
Without exporting this second match table, the module lacks the modalias for
"fsl,mpc5200-gpio". Could this prevent it from automatically loading if the
system's device tree only contains the simple GPIO node (such as when the
wakeup node is absent or disabled)?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784013063.git.u.kleine-koenig@baylibre.com?part=7
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 07/20] gpio: Add missing OF module annotations
2026-07-14 7:34 ` sashiko-bot
@ 2026-07-14 8:09 ` Uwe Kleine-König (The Capable Hub)
0 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-14 8:09 UTC (permalink / raw)
To: sashiko-reviews; +Cc: Frank.Li, imx
[-- Attachment #1: Type: text/plain, Size: 1772 bytes --]
Hello,
On Tue, Jul 14, 2026 at 07:34:25AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] Missing MODULE_DEVICE_TABLE export for the mpc52xx_simple_gpiochip_match table.
> --
>
> --- Patch [7]: [PATCH v1 07/20] gpio: Add missing OF module annotations ---
> commit 292bbbdcede3ce86fe1309d514a852f272c27bac
> Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
>
> gpio: Add missing OF module annotations
>
> A driver module matching devices using an of device id table is supposed
> to declare that in the module's metadata. Add this information for
> several drivers that failed to declare these.
>
> [ ... ]
>
> > diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c
> > index 00f209157fd0f..2c828bc922ae3 100644
> > --- a/drivers/gpio/gpio-mpc5200.c
> > +++ b/drivers/gpio/gpio-mpc5200.c
> > @@ -180,6 +180,7 @@ static const struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
> > { .compatible = "fsl,mpc5200-gpio-wkup", },
> > {}
> > };
> > +MODULE_DEVICE_TABLE(of, mpc52xx_wkup_gpiochip_match);
> >
> > static struct platform_driver mpc52xx_wkup_gpiochip_driver = {
> > .driver = {
>
> [Severity: High]
> This isn't a bug introduced by this patch, but since the patch focuses on
> adding missing OF module annotations, should it also add one for the second
> match table in this same file?
Ah, this is snaky, there are two drivers in that file and thus two
of_device_id arrays. My script only handles the first, so the style fixes
are missing here, too.
I will wait a bit for further review and then address this in a v2.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-07-14 8:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-14 7:24 [PATCH v1 00/20] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-07-14 7:24 ` [PATCH v1 07/20] gpio: Add missing OF module annotations Uwe Kleine-König (The Capable Hub)
2026-07-14 7:34 ` sashiko-bot
2026-07-14 8:09 ` Uwe Kleine-König (The Capable Hub)
2026-07-14 7:24 ` [PATCH v1 16/20] gpio: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox