Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "Harrison, John C" <john.c.harrison@intel.com>,
	"Intel-GFX@Lists.FreeDesktop.Org"
	<Intel-GFX@Lists.FreeDesktop.Org>
Cc: "DRI-Devel@Lists.FreeDesktop.Org" <DRI-Devel@Lists.FreeDesktop.Org>
Subject: Re: [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers
Date: Fri, 17 Feb 2023 08:39:01 +0000	[thread overview]
Message-ID: <03de3c68458fd5c44e9fe1d4bba4687ea49c4788.camel@intel.com> (raw)
In-Reply-To: <20230216011101.1909009-1-John.C.Harrison@Intel.com>

On Wed, 2023-02-15 at 17:10 -0800, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
> 
> Instruction from hardware arch is that stolen memory and BAR mappings
> are unsafe for use as ring buffers. There can be issues with cache
> aliasing due to the CPU access going to memory via the BAR. So, don't
> do it.

Tested these patches for GPU Hang I was debugging. Seem to fix that one
as well:

Tested-by: Jouni Högander <jouni.hogander@intel.com>

> 
> v2: Dont use BAR mappings either.
> Make conditional on LLC so as not to change platforms that don't need
> to change (Daniele).
> Add 'Fixes' tags (Tvrtko).
> v3: Fix dumb typo.
> 
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> 
> 
> John Harrison (2):
>   drm/i915: Don't use stolen memory for ring buffers with LLC
>   drm/i915: Don't use BAR mappings for ring buffers with LLC
> 
>  drivers/gpu/drm/i915/gt/intel_ring.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 


  parent reply	other threads:[~2023-02-17  8:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
2023-02-16  1:11 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Don't use stolen memory for ring buffers with LLC John.C.Harrison
2023-02-17 15:41   ` Ceraolo Spurio, Daniele
2023-02-16  1:11 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Don't use BAR mappings " John.C.Harrison
2023-02-17 15:50   ` Ceraolo Spurio, Daniele
2023-02-16  2:04 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Don't use stolen memory or BAR mappings for ring buffers Patchwork
2023-02-16 19:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Don't use stolen memory or BAR mappings for ring buffers (rev2) Patchwork
2023-02-17  7:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-17  8:39 ` Hogander, Jouni [this message]
2023-02-17 17:18   ` [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John Harrison
2023-02-20  6:50     ` Hogander, Jouni
2023-02-20  8:39 ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03de3c68458fd5c44e9fe1d4bba4687ea49c4788.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=DRI-Devel@Lists.FreeDesktop.Org \
    --cc=Intel-GFX@Lists.FreeDesktop.Org \
    --cc=john.c.harrison@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox