* [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers
@ 2023-02-16 1:10 John.C.Harrison
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Don't use stolen memory for ring buffers with LLC John.C.Harrison
` (6 more replies)
0 siblings, 7 replies; 12+ messages in thread
From: John.C.Harrison @ 2023-02-16 1:10 UTC (permalink / raw)
To: Intel-GFX; +Cc: DRI-Devel
From: John Harrison <John.C.Harrison@Intel.com>
Instruction from hardware arch is that stolen memory and BAR mappings
are unsafe for use as ring buffers. There can be issues with cache
aliasing due to the CPU access going to memory via the BAR. So, don't
do it.
v2: Dont use BAR mappings either.
Make conditional on LLC so as not to change platforms that don't need
to change (Daniele).
Add 'Fixes' tags (Tvrtko).
v3: Fix dumb typo.
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
John Harrison (2):
drm/i915: Don't use stolen memory for ring buffers with LLC
drm/i915: Don't use BAR mappings for ring buffers with LLC
drivers/gpu/drm/i915/gt/intel_ring.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.39.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v3 1/2] drm/i915: Don't use stolen memory for ring buffers with LLC
2023-02-16 1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
@ 2023-02-16 1:11 ` John.C.Harrison
2023-02-17 15:41 ` Ceraolo Spurio, Daniele
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Don't use BAR mappings " John.C.Harrison
` (5 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: John.C.Harrison @ 2023-02-16 1:11 UTC (permalink / raw)
To: Intel-GFX; +Cc: intel-gfx, Chris Wilson, DRI-Devel, Rodrigo Vivi, stable
From: John Harrison <John.C.Harrison@Intel.com>
Direction from hardware is that stolen memory should never be used for
ring buffer allocations on platforms with LLC. There are too many
caching pitfalls due to the way stolen memory accesses are routed. So
it is safest to just not use it.
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Fixes: c58b735fc762 ("drm/i915: Allocate rings from stolen")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v4.9+
---
drivers/gpu/drm/i915/gt/intel_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c
index 15ec64d881c44..fb1d2595392ed 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring.c
@@ -116,7 +116,7 @@ static struct i915_vma *create_ring_vma(struct i915_ggtt *ggtt, int size)
obj = i915_gem_object_create_lmem(i915, size, I915_BO_ALLOC_VOLATILE |
I915_BO_ALLOC_PM_VOLATILE);
- if (IS_ERR(obj) && i915_ggtt_has_aperture(ggtt))
+ if (IS_ERR(obj) && i915_ggtt_has_aperture(ggtt) && !HAS_LLC(i915))
obj = i915_gem_object_create_stolen(i915, size);
if (IS_ERR(obj))
obj = i915_gem_object_create_internal(i915, size);
--
2.39.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v3 2/2] drm/i915: Don't use BAR mappings for ring buffers with LLC
2023-02-16 1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Don't use stolen memory for ring buffers with LLC John.C.Harrison
@ 2023-02-16 1:11 ` John.C.Harrison
2023-02-17 15:50 ` Ceraolo Spurio, Daniele
2023-02-16 2:04 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Don't use stolen memory or BAR mappings for ring buffers Patchwork
` (4 subsequent siblings)
6 siblings, 1 reply; 12+ messages in thread
From: John.C.Harrison @ 2023-02-16 1:11 UTC (permalink / raw)
To: Intel-GFX; +Cc: intel-gfx, Chris Wilson, DRI-Devel, Rodrigo Vivi, stable
From: John Harrison <John.C.Harrison@Intel.com>
Direction from hardware is that ring buffers should never be mapped
via the BAR on systems with LLC. There are too many caching pitfalls
due to the way BAR accesses are routed. So it is safest to just not
use it.
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Fixes: 9d80841ea4c9 ("drm/i915: Allow ringbuffers to be bound anywhere")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v4.9+
---
drivers/gpu/drm/i915/gt/intel_ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c
index fb1d2595392ed..fb99143be98e7 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring.c
@@ -53,7 +53,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww)
if (unlikely(ret))
goto err_unpin;
- if (i915_vma_is_map_and_fenceable(vma)) {
+ if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) {
addr = (void __force *)i915_vma_pin_iomap(vma);
} else {
int type = i915_coherent_map_type(vma->vm->i915, vma->obj, false);
@@ -98,7 +98,7 @@ void intel_ring_unpin(struct intel_ring *ring)
return;
i915_vma_unset_ggtt_write(vma);
- if (i915_vma_is_map_and_fenceable(vma))
+ if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915))
i915_vma_unpin_iomap(vma);
else
i915_gem_object_unpin_map(vma->obj);
--
2.39.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for Don't use stolen memory or BAR mappings for ring buffers
2023-02-16 1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Don't use stolen memory for ring buffers with LLC John.C.Harrison
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Don't use BAR mappings " John.C.Harrison
@ 2023-02-16 2:04 ` Patchwork
2023-02-16 19:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Don't use stolen memory or BAR mappings for ring buffers (rev2) Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-16 2:04 UTC (permalink / raw)
To: john.c.harrison; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5158 bytes --]
== Series Details ==
Series: Don't use stolen memory or BAR mappings for ring buffers
URL : https://patchwork.freedesktop.org/series/114080/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12746 -> Patchwork_114080v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_114080v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_114080v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114080v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hugepages:
- fi-bsw-n3050: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/fi-bsw-n3050/igt@i915_selftest@live@hugepages.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/fi-bsw-n3050/igt@i915_selftest@live@hugepages.html
Known issues
------------
Here are the changes found in Patchwork_114080v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][3] -> [FAIL][4] ([i915#7229])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-blb-e6850: NOTRUN -> [SKIP][5] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/fi-blb-e6850/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-n3050: [PASS][6] -> [FAIL][7] ([i915#6298])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {bat-dg2-11}: [ABORT][8] ([i915#7913] / [i915#7979]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@migrate:
- {bat-adlp-6}: [DMESG-FAIL][10] ([i915#7699]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/bat-adlp-6/igt@i915_selftest@live@migrate.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/bat-adlp-6/igt@i915_selftest@live@migrate.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-blb-e6850: [ABORT][12] -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12746/fi-blb-e6850/igt@i915_suspend@basic-s2idle-without-i915.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/fi-blb-e6850/igt@i915_suspend@basic-s2idle-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
Build changes
-------------
* Linux: CI_DRM_12746 -> Patchwork_114080v1
CI-20190529: 20190529
CI_DRM_12746: 6ce36b596fa77ffb513126191268bc3637c96413 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114080v1: 6ce36b596fa77ffb513126191268bc3637c96413 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
252fc1d0fef7 drm/i915: Don't use BAR mappings for ring buffers with LLC
34ac5b5bb7c9 drm/i915: Don't use stolen memory for ring buffers with LLC
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v1/index.html
[-- Attachment #2: Type: text/html, Size: 5624 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Don't use stolen memory or BAR mappings for ring buffers (rev2)
2023-02-16 1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
` (2 preceding siblings ...)
2023-02-16 2:04 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Don't use stolen memory or BAR mappings for ring buffers Patchwork
@ 2023-02-16 19:10 ` Patchwork
2023-02-17 7:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-16 19:10 UTC (permalink / raw)
To: john.c.harrison; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9539 bytes --]
== Series Details ==
Series: Don't use stolen memory or BAR mappings for ring buffers (rev2)
URL : https://patchwork.freedesktop.org/series/114080/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12751 -> Patchwork_114080v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/index.html
Participating hosts (38 -> 38)
------------------------------
Additional (2): bat-atsm-1 fi-pnv-d510
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_114080v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@eof:
- bat-atsm-1: NOTRUN -> [SKIP][1] ([i915#2582]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@fbdev@eof.html
* igt@gem_mmap@basic:
- bat-atsm-1: NOTRUN -> [SKIP][2] ([i915#4083])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@gem_mmap@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-atsm-1: NOTRUN -> [SKIP][3] ([i915#4077]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-atsm-1: NOTRUN -> [SKIP][4] ([i915#4079]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rpm@basic-rte:
- bat-adlp-6: [PASS][5] -> [ABORT][6] ([i915#7977])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/bat-adlp-6/igt@i915_pm_rpm@basic-rte.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-adlp-6/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rps@basic-api:
- bat-atsm-1: NOTRUN -> [SKIP][7] ([i915#6621])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-skl-guc: [PASS][8] -> [DMESG-FAIL][9] ([i915#5334])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/fi-skl-guc/igt@i915_selftest@live@gt_heartbeat.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/fi-skl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [PASS][10] -> [DMESG-FAIL][11] ([i915#4258])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][12] ([i915#6367])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][13] ([i915#6645])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@size-max:
- bat-atsm-1: NOTRUN -> [SKIP][14] ([i915#6077]) +36 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@kms_addfb_basic@size-max.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-2: NOTRUN -> [SKIP][15] ([i915#7828])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-flip-after-cursor:
- bat-atsm-1: NOTRUN -> [SKIP][16] ([i915#6078]) +14 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor.html
* igt@kms_flip@basic-plain-flip:
- bat-atsm-1: NOTRUN -> [SKIP][17] ([i915#6166]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@kms_flip@basic-plain-flip.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-atsm-1: NOTRUN -> [SKIP][18] ([i915#6093]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@hang-read-crc:
- bat-atsm-1: NOTRUN -> [SKIP][19] ([i915#1836]) +6 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@kms_pipe_crc_basic@hang-read-crc.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-2: NOTRUN -> [SKIP][20] ([i915#1845])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@kms_prop_blob@basic:
- bat-atsm-1: NOTRUN -> [SKIP][21] ([i915#7357])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@kms_prop_blob@basic.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][22] ([fdo#109271]) +44 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-atsm-1: NOTRUN -> [SKIP][23] ([i915#1072]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-atsm-1: NOTRUN -> [SKIP][24] ([i915#6094])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-atsm-1: NOTRUN -> [SKIP][25] ([fdo#109295] / [i915#6078])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-atsm-1: NOTRUN -> [SKIP][26] ([fdo#109295] / [i915#4077]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-write:
- bat-atsm-1: NOTRUN -> [SKIP][27] ([fdo#109295]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-atsm-1/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][28] ([i915#4983]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/bat-rpls-2/igt@i915_selftest@live@reset.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][30] ([i915#6367] / [i915#7996]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/bat-rpls-1/igt@i915_selftest@live@slpc.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/bat-rpls-1/igt@i915_selftest@live@slpc.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_12751 -> Patchwork_114080v2
CI-20190529: 20190529
CI_DRM_12751: b6ba15d59cdc7e7d488646370f9ca6b0a36f9db5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7161: 5574f110ae838031eef6db5236bad02e8c2d2dee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114080v2: b6ba15d59cdc7e7d488646370f9ca6b0a36f9db5 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
88573c299fbc drm/i915: Don't use BAR mappings for ring buffers with LLC
d3fea17516ce drm/i915: Don't use stolen memory for ring buffers with LLC
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/index.html
[-- Attachment #2: Type: text/html, Size: 11152 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Don't use stolen memory or BAR mappings for ring buffers (rev2)
2023-02-16 1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
` (3 preceding siblings ...)
2023-02-16 19:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Don't use stolen memory or BAR mappings for ring buffers (rev2) Patchwork
@ 2023-02-17 7:55 ` Patchwork
2023-02-17 8:39 ` [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers Hogander, Jouni
2023-02-20 8:39 ` Tvrtko Ursulin
6 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-02-17 7:55 UTC (permalink / raw)
To: john.c.harrison; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 22589 bytes --]
== Series Details ==
Series: Don't use stolen memory or BAR mappings for ring buffers (rev2)
URL : https://patchwork.freedesktop.org/series/114080/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12751_full -> Patchwork_114080v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/index.html
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114080v2_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_schedule@wide@rcs0:
- {shard-rkl}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-3/igt@gem_exec_schedule@wide@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@gem_exec_schedule@wide@rcs0.html
* {igt@v3d/v3d_job_submission@array-job-submission}:
- {shard-dg1}: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-dg1-16/igt@v3d/v3d_job_submission@array-job-submission.html
Known issues
------------
Here are the changes found in Patchwork_114080v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-hang:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-snb1/igt@gem_ctx_persistence@engines-hang.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [PASS][5] -> [TIMEOUT][6] ([i915#3063])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-apl2/igt@gem_eio@in-flight-contexts-1us.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-apl4/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_pxp@reject-modify-context-protection-off-3:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271]) +85 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-snb1/igt@gem_pxp@reject-modify-context-protection-off-3.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [PASS][10] -> [FAIL][11] ([i915#6537])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-apl6/igt@i915_pm_rps@engine-order.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-apl1/igt@i915_pm_rps@engine-order.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][12] -> [FAIL][13] ([i915#4767])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#79])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
#### Possible fixes ####
* igt@fbdev@eof:
- {shard-rkl}: [SKIP][16] ([i915#2582]) -> [PASS][17] +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-3/igt@fbdev@eof.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@fbdev@eof.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][18] ([i915#6268]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-5/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_persistence@smoketest:
- {shard-rkl}: [FAIL][20] ([i915#5099]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-5/igt@gem_ctx_persistence@smoketest.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-5/igt@gem_ctx_persistence@smoketest.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [FAIL][22] ([i915#2842]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-glk3/igt@gem_exec_fair@basic-none@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_reloc@basic-write-gtt-noreloc:
- {shard-rkl}: [SKIP][24] ([i915#3281]) -> [PASS][25] +4 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-2/igt@gem_exec_reloc@basic-write-gtt-noreloc.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-5/igt@gem_exec_reloc@basic-write-gtt-noreloc.html
* igt@gem_mmap_gtt@coherency:
- {shard-rkl}: [SKIP][26] ([fdo#111656]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-2/igt@gem_mmap_gtt@coherency.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-5/igt@gem_mmap_gtt@coherency.html
* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-snb: [ABORT][28] ([i915#5161]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-snb1/igt@gem_mmap_gtt@fault-concurrent-x.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-snb2/igt@gem_mmap_gtt@fault-concurrent-x.html
* igt@gem_pwrite_snooped:
- {shard-rkl}: [SKIP][30] ([i915#3282]) -> [PASS][31] +4 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-6/igt@gem_pwrite_snooped.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-5/igt@gem_pwrite_snooped.html
* igt@gem_userptr_blits@huge-split:
- shard-snb: [FAIL][32] ([i915#2724]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-snb1/igt@gem_userptr_blits@huge-split.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-snb4/igt@gem_userptr_blits@huge-split.html
* igt@gen9_exec_parse@bb-start-far:
- {shard-rkl}: [SKIP][34] ([i915#2527]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-2/igt@gen9_exec_parse@bb-start-far.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-5/igt@gen9_exec_parse@bb-start-far.html
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- {shard-rkl}: [SKIP][36] ([i915#4098]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-3/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1:
- shard-glk: [FAIL][38] ([i915#2521]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-glk1/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-glk4/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][40] ([i915#1845] / [i915#4098]) -> [PASS][41] +29 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][42] ([i915#2346]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_dp_aux_dev:
- {shard-rkl}: [SKIP][44] ([i915#1257]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-3/igt@kms_dp_aux_dev.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@kms_dp_aux_dev.html
* igt@kms_fbcon_fbt@psr:
- {shard-rkl}: [SKIP][46] ([i915#3955]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-3/igt@kms_fbcon_fbt@psr.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@kms_fbcon_fbt@psr.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [FAIL][48] ([i915#79]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- {shard-rkl}: [SKIP][50] ([i915#1849] / [i915#4098]) -> [PASS][51] +13 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-4/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-tiling-linear.html
* igt@kms_plane@plane-position-hole-dpms@pipe-b-planes:
- {shard-rkl}: [SKIP][52] ([i915#1849]) -> [PASS][53] +3 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-3/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html
* igt@kms_psr@sprite_plane_onoff:
- {shard-rkl}: [SKIP][54] ([i915#1072]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-3/igt@kms_psr@sprite_plane_onoff.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-6/igt@kms_psr@sprite_plane_onoff.html
* igt@perf_pmu@module-unload:
- shard-snb: [ABORT][56] ([i915#4528]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-snb4/igt@perf_pmu@module-unload.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-snb1/igt@perf_pmu@module-unload.html
* igt@prime_vgem@basic-fence-read:
- {shard-rkl}: [SKIP][58] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12751/shard-rkl-2/igt@prime_vgem@basic-fence-read.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/shard-rkl-5/igt@prime_vgem@basic-fence-read.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099
[i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
Build changes
-------------
* Linux: CI_DRM_12751 -> Patchwork_114080v2
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12751: b6ba15d59cdc7e7d488646370f9ca6b0a36f9db5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7161: 5574f110ae838031eef6db5236bad02e8c2d2dee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114080v2: b6ba15d59cdc7e7d488646370f9ca6b0a36f9db5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114080v2/index.html
[-- Attachment #2: Type: text/html, Size: 16244 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers
2023-02-16 1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
` (4 preceding siblings ...)
2023-02-17 7:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-02-17 8:39 ` Hogander, Jouni
2023-02-17 17:18 ` John Harrison
2023-02-20 8:39 ` Tvrtko Ursulin
6 siblings, 1 reply; 12+ messages in thread
From: Hogander, Jouni @ 2023-02-17 8:39 UTC (permalink / raw)
To: Harrison, John C, Intel-GFX@Lists.FreeDesktop.Org
Cc: DRI-Devel@Lists.FreeDesktop.Org
On Wed, 2023-02-15 at 17:10 -0800, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Instruction from hardware arch is that stolen memory and BAR mappings
> are unsafe for use as ring buffers. There can be issues with cache
> aliasing due to the CPU access going to memory via the BAR. So, don't
> do it.
Tested these patches for GPU Hang I was debugging. Seem to fix that one
as well:
Tested-by: Jouni Högander <jouni.hogander@intel.com>
>
> v2: Dont use BAR mappings either.
> Make conditional on LLC so as not to change platforms that don't need
> to change (Daniele).
> Add 'Fixes' tags (Tvrtko).
> v3: Fix dumb typo.
>
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>
>
> John Harrison (2):
> drm/i915: Don't use stolen memory for ring buffers with LLC
> drm/i915: Don't use BAR mappings for ring buffers with LLC
>
> drivers/gpu/drm/i915/gt/intel_ring.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Don't use stolen memory for ring buffers with LLC
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Don't use stolen memory for ring buffers with LLC John.C.Harrison
@ 2023-02-17 15:41 ` Ceraolo Spurio, Daniele
0 siblings, 0 replies; 12+ messages in thread
From: Ceraolo Spurio, Daniele @ 2023-02-17 15:41 UTC (permalink / raw)
To: John.C.Harrison, Intel-GFX; +Cc: Rodrigo Vivi, stable, DRI-Devel, Chris Wilson
On 2/15/2023 5:11 PM, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Direction from hardware is that stolen memory should never be used for
> ring buffer allocations on platforms with LLC. There are too many
> caching pitfalls due to the way stolen memory accesses are routed. So
> it is safest to just not use it.
>
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> Fixes: c58b735fc762 ("drm/i915: Allocate rings from stolen")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v4.9+
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Daniele
> ---
> drivers/gpu/drm/i915/gt/intel_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c
> index 15ec64d881c44..fb1d2595392ed 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ring.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ring.c
> @@ -116,7 +116,7 @@ static struct i915_vma *create_ring_vma(struct i915_ggtt *ggtt, int size)
>
> obj = i915_gem_object_create_lmem(i915, size, I915_BO_ALLOC_VOLATILE |
> I915_BO_ALLOC_PM_VOLATILE);
> - if (IS_ERR(obj) && i915_ggtt_has_aperture(ggtt))
> + if (IS_ERR(obj) && i915_ggtt_has_aperture(ggtt) && !HAS_LLC(i915))
> obj = i915_gem_object_create_stolen(i915, size);
> if (IS_ERR(obj))
> obj = i915_gem_object_create_internal(i915, size);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Don't use BAR mappings for ring buffers with LLC
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Don't use BAR mappings " John.C.Harrison
@ 2023-02-17 15:50 ` Ceraolo Spurio, Daniele
0 siblings, 0 replies; 12+ messages in thread
From: Ceraolo Spurio, Daniele @ 2023-02-17 15:50 UTC (permalink / raw)
To: John.C.Harrison, Intel-GFX; +Cc: Rodrigo Vivi, stable, DRI-Devel, Chris Wilson
On 2/15/2023 5:11 PM, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Direction from hardware is that ring buffers should never be mapped
> via the BAR on systems with LLC. There are too many caching pitfalls
> due to the way BAR accesses are routed. So it is safest to just not
> use it.
>
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> Fixes: 9d80841ea4c9 ("drm/i915: Allow ringbuffers to be bound anywhere")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v4.9+
I've double-checked the original patches to make sure the 4.9 fixes tag
was correct for both (which dim confirmed), because if we backport this
fix without the previous one then the driver would break. Also, the
original patches were merged as part of the same series
(https://patchwork.freedesktop.org/series/11278/), so we should be
guaranteed that they're always there as a pair.
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Daniele
> ---
> drivers/gpu/drm/i915/gt/intel_ring.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c
> index fb1d2595392ed..fb99143be98e7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ring.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ring.c
> @@ -53,7 +53,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww)
> if (unlikely(ret))
> goto err_unpin;
>
> - if (i915_vma_is_map_and_fenceable(vma)) {
> + if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) {
> addr = (void __force *)i915_vma_pin_iomap(vma);
> } else {
> int type = i915_coherent_map_type(vma->vm->i915, vma->obj, false);
> @@ -98,7 +98,7 @@ void intel_ring_unpin(struct intel_ring *ring)
> return;
>
> i915_vma_unset_ggtt_write(vma);
> - if (i915_vma_is_map_and_fenceable(vma))
> + if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915))
> i915_vma_unpin_iomap(vma);
> else
> i915_gem_object_unpin_map(vma->obj);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers
2023-02-17 8:39 ` [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers Hogander, Jouni
@ 2023-02-17 17:18 ` John Harrison
2023-02-20 6:50 ` Hogander, Jouni
0 siblings, 1 reply; 12+ messages in thread
From: John Harrison @ 2023-02-17 17:18 UTC (permalink / raw)
To: Hogander, Jouni, Intel-GFX@Lists.FreeDesktop.Org
Cc: DRI-Devel@Lists.FreeDesktop.Org
On 2/17/2023 00:39, Hogander, Jouni wrote:
> On Wed, 2023-02-15 at 17:10 -0800, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> Instruction from hardware arch is that stolen memory and BAR mappings
>> are unsafe for use as ring buffers. There can be issues with cache
>> aliasing due to the CPU access going to memory via the BAR. So, don't
>> do it.
> Tested these patches for GPU Hang I was debugging. Seem to fix that one
> as well:
>
> Tested-by: Jouni Högander <jouni.hogander@intel.com>
Sweet! Out of interest, which platform was that? And how reproducible
was it? It would be interesting to know if an IGT was actually regularly
showing the issue and we had just been ignoring it!
John.
>
>> v2: Dont use BAR mappings either.
>> Make conditional on LLC so as not to change platforms that don't need
>> to change (Daniele).
>> Add 'Fixes' tags (Tvrtko).
>> v3: Fix dumb typo.
>>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>>
>>
>> John Harrison (2):
>> drm/i915: Don't use stolen memory for ring buffers with LLC
>> drm/i915: Don't use BAR mappings for ring buffers with LLC
>>
>> drivers/gpu/drm/i915/gt/intel_ring.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers
2023-02-17 17:18 ` John Harrison
@ 2023-02-20 6:50 ` Hogander, Jouni
0 siblings, 0 replies; 12+ messages in thread
From: Hogander, Jouni @ 2023-02-20 6:50 UTC (permalink / raw)
To: Harrison, John C, Intel-GFX@Lists.FreeDesktop.Org
Cc: DRI-Devel@Lists.FreeDesktop.Org
On Fri, 2023-02-17 at 09:18 -0800, John Harrison wrote:
> On 2/17/2023 00:39, Hogander, Jouni wrote:
> > On Wed, 2023-02-15 at 17:10 -0800, John.C.Harrison@Intel.com wrote:
> > > From: John Harrison <John.C.Harrison@Intel.com>
> > >
> > > Instruction from hardware arch is that stolen memory and BAR
> > > mappings
> > > are unsafe for use as ring buffers. There can be issues with
> > > cache
> > > aliasing due to the CPU access going to memory via the BAR. So,
> > > don't
> > > do it.
> > Tested these patches for GPU Hang I was debugging. Seem to fix that
> > one
> > as well:
> >
> > Tested-by: Jouni Högander <jouni.hogander@intel.com>
> Sweet! Out of interest, which platform was that? And how reproducible
> was it? It would be interesting to know if an IGT was actually
> regularly
> showing the issue and we had just been ignoring it!
It was Alderlake. It wasn't igt test. Opened several browser
instances:
https://webglsamples.org/aquarium/aquarium.html
Took max. couple of minutes to reproduce. For some reason PSR2
DEEP_SLEEP entry/exit was some kind of trigger for this. Without PSR2
DEEP_SLEEP I couldn't reproduce the issue.
BR,
Jouni Högander
> John.
>
> >
> > > v2: Dont use BAR mappings either.
> > > Make conditional on LLC so as not to change platforms that don't
> > > need
> > > to change (Daniele).
> > > Add 'Fixes' tags (Tvrtko).
> > > v3: Fix dumb typo.
> > >
> > > Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> > >
> > >
> > > John Harrison (2):
> > > drm/i915: Don't use stolen memory for ring buffers with LLC
> > > drm/i915: Don't use BAR mappings for ring buffers with LLC
> > >
> > > drivers/gpu/drm/i915/gt/intel_ring.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers
2023-02-16 1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
` (5 preceding siblings ...)
2023-02-17 8:39 ` [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers Hogander, Jouni
@ 2023-02-20 8:39 ` Tvrtko Ursulin
6 siblings, 0 replies; 12+ messages in thread
From: Tvrtko Ursulin @ 2023-02-20 8:39 UTC (permalink / raw)
To: John.C.Harrison, Intel-GFX; +Cc: DRI-Devel
On 16/02/2023 01:10, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Instruction from hardware arch is that stolen memory and BAR mappings
> are unsafe for use as ring buffers. There can be issues with cache
> aliasing due to the CPU access going to memory via the BAR. So, don't
> do it.
>
> v2: Dont use BAR mappings either.
> Make conditional on LLC so as not to change platforms that don't need
> to change (Daniele).
> Add 'Fixes' tags (Tvrtko).
> v3: Fix dumb typo.
>
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>
>
> John Harrison (2):
> drm/i915: Don't use stolen memory for ring buffers with LLC
> drm/i915: Don't use BAR mappings for ring buffers with LLC
>
> drivers/gpu/drm/i915/gt/intel_ring.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
It is doing what it laid out as the problem statement so series looks
good to me.
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-02-20 8:39 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16 1:10 [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers John.C.Harrison
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Don't use stolen memory for ring buffers with LLC John.C.Harrison
2023-02-17 15:41 ` Ceraolo Spurio, Daniele
2023-02-16 1:11 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Don't use BAR mappings " John.C.Harrison
2023-02-17 15:50 ` Ceraolo Spurio, Daniele
2023-02-16 2:04 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Don't use stolen memory or BAR mappings for ring buffers Patchwork
2023-02-16 19:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Don't use stolen memory or BAR mappings for ring buffers (rev2) Patchwork
2023-02-17 7:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-17 8:39 ` [Intel-gfx] [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers Hogander, Jouni
2023-02-17 17:18 ` John Harrison
2023-02-20 6:50 ` Hogander, Jouni
2023-02-20 8:39 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox