* [PATCH] drm/i915: Missed "ret" initialization on gem_context_size
@ 2012-10-09 17:49 Rodrigo Vivi
2012-10-09 18:04 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Rodrigo Vivi @ 2012-10-09 17:49 UTC (permalink / raw)
To: intel-gfx
Although default case is a bug, being conservative on the initialization helps to shut up coverity scan.
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
---
drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
index 4aa7ecf..bf78882 100644
--- a/drivers/gpu/drm/i915/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/i915_gem_context.c
@@ -102,7 +102,7 @@ static int do_switch(struct i915_hw_context *to);
static int get_context_size(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = dev->dev_private;
- int ret;
+ int ret = 0;
u32 reg;
switch (INTEL_INFO(dev)->gen) {
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: Missed "ret" initialization on gem_context_size
2012-10-09 17:49 [PATCH] drm/i915: Missed "ret" initialization on gem_context_size Rodrigo Vivi
@ 2012-10-09 18:04 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2012-10-09 18:04 UTC (permalink / raw)
To: Rodrigo Vivi, intel-gfx
On Tue, 9 Oct 2012 14:49:06 -0300, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> Although default case is a bug, being conservative on the initialization helps to shut up coverity scan.
>
So many more issues would be resolved if you taught coverity that BUG()
was noreturn. :-p
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-09 18:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-09 17:49 [PATCH] drm/i915: Missed "ret" initialization on gem_context_size Rodrigo Vivi
2012-10-09 18:04 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox