* [PATCH] drm/i915: Bail out of pipe config compute loop on LPT
@ 2016-05-03 8:33 Daniel Vetter
2016-05-03 9:15 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Daniel Vetter @ 2016-05-03 8:33 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Daniel Vetter
LPT is pch, so might run into the fdi bandwidth constraint (especially
since it has only 2 lanes). But right now we just force pipe_bpp back
to 24, resulting in a nice loop (which we bail out with a loud
WARN_ON). Fix this.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=93477
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/i915/intel_crt.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index a2a31fd01d1d..3fbb6fc66451 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -261,8 +261,14 @@ static bool intel_crt_compute_config(struct intel_encoder *encoder,
pipe_config->has_pch_encoder = true;
/* LPT FDI RX only supports 8bpc. */
- if (HAS_PCH_LPT(dev))
+ if (HAS_PCH_LPT(dev)) {
+ if (pipe_config->bw_constrained && pipe_config->pipe_bpp < 24) {
+ DRM_DEBUG_KMS("LPT only supports 24bpp\n");
+ return false;
+ }
+
pipe_config->pipe_bpp = 24;
+ }
/* FDI must always be 2.7 GHz */
if (HAS_DDI(dev))
--
2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Bail out of pipe config compute loop on LPT
2016-05-03 8:33 [PATCH] drm/i915: Bail out of pipe config compute loop on LPT Daniel Vetter
@ 2016-05-03 9:15 ` Chris Wilson
2016-05-03 9:25 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-05-03 9:29 ` [PATCH] " Maarten Lankhorst
2 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2016-05-03 9:15 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Intel Graphics Development
On Tue, May 03, 2016 at 10:33:01AM +0200, Daniel Vetter wrote:
> LPT is pch, so might run into the fdi bandwidth constraint (especially
> since it has only 2 lanes). But right now we just force pipe_bpp back
> to 24, resulting in a nice loop (which we bail out with a loud
> WARN_ON). Fix this.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=93477
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: Bail out of pipe config compute loop on LPT
2016-05-03 8:33 [PATCH] drm/i915: Bail out of pipe config compute loop on LPT Daniel Vetter
2016-05-03 9:15 ` Chris Wilson
@ 2016-05-03 9:25 ` Patchwork
2016-05-03 9:33 ` Chris Wilson
2016-05-04 15:14 ` Daniel Vetter
2016-05-03 9:29 ` [PATCH] " Maarten Lankhorst
2 siblings, 2 replies; 7+ messages in thread
From: Patchwork @ 2016-05-03 9:25 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Bail out of pipe config compute loop on LPT
URL : https://patchwork.freedesktop.org/series/6646/
State : warning
== Summary ==
Series 6646v1 drm/i915: Bail out of pipe config compute loop on LPT
http://patchwork.freedesktop.org/api/1.0/series/6646/revisions/1/mbox/
Test kms_force_connector_basic:
Subgroup force-edid:
pass -> SKIP (snb-x220t)
Subgroup force-load-detect:
skip -> PASS (snb-x220t)
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-b:
pass -> DMESG-WARN (snb-dellxps)
Test kms_sink_crc_basic:
pass -> SKIP (bdw-ultra)
bdw-nuci7-2 total:221 pass:209 dwarn:0 dfail:0 fail:0 skip:12
bdw-ultra total:221 pass:195 dwarn:0 dfail:0 fail:0 skip:26
bsw-nuc-2 total:220 pass:176 dwarn:0 dfail:0 fail:3 skip:41
byt-nuc total:220 pass:176 dwarn:0 dfail:0 fail:3 skip:41
hsw-brixbox total:221 pass:195 dwarn:0 dfail:0 fail:0 skip:26
hsw-gt2 total:26 pass:23 dwarn:0 dfail:0 fail:0 skip:2
ilk-hp8440p total:221 pass:158 dwarn:0 dfail:0 fail:2 skip:61
ivb-t430s total:221 pass:190 dwarn:0 dfail:0 fail:0 skip:31
skl-i7k-2 total:221 pass:194 dwarn:0 dfail:0 fail:0 skip:27
skl-nuci5 total:221 pass:210 dwarn:0 dfail:0 fail:0 skip:11
snb-dellxps total:221 pass:178 dwarn:1 dfail:0 fail:0 skip:42
snb-x220t total:221 pass:177 dwarn:0 dfail:0 fail:1 skip:43
Results at /archive/results/CI_IGT_test/Patchwork_2126/
4c6b0d9cea0a81653fc290fe64d5c43e7d5c5762 drm-intel-nightly: 2016y-05m-03d-08h-18m-32s UTC integration manifest
1581c79 drm/i915: Bail out of pipe config compute loop on LPT
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: ✗ Fi.CI.BAT: warning for drm/i915: Bail out of pipe config compute loop on LPT
2016-05-03 9:25 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-05-03 9:33 ` Chris Wilson
2016-05-04 15:14 ` Daniel Vetter
1 sibling, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2016-05-03 9:33 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
On Tue, May 03, 2016 at 09:25:06AM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Bail out of pipe config compute loop on LPT
> URL : https://patchwork.freedesktop.org/series/6646/
> State : warning
>
> == Summary ==
>
> Series 6646v1 drm/i915: Bail out of pipe config compute loop on LPT
> http://patchwork.freedesktop.org/api/1.0/series/6646/revisions/1/mbox/
>
> Test kms_force_connector_basic:
> Subgroup force-edid:
> pass -> SKIP (snb-x220t)
> Subgroup force-load-detect:
> skip -> PASS (snb-x220t)
> Test kms_pipe_crc_basic:
> Subgroup hang-read-crc-pipe-b:
> pass -> DMESG-WARN (snb-dellxps)
> Test kms_sink_crc_basic:
> pass -> SKIP (bdw-ultra)
>
> bdw-nuci7-2 total:221 pass:209 dwarn:0 dfail:0 fail:0 skip:12
> bdw-ultra total:221 pass:195 dwarn:0 dfail:0 fail:0 skip:26
> bsw-nuc-2 total:220 pass:176 dwarn:0 dfail:0 fail:3 skip:41
> byt-nuc total:220 pass:176 dwarn:0 dfail:0 fail:3 skip:41
> hsw-brixbox total:221 pass:195 dwarn:0 dfail:0 fail:0 skip:26
> hsw-gt2 total:26 pass:23 dwarn:0 dfail:0 fail:0 skip:2
> ilk-hp8440p total:221 pass:158 dwarn:0 dfail:0 fail:2 skip:61
> ivb-t430s total:221 pass:190 dwarn:0 dfail:0 fail:0 skip:31
> skl-i7k-2 total:221 pass:194 dwarn:0 dfail:0 fail:0 skip:27
> skl-nuci5 total:221 pass:210 dwarn:0 dfail:0 fail:0 skip:11
> snb-dellxps total:221 pass:178 dwarn:1 dfail:0 fail:0 skip:42
> snb-x220t total:221 pass:177 dwarn:0 dfail:0 fail:1 skip:43
Aside: What's the reason for distinguishing dfail and fail?
A fail is a fail, and there are cases that are outright failures that
get marked as dfail instead.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for drm/i915: Bail out of pipe config compute loop on LPT
2016-05-03 9:25 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-05-03 9:33 ` Chris Wilson
@ 2016-05-04 15:14 ` Daniel Vetter
1 sibling, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2016-05-04 15:14 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter
On Tue, May 03, 2016 at 09:25:06AM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Bail out of pipe config compute loop on LPT
> URL : https://patchwork.freedesktop.org/series/6646/
> State : warning
>
> == Summary ==
>
> Series 6646v1 drm/i915: Bail out of pipe config compute loop on LPT
> http://patchwork.freedesktop.org/api/1.0/series/6646/revisions/1/mbox/
>
> Test kms_force_connector_basic:
> Subgroup force-edid:
> pass -> SKIP (snb-x220t)
> Subgroup force-load-detect:
> skip -> PASS (snb-x220t)
Both an old classic:
https://bugs.freedesktop.org/show_bug.cgi?id=93769
> Test kms_pipe_crc_basic:
> Subgroup hang-read-crc-pipe-b:
> pass -> DMESG-WARN (snb-dellxps)
Shows up a few times in CI, but no bug yet filed. I made a new one:
https://bugs.freedesktop.org/show_bug.cgi?id=95262
> Test kms_sink_crc_basic:
> pass -> SKIP (bdw-ultra)
Seems to be a dupe of the existing bug:
https://bugs.freedesktop.org/show_bug.cgi?id=94417
>
> bdw-nuci7-2 total:221 pass:209 dwarn:0 dfail:0 fail:0 skip:12
> bdw-ultra total:221 pass:195 dwarn:0 dfail:0 fail:0 skip:26
> bsw-nuc-2 total:220 pass:176 dwarn:0 dfail:0 fail:3 skip:41
> byt-nuc total:220 pass:176 dwarn:0 dfail:0 fail:3 skip:41
> hsw-brixbox total:221 pass:195 dwarn:0 dfail:0 fail:0 skip:26
> hsw-gt2 total:26 pass:23 dwarn:0 dfail:0 fail:0 skip:2
> ilk-hp8440p total:221 pass:158 dwarn:0 dfail:0 fail:2 skip:61
> ivb-t430s total:221 pass:190 dwarn:0 dfail:0 fail:0 skip:31
> skl-i7k-2 total:221 pass:194 dwarn:0 dfail:0 fail:0 skip:27
> skl-nuci5 total:221 pass:210 dwarn:0 dfail:0 fail:0 skip:11
> snb-dellxps total:221 pass:178 dwarn:1 dfail:0 fail:0 skip:42
> snb-x220t total:221 pass:177 dwarn:0 dfail:0 fail:1 skip:43
>
> Results at /archive/results/CI_IGT_test/Patchwork_2126/
>
> 4c6b0d9cea0a81653fc290fe64d5c43e7d5c5762 drm-intel-nightly: 2016y-05m-03d-08h-18m-32s UTC integration manifest
> 1581c79 drm/i915: Bail out of pipe config compute loop on LPT
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Bail out of pipe config compute loop on LPT
2016-05-03 8:33 [PATCH] drm/i915: Bail out of pipe config compute loop on LPT Daniel Vetter
2016-05-03 9:15 ` Chris Wilson
2016-05-03 9:25 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-05-03 9:29 ` Maarten Lankhorst
2016-05-04 15:16 ` Daniel Vetter
2 siblings, 1 reply; 7+ messages in thread
From: Maarten Lankhorst @ 2016-05-03 9:29 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics Development; +Cc: Daniel Vetter
Op 03-05-16 om 10:33 schreef Daniel Vetter:
> LPT is pch, so might run into the fdi bandwidth constraint (especially
> since it has only 2 lanes). But right now we just force pipe_bpp back
> to 24, resulting in a nice loop (which we bail out with a loud
> WARN_ON). Fix this.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=93477
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/i915/intel_crt.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> index a2a31fd01d1d..3fbb6fc66451 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -261,8 +261,14 @@ static bool intel_crt_compute_config(struct intel_encoder *encoder,
> pipe_config->has_pch_encoder = true;
>
> /* LPT FDI RX only supports 8bpc. */
> - if (HAS_PCH_LPT(dev))
> + if (HAS_PCH_LPT(dev)) {
> + if (pipe_config->bw_constrained && pipe_config->pipe_bpp < 24) {
> + DRM_DEBUG_KMS("LPT only supports 24bpp\n");
> + return false;
> + }
> +
> pipe_config->pipe_bpp = 24;
> + }
>
> /* FDI must always be 2.7 GHz */
> if (HAS_DDI(dev))
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Bail out of pipe config compute loop on LPT
2016-05-03 9:29 ` [PATCH] " Maarten Lankhorst
@ 2016-05-04 15:16 ` Daniel Vetter
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2016-05-04 15:16 UTC (permalink / raw)
To: Maarten Lankhorst
Cc: Daniel Vetter, Intel Graphics Development, Daniel Vetter
On Tue, May 03, 2016 at 11:29:21AM +0200, Maarten Lankhorst wrote:
> Op 03-05-16 om 10:33 schreef Daniel Vetter:
> > LPT is pch, so might run into the fdi bandwidth constraint (especially
> > since it has only 2 lanes). But right now we just force pipe_bpp back
> > to 24, resulting in a nice loop (which we bail out with a loud
> > WARN_ON). Fix this.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=93477
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_crt.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> > index a2a31fd01d1d..3fbb6fc66451 100644
> > --- a/drivers/gpu/drm/i915/intel_crt.c
> > +++ b/drivers/gpu/drm/i915/intel_crt.c
> > @@ -261,8 +261,14 @@ static bool intel_crt_compute_config(struct intel_encoder *encoder,
> > pipe_config->has_pch_encoder = true;
> >
> > /* LPT FDI RX only supports 8bpc. */
> > - if (HAS_PCH_LPT(dev))
> > + if (HAS_PCH_LPT(dev)) {
> > + if (pipe_config->bw_constrained && pipe_config->pipe_bpp < 24) {
> > + DRM_DEBUG_KMS("LPT only supports 24bpp\n");
> > + return false;
> > + }
> > +
> > pipe_config->pipe_bpp = 24;
> > + }
> >
> > /* FDI must always be 2.7 GHz */
> > if (HAS_DDI(dev))
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Applied the patch to dinq.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-05-04 15:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-03 8:33 [PATCH] drm/i915: Bail out of pipe config compute loop on LPT Daniel Vetter
2016-05-03 9:15 ` Chris Wilson
2016-05-03 9:25 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-05-03 9:33 ` Chris Wilson
2016-05-04 15:14 ` Daniel Vetter
2016-05-03 9:29 ` [PATCH] " Maarten Lankhorst
2016-05-04 15:16 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox