Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Keith Packard <keithp@keithp.com>, Eric Anholt <eric@anholt.net>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix restore of 965 fence regs since the register tracing change.
Date: Thu, 18 Nov 2010 14:46:07 +0000	[thread overview]
Message-ID: <0d30dc$k79tj9@orsmga001.jf.intel.com> (raw)
In-Reply-To: <yunr5ejgunz.fsf@aiko.keithp.com>

On Thu, 18 Nov 2010 11:47:12 +0800, Keith Packard <keithp@keithp.com> wrote:
> 
> We were reading our 64-bit value in I915_READ64 and returning 32 bits
> of it.  The restoration of fence regs at resume then had a zero end
> value, and the fence had no effect.
> 
> Version 2: Split register access functions into per-size versions

This also helps silence sparse since it doesn't seem able to do
compile-time constant propagation dead-code elimination. Minor,
yet annoying, issue.

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2010-11-18 14:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18  2:05 [PATCH] drm/i915: Fix restore of 965 fence regs since the register tracing change Eric Anholt
2010-11-18  3:47 ` Keith Packard
2010-11-18 14:46   ` Chris Wilson [this message]
2010-11-22 12:13   ` Chris Wilson
2010-11-22 14:18     ` Peter Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0d30dc$k79tj9@orsmga001.jf.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox