From: Peter Clifton <pcjc2@cam.ac.uk>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix restore of 965 fence regs since the register tracing change.
Date: Mon, 22 Nov 2010 14:18:39 +0000 [thread overview]
Message-ID: <1290435519.7760.1.camel@pcjc2lap> (raw)
In-Reply-To: <c6d829$pk9kmn@fmsmga001.fm.intel.com>
On Mon, 2010-11-22 at 12:13 +0000, Chris Wilson wrote:
> On Thu, 18 Nov 2010 11:47:12 +0800, Keith Packard <keithp@keithp.com> wrote:
> >
> > We were reading our 64-bit value in I915_READ64 and returning 32 bits
> > of it. The restoration of fence regs at resume then had a zero end
> > value, and the fence had no effect.
>
> It was a good catch. Applied one final tweak to use macros to generate
> the various read/write routines and applied to -next.
> -Chris
Chris, does this sound like it might be behind the bug I mentioned on
IRC?
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)
prev parent reply other threads:[~2010-11-22 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 2:05 [PATCH] drm/i915: Fix restore of 965 fence regs since the register tracing change Eric Anholt
2010-11-18 3:47 ` Keith Packard
2010-11-18 14:46 ` Chris Wilson
2010-11-22 12:13 ` Chris Wilson
2010-11-22 14:18 ` Peter Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290435519.7760.1.camel@pcjc2lap \
--to=pcjc2@cam.ac.uk \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox