Re: [Intel-gfx] [PATCH 1/7] drm: Do not round to megabytes for greater than 1MiB sizes in fdinfo stats

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 26/10/2023 15:43, Tvrtko Ursulin wrote:
> 
> On 28/09/2023 13:47, Tvrtko Ursulin wrote:
>>
>> On 27/09/2023 14:48, Steven Price wrote:
>>> On 27/09/2023 14:38, Tvrtko Ursulin wrote:
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> It is better not to lose precision and not revert to 1 MiB size
>>>> granularity for every size greater than 1 MiB.
>>>>
>>>> Sizes in KiB should not be so troublesome to read (and in fact machine
>>>> parsing is I expect the norm here), they align with other api like
>>>> /proc/meminfo, and they allow writing tests for the interface without
>>>> having to embed drm.ko implementation knowledge into them. (Like 
>>>> knowing
>>>> that minimum buffer size one can use for successful verification has 
>>>> to be
>>>> 1MiB aligned, and on top account for any pre-existing memory 
>>>> utilisation
>>>> outside of driver's control.)
>>>>
>>>> But probably even more importantly I think that it is just better to 
>>>> show
>>>> the accurate sizes and not arbitrary lose precision for a little bit 
>>>> of a
>>>> stretched use case of eyeballing fdinfo text directly.
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>> Cc: Rob Clark <robdclark@gmail.com>
>>>> Cc: Adrián Larumbe <adrian.larumbe@collabora.com>
>>>> Cc: steven.price@arm.com
>>>
>>> Reviewed-by: Steven Price <steven.price@arm.com>
>>
>> Thanks! Rob? Can we have your blessing? Could you live with KiBs? :)
> 
> Acked received on #dri-devel:
> 
> [12:15] <tursulin> robclark: ping on 
> https://lists.freedesktop.org/archives/dri-devel/2023-September/424905.html - can you live with it or object?
> [14:41] <robclark> tursulin: a-b
> 
> Adding the drm-misc maintainers with an ask to merge please.

Ping please - just this one patch to merge to drm-misc-next if possible.

Regards,

Tvrtko