From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Adrián Larumbe" <adrian.larumbe@collabora.com>, steven.price@arm.com
Subject: [Intel-gfx] [PATCH 1/7] drm: Do not round to megabytes for greater than 1MiB sizes in fdinfo stats
Date: Wed, 27 Sep 2023 14:38:37 +0100 [thread overview]
Message-ID: <20230927133843.247957-2-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20230927133843.247957-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
It is better not to lose precision and not revert to 1 MiB size
granularity for every size greater than 1 MiB.
Sizes in KiB should not be so troublesome to read (and in fact machine
parsing is I expect the norm here), they align with other api like
/proc/meminfo, and they allow writing tests for the interface without
having to embed drm.ko implementation knowledge into them. (Like knowing
that minimum buffer size one can use for successful verification has to be
1MiB aligned, and on top account for any pre-existing memory utilisation
outside of driver's control.)
But probably even more importantly I think that it is just better to show
the accurate sizes and not arbitrary lose precision for a little bit of a
stretched use case of eyeballing fdinfo text directly.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Adrián Larumbe <adrian.larumbe@collabora.com>
Cc: steven.price@arm.com
---
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index e692770ef6d3..ecb5038009e7 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -913,7 +913,7 @@ static void print_size(struct drm_printer *p, const char *stat,
unsigned u;
for (u = 0; u < ARRAY_SIZE(units) - 1; u++) {
- if (sz < SZ_1K)
+ if (sz == 0 || !IS_ALIGNED(sz, SZ_1K))
break;
sz = div_u64(sz, SZ_1K);
}
--
2.39.2
next prev parent reply other threads:[~2023-09-27 13:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 13:38 [Intel-gfx] [PATCH v8 0/7] fdinfo memory stats Tvrtko Ursulin
2023-09-27 13:38 ` Tvrtko Ursulin [this message]
2023-09-27 13:48 ` [Intel-gfx] [PATCH 1/7] drm: Do not round to megabytes for greater than 1MiB sizes in fdinfo stats Steven Price
2023-09-28 12:47 ` Tvrtko Ursulin
2023-10-26 14:43 ` Tvrtko Ursulin
2023-11-02 9:50 ` Tvrtko Ursulin
2023-11-06 10:45 ` [Intel-gfx] (subset) " Maxime Ripard
2023-09-27 13:38 ` [Intel-gfx] [PATCH 2/7] drm/i915: Add ability for tracking buffer objects per client Tvrtko Ursulin
2023-09-27 13:38 ` [Intel-gfx] [PATCH 3/7] drm/i915: Record which client owns a VM Tvrtko Ursulin
2023-09-27 13:38 ` [Intel-gfx] [PATCH 4/7] drm/i915: Track page table backing store usage Tvrtko Ursulin
2023-09-27 13:38 ` [Intel-gfx] [PATCH 5/7] drm/i915: Account ring buffer and context state storage Tvrtko Ursulin
2023-09-27 13:38 ` [Intel-gfx] [PATCH 6/7] drm/i915: Add stable memory region names Tvrtko Ursulin
2023-09-27 13:38 ` [Intel-gfx] [PATCH 7/7] drm/i915: Implement fdinfo memory stats printing Tvrtko Ursulin
2023-09-27 20:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for fdinfo memory stats (rev9) Patchwork
2023-09-27 20:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-28 10:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927133843.247957-2-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=adrian.larumbe@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox