Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: dri-devel@lists.freedesktop.org
Cc: Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Daniel@freedesktop.org, Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] drm/i915: error_buffer->ring should be signed
Date: Thu, 16 Feb 2012 11:18:53 +0100	[thread overview]
Message-ID: <1329387533.3518.46.camel@mattotaupa> (raw)
In-Reply-To: <1329386609-15885-1-git-send-email-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 1123 bytes --]

Am Donnerstag, den 16.02.2012, 11:03 +0100 schrieb Daniel Vetter:
> gcc seems to get uber-anal recently about these things.

which was introduced by the following commit.

        96154f2faba5: "drm/i915: switch ring->id to be a real id"

> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

The URL of the report is the following.

http://lists.freedesktop.org/archives/dri-devel/2012-February/019183.html

> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

> ---
>  drivers/gpu/drm/i915/i915_drv.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index b839728..35833fc 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -199,7 +199,7 @@ struct drm_i915_error_state {
>  		u32 tiling:2;
>  		u32 dirty:1;
>  		u32 purgeable:1;
> -		u32 ring:4;
> +		s32 ring:4;
>  		u32 cache_level:2;
>  	} *active_bo, *pinned_bo;
>  	u32 active_bo_count, pinned_bo_count;


Thanks,

Paul

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2012-02-16 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120216064004.GA23794@elgon.mountain>
2012-02-16 10:03 ` [PATCH] drm/i915: error_buffer->ring should be signed Daniel Vetter
2012-02-16 10:18   ` Paul Menzel [this message]
2012-02-16 11:16   ` Dan Carpenter
2012-02-27 17:15     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329387533.3518.46.camel@mattotaupa \
    --to=paulepanter@users.sourceforge.net \
    --cc=Daniel@freedesktop.org \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox