Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: error_buffer->ring should be signed
Date: Thu, 16 Feb 2012 14:16:27 +0300	[thread overview]
Message-ID: <20120216111627.GM26353@mwanda> (raw)
In-Reply-To: <1329386609-15885-1-git-send-email-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 442 bytes --]

On Thu, Feb 16, 2012 at 11:03:29AM +0100, Daniel Vetter wrote:
> gcc seems to get uber-anal recently about these things.
> 

Sorry, I should have said that it's not a gcc warning, it's a
smatch thing.  But also it's not uber-anal.  It's the exact level of
anality which is required to make the == -1 test work.  You can
compare unsigned int and longs to -1 and it works but for smaller
types it doesn't.

regards,
dan carpenter


[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2012-02-16 11:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120216064004.GA23794@elgon.mountain>
2012-02-16 10:03 ` [PATCH] drm/i915: error_buffer->ring should be signed Daniel Vetter
2012-02-16 10:18   ` Paul Menzel
2012-02-16 11:16   ` Dan Carpenter [this message]
2012-02-27 17:15     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120216111627.GM26353@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox