* [PATCH] drm/i915: error_buffer->ring should be signed [not found] <20120216064004.GA23794@elgon.mountain> @ 2012-02-16 10:03 ` Daniel Vetter 2012-02-16 10:18 ` Paul Menzel 2012-02-16 11:16 ` Dan Carpenter 0 siblings, 2 replies; 4+ messages in thread From: Daniel Vetter @ 2012-02-16 10:03 UTC (permalink / raw) To: Intel Graphics Development; +Cc: Daniel Vetter, Dan Carpenter, DRI Development gcc seems to get uber-anal recently about these things. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index b839728..35833fc 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -199,7 +199,7 @@ struct drm_i915_error_state { u32 tiling:2; u32 dirty:1; u32 purgeable:1; - u32 ring:4; + s32 ring:4; u32 cache_level:2; } *active_bo, *pinned_bo; u32 active_bo_count, pinned_bo_count; -- 1.7.9 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: error_buffer->ring should be signed 2012-02-16 10:03 ` [PATCH] drm/i915: error_buffer->ring should be signed Daniel Vetter @ 2012-02-16 10:18 ` Paul Menzel 2012-02-16 11:16 ` Dan Carpenter 1 sibling, 0 replies; 4+ messages in thread From: Paul Menzel @ 2012-02-16 10:18 UTC (permalink / raw) To: dri-devel; +Cc: Vetter, Intel Graphics Development, Daniel, Dan Carpenter [-- Attachment #1.1: Type: text/plain, Size: 1123 bytes --] Am Donnerstag, den 16.02.2012, 11:03 +0100 schrieb Daniel Vetter: > gcc seems to get uber-anal recently about these things. which was introduced by the following commit. 96154f2faba5: "drm/i915: switch ring->id to be a real id" > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> The URL of the report is the following. http://lists.freedesktop.org/archives/dri-devel/2012-February/019183.html > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net> > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index b839728..35833fc 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -199,7 +199,7 @@ struct drm_i915_error_state { > u32 tiling:2; > u32 dirty:1; > u32 purgeable:1; > - u32 ring:4; > + s32 ring:4; > u32 cache_level:2; > } *active_bo, *pinned_bo; > u32 active_bo_count, pinned_bo_count; Thanks, Paul [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 198 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: error_buffer->ring should be signed 2012-02-16 10:03 ` [PATCH] drm/i915: error_buffer->ring should be signed Daniel Vetter 2012-02-16 10:18 ` Paul Menzel @ 2012-02-16 11:16 ` Dan Carpenter 2012-02-27 17:15 ` Daniel Vetter 1 sibling, 1 reply; 4+ messages in thread From: Dan Carpenter @ 2012-02-16 11:16 UTC (permalink / raw) To: Daniel Vetter; +Cc: Intel Graphics Development, DRI Development [-- Attachment #1.1: Type: text/plain, Size: 442 bytes --] On Thu, Feb 16, 2012 at 11:03:29AM +0100, Daniel Vetter wrote: > gcc seems to get uber-anal recently about these things. > Sorry, I should have said that it's not a gcc warning, it's a smatch thing. But also it's not uber-anal. It's the exact level of anality which is required to make the == -1 test work. You can compare unsigned int and longs to -1 and it works but for smaller types it doesn't. regards, dan carpenter [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: error_buffer->ring should be signed 2012-02-16 11:16 ` Dan Carpenter @ 2012-02-27 17:15 ` Daniel Vetter 0 siblings, 0 replies; 4+ messages in thread From: Daniel Vetter @ 2012-02-27 17:15 UTC (permalink / raw) To: Dan Carpenter; +Cc: Daniel Vetter, Intel Graphics Development, DRI Development On Thu, Feb 16, 2012 at 02:16:27PM +0300, Dan Carpenter wrote: > On Thu, Feb 16, 2012 at 11:03:29AM +0100, Daniel Vetter wrote: > > gcc seems to get uber-anal recently about these things. > > > > Sorry, I should have said that it's not a gcc warning, it's a > smatch thing. But also it's not uber-anal. It's the exact level of > anality which is required to make the == -1 test work. You can > compare unsigned int and longs to -1 and it works but for smaller > types it doesn't. I've picked this one here up for -next, thanks for your clarification (added to the commit message in). -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-27 17:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120216064004.GA23794@elgon.mountain>
2012-02-16 10:03 ` [PATCH] drm/i915: error_buffer->ring should be signed Daniel Vetter
2012-02-16 10:18 ` Paul Menzel
2012-02-16 11:16 ` Dan Carpenter
2012-02-27 17:15 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).