From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: use mode values consistently when converting to sdvo dtd
Date: Tue, 24 Apr 2012 20:24:20 +0100 [thread overview]
Message-ID: <1335295491_40619@CP5-2952> (raw)
In-Reply-To: <1335284878-22201-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 24 Apr 2012 18:27:57 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> The drm_mode->dtd conversion used the crtc timings, whereas the
> dtd->drm_mod did not set these. Use the standard mode information, not
> the crtc timings, in both cases to make these two functions proper
> inverses of each another.
>
> Note that this also kills the risk that we handle interlaced timings
> inconsistently because the drm core uses half-frames for crtc timings,
> whereas we need full frames. But interlaced support is pretty decently
> broken anyway for sdvo encoders, so no big deal.
So as I understand it, if we had interlacing or dblscan enabled on the
incoming mode we would have been feeding the display timing into the
magic black box of the SDVO encoder rather the mode line.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-24 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 16:27 [PATCH 1/2] drm/i915: use mode values consistently when converting to sdvo dtd Daniel Vetter
2012-04-24 16:27 ` [PATCH 2/2] drm/i915: properly handle interlaced bit for sdvo dtd conversion Daniel Vetter
2012-04-24 19:24 ` Chris Wilson [this message]
2012-05-04 9:35 ` [PATCH 1/2] drm/i915: use mode values consistently when converting to sdvo dtd Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335295491_40619@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox