Re: [PATCH 1/2] drm/i915: use mode values consistently when converting to sdvo dtd

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Apr 24, 2012 at 08:24:20PM +0100, Chris Wilson wrote:
> On Tue, 24 Apr 2012 18:27:57 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > The drm_mode->dtd conversion used the crtc timings, whereas the
> > dtd->drm_mod did not set these. Use the standard mode information, not
> > the crtc timings, in both cases to make these two functions proper
> > inverses of each another.
> > 
> > Note that this also kills the risk that we handle interlaced timings
> > inconsistently because the drm core uses half-frames for crtc timings,
> > whereas we need full frames. But interlaced support is pretty decently
> > broken anyway for sdvo encoders, so no big deal.
> 
> So as I understand it, if we had interlacing or dblscan enabled on the
> incoming mode we would have been feeding the display timing into the
> magic black box of the SDVO encoder rather the mode line.
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48