From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Kurtz <djkurtz@chromium.org>
Subject: [PATCH] drm/i915: don't return -ENXIO from gmbus xfer
Date: Mon, 14 May 2012 07:56:21 +0200 [thread overview]
Message-ID: <1336974981-5176-1-git-send-email-daniel.vetter@ffwll.ch> (raw)
... too much risk for flaky edid transfers.
Cc: Daniel Kurtz <djkurtz@chromium.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49518
Reported-and-Tested-by: Julian Simioni <julian.simioni@gmail.com>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_i2c.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index e04255e..0588d8e 100644
--- a/drivers/gpu/drm/i915/intel_i2c.c
+++ b/drivers/gpu/drm/i915/intel_i2c.c
@@ -418,10 +418,11 @@ clear_err:
* If no ACK is received during the address phase of a transaction,
* the adapter must report -ENXIO.
* It is not clear what to return if no ACK is received at other times.
- * So, we always return -ENXIO in all NAK cases, to ensure we send
- * it at least during the one case that is specified.
+ *
+ * Unfortunately we can't afford false positives in returning -ENXIO,
+ * hence never return -ENXIO.
*/
- ret = -ENXIO;
+ ret = i;
goto out;
timeout:
--
1.7.10
next reply other threads:[~2012-05-14 5:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 5:56 Daniel Vetter [this message]
2012-05-19 20:10 ` [PATCH] drm/i915: don't return -ENXIO from gmbus xfer Daniel Vetter
2012-05-20 15:19 ` Daniel Vetter
[not found] ` <CAGS+omCnwFf-uKiQewMnprPJ5maSjS9ROeyoRTiYd_JRBjSBiQ@mail.gmail.com>
2012-05-20 18:16 ` Daniel Vetter
2012-05-21 18:19 ` [PATCH] drm/i915: be more careful when returning -ENXIO in gmbus transfer Daniel Vetter
2012-05-21 18:24 ` Chris Wilson
[not found] ` <CAGS+omANiYtmKX_z2m2J-5j7a-K0z2MJ=wE3PcZRATmyh_VGxQ@mail.gmail.com>
2012-05-21 19:04 ` Daniel Vetter
2012-05-21 18:20 ` [PATCH] drm/i915: don't return -ENXIO from gmbus xfer Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336974981-5176-1-git-send-email-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=djkurtz@chromium.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox