From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: be more careful when returning -ENXIO in gmbus transfer
Date: Mon, 21 May 2012 21:04:56 +0200 [thread overview]
Message-ID: <20120521190456.GF4970@phenom.ffwll.local> (raw)
In-Reply-To: <CAGS+omANiYtmKX_z2m2J-5j7a-K0z2MJ=wE3PcZRATmyh_VGxQ@mail.gmail.com>
On Mon, May 21, 2012 at 11:31:20AM -0700, Daniel Kurtz wrote:
> On Mon, May 21, 2012 at 11:24 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Mon, 21 May 2012 20:19:48 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> >> ... flaky ddc hardware can cause a spurious NAK, resulting in the i2c
> >> core and drm edid functions not trying to retry the edid transfer.
> >>
> >> Luckily the gmbus quiescenting also times out for these cases, so we
> >> can get out of this mess by returning -ETIMEDOUT for this specific
> >> case. This way we keep the fast-fail of returning -ENXIO if there is
> >> no device present, speeding up the boot process.
> >>
> >> This regression has been introduced in
> >>
> >> commit e646d5773572bf52017983d758bdf05777dc5600
> >> Author: Daniel Kurtz <djkurtz@chromium.org>
> >> Date: Fri Mar 30 19:46:38 2012 +0800
> >>
> >> drm/i915/intel_i2c: always wait for IDLE before clearing NAK
> >>
> >> v2: Return -ETIMEDOUT for this case and keep the -ENXIO for real NAKs,
> >> suggested by Daniel Kurtz.
> >>
> >> Cc: Daniel Kurtz <djkurtz@chromium.org>
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49518
> >> Reported-and-Tested-by: Julian Simioni <julian.simioni@gmail.com>
> >> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> > -Chris
> >
> > --
> > Chris Wilson, Intel Open Source Technology Centre
>
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Picked up for -fixes, thanks for the review.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-05-21 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 5:56 [PATCH] drm/i915: don't return -ENXIO from gmbus xfer Daniel Vetter
2012-05-19 20:10 ` Daniel Vetter
2012-05-20 15:19 ` Daniel Vetter
[not found] ` <CAGS+omCnwFf-uKiQewMnprPJ5maSjS9ROeyoRTiYd_JRBjSBiQ@mail.gmail.com>
2012-05-20 18:16 ` Daniel Vetter
2012-05-21 18:19 ` [PATCH] drm/i915: be more careful when returning -ENXIO in gmbus transfer Daniel Vetter
2012-05-21 18:24 ` Chris Wilson
[not found] ` <CAGS+omANiYtmKX_z2m2J-5j7a-K0z2MJ=wE3PcZRATmyh_VGxQ@mail.gmail.com>
2012-05-21 19:04 ` Daniel Vetter [this message]
2012-05-21 18:20 ` [PATCH] drm/i915: don't return -ENXIO from gmbus xfer Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521190456.GF4970@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=djkurtz@chromium.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox