From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fix up ivb plane 3 pageflips
Date: Wed, 23 May 2012 13:05:35 +0100 [thread overview]
Message-ID: <1337774750_201559@CP5-2952> (raw)
In-Reply-To: <1337774520-26572-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 23 May 2012 14:02:00 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Or at least plug another gapping hole. Apparrently hw desingers only
> moved the bit field, but did not bother ot re-enumerate the planes
> when adding support for a 3rd pipe.
>
> Discovered by i-g-t/flip_test.
>
> This may or may not fix the reference bugzilla, because that one
> smells like we have still larger fish to fry.
>
> v2: Fixup the impossible case to catch programming errors, noticed by
> Chris Wilson.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=50069
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
The code looks correct, just not in a position atm to verify the
MI_DISPLAY_FLIP bits.
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-23 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 11:20 [PATCH] drm/i915: fix up ivb plane 3 pageflips Daniel Vetter
2012-05-23 11:30 ` Chris Wilson
2012-05-23 12:02 ` Daniel Vetter
2012-05-23 12:05 ` Chris Wilson [this message]
2012-06-05 8:56 ` Daniel Vetter
2012-06-05 16:35 ` Ben Widawsky
2012-06-05 18:52 ` Eugeni Dodonov
2012-06-05 18:59 ` Eugeni Dodonov
2012-06-05 19:06 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337774750_201559@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox