From: Daniel Vetter <daniel@ffwll.ch>
To: eugeni.dodonov@intel.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: fix up ivb plane 3 pageflips
Date: Tue, 5 Jun 2012 21:06:29 +0200 [thread overview]
Message-ID: <20120605190629.GC4704@phenom.ffwll.local> (raw)
In-Reply-To: <4FCE5703.4030405@linux.intel.com>
On Tue, Jun 05, 2012 at 03:59:15PM -0300, Eugeni Dodonov wrote:
> On 06/05/2012 03:52 PM, Eugeni Dodonov wrote:
> >On 06/05/2012 05:56 AM, Daniel Vetter wrote:
> >>On Wed, May 23, 2012 at 02:02:00PM +0200, Daniel Vetter wrote:
> >>>Or at least plug another gapping hole. Apparrently hw desingers only
> >>>moved the bit field, but did not bother ot re-enumerate the planes
> >>>when adding support for a 3rd pipe.
> >>>
> >>>Discovered by i-g-t/flip_test.
> >>>
> >>>This may or may not fix the reference bugzilla, because that one
> >>>smells like we have still larger fish to fry.
> >>>
> >>>v2: Fixup the impossible case to catch programming errors, noticed by
> >>>Chris Wilson.
> >>>
> >>>References: https://bugs.freedesktop.org/show_bug.cgi?id=50069
> >>>Signed-Off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
> >>
> >>Ping for review and maybe a tested-by. This fixes
> >>i-g-t/tests/flip_test on
> >>my ivb, but for some strange reasons QA can't confirm that. Still, I'd
> >>like to push this patch to -fixes. Eugeni, Ben?
> >
> >Although I don't get exact symptoms (I don't get any BUG in dmesg),
> >without this patch the flip_test hangs when running on 3rd pipe, and
> >with this patch it proceeds and finishes correctly.
> >
> >So this patch fixes this test case, and as far I can see it is correct.
> >
> >Tested-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
>
> ..and also Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Picked up for -fixes (with a cc stable added), thanks for the review and
testing.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-06-05 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 11:20 [PATCH] drm/i915: fix up ivb plane 3 pageflips Daniel Vetter
2012-05-23 11:30 ` Chris Wilson
2012-05-23 12:02 ` Daniel Vetter
2012-05-23 12:05 ` Chris Wilson
2012-06-05 8:56 ` Daniel Vetter
2012-06-05 16:35 ` Ben Widawsky
2012-06-05 18:52 ` Eugeni Dodonov
2012-06-05 18:59 ` Eugeni Dodonov
2012-06-05 19:06 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605190629.GC4704@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox